Subject: Re: bug#62309: [PATCH core-updates 0/2] Fix qemu build

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 20 Mar 2023 21:29:45 -0400

Hi Josselin,

Josselin Poiret <[email-masked]> writes:

> * gnu/packages/firmware.scm (make-opensbi-package): Do it.

Nitpick: The change log should state the change; it took me an instant
to realize the "Do it" meant implement the git summary description.  The
summary can be more brief (or it could say the same if it fits under 80
chars).

>  gnu/packages/firmware.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
> index 956ece5d6d..9b9443effe 100644
> --- a/gnu/packages/firmware.scm
> +++ b/gnu/packages/firmware.scm
> @@ -486,7 +486,7 @@ (define* (make-opensbi-package platform name #:optional (arch "riscv64"))
>      (native-inputs
>       `(,@(if (and (not (string-prefix? "riscv64" (%current-system)))
>                    (string-prefix? "riscv64" arch))
> -           `(("cross-gcc" ,(cross-gcc "riscv64-linux-gnu" #:xgcc gcc-7))
> +           `(("cross-gcc" ,(cross-gcc "riscv64-linux-gnu"))
>               ("cross-binutils" ,(cross-binutils "riscv64-linux-gnu")))
>             '())))
>      (arguments
> @@ -499,6 +499,8 @@ (define* (make-opensbi-package platform name #:optional (arch "riscv64"))
>                                  `("CC=gcc"))
>                            "FW_PAYLOAD=n"
>                            "V=1")
> +       ;; fence.i instructions are used, so we need a non-default micro arch
> +       #:configure-flags (list "-march=rv64g")

I don't quite understand, but then I don't know what is opensbi either,
so I'd have to read more.  Or if you can expound a bit that comment for
neophytes like me, that'd be nice.

Thanks for the fix!

-- 
Maxim