From unknown Thu Jun 19 16:16:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62300 <62300@debbugs.gnu.org> To: bug#62300 <62300@debbugs.gnu.org> Subject: Status: 29.0.60; No hyperlinks for some symbols in *Help* buffers Reply-To: bug#62300 <62300@debbugs.gnu.org> Date: Thu, 19 Jun 2025 23:16:00 +0000 retitle 62300 29.0.60; No hyperlinks for some symbols in *Help* buffers reassign 62300 emacs submitter 62300 Eli Zaretskii severity 62300 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 14:33:58 2023 Received: (at submit) by debbugs.gnu.org; 20 Mar 2023 18:33:58 +0000 Received: from localhost ([127.0.0.1]:56782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKKU-0001lj-52 for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:33:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:39258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKKS-0001lc-KR for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:33:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKKS-0008Tc-D0 for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:33:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKKS-0001ao-2J for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:33:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=rqKZsAbQ6hZ1ihiYYScfs6FWUZgZqCRu0nGgv+5B3wQ=; b=L7qQ8t5elUsauV wJANCmOV1EGVZEVq39Nf8JSBRK+ikK2drvQTb+XHRBufpGCDe3WIHjv/RMvlIqE86KB3uRUHPegVY oCF+TER56gcl0hBjb5+LCe/kCoqI9so5KhUY5rQfH6CFaoXUZPrcFcdDPwRZK+G++tggqEqe+A68G zWvrwrnJ9fqWtQOnBfyg7K00fiZJrDuQpuV0TBHuZ2INL03us6fHGql29OyhPdWVpZKUadt9Jmq2j VB9tKUJ+UBjbZsljmQ+3hmk+ujb9aHq4MwccMCRooLJieP3rIf+mxkkEZ0vzR27edXo9HmWUwVJJy stvD75vwsoHRWn2LKHhQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKKR-00050e-C4 for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:33:55 -0400 Date: Mon, 20 Mar 2023 20:34:04 +0200 Message-Id: <83y1nr6zmr.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 29.0.60; No hyperlinks for some symbols in *Help* buffers X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) To reproduce: emacs -Q C-h f global-text-scale-adjust RET Observe that in the *Help* buffer the variable global-text-scale-adjust-resizes-frames does not have the link appearance. This is because: (boundp 'global-text-scale-adjust-resizes-frames) => nil By contrast, if you try C-h f text-scale-adjust RET then the variable text-scale-mode-step in the *Help* buffer does get the link appearance, and boundp returns non-nil for that variable. The reason seems to be that in the latter case typing the "C-h f" command causes face-remap.el to be loaded, whereas in the former case face-remap.el is not loaded. I traced that to a problem which can be demonstrated by the following recipe: emacs -Q M-x load-library RET help-fns RET Now evaluate: (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust") This returns nil, whereas if you do the same with "text-scale-adjust", you get: (("text-scale-" "face-remap") ("tex" "flyspell")) Interestingly, just appending a dash to global-text-scale-adjust, i.e. (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust-") does yield non-nil result: (("global-text-scale-adjust-" "face-remap")) The non-nil result causes help-fns.el:help--symbol-completion-table to load the file: (when help-enable-completion-autoload (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) (help--load-prefixes prefixes))) The load happens inside help--load-prefixes. As result face-remap.el is loaded for text-scale-adjust, and the variables defined in face-remap.el become defined. With global-text-scale-adjust the loading doesn't happen, and the variable stays unbound. This sounds like some snafu with some heuristic somewhere, perhaps in radix-tree-prefixes, or in the code which registers the prefixes to begin with? Can this be fixed, please, so that variables referenced in doc strings would reliably be displayed as links? In GNU Emacs 29.0.60 (build 400, i686-pc-mingw32) of 2023-03-20 built on HOME-C4E4A596F7 Repository revision: 786de66ec3c4cff90cafd0f8a68f9bce027e9947 Repository branch: emacs-29 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dabbrev misearch multi-isearch pp cl-macs derived pcase subr-x help-fns radix-tree cl-print byte-opt gv bytecomp byte-compile debug backtrace help-mode find-func cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 170820 17000) (symbols 48 7828 0) (strings 16 25056 2790) (string-bytes 1 712251) (vectors 16 12758) (vector-slots 8 191144 13690) (floats 8 36 30) (intervals 40 10017 117) (buffers 888 13)) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 14:52:27 2023 Received: (at 62300) by debbugs.gnu.org; 20 Mar 2023 18:52:27 +0000 Received: from localhost ([127.0.0.1]:56825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKcM-0002JY-L0 for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:52:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKcK-0002JL-IA for 62300@debbugs.gnu.org; Mon, 20 Mar 2023 14:52:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKcF-0007oY-7b; Mon, 20 Mar 2023 14:52:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7EAVQoYkQUE4XnPV+/+yFXbtj45ANfn5V+WZ99qK2gA=; b=H4MKrd2S1I1k yaXQMuQ9SIc40ttdO7JBePxz3Bxd+3Ogg3xHKb0Mvu15lDVFEWFHrwMl7NS/T2zzDVV2jia0S3IrX 5AD8t5jI0fx2t5xuznA3CWnceDdzm90Cdu1KhPcHNxNY+hseQpMu8RFOrGiTOydjrt/P5Z8CjEQni sUHm3Q/+EP9cFgQGNb5wdopxgTUKC8S2J2cu3/UsyggoQTa7Fse/yI8cT5pWtp2M2lMW4nnjWL/xI XILtpBlCfsl0yrR5+hic3+aZyotmiLO/ui5OxrOLEzl+c9LJYrV0ya2nCpVS/YVnXWowALXydd1Fc vFjDWidsy9iowSBdW7TfuQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKcE-0006Lb-No; Mon, 20 Mar 2023 14:52:19 -0400 Date: Mon, 20 Mar 2023 20:52:28 +0200 Message-Id: <83ttyf6ys3.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: <83y1nr6zmr.fsf@gnu.org> (message from Eli Zaretskii on Mon, 20 Mar 2023 20:34:04 +0200) Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers References: <83y1nr6zmr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 20 Mar 2023 20:34:04 +0200 > From: Eli Zaretskii > > To reproduce: > > emacs -Q > C-h f global-text-scale-adjust RET > > Observe that in the *Help* buffer the variable > global-text-scale-adjust-resizes-frames does not have the link > appearance. This is because: > > (boundp 'global-text-scale-adjust-resizes-frames) => nil > > By contrast, if you try > > C-h f text-scale-adjust RET > > then the variable text-scale-mode-step in the *Help* buffer does get > the link appearance, and boundp returns non-nil for that variable. > > The reason seems to be that in the latter case typing the "C-h f" > command causes face-remap.el to be loaded, whereas in the former case > face-remap.el is not loaded. I traced that to a problem which can be > demonstrated by the following recipe: > > emacs -Q > M-x load-library RET help-fns RET > > Now evaluate: > > (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust") > > This returns nil, whereas if you do the same with "text-scale-adjust", > you get: > > (("text-scale-" "face-remap") ("tex" "flyspell")) > > Interestingly, just appending a dash to global-text-scale-adjust, i.e. > > (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust-") > > does yield non-nil result: > > (("global-text-scale-adjust-" "face-remap")) > > The non-nil result causes help-fns.el:help--symbol-completion-table to > load the file: > > (when help-enable-completion-autoload > (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) > (help--load-prefixes prefixes))) > > The load happens inside help--load-prefixes. As result face-remap.el > is loaded for text-scale-adjust, and the variables defined in > face-remap.el become defined. With global-text-scale-adjust the > loading doesn't happen, and the variable stays unbound. > > This sounds like some snafu with some heuristic somewhere, perhaps in > radix-tree-prefixes, or in the code which registers the prefixes to > begin with? > > Can this be fixed, please, so that variables referenced in doc strings > would reliably be displayed as links? Adding Stefan. Stefan, any suggestions or ideas? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 17:55:52 2023 Received: (at 62300) by debbugs.gnu.org; 20 Mar 2023 21:55:52 +0000 Received: from localhost ([127.0.0.1]:56945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peNTr-0006u3-MP for submit@debbugs.gnu.org; Mon, 20 Mar 2023 17:55:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peNTp-0006tp-Jo for 62300@debbugs.gnu.org; Mon, 20 Mar 2023 17:55:50 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A252680AD5; Mon, 20 Mar 2023 17:55:43 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E9ABF800A8; Mon, 20 Mar 2023 17:55:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679349341; bh=I7sp9D4rbHyI6EMNOm5RDgaONKu0RfAdkHpBoiD6r7Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iDBOSGp1iD3/tdS6Rl/QRNK7anwvMYqHRTbjHOfCRDtynGndFYcCexJ4u2tiQQcc1 4vBkZXxv5jDypM2ptnYX2/V1/diIOPWeNhlUhX50LRsyCbx+w5SyVaufZEyFBByEIZ 0b9IDEH5zHdi9QTy9ddvj/B+7GHXFlB3H1aaER9IgzqYFNyfRo5Tp09cvMdpaAdw+T RV+IAF/OzKiVppXtGJAtHL7gQ+8YzTfqUlQ5KaG2HGcTn1ZvyBD6uelOTanKxHR6/4 AchFr0R488fji6G/3GT32Fkfd3kdwL1f+xk4ro6wXEyq0TfVu0oGLK7KFIhu1Zk02A OP1B0GgA/BGFA== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1D5E123210; Mon, 20 Mar 2023 17:55:41 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers In-Reply-To: <83ttyf6ys3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Mar 2023 20:52:28 +0200") Message-ID: References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> Date: Mon, 20 Mar 2023 17:55:40 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> emacs -Q >> C-h f global-text-scale-adjust RET >> >> Observe that in the *Help* buffer the variable >> global-text-scale-adjust-resizes-frames does not have the link >> appearance. This is because: >> >> (boundp 'global-text-scale-adjust-resizes-frames) => nil `help-definition-prefixes` and friends (`help-enable-completion-autoload`, ...) are the result of a tradeoff: we offer to autoload files "on demand" but the "demand" is often vague/implicit, so we have to judge when the demand is clear enough to justify loading a file and when it's not. If we're too trigger happy, we can end up auto-loading all the .el files in sight, making Emacs unnecessarily bigger&slower (and increasing the risk that we bump into a file that breaks the convention, such as `c-ts-mode`). In this case, `global-text-scale-adjust` has an explicit autoload in `loaddefs.el` so we already have the docstring needed to display `C-h f global-text-scale-adjust RET` without having to load `face-remap.el`, so `help-enable-completion-autoload` doesn't load `face-remap.el`. >> By contrast, if you try >> >> C-h f text-scale-adjust RET >> >> then the variable text-scale-mode-step in the *Help* buffer does get >> the link appearance, and boundp returns non-nil for that variable. Among the prefixes registered for `face-remap.el` there is `text-scale-` because there are various other functions beside `text-scale-adjust` which start with `text-scale-`. I'm not completely sure why we end up loading `face-remap.el` here (it doesn't seem necessary since the function is also autoloaded), but this difference in the definition-prefixes is probably the reason for the difference in behavior (apparently completion gets involved somewhere even tho it's not needed). >> (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust") >> >> This returns nil, whereas if you do the same with "text-scale-adjust", >> you get: >> >> (("text-scale-" "face-remap") ("tex" "flyspell")) >> >> Interestingly, just appending a dash to global-text-scale-adjust, i.e. >> >> (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust-") Yup: in `face-remap.el`, all the definitions that aren't known before the file is loaded (i.e. not autoloaded) and whose name starts with "global-text-" also start with "global-text-scale-adjust-", so the definition-prefixes data registers this longer prefix, which is more precise. BTW, this is also related to the part of `C-h f` which loads autoloaded functions when it sees something like \\< or \\[ (this is controlled by `help-enable-autoload`). We could change it so it does it also when it sees `...' in the docstring. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 09:11:38 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 13:11:38 +0000 Received: from localhost ([127.0.0.1]:57916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pebm5-0006TF-NQ for submit@debbugs.gnu.org; Tue, 21 Mar 2023 09:11:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pebm4-0006T3-Nr for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 09:11:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peblz-0000S3-G4; Tue, 21 Mar 2023 09:11:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t4Mcynog+1MDGMws8xVQYqMwwr76aWrU71b6aZpMWQk=; b=R6vwUcaCWgaj 7fjnUUYJvAu0Vr9LqEFPaFHeNzeMirEp83LY5wCu4leaOOubQL9eFTmQ9wCQuFnz8jFf6yhd7FS+c twLLYTz/bgPo2V86E3p3x0JGEs93uQJfgoBuiggttJsuBwg9qMavIkgJqpQN7CYpKuuKc9EAHC14N iYBWRflguhxTprQcOhBNED+haxKOS5Cvf2Ht32M2et+wfyGCgEEW20Onwc7XcMf9CQ3aYBu5CS+dd F7SVR5funjHZRIIeK7XCI5t+H4zm5wAj+6hdnKeAgEXwwfDTAEvqst5pXgknVOmW4wR+ofOtbGSSq 6yZTANBvarM7MVVYE35K9w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pebly-0002da-Rx; Tue, 21 Mar 2023 09:11:31 -0400 Date: Tue, 21 Mar 2023 15:11:42 +0200 Message-Id: <83lejq6ygh.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 20 Mar 2023 17:55:40 -0400) Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 62300@debbugs.gnu.org > Date: Mon, 20 Mar 2023 17:55:40 -0400 > > >> emacs -Q > >> C-h f global-text-scale-adjust RET > >> > >> Observe that in the *Help* buffer the variable > >> global-text-scale-adjust-resizes-frames does not have the link > >> appearance. This is because: > >> > >> (boundp 'global-text-scale-adjust-resizes-frames) => nil > > `help-definition-prefixes` and friends > (`help-enable-completion-autoload`, ...) are the result of a tradeoff: > we offer to autoload files "on demand" but the "demand" is often > vague/implicit, so we have to judge when the demand is clear enough to > justify loading a file and when it's not. > > If we're too trigger happy, we can end up auto-loading all the .el files > in sight, making Emacs unnecessarily bigger&slower (and increasing the > risk that we bump into a file that breaks the convention, such as > `c-ts-mode`). > > In this case, `global-text-scale-adjust` has an explicit autoload in > `loaddefs.el` so we already have the docstring needed to display > `C-h f global-text-scale-adjust RET` without having to load > `face-remap.el`, so `help-enable-completion-autoload` doesn't load > `face-remap.el`. So you are saying that the only way of having global-text-scale-adjust-resizes-frames decorated as a link is to autoload it? Even though autoloading defcustoms is frowned upon? Or is there a better way? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 10:20:06 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 14:20:06 +0000 Received: from localhost ([127.0.0.1]:60106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecqL-0005Ea-Oi for submit@debbugs.gnu.org; Tue, 21 Mar 2023 10:20:06 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecqK-0005Du-DD for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 10:20:04 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A61AB1000DF; Tue, 21 Mar 2023 10:19:58 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 594741000BE; Tue, 21 Mar 2023 10:19:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679408397; bh=YJG3Ye0VJZDre3rpNQLI4l73ptQgBjWBvDiNAVZ0DOM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=B9QP++35GgzaBI/S38oU7jkO6XqMffRZBVwrAz95uraOry4pxCHxAdSeXIrSjlnGK j9UfSydBU+8sXvc3SDtTrOacDM4z7pesVAI2qMSawM3IP5hBjX5ZujR6hIOfMUi0DO MUU7JI7TaTZXVeB04NAyIvgCi1RCyWc97Rnx3iEK/Ka2IAukCXWAXWLmFudN92APbr TSwvAX2SXn0r1sJwTsQU63hcZ7kbi0Txi095cuTO3sJ/dapeXCffkgK8eDNpfQcWrn deOuCV3LOPye+L5OihK5/3Vpx4e5ILREFLgrftChkHTD4fZmsyUyqMkzStI3DZ415t xrjNCpy0Ikkag== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2EDE512328D; Tue, 21 Mar 2023 10:19:57 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers In-Reply-To: <83lejq6ygh.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Mar 2023 15:11:42 +0200") Message-ID: References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> Date: Tue, 21 Mar 2023 10:19:55 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > So you are saying that the only way of having > global-text-scale-adjust-resizes-frames decorated as a link is to > autoload it? Not at all, no, I must have been unclear somewhere (maybe because there's "autoload" as in using a `;;;###autoload` cookie somewhere, and "autoload" as in having help-fns.el `load`ing a file in response to something the user did in order to try and get more information about the contents in that file). I was saying that we can avoid the discrepancy either by: - Change `help-enable-autoload` to also cause `help-fns.el` to (auto)load `face-remap.el` when you do `C-h f global-text-scale-adjust RET` - To try and figure out why `C-h f text-scale-adjust RET` causes `help-fns.el` to (auto)load `face-remap.el` (presumably conditioned on `help-enable-completion-autoload`) and change it so it behaves like `C-h f global-text-scale-adjust RET` instead. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 13:26:27 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 17:26:27 +0000 Received: from localhost ([127.0.0.1]:60447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pefkg-0000ZG-MX for submit@debbugs.gnu.org; Tue, 21 Mar 2023 13:26:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pefke-0000Z3-Rx for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 13:26:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pefkZ-0007wE-5K; Tue, 21 Mar 2023 13:26:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ud2h4sczkNR8lwmvb7VFyzL8TekXPLSQXCAhYWh/Tgw=; b=WujUaCOgR0OP jSZt4inaraU9FLbyODJLbLzb8Zxzru5/z4raXu4+F6D1/R77wt36ii0hC/IkfZKBHFPtFADpbxdyG 1C42yKxp1tMciBHAVw8O4AfdIXP0jYWm8nj0BPG9PQ9WPVGyaIurm4NVurRheCQk9Ni2HXlaxBv/7 b6YLsh7cHQfqOi+RnA56HfQH5uNHEsp2Ezp41w1NstQbBgaZf4/OJ28cM/J+d8xHL2JunkBaUul03 ETHTA6unt6tyL7rZtywFiBVKQmST3iQyf8IORwrVe5Z/6e8jYRiWszez4V6/WBfutfOWwy0Vwm6U7 BoQkRQh/Cl1AKo1CvApkfQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pefkX-0007hZ-8t; Tue, 21 Mar 2023 13:26:18 -0400 Date: Tue, 21 Mar 2023 19:26:29 +0200 Message-Id: <83a6066mnu.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Tue, 21 Mar 2023 10:19:55 -0400) Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 62300@debbugs.gnu.org > Date: Tue, 21 Mar 2023 10:19:55 -0400 > > > So you are saying that the only way of having > > global-text-scale-adjust-resizes-frames decorated as a link is to > > autoload it? > > Not at all, no, I must have been unclear somewhere (maybe because > there's "autoload" as in using a `;;;###autoload` cookie somewhere, and > "autoload" as in having help-fns.el `load`ing a file in response to > something the user did in order to try and get more information about > the contents in that file). > > I was saying that we can avoid the discrepancy either by: > - Change `help-enable-autoload` to also cause `help-fns.el` to (auto)load > `face-remap.el` when you do `C-h f global-text-scale-adjust RET` > - To try and figure out why `C-h f text-scale-adjust RET` > causes `help-fns.el` to (auto)load `face-remap.el` (presumably > conditioned on `help-enable-completion-autoload`) and change it so > it behaves like `C-h f global-text-scale-adjust RET` instead. The latter means a regression, since symbols mentioned in the doc string of text-scale-adjust will not be buttonized, like symbols in the doc string of global-text-scale-adjust aren't now. I'd like to find a solution that would cause symbols in both doc strings to be buttonized (autoloading the defcustom does). From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:00:06 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 18:00:06 +0000 Received: from localhost ([127.0.0.1]:60494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegHG-0001Wi-JO for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:00:06 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegHF-0001Vf-OI for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 14:00:06 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 532AD808F9; Tue, 21 Mar 2023 14:00:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C5624805D4; Tue, 21 Mar 2023 13:59:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679421598; bh=OQCGhM5pEzJEjq13FZ1Rgu1M2gwLQgCutc8HwVPxan8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BZuBFCJPQCqK3IJkWw6uE1GMpJfwRk2X9PnByiL/QXsx7XSJFdt11Iywna2TlcMei 2FIB1I8ryKt/CX2Zf4cOZk5sG8swYIPFmXgKJyl3QW/Kvif8VLNhRGnE8e2CTvFg04 F9tkwEeyjisNKpCV7Uv7u99hJ0ZGW2EqR/nbZKQFjc/4CfBsrGiEP31Wsz3GxWuAzJ l0Ko8wpWfdHHTFobb5zipyna27VV98O7l1tqPGUxy4n4phlvWgs+Nej7IZWqVR9hbI SLLXOz6/m4bZIcBbHARVhkWZ0ZmIOHvr0py1Ay/U50Ds7cYUBQP8p9fXKZnq7/Quj/ DFRF4G4H25qDQ== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6292D123254; Tue, 21 Mar 2023 13:59:58 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers In-Reply-To: <83a6066mnu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Mar 2023 19:26:29 +0200") Message-ID: References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> Date: Tue, 21 Mar 2023 13:59:50 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The latter means a regression, since symbols mentioned in the doc > string of text-scale-adjust will not be buttonized, like symbols in > the doc string of global-text-scale-adjust aren't now. I'd like to > find a solution that would cause symbols in both doc strings to be > buttonized (autoloading the defcustom does). The difference between the two use cases is largely accidental (due to details of how the definition-prefixes functionality works). I don't think tweaking the definition-prefixes would be wise way to solve this problem. (describe-function 'text-scale-adjust) suffers from the same "problem". We have not treated this as a problem until now, but if we want to treat it as a problem, then I suggest we do it by refining the way `help-enable-autoload` works. E.g. with the patch below. Stefan diff --git a/lisp/help-fns.el b/lisp/help-fns.el index a81051cee03..083acc5c98c 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1138,7 +1138,7 @@ describe-function-1 ;; key substitution constructs, load the library. (and (autoloadp real-def) doc-raw help-enable-autoload - (string-match "\\([^\\]=\\|[^=]\\|\\`\\)\\\\[[{<]" doc-raw) + (string-match "\\([^\\]=\\|[^=]\\|\\`\\)\\\\[[{<]\\|`.*'" doc-raw) (autoload-do-load real-def)) (help-fns--key-bindings function) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:23:02 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 18:23:02 +0000 Received: from localhost ([127.0.0.1]:60564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegdS-0004bd-1O for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:23:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegdQ-0004b6-4k for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 14:23:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pegdK-0005SJ-3k; Tue, 21 Mar 2023 14:22:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UAqK3I0puVijGRsVgIn8wGA2MO8c1Ne0A052aivU+7o=; b=nBPhK19e27ir YhPkvP/1ZyZ5K+0SE6OLkS/4iXur35NEx/GgArm4K/D2yPhBXVRQkAPNoFDTDVrthqsB3oEjLPdbE IsNDRsvUFlG4a3iWoPJj71tsMhpH3/uqrFjXa77Hw8sjIA8W6sd6hrrlrMyTLokRW8vE9516YVnd7 4JyKDctz79x2Xc2EpP0tZ/ruVBMQ4GjWNtLR5NRW+djMld4aSJG5w70Aq3ku8sEQi4iMOv7CTlyBO fgicbhMIzwGI+gqkCnmBfVTpEsR/jM/xLT/i9OHCH/oT40YZQM43u7aFtfbXDeYnRpe5UrC61lzXq /3QuvFYrfFpHwQwZi0v7Yw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pegdH-0006wE-U1; Tue, 21 Mar 2023 14:22:53 -0400 Date: Tue, 21 Mar 2023 20:23:03 +0200 Message-Id: <835yau6k1k.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Tue, 21 Mar 2023 13:59:50 -0400) Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 62300@debbugs.gnu.org > Date: Tue, 21 Mar 2023 13:59:50 -0400 > > > The latter means a regression, since symbols mentioned in the doc > > string of text-scale-adjust will not be buttonized, like symbols in > > the doc string of global-text-scale-adjust aren't now. I'd like to > > find a solution that would cause symbols in both doc strings to be > > buttonized (autoloading the defcustom does). > > The difference between the two use cases is largely accidental (due to > details of how the definition-prefixes functionality works). I don't > think tweaking the definition-prefixes would be wise way to solve > this problem. > > (describe-function 'text-scale-adjust) suffers from the same "problem". > We have not treated this as a problem until now, but if we want to treat > it as a problem, then I suggest we do it by refining the way > `help-enable-autoload` works. > > E.g. with the patch below. Thanks. Do you consider this safe enough for the emacs-29 branch? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 15:09:16 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 19:09:16 +0000 Received: from localhost ([127.0.0.1]:60675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pehMC-0005yj-Hs for submit@debbugs.gnu.org; Tue, 21 Mar 2023 15:09:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pehMA-0005yG-DG for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 15:09:15 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C7A8680443; Tue, 21 Mar 2023 15:09:08 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C3038801D6; Tue, 21 Mar 2023 15:09:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679425742; bh=bAOL1pZ1vAeEZNilgVAUhmkk1M0DmoEtthxnS6WBvq8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HM95MQmQDeUBvsOyuuzMk8Zl19jMmEgiyPr8CarRhCPqy5j+26gcW/tdraC7rN8hr BcYXMRTl7xd01aibzLnkIBgtYG7K17rlW8BXYFysZqMxnk78oxByuiWK/P+5PQxrYX RkoWXF1HSsNedtQS2ZHgrN/gsUvaQ5l0BAZKO/RGR/5++BsPgzPh4SWs2ec3bdz3zY 1b2/CefpsKmlhkZaZoJJIvp6NJde86OUBRxFLaCfRWgOPiu/WgfEVK3rpxZzIEA2de xCqIJTz5P5bk9CvMFYrAAvPKExXCdEgm9I2OT6+t0so8pUhAF32wvJkQsXmn8GNISS vP0Hug4V6ItxA== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4F6CE121322; Tue, 21 Mar 2023 15:09:02 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers In-Reply-To: <835yau6k1k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Mar 2023 20:23:03 +0200") Message-ID: References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> <835yau6k1k.fsf@gnu.org> Date: Tue, 21 Mar 2023 15:09:00 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> E.g. with the patch below. > Thanks. Do you consider this safe enough for the emacs-29 branch? The risk is very small, but the gain is also very small (the problem is definitely not a regression: AFAICT this is unchanged since Emacs-26 and before that the result was more consistent but with fewer links). I'd keep it on `master`, personally. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 15:54:20 2023 Received: (at 62300) by debbugs.gnu.org; 21 Mar 2023 19:54:21 +0000 Received: from localhost ([127.0.0.1]:60794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pei3o-0003kQ-Go for submit@debbugs.gnu.org; Tue, 21 Mar 2023 15:54:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pei3m-0003kC-RY for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 15:54:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pei3g-0007HO-Th; Tue, 21 Mar 2023 15:54:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bPF/qdw5dnBZda6cdKLVJyKTxkv3Z02JJNXuceZWD54=; b=aBh+WMXS83co eZoZNqxDW9bgGbQoOxA7H9YQfJlUHlQisTqne7uN6Pd30Afgh1XMGku7xfJlTlTUp//3nDDy+wM4j 9JMmx6ZJEQizyEQyFPYETJbroLohlxvwSKtQTodK2vUsYaZW5RaYuKrk0PrhXb6Njh4TusuflrcrW xTU9s/QKpqAmYEOZl7c/8iwX5h5sYES3aa4z+ZWcdDWlJYLV6275ccsFAqyLu4Ca4EScTDwBqdPnZ PF8epMasBA7cvmEiw8a569SQ8h+aVFmmHVg8UxxxZjb93FqsP76BE+nT6bPbbFRYb4/cfdLhXUV+L H6zZH521/MFKHW8PN7k14A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pei3g-0008Lm-E2; Tue, 21 Mar 2023 15:54:12 -0400 Date: Tue, 21 Mar 2023 21:54:24 +0200 Message-Id: <834jqd7udr.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Tue, 21 Mar 2023 15:09:00 -0400) Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> <835yau6k1k.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 62300@debbugs.gnu.org > Date: Tue, 21 Mar 2023 15:09:00 -0400 > > >> E.g. with the patch below. > > Thanks. Do you consider this safe enough for the emacs-29 branch? > > The risk is very small, but the gain is also very small (the problem > is definitely not a regression: AFAICT this is unchanged since Emacs-26 > and before that the result was more consistent but with fewer links). > > I'd keep it on `master`, personally. OK, master it is, then. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 21:48:52 2023 Received: (at 62300) by debbugs.gnu.org; 22 Mar 2023 01:48:52 +0000 Received: from localhost ([127.0.0.1]:33032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1penau-00046h-3c for submit@debbugs.gnu.org; Tue, 21 Mar 2023 21:48:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1penas-00046R-Nt for 62300@debbugs.gnu.org; Tue, 21 Mar 2023 21:48:50 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EA427808F9; Tue, 21 Mar 2023 21:48:44 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C4EFD80443; Tue, 21 Mar 2023 21:48:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679449723; bh=J97r2mZKE5eCIRu881ZuG8AaBPOJXrj2bcCep4441BI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pKyrFUaKFk5xcB5PL9CqtI56++UaRUZ1blxMmtJxF953fnyfOU3CdSnqOUxUbfq0B 4IdBwiR4iSwtLk2BoNSlxMSCiSjN8YvJYiX39mBM/TEnvBzmA0onoU5kJ5gvxjAzkH f5dszp1GSk1dc0z9DdRGiW0qSZv9YOBcsiEBfRg/jmBary8QWvqPydcuo5KV+R7V9o AodaDG1g7/OjnmOOijzKKKLerC9zqqw69fBgeKxHpIm3v98pTfDhngwVsTIB6+7DxH zituGc/NehBxOgwZrDfbDKoKQTs3cNagm0/i1bdyPC/1WVZBG+PEXwj3JSTcVdCgYn jkhw/oJpaRb/A== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A0F70120B04; Tue, 21 Mar 2023 21:48:43 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers In-Reply-To: <834jqd7udr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Mar 2023 21:54:24 +0200") Message-ID: References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> <835yau6k1k.fsf@gnu.org> <834jqd7udr.fsf@gnu.org> Date: Tue, 21 Mar 2023 21:48:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300 Cc: 62300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > OK, master it is, then. Pushed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 11:52:53 2023 Received: (at 62300-done) by debbugs.gnu.org; 22 Mar 2023 15:52:53 +0000 Received: from localhost ([127.0.0.1]:36405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf0lg-0007FI-NN for submit@debbugs.gnu.org; Wed, 22 Mar 2023 11:52:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf0le-0007F3-IM for 62300-done@debbugs.gnu.org; Wed, 22 Mar 2023 11:52:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf0lZ-0008H7-2e; Wed, 22 Mar 2023 11:52:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z4qCvYGM5xfWdjDnp4Lod5tSHKS0UCOZp6370mzhe24=; b=WKhDs/RW+ajZ 0mPxw2H0/dDb4C7Zim+TJh9hobncEH5F2DktHtUbRFz1D9fNwytV33xhqY/g3n131SBz0at1QbPjf fHz3XmYkJO9dhR83P/H0RA7fMOZEmVYiXa/xsAzO2Q8S7Q6W72pXKfx98sGtF1byX2RtNQH6CFsOC ozO+VXY4YiHxgruRWc3+ZUyaUhYLt/qrVKtUBfjgMU+X9SxZt2dD+F8Ca5O58fw5m4TqniNGT6fSO QRWIVXW65IvcOsHPhlehFsKpKB3Ya01i59MHdQlRWl/Wwa1YxyG5dj5RatoU+IWfxOisKrjeYSU5S pzF0ZW+admz1Ag8EMav1cg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf0lY-0001JK-Ij; Wed, 22 Mar 2023 11:52:44 -0400 Date: Wed, 22 Mar 2023 17:52:59 +0200 Message-Id: <83pm906aw4.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Tue, 21 Mar 2023 21:48:42 -0400) Subject: Re: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers References: <83y1nr6zmr.fsf@gnu.org> <83ttyf6ys3.fsf@gnu.org> <83lejq6ygh.fsf@gnu.org> <83a6066mnu.fsf@gnu.org> <835yau6k1k.fsf@gnu.org> <834jqd7udr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62300-done Cc: 62300-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 62300@debbugs.gnu.org > Date: Tue, 21 Mar 2023 21:48:42 -0400 > > > OK, master it is, then. > > Pushed, Thanks, closing. From unknown Thu Jun 19 16:16:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Apr 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator