GNU bug report logs - #62298
[PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 62298 <at> debbugs.gnu.org, ludo <at> gnu.org, liliana.prikler <at> gmail.com
Subject: [bug#62298] [PATCH v2 2/8] services: replace bare serializers with (serializer ...)
Date: Fri, 24 Mar 2023 10:28:05 -0400

Bruno Victal <mirai <at> makinata.eu> writes:

> * gnu/home/services/shells.scm (home-zsh-configuration)[environment-variables]: Use (serializer ...).
> (home-bash-configuration)[aliases, environment-variables]: Ditto.
> (home-fish-configuration)[abbreviations, aliases, environment-variables]: Ditto.
> * gnu/services/audio.scm (mpd-configuration)[music-dir, playlist-dir, endpoints]
> [address, inputs, archive-plugins, input-cache-size, decoders, filters, playlist-plugins]: Ditto.
> * gnu/services/linux.scm (fstrim-configuration)[extra-arguments]: Ditto.
> * gnu/services/security.scm (fail2ban-jail-configuration)[backend, log-encoding, extra-content]: Ditto.
> * tests/services/configuration.scm: Update tests. Add test for deprecated bare serializers.

The commit message should be line-wrapped around 80 chars and the title
should be puncutated like: "services: Replace [...] ."

The rest LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.