GNU bug report logs - #62298
[PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes

Previous Next

Full log

Message #80 received at 62298 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 62298 <at> debbugs.gnu.org, ludo <at> gnu.org, liliana.prikler <at> gmail.com
Subject: Re: [PATCH v2 4/8] services: mympd: Require 'syslog service when
 configured to log to syslog.
Date: Fri, 24 Mar 2023 10:32:17 -0400

Hi,

Bruno Victal <mirai <at> makinata.eu> writes:

> * gnu/services/audio.scm (mympd-shepherd-service): Depend on 'syslog when
> configured to log to syslog.
> ---
>  gnu/services/audio.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
> index e9ecccd614..e5b065a479 100644
> --- a/gnu/services/audio.scm
> +++ b/gnu/services/audio.scm
> @@ -749,7 +749,9 @@ (define (mympd-shepherd-service config)
>      (let ((log-level* (format #f "MYMPD_LOGLEVEL=~a" log-level)))
>        (shepherd-service
>         (documentation "Run the myMPD daemon.")
> -       (requirement `(loopback user-processes ,@shepherd-requirement))
> +       (requirement `(loopback user-processes
> +                               ,@(if (eqv? log-to 'syslog) '(syslog) '())

eq? is sufficient to compare symbols.  Otherwise, LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.