GNU bug report logs - #62298
[PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes

Previous Next

Package: guix-patches;

Reported by: Bruno Victal <mirai <at> makinata.eu>

Date: Mon, 20 Mar 2023 16:47:01 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62298: closed ([PATCH 0/8] Extensible define-configuration &
 mpd/mympd service fixes)
Date: Sun, 02 Apr 2023 10:47:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 02 Apr 2023 12:46:12 +0200
with message-id <7c60556d021507973524cdbadc496571a678b826.camel <at> gmail.com>
and subject line Re: [PATCH v4 1/5] services: configuration: Add user-defined sanitizer support.
has caused the debbugs.gnu.org bug report #62298,
regarding [PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62298: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62298
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes
Date: Mon, 20 Mar 2023 16:45:47 +0000
Highlights:

* Make define-configuration extensible.
  define-configuration can now have extra fields where custom-serializer
  was located.

  * New literals: sanitizer, serializer.
    Support user-specified sanitizers.    

* Fixes <https://issues.guix.gnu.org/61570>.
  * Switch to user-account/group for mympd-service-type as well.

* Make mpd-service-type with pulseaudio usable out-of-the-box.

* Fix a mympd-service-type when logging with syslog.


Bruno Victal (8):
  services: configuration: Add user-defined sanitizer support.
  services: replace bare serializers with (serializer ...)
  services: audio: remove redundant list-of-string? predicate.
  services: mympd: Require 'syslog service when configured to log to
    syslog.
  services: mpd: Fix unintentional API breakage for mixer-type field.
  services: mpd: Set PulseAudio related variables as default value for
    environment-variables field.
  services: mpd: Use user-account (resp. user-group) for user (resp.
    group) fields.
  services: mympd: Use user-account (resp. user-group) for user (resp.
    group) fields.

 doc/guix.texi                    |  46 +++++--
 gnu/home/services/shells.scm     |  12 +-
 gnu/services/audio.scm           | 224 ++++++++++++++++++++++---------
 gnu/services/configuration.scm   |  97 ++++++++++---
 gnu/services/security.scm        |   6 +-
 tests/services/configuration.scm | 156 ++++++++++++++++++++-
 6 files changed, 431 insertions(+), 110 deletions(-)

-- 
2.39.1



[Message part 3 (message/rfc822, inline)]
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>, 62298-done <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH v4 1/5] services: configuration: Add user-defined
 sanitizer support.
Date: Sun, 02 Apr 2023 12:46:12 +0200
Am Sonntag, dem 26.03.2023 um 19:41 +0100 schrieb Bruno Victal:
> This changes the 'custom-serializer' field into a generic
> 'extra-args' field that can be extended to support new literals.
> With this mechanism, the literals 'sanitizer' allow for user-defined
> sanitizer procedures while the 'serializer' literal is used for
> custom serializer procedures. The 'empty-serializer' was also added
> as a 'literal' and can be used just like it was previously.
> ...
I pushed v4 with changes to the ChangeLog as necessary and the
following:

- mpd-user and mympd-user belong to %lazy-group.
- inject-user-into-group is %set-user-group.
- %mpd-user and %mpd-group are properly documented, 
  but remain unexported.
  Same for %mympd-user and %mympd-group.

Thanks for your hard work and cheers
Liliana


This bug report was last modified 2 years and 51 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.