From unknown Sat Jun 14 03:53:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62279: Add an option to restore C-h b "Prefix Command" output Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Mar 2023 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 62279@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167925401519785 (code B ref -1); Sun, 19 Mar 2023 19:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Mar 2023 19:26:55 +0000 Received: from localhost ([127.0.0.1]:52794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdygB-000593-4e for submit@debbugs.gnu.org; Sun, 19 Mar 2023 15:26:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:33140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdyg9-00058s-NR for submit@debbugs.gnu.org; Sun, 19 Mar 2023 15:26:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdyg9-00026N-Hh for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 15:26:53 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdyg6-00052t-C8 for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 15:26:53 -0400 Received: by mail-pj1-x1030.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso11917822pjc.1 for ; Sun, 19 Mar 2023 12:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rgrjr-com.20210112.gappssmtp.com; s=20210112; t=1679254009; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fTJQMNg0cs0io3vCHNWLgzxv5nBf53SZh6rkp7eF6po=; b=txnALV90Ut/j6LtBEm0AmdB5NTdR4MC9Qn8RD5+s/ouGw+8C8KFFYUT2KBZFdSPdNM N3airhU32172Ef0hhscwLd5R8/bhETnosDYSiQq6SqjqHRsiUqrl8ejL3Xy2jnaWeIpZ LA9lT0hkiNoh9t5cZ4dwXrggdp95P+6cSGELo8kImyLNvzp/quWUX1lWJhRSoqdWht+Y T4bQS0Kv7lD355JF6jpk64rvA+rKxpZu1dyRvW8UYWAj35udcx88Ibv4afjcfXGWh1i9 RyQt2cHi8HRSj7XNSc/vVWsfLG/Z7fwgWWwb9Osx6J1ftb+/ZMys3iyPzi+2Ess1ztik CKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679254009; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fTJQMNg0cs0io3vCHNWLgzxv5nBf53SZh6rkp7eF6po=; b=va5xXNu245QugsuCoh4mPF+1VldOuoVyZlwMyl1yEEVguLTcJTN567b4sQeDvOI17N jdqkRRmjf9f84TBs8Tl4snxfmaUyxu9gVOfPmteS1ZS89wgXd8QcfPq2cxvSKBhoN7TX GDP3xxpXJsnQj9s11qv+ZCuRXVO2mf2l8YorI0AjnvQaRhfOhG+RLbn169erFKDF9OcO a/flJgrZHX39EGPJw1bjU94ObIzp5cmoFZob15Lx0h2yEfPt79mLy6109Jz2YhUuHXrp DRP99gjpS/pPI4mcRJNwjiHPmhwlO1wMDyYwqXN7KR9v8Atv9v28PExaPFTs0Kjr5bpu 7prA== X-Gm-Message-State: AO0yUKXsoWb3vVPAnbwl/IjzRAKTZPl0jmc5ElGcXwvYK9AWjUJ8MDkD MJ/PZdkkIvQxeaMVbcbGwKIyt0AmS4+W/9jU344= X-Google-Smtp-Source: AK7set+2mxcXtXE79e7c8NbBMv7rfs3zWy57GJwHcdcZwTIq3bwuJorsTw10qlxZZlJJo5mGZngEaQ== X-Received: by 2002:a17:90a:19d1:b0:237:752f:1af0 with SMTP id 17-20020a17090a19d100b00237752f1af0mr16044457pjj.29.1679254008689; Sun, 19 Mar 2023 12:26:48 -0700 (PDT) Received: from orion.rgrjr.com ([2600:1700:7c2c:e000::24]) by smtp.gmail.com with ESMTPSA id q10-20020a17090a304a00b00233acae2ce6sm8077941pjl.23.2023.03.19.12.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 12:26:48 -0700 (PDT) From: Bob Rogers Date: Sun, 19 Mar 2023 12:26:46 -0700 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=2607:f8b0:4864:20::1030; envelope-from=rogers@rgrjr.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Tags: patch Pursuant to the 'No more "Prefix Command" in C-h m' discussion in the emacs-devel list. -- Bob Rogers http://www.rgrjr.com/ In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) of 2023-03-13 built on orion Repository revision: a79d209748857c7d63ac48a7172a89e5ad1e752b Repository branch: rgr-smtpmail-env-from Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: openSUSE Leap 15.4 Configured using: 'configure --with-dbus=no --with-gsettings=no --with-gif=ifavailable --with-tiff=no --with-gnutls=yes --with-gconf=no' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=describe-bindings-show-prefixes-2.patch Add an option to restore C-h b "Prefix Command" output * lisp/help.el (describe-bindings-show-prefixes): Option to enable prefixes. (describe-map): If true, restore "Prefix Command" output. * etc/NEWS: Describe the new option. diff --git a/etc/NEWS b/etc/NEWS index 3b02e85b691..5a4a038e953 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -61,6 +61,11 @@ This allows the user to customize the prompt that is appended by This is used for displaying the time and date components of 'display-time-mode'. +** New user option 'describe-bindings-show-prefixes'. +If true (the default is false), restores the "Prefix Command" entries +in 'describe-binding' ('C-h b') output for keys that are prefixes, the +details of which are shown later (regardless of this option setting). + * Editing Changes in Emacs 30.1 diff --git a/lisp/help.el b/lisp/help.el index 83be85b1ee4..37a08718f9d 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -717,6 +717,12 @@ describe-bindings-outline :group 'help :version "29.1") +(defcustom describe-bindings-show-prefixes nil + "Non-nil shows prefixes in the output buffer of `describe-bindings'." + :type 'boolean + :group 'help + :version "30.1") + (declare-function outline-hide-subtree "outline") (defun describe-bindings (&optional prefix buffer) @@ -1699,6 +1705,7 @@ describe-map (setq vect (cdr vect)) (setq end (caar vect)))) (when (or (not (eq start end)) + describe-bindings-show-prefixes ;; Don't output keymap prefixes. (not (keymapp definition))) (when first --=-=-=-- From unknown Sat Jun 14 03:53:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62279: Add an option to restore C-h b "Prefix Command" output Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Mar 2023 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Bob Rogers Cc: 62279@debbugs.gnu.org Received: via spool by 62279-submit@debbugs.gnu.org id=B62279.167925455720835 (code B ref 62279); Sun, 19 Mar 2023 19:36:01 +0000 Received: (at 62279) by debbugs.gnu.org; 19 Mar 2023 19:35:57 +0000 Received: from localhost ([127.0.0.1]:52814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdyou-0005Pz-LE for submit@debbugs.gnu.org; Sun, 19 Mar 2023 15:35:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdyor-0005Pm-GV for 62279@debbugs.gnu.org; Sun, 19 Mar 2023 15:35:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdyom-0000p7-6M; Sun, 19 Mar 2023 15:35:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Vh3/IeA6NEP6CX7PfbU+BxgvUp4IkxM4FfwQOgS8w0o=; b=AIMygW/YThU0 xEGEZRBCWJwBwqq6I1G3tNc8XCIBxg7LkPkg453FAAEhydBHKmD0BZrTfi6dlsyI27dq1s0IpXTlR y49xRguOEhDiGxadi8I88cQo399nyP53gu9AnElmpxKLGqoDLMNmYizHmaY1VzqlE5A7QaDeB5uYX +Yl7P3E6qn3Ah+7effA8I1yjPT6oU4nkP0JwancPD9zzYMTvVaWlOHS4iDnUtDc61rJRer5oWJzxR MqfVqE5ApCNOMQvqELWrEdMlevn5estqdDVP5pVPdxIS7YKEOPdp8dUTN8LV17C3xo1qq1WRSY7D5 SXRzcgjK8Y9fFTbjBs8E9g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdyoU-0000k3-Un; Sun, 19 Mar 2023 15:35:46 -0400 Date: Sun, 19 Mar 2023 21:35:37 +0200 Message-Id: <83zg888rg6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Bob Rogers on Sun, 19 Mar 2023 12:26:46 -0700) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Bob Rogers > Date: Sun, 19 Mar 2023 12:26:46 -0700 > > Pursuant to the 'No more "Prefix Command" in C-h m' discussion in the > emacs-devel list. Thanks. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -61,6 +61,11 @@ This allows the user to customize the prompt that is appended by > This is used for displaying the time and date components of > 'display-time-mode'. > > +** New user option 'describe-bindings-show-prefixes'. > +If true (the default is false), restores the "Prefix Command" entries We use "If non-nil", not "If true". And similarly for "false". > +in 'describe-binding' ('C-h b') output for keys that are prefixes, the > +details of which are shown later (regardless of this option setting). This NEWS entry should go to where the change in "C-h b"s behavior is described in NEWS (on emacs-29 branch), and should be reworded to tell users how to get the previous behavior back ("To get the previous behavior back, customize ..."). > +(defcustom describe-bindings-show-prefixes nil > + "Non-nil shows prefixes in the output buffer of `describe-bindings'." > + :type 'boolean > + :group 'help > + :version "30.1") This should be "29.1". Since the behavior change was introduced in Emacs 29, we need to add this option in the same version. From unknown Sat Jun 14 03:53:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62279: Add an option to restore C-h b "Prefix Command" output Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Mar 2023 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 62279@debbugs.gnu.org Received: via spool by 62279-submit@debbugs.gnu.org id=B62279.167925599532651 (code B ref 62279); Sun, 19 Mar 2023 20:00:02 +0000 Received: (at 62279) by debbugs.gnu.org; 19 Mar 2023 19:59:55 +0000 Received: from localhost ([127.0.0.1]:52833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdzC6-0008UY-Sj for submit@debbugs.gnu.org; Sun, 19 Mar 2023 15:59:55 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:41562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdzC4-0008UK-Uo for 62279@debbugs.gnu.org; Sun, 19 Mar 2023 15:59:53 -0400 Received: by mail-pj1-f50.google.com with SMTP id fy10-20020a17090b020a00b0023b4bcf0727so10406038pjb.0 for <62279@debbugs.gnu.org>; Sun, 19 Mar 2023 12:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rgrjr-com.20210112.gappssmtp.com; s=20210112; t=1679255987; h=references:in-reply-to:subject:cc:to:date:message-id :content-transfer-encoding:mime-version:from:from:to:cc:subject:date :message-id:reply-to; bh=ilK5LGlZEtIGYN9DehtHbYJH4SfiT6amUjk8rMtpWvU=; b=tUbX4jdkF4vOxqgULiae9+M363yemK2IysCD85y8ZTIbpU+oNWnxMEjwBbn8/XC1JB 6RJy0utRyu3bR5a1gsi6dTZfONpW42/lpDteh2GFQZUCAUw1eQzkYIwoyj7og3NT3n1X Le4/WvpM09n6/e6XtgCU7bFobGkBiIQi6JgDtXOX9Pm3KWlOHRgnTXBofJQpR9OH4sXc HTQq9DXFhKbYqc/rvkYMymZYqd9au6xthe/mDZ5X3DrZyaLW8Fld/m3AdkLcf1aOOii9 OrDe0K8RFqh1q2M4UeJ0anxOMqngTdEBnueO+HMPaEOT8lMvKHSUGIf+bicxaGVSyXv1 DXBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679255987; h=references:in-reply-to:subject:cc:to:date:message-id :content-transfer-encoding:mime-version:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ilK5LGlZEtIGYN9DehtHbYJH4SfiT6amUjk8rMtpWvU=; b=EGV5MruvgXKMuDAhAfQSJ77CTt+rJ+CANCiCrVuxnzTVouf/oW5iwKGzwMZzXph+eX /YzeE42uw6X3+vyaqj8blspWfYCVeYlLChoLBHUHccqzoPnvAoCLHhB9DpK6Ie2Rmrk9 l7jYOGx0SZrOUF5sIkMZ0C5PTl+JGyb0CM3/QHTzbKe3ftMdcBTVpG3lj3EaQzIHb/xN IZGZUCY8+v+2xpTl6C6NKQdgcC9CirkqgF7jcDualQARHqepacBietP0hJgYXlqgn/fK h8napXXQEes3zhsSezjXmu11vHwcIiZfOgt+sYM6aVFm+mIX2GwAq7fW6Ssa4zFD4v+D J6rQ== X-Gm-Message-State: AO0yUKVXYc+eCYDYmMtwUUIomJaARMCuLSUPIX8WWWp+tV/10EkIWVHA fPXJAngZ2SaB1LDJ1xPWr7x0kQ== X-Google-Smtp-Source: AK7set9jY67D7p+a1n82xIJTKz0G2AonVLcQ1h3UmdyMmDKYFr1TsqeGYwAVIt9kp9kqqJSPXZnM0A== X-Received: by 2002:a17:90a:4041:b0:23f:9445:318c with SMTP id k1-20020a17090a404100b0023f9445318cmr3869305pjg.38.1679255986952; Sun, 19 Mar 2023 12:59:46 -0700 (PDT) Received: from orion.rgrjr.com ([2600:1700:7c2c:e000::24]) by smtp.gmail.com with ESMTPSA id bh9-20020a17090b048900b0023af4eb597csm8293429pjb.52.2023.03.19.12.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 12:59:46 -0700 (PDT) From: Bob Rogers MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MfnzWuhdc8" Content-Transfer-Encoding: 7bit Message-ID: <25623.27057.76142.835365@orion.rgrjr.com> Date: Sun, 19 Mar 2023 12:59:45 -0700 In-Reply-To: <83zg888rg6.fsf@gnu.org> References: <83zg888rg6.fsf@gnu.org> X-Mailer: VM 8.2.0b under 30.0.50 (x86_64-pc-linux-gnu) X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --MfnzWuhdc8 Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit From: Eli Zaretskii Date: Sun, 19 Mar 2023 21:35:37 +0200 > From: Bob Rogers > Date: Sun, 19 Mar 2023 12:26:46 -0700 > > Pursuant to the 'No more "Prefix Command" in C-h m' discussion in the > emacs-devel list. Thanks. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -61,6 +61,11 @@ This allows the user to customize the prompt that is appended by > This is used for displaying the time and date components of > 'display-time-mode'. > > +** New user option 'describe-bindings-show-prefixes'. > +If true (the default is false), restores the "Prefix Command" entries We use "If non-nil", not "If true". And similarly for "false". Guess I've been thinking too much in Perl lately. ;-} > +in 'describe-binding' ('C-h b') output for keys that are prefixes, the > +details of which are shown later (regardless of this option setting). This NEWS entry should go to where the change in "C-h b"s behavior is described in NEWS (on emacs-29 branch), and should be reworded to tell users how to get the previous behavior back ("To get the previous behavior back, customize ..."). OK. I also subordinated it to the "Keymap descriptions have changed" entry, since that seemed apt. > +(defcustom describe-bindings-show-prefixes nil > + "Non-nil shows prefixes in the output buffer of `describe-bindings'." > + :type 'boolean > + :group 'help > + :version "30.1") This should be "29.1". Since the behavior change was introduced in Emacs 29, we need to add this option in the same version. OK, I wasn't sure Lars' change actually made it into 29. -- Bob --MfnzWuhdc8 Content-Type: text/x-patch; name="describe-bindings-show-prefixes-3.patch" Content-Disposition: inline; filename="describe-bindings-show-prefixes-3.patch" Content-Transfer-Encoding: 7bit Add an option to restore C-h b "Prefix Command" output * lisp/help.el (describe-bindings-show-prefixes): Option to enable prefixes. (describe-map): If true, restore "Prefix Command" output. * etc/NEWS: Describe the new option. diff --git a/etc/NEWS b/etc/NEWS index a5f9f8c6ec1..c4e16221d72 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -3563,6 +3563,10 @@ keymap descriptions have changed. In particular, prefix commands are not output at all, and instead of "??" for closures/functions, "[closure]"/"[lambda]" is output. +*** New user option 'describe-bindings-show-prefixes'. +To reinstate the "Prefix Command" entries in key binding output for +keys that are prefixes, set this option non-nil (the default is nil). + --- ** 'downcase' details have changed slightly. In certain locales, changing the case of an ASCII-range character may diff --git a/lisp/help.el b/lisp/help.el index 83be85b1ee4..3e450fe0763 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -717,6 +717,12 @@ describe-bindings-outline :group 'help :version "29.1") +(defcustom describe-bindings-show-prefixes nil + "Non-nil shows prefixes in the output buffer of `describe-bindings'." + :type 'boolean + :group 'help + :version "29.1") + (declare-function outline-hide-subtree "outline") (defun describe-bindings (&optional prefix buffer) @@ -1699,6 +1705,7 @@ describe-map (setq vect (cdr vect)) (setq end (caar vect)))) (when (or (not (eq start end)) + describe-bindings-show-prefixes ;; Don't output keymap prefixes. (not (keymapp definition))) (when first --MfnzWuhdc8-- From unknown Sat Jun 14 03:53:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bob Rogers Subject: bug#62279: closed (Re: bug#62279: Add an option to restore C-h b "Prefix Command" output) Message-ID: References: <835yar6f4e.fsf@gnu.org> X-Gnu-PR-Message: they-closed 62279 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 62279@debbugs.gnu.org Date: Thu, 23 Mar 2023 08:34:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1679560442-20429-1" This is a multi-part message in MIME format... ------------=_1679560442-20429-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62279: Add an option to restore C-h b "Prefix Command" output which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62279@debbugs.gnu.org. --=20 62279: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62279 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1679560442-20429-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62279-done) by debbugs.gnu.org; 23 Mar 2023 08:33:45 +0000 Received: from localhost ([127.0.0.1]:37304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfGOG-0005Ip-PZ for submit@debbugs.gnu.org; Thu, 23 Mar 2023 04:33:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfGOE-0005Id-UX for 62279-done@debbugs.gnu.org; Thu, 23 Mar 2023 04:33:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfGO9-00066O-J2; Thu, 23 Mar 2023 04:33:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KFkxvXFYXdyyCELjYcv31GsWQatCJmx1KZGFccGsBc4=; b=qYUr9itOtzlV hhKLRfsJooU6v9RAwL77juu5BNvNQwuAS5L8jHFqluJP59g+ODjgd9SydFtQydx480SepVLnSOXCw NQbA8/p0OlebvREkl8Ibf8hVLdpkb6IWtJssnnCG3VaeshHxZFyxz1yO2Y/iACaifnkg0KqbHmjwK 8tlOuvFFtAxAGQ5wK9CRvsfzlpcjKZurVosECmbDXZDHWCAuMRVNDqIj+grUQb8QV5Bwph66bOxrQ /575OyWCLj3iQGg9UCjh37m2H9+fnXWJwNqEUOqQB3TVZIMtjQDI1IwVbuFjwpZf6vkbcQ40vV6z+ zsuPy5LW+vwg1xAlIL0KTw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfGO8-0004ky-W9; Thu, 23 Mar 2023 04:33:37 -0400 Date: Thu, 23 Mar 2023 10:33:53 +0200 Message-Id: <835yar6f4e.fsf@gnu.org> From: Eli Zaretskii To: Bob Rogers In-Reply-To: <25623.27057.76142.835365@orion.rgrjr.com> (message from Bob Rogers on Sun, 19 Mar 2023 12:59:45 -0700) Subject: Re: bug#62279: Add an option to restore C-h b "Prefix Command" output References: <83zg888rg6.fsf@gnu.org> <25623.27057.76142.835365@orion.rgrjr.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62279-done Cc: 62279-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Bob Rogers > Date: Sun, 19 Mar 2023 12:59:45 -0700 > CC: 62279@debbugs.gnu.org > > From: Eli Zaretskii > Date: Sun, 19 Mar 2023 21:35:37 +0200 > > > From: Bob Rogers > > Date: Sun, 19 Mar 2023 12:26:46 -0700 > > > > Pursuant to the 'No more "Prefix Command" in C-h m' discussion in the > > emacs-devel list. > > Thanks. > > > --- a/etc/NEWS > > +++ b/etc/NEWS > > @@ -61,6 +61,11 @@ This allows the user to customize the prompt that is appended by > > This is used for displaying the time and date components of > > 'display-time-mode'. > > > > +** New user option 'describe-bindings-show-prefixes'. > > +If true (the default is false), restores the "Prefix Command" entries > > We use "If non-nil", not "If true". And similarly for "false". > > Guess I've been thinking too much in Perl lately. ;-} > > > +in 'describe-binding' ('C-h b') output for keys that are prefixes, the > > +details of which are shown later (regardless of this option setting). > > This NEWS entry should go to where the change in "C-h b"s behavior is > described in NEWS (on emacs-29 branch), and should be reworded to tell > users how to get the previous behavior back ("To get the previous > behavior back, customize ..."). > > OK. I also subordinated it to the "Keymap descriptions have changed" > entry, since that seemed apt. > > > +(defcustom describe-bindings-show-prefixes nil > > + "Non-nil shows prefixes in the output buffer of `describe-bindings'." > > + :type 'boolean > > + :group 'help > > + :version "30.1") > > This should be "29.1". Since the behavior change was introduced in > Emacs 29, we need to add this option in the same version. > > OK, I wasn't sure Lars' change actually made it into 29. Thanks, I've now installed this (with some minor changes) on the emacs-29 branch, and I'm therefore closing this bug. ------------=_1679560442-20429-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Mar 2023 19:26:55 +0000 Received: from localhost ([127.0.0.1]:52794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdygB-000593-4e for submit@debbugs.gnu.org; Sun, 19 Mar 2023 15:26:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:33140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdyg9-00058s-NR for submit@debbugs.gnu.org; Sun, 19 Mar 2023 15:26:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdyg9-00026N-Hh for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 15:26:53 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdyg6-00052t-C8 for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 15:26:53 -0400 Received: by mail-pj1-x1030.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso11917822pjc.1 for ; Sun, 19 Mar 2023 12:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rgrjr-com.20210112.gappssmtp.com; s=20210112; t=1679254009; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fTJQMNg0cs0io3vCHNWLgzxv5nBf53SZh6rkp7eF6po=; b=txnALV90Ut/j6LtBEm0AmdB5NTdR4MC9Qn8RD5+s/ouGw+8C8KFFYUT2KBZFdSPdNM N3airhU32172Ef0hhscwLd5R8/bhETnosDYSiQq6SqjqHRsiUqrl8ejL3Xy2jnaWeIpZ LA9lT0hkiNoh9t5cZ4dwXrggdp95P+6cSGELo8kImyLNvzp/quWUX1lWJhRSoqdWht+Y T4bQS0Kv7lD355JF6jpk64rvA+rKxpZu1dyRvW8UYWAj35udcx88Ibv4afjcfXGWh1i9 RyQt2cHi8HRSj7XNSc/vVWsfLG/Z7fwgWWwb9Osx6J1ftb+/ZMys3iyPzi+2Ess1ztik CKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679254009; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fTJQMNg0cs0io3vCHNWLgzxv5nBf53SZh6rkp7eF6po=; b=va5xXNu245QugsuCoh4mPF+1VldOuoVyZlwMyl1yEEVguLTcJTN567b4sQeDvOI17N jdqkRRmjf9f84TBs8Tl4snxfmaUyxu9gVOfPmteS1ZS89wgXd8QcfPq2cxvSKBhoN7TX GDP3xxpXJsnQj9s11qv+ZCuRXVO2mf2l8YorI0AjnvQaRhfOhG+RLbn169erFKDF9OcO a/flJgrZHX39EGPJw1bjU94ObIzp5cmoFZob15Lx0h2yEfPt79mLy6109Jz2YhUuHXrp DRP99gjpS/pPI4mcRJNwjiHPmhwlO1wMDyYwqXN7KR9v8Atv9v28PExaPFTs0Kjr5bpu 7prA== X-Gm-Message-State: AO0yUKXsoWb3vVPAnbwl/IjzRAKTZPl0jmc5ElGcXwvYK9AWjUJ8MDkD MJ/PZdkkIvQxeaMVbcbGwKIyt0AmS4+W/9jU344= X-Google-Smtp-Source: AK7set+2mxcXtXE79e7c8NbBMv7rfs3zWy57GJwHcdcZwTIq3bwuJorsTw10qlxZZlJJo5mGZngEaQ== X-Received: by 2002:a17:90a:19d1:b0:237:752f:1af0 with SMTP id 17-20020a17090a19d100b00237752f1af0mr16044457pjj.29.1679254008689; Sun, 19 Mar 2023 12:26:48 -0700 (PDT) Received: from orion.rgrjr.com ([2600:1700:7c2c:e000::24]) by smtp.gmail.com with ESMTPSA id q10-20020a17090a304a00b00233acae2ce6sm8077941pjl.23.2023.03.19.12.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 12:26:48 -0700 (PDT) From: Bob Rogers To: bug-gnu-emacs@gnu.org Subject: Add an option to restore C-h b "Prefix Command" output Date: Sun, 19 Mar 2023 12:26:46 -0700 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=2607:f8b0:4864:20::1030; envelope-from=rogers@rgrjr.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Tags: patch Pursuant to the 'No more "Prefix Command" in C-h m' discussion in the emacs-devel list. -- Bob Rogers http://www.rgrjr.com/ In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) of 2023-03-13 built on orion Repository revision: a79d209748857c7d63ac48a7172a89e5ad1e752b Repository branch: rgr-smtpmail-env-from Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: openSUSE Leap 15.4 Configured using: 'configure --with-dbus=no --with-gsettings=no --with-gif=ifavailable --with-tiff=no --with-gnutls=yes --with-gconf=no' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=describe-bindings-show-prefixes-2.patch Add an option to restore C-h b "Prefix Command" output * lisp/help.el (describe-bindings-show-prefixes): Option to enable prefixes. (describe-map): If true, restore "Prefix Command" output. * etc/NEWS: Describe the new option. diff --git a/etc/NEWS b/etc/NEWS index 3b02e85b691..5a4a038e953 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -61,6 +61,11 @@ This allows the user to customize the prompt that is appended by This is used for displaying the time and date components of 'display-time-mode'. +** New user option 'describe-bindings-show-prefixes'. +If true (the default is false), restores the "Prefix Command" entries +in 'describe-binding' ('C-h b') output for keys that are prefixes, the +details of which are shown later (regardless of this option setting). + * Editing Changes in Emacs 30.1 diff --git a/lisp/help.el b/lisp/help.el index 83be85b1ee4..37a08718f9d 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -717,6 +717,12 @@ describe-bindings-outline :group 'help :version "29.1") +(defcustom describe-bindings-show-prefixes nil + "Non-nil shows prefixes in the output buffer of `describe-bindings'." + :type 'boolean + :group 'help + :version "30.1") + (declare-function outline-hide-subtree "outline") (defun describe-bindings (&optional prefix buffer) @@ -1699,6 +1705,7 @@ describe-map (setq vect (cdr vect)) (setq end (caar vect)))) (when (or (not (eq start end)) + describe-bindings-show-prefixes ;; Don't output keymap prefixes. (not (keymapp definition))) (when first --=-=-=-- ------------=_1679560442-20429-1--