GNU bug report logs - #62274
[PATCH] home: 'home-environment-with-provenance' uses the HE location info.

Previous Next

Full log

Message #22 received at 62274 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Sergey Trofimov <sarg <at> sarg.org.ru>, Ludovic Courtès
 <ludo <at> gnu.org>
Cc: 62274 <at> debbugs.gnu.org, paren <at> disroot.org
Subject: Re: bug#62274: [PATCH] home: 'home-environment-with-provenance'
 uses the HE location info.
Date: Tue, 21 Mar 2023 14:56:18 +0400

[Message part 1 (text/plain, inline)]

On 2023-03-20 20:03, Sergey Trofimov wrote:

> Hi Ludovic,
>
>> Hi Sergey and all,
>>
>> Sergey Trofimov <sarg <at> sarg.org.ru> skribis:
>>
>>> * gnu/home.scm (home-environment-with-provenance): Make 
>>> `config-file`
>>> optional, with the default taken from the HE location info.
>>
>> [...]
>>
>>> +(define* (home-environment-with-provenance he
>>> +                                           #:optional
>>> +                                           (config-file
>>> + 
>>> (home-environment-configuration-file
>>> +                                             he)))
>>
>> AFAICS, there’s only one call site for
>> ‘home-environment-with-provenance’, and it passes two arguments. 
>> Thus,
>> the default value added by this patch will never be used.
>>
>> Am I missing something?
>
> You're right, the new signature is not used anywhere yet. Though 
> I'm working on a patch to embed home profiles in disk images 
> produced with `guix system image`. That's where this method comes 
> handy, see example usage:
>
> (image
>  (inherit efi-disk-image)
>  (operating-system (operating-system-with-provenance (load 
>  "./system.scm")))
>  (inputs
>   `(("guix-home"
>      ,(home-environment-with-provenance (load "./home.scm")))))
>  (partition-table-type 'gpt)
>  (volatile-root? #false))

Also, take a look at this thread:
https://yhetil.org/63960cf762aec1ed2c4182f49cac66bc37fce2aa.camel <at> rdmp.org

and this prototype:
https://git.sr.ht/~abcdw/rde/tree/044de83e980b7038b87d27a090aef24229df85eb/src/gnu/services/home.scm#L1

It can be related to what you want to achieve, whithout modifying
image-related code.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.