GNU bug report logs - #62274
[PATCH] home: 'home-environment-with-provenance' uses the HE location info.

Previous Next

Package: guix-patches;

Reported by: Sergey Trofimov <sarg <at> sarg.org.ru>

Date: Sun, 19 Mar 2023 15:46:01 UTC

Severity: normal

Tags: patch

Done: Andrew Tropin <andrew <at> trop.in>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 62274 <at> debbugs.gnu.org, paren <at> disroot.org, andrew <at> trop.in
Subject: [bug#62274] [PATCH] home: 'home-environment-with-provenance' uses the HE location info.
Date: Mon, 20 Mar 2023 20:03:00 +0100
Hi Ludovic,

> Hi Sergey and all,
>
> Sergey Trofimov <sarg <at> sarg.org.ru> skribis:
>
>> * gnu/home.scm (home-environment-with-provenance): Make 
>> `config-file`
>> optional, with the default taken from the HE location info.
>
> [...]
>
>> +(define* (home-environment-with-provenance he
>> +                                           #:optional
>> +                                           (config-file
>> + 
>> (home-environment-configuration-file
>> +                                             he)))
>
> AFAICS, there’s only one call site for
> ‘home-environment-with-provenance’, and it passes two arguments. 
> Thus,
> the default value added by this patch will never be used.
>
> Am I missing something?

You're right, the new signature is not used anywhere yet. Though 
I'm working on a patch to embed home profiles in disk images 
produced with `guix system image`. That's where this method comes 
handy, see example usage:

(image
(inherit efi-disk-image)
(operating-system (operating-system-with-provenance (load 
"./system.scm")))
(inputs
 `(("guix-home"
    ,(home-environment-with-provenance (load "./home.scm")))))
(partition-table-type 'gpt)
(volatile-root? #false))




This bug report was last modified 2 years and 144 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.