Subject: Re: bug#62274: [PATCH] home: 'home-environment-with-provenance' uses the HE location info.

From: Sergey Trofimov <[email-masked]>
Date: Mon, 20 Mar 2023 20:03:00 +0100

Hi Ludovic,

> Hi Sergey and all,
>
> Sergey Trofimov <[email-masked]> skribis:
>
>> * gnu/home.scm (home-environment-with-provenance): Make 
>> `config-file`
>> optional, with the default taken from the HE location info.
>
> [...]
>
>> +(define* (home-environment-with-provenance he
>> +                                           #:optional
>> +                                           (config-file
>> + 
>> (home-environment-configuration-file
>> +                                             he)))
>
> AFAICS, there’s only one call site for
> ‘home-environment-with-provenance’, and it passes two arguments. 
> Thus,
> the default value added by this patch will never be used.
>
> Am I missing something?

You're right, the new signature is not used anywhere yet. Though 
I'm working on a patch to embed home profiles in disk images 
produced with `guix system image`. That's where this method comes 
handy, see example usage:

(image
 (inherit efi-disk-image)
 (operating-system (operating-system-with-provenance (load 
 "./system.scm")))
 (inputs
  `(("guix-home"
     ,(home-environment-with-provenance (load "./home.scm")))))
 (partition-table-type 'gpt)
 (volatile-root? #false))