From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 11:18:18 2023 Received: (at submit) by debbugs.gnu.org; 18 Mar 2023 15:18:18 +0000 Received: from localhost ([127.0.0.1]:48889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdYK1-0006ts-T9 for submit@debbugs.gnu.org; Sat, 18 Mar 2023 11:18:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:54872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdYJz-0006tj-Fb for submit@debbugs.gnu.org; Sat, 18 Mar 2023 11:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdYJz-0005Bg-6g for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 11:18:15 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdYJw-0006cM-HZ for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 11:18:14 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=E+TA/VaJ 343jFlYIrb7K6H+WjELw6MLg2zhEW0BCzWg=; h=date:subject:to:from; d=ledu-giraud.fr; b=GWA7Fx/eysxc0HBUlgavDmwE2fYwec4QnZo7XuITJAtDf2+CbZ 5vDbVe10Fe+obuuNMD3qRZq/dFZNVAt/kNCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=E+TA/VaJ343jFlYI rb7K6H+WjELw6MLg2zhEW0BCzWg=; h=date:subject:to:from; d=ledu-giraud.fr; b=HBDcFVbXfwQx4OzParAkSDK8o5L5HRTqoxgwlq1n2RqA55Ep/I CiSOXhnJeURg78gKHhIdLkXR8vTWOOWTWLbf246uupP1UcLB+CDhOyxReeNsvkvxj1t4iT uisP/uQfJmDXfWNVZg8H3AnlLD/2rodMdfOxUY8q4brmyJw1trmLtj5h0Fe/BjWVFRnOkG WcLMoP2ZavS177i+SfApSkogIl/jA6j9Ui0F/OAuKkU2Fo6WojDGv6j3j7M4Fsl6zNMZ92 VNP8tR2hA6Ai343HC7h7mAi9wJHblwVZvaX6JMPvTuGxLlrdvtETHC0HuqpNW8wKncGOPy qH8KtdPc+AAw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1c264f6a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Mar 2023 16:18:09 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Restrict auto-save file mode Date: Sat, 18 Mar 2023 16:18:07 +0100 Message-ID: <87v8iynl5c.fsf@ledu-giraud.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, I'm surely missing something but wouldn't it be a good thing to tighten auto-save files mode. Mostly for remote or sudo files, this seems like a better default. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Restrict-auto-save-file-mode.patch >From 0039dd6b5076d3edd61b15f017c27d9424ad559e Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sat, 18 Mar 2023 16:10:44 +0100 Subject: [PATCH] Restrict auto-save file mode * src/fileio.c (auto_save_1): Restrict auto-save file to user's mode only. --- src/fileio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/fileio.c b/src/fileio.c index b80f8d61de4..73c7dc5e063 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -5905,20 +5905,20 @@ auto_save_1 (void) struct stat st; Lisp_Object modes; - auto_save_mode_bits = 0666; + auto_save_mode_bits = 0600; - /* Get visited file's mode to become the auto save file's mode. */ + /* Get visited file's user mode to become the auto save file's mode. */ if (! NILP (BVAR (current_buffer, filename))) { if (emacs_fstatat (AT_FDCWD, SSDATA (BVAR (current_buffer, filename)), &st, 0) == 0) /* But make sure we can overwrite it later! */ - auto_save_mode_bits = (st.st_mode | 0600) & 0777; + auto_save_mode_bits = (st.st_mode | 0600) & 0700; else if (modes = Ffile_modes (BVAR (current_buffer, filename), Qnil), FIXNUMP (modes)) /* Remote files don't cooperate with fstatat. */ - auto_save_mode_bits = (XFIXNUM (modes) | 0600) & 0777; + auto_save_mode_bits = (XFIXNUM (modes) | 0600) & 0700; } return -- 2.39.2 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.3, cairo version 1.17.8) of 2023-03-18 built on computer Repository revision: 4234e204ec0e73211e0041d78460b2c51913a517 Repository branch: mgi/restrict-auto-save Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD computer 7.3 GENERIC.MP#1105 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t gnus-dired-mode: t display-time-mode: t display-battery-mode: t server-mode: t shell-dirtrack-mode: t repeat-mode: t desktop-save-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-0.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs /home/manuel/.emacs.d/elpa/transient-0.3.7/transient hides /home/manuel/emacs/share/emacs/30.0.50/lisp/transient Features: (shadow sort mail-extr dabbrev emacsbug whitespace magit-patch tramp-cmds pulse magit-extras face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff git-commit log-edit add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-section magit-utils dash vc-bzr rfc2104 tramp-cache time-stamp tramp-sh org-indent idlwave idlwave-help idlw-help emacs-news-mode view vc-dir ewoc rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-enc xmltok pascal vc-cvs vc-rcs log-view pcvs-util conf-mode css-mode sgml-mode facemenu imenu vc-hg sh-script smie treesit executable smerge-mode diff oc-basic ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi mule-util paredit edmacro autorevert filenotify vc-git diff-mode vc-svn vc vc-dispatcher bug-reference gnus-dired time battery cus-load exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server modus-operandi-theme modus-themes ytdious mingus libmpdee reporter edebug debug backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell parse-time iso8601 ls-lisp slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop xref project arc-mode archive-mode pp hyperspec thingatpt slime-autoloads org-agenda org-element org-persist xdg org-id avl-tree generator org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc ansi-color ring org-list org-footnote org-faces org-entities time-date noutline outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table org-keys oc org-loaddefs find-func ol rx org-fold org-fold-core org-compat org-version org-macs format-spec appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-aux dired-x dired dired-loaddefs notifications dbus xml repeat easy-mmode desktop frameset osm-autoloads rust-mode-autoloads ebdb-autoloads compat-autoloads magit-autoloads debbugs-autoloads git-commit-autoloads magit-section-autoloads ef-themes-autoloads with-editor-autoloads paredit-autoloads dash-autoloads ytdious-autoloads transmission-autoloads transient-autoloads exwm-autoloads hyperbole-autoloads detached-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 765135 152535) (symbols 48 60399 6) (strings 32 197023 9623) (string-bytes 1 6230759) (vectors 16 117472) (vector-slots 8 2355311 71951) (floats 8 566 318) (intervals 56 21464 629) (buffers 984 137)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 11:43:06 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 15:43:07 +0000 Received: from localhost ([127.0.0.1]:48896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdYi2-0007Uo-Jv for submit@debbugs.gnu.org; Sat, 18 Mar 2023 11:43:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdYi0-0007UK-VL for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 11:43:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdYhu-0003e2-Hw; Sat, 18 Mar 2023 11:42:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OtyTbMaNBMLPbwKatIAxg4ArFXmrPsCxbL9O7EjjDWA=; b=CIlLFgWvpQvh hLE4yD8gzU5MHd43vBxgsEMVxfR191ocKTQUpETKDqG98y5IPFE0fQFyjRX/D3hzHDQaSGpz2LVrJ xemBJ4VRxTNt6l65I4aADj6ZUXd5npA2sK/wgJhmbUVUWexumnQO9X1+xZRMpL2LwU3DsfQUy25uZ WKdhUpAoCVBTQN2wJlOhmEP5n340iDzw+k5nIz4GPjRGoAcgll7o3zytobrHOH2oHBNQtZwxg4wLx QWRcYsmUx0q6yrT4GB/sWB4zPM0xTQcO19A28cS54R9q1wz+qoWMrOXQNia1AVjznBy8hg5fpXmi/ ldJfTC5lgbOt+BBvrkwhnA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdYhu-0004LJ-1N; Sat, 18 Mar 2023 11:42:58 -0400 Date: Sat, 18 Mar 2023 17:43:00 +0200 Message-Id: <83h6uiawvv.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87v8iynl5c.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 18 Mar 2023 16:18:07 +0100 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I'm surely missing something but wouldn't it be a good thing to tighten > auto-save files mode. Mostly for remote or sudo files, this seems like > a better default. That could make it impossible to overwrite the auto-save file later. So I don't think we should make this change. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 14:39:26 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 18:39:26 +0000 Received: from localhost ([127.0.0.1]:49059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbSf-0003n2-P2 for submit@debbugs.gnu.org; Sat, 18 Mar 2023 14:39:26 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:28683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbSd-0003mr-DL for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 14:39:24 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=wdasrZDb SCVBknDdLlUlktSS2LDyc2PPCuiWiatATX0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=avHSashQEYoIVyXDFKIBYrlS0QwTmD 8T3O3asiLFKYRChrGsRdxxtoVRtoRS/FdAlJ66l+jkiKbirKvTI4G1Dw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=wdasrZDbSCVBknDd LlUlktSS2LDyc2PPCuiWiatATX0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=owXEY8rzf8F+b9RGRTdi3Y24/x5+yy//D+jAPE qlIOLavwd1H6YyRiQElsAr3B9ixQVa3BeRZjTwWljlRARRtBoYPEFBRxAc0zNeP9xU+cIE 9ns8JnaiAIZ5GDwOPgBCWE2H56B0CHw8unmus85fgM0pp20odxH4hfD1mXcvsRanQMytpG yj+7CLWGv2NmmdLA3ur6KB5jQXY0Jo79zqSBVb1Rcl3XTR9Snks/+2xAA99i0tV62+Mz3X zs8pvWM9J2GHMJYeOFao7RlY8AiB+wgJ38SBqInFmx5eSK82iKf1Tj4aIpf5dbC7q4rqkQ m7hAyO2JgFUwpg4wEt3+BjMw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 80574bd1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Mar 2023 19:39:21 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <83h6uiawvv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Mar 2023 17:43:00 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> Date: Sat, 18 Mar 2023 19:39:20 +0100 Message-ID: <87r0tlnbtz.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > That could make it impossible to overwrite the auto-save file later. > So I don't think we should make this change. I've tried it but I'm not able to come with such an example. With this patch, the auto-save file has always a mode of 0600 even for a file with a mode of 0006 not own by me. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 14:47:22 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 18:47:22 +0000 Received: from localhost ([127.0.0.1]:49072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbaM-000404-B5 for submit@debbugs.gnu.org; Sat, 18 Mar 2023 14:47:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbaL-0003zq-5S for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 14:47:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdbaE-0001WA-U5; Sat, 18 Mar 2023 14:47:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rj2rnqZwjSaQxCNi2W1UAXHraQzL0tf6Rtp0AGtExqM=; b=Ak6gcFg3UcXI vklHOigSELV+hv+4QpWFR9rM6syal7bZwLJ2J7Q1QVI+n3K0nWBg20YdIxRptGmJkxxWiXkqMsB9z mQMzecdMbv2kHUKaL27QQGbLcP85OwyVtyM72J248IuWsxWQf0hUvrnWXLvDpMbw2+AmIOySXmK/U uHmCiRGGtfok1uGw6nkYqBiPylXQQOR/TG8geySqQciWtQps3/01HJdS4H8EUh/hN+Nz6oGDep/Yk Qtma++mXGsz68bFMsPh97DHXYvc2bStGvBUnNrnDotI3eiMbVBVx7B/nR20MWczmZbJgT6rEEDHRc LVKbdK2CNVHe9Id/N8fKSg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdbaD-0001Lc-Ue; Sat, 18 Mar 2023 14:47:14 -0400 Date: Sat, 18 Mar 2023 20:47:17 +0200 Message-Id: <83bkkpc2x6.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87r0tlnbtz.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 18 Mar 2023 19:39:20 +0100) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 62260@debbugs.gnu.org > Date: Sat, 18 Mar 2023 19:39:20 +0100 > > Eli Zaretskii writes: > > [...] > > > That could make it impossible to overwrite the auto-save file later. > > So I don't think we should make this change. > > I've tried it but I'm not able to come with such an example. With this > patch, the auto-save file has always a mode of 0600 even for a file with > a mode of 0006 not own by me. Did you try a different user? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 14:51:31 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 18:51:31 +0000 Received: from localhost ([127.0.0.1]:49081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbeN-0004B0-96 for submit@debbugs.gnu.org; Sat, 18 Mar 2023 14:51:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdbeL-0004Ao-J6 for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 14:51:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdbeG-0002Du-Bj; Sat, 18 Mar 2023 14:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UWF4RyW6JLicmiWInzcZ+Zkvlq/scCsoOhy2JvNNNQs=; b=dyi9axe8nsqP Y4Uz7WpbezHFYvPtMyLN4Egftl27hxQRb8mlZ7DccVsRQ4fr8lciSNl+GuzydYUpRFkLgGnSqb/us L4VgJgPP5AERKWJKPN87ndiNyXS1IwRFlM1EAZ14+/Po6fi3nyFnbwgf+KqCtTuW6+f9zO14wWjaQ rkSG5Z6UftcK2w+TAenNGw9I564LpUpoZJ2iRWNV/t+QM2qnvq2ZBpcrcVmta5mAyLByNKI36+qfy oHRg5pB17wljeu1FVwCIj71UuiDlDUqAm12L/N/lRjqm3dehZ6wYLbVZlTbHK/3Fsm1mphbiFqFtS U4k3xnbudRZ0wSlimK75wQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdbeF-0001p1-Op; Sat, 18 Mar 2023 14:51:24 -0400 Date: Sat, 18 Mar 2023 20:51:28 +0200 Message-Id: <83a609c2q7.fsf@gnu.org> From: Eli Zaretskii To: manuel@ledu-giraud.fr In-Reply-To: <83bkkpc2x6.fsf@gnu.org> (message from Eli Zaretskii on Sat, 18 Mar 2023 20:47:17 +0200) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 62260@debbugs.gnu.org > Date: Sat, 18 Mar 2023 20:47:17 +0200 > From: Eli Zaretskii > > > From: Manuel Giraud > > Cc: 62260@debbugs.gnu.org > > Date: Sat, 18 Mar 2023 19:39:20 +0100 > > > > Eli Zaretskii writes: > > > > [...] > > > > > That could make it impossible to overwrite the auto-save file later. > > > So I don't think we should make this change. > > > > I've tried it but I'm not able to come with such an example. With this > > patch, the auto-save file has always a mode of 0600 even for a file with > > a mode of 0006 not own by me. > > Did you try a different user? Actually, the right question is: what exactly did you try? As you can see from the code, 0666 value is used only for buffers that don't visit files. Did you try with such a buffer, and what exactly did you try? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 15:16:15 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 19:16:16 +0000 Received: from localhost ([127.0.0.1]:49086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdc2J-0004lb-Kb for submit@debbugs.gnu.org; Sat, 18 Mar 2023 15:16:15 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:17223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdc2G-0004lQ-5J for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 15:16:13 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=EBT4MGId JiI95KS2m5CggXkzTl3/ih1xYW2STf6wBlQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=8bb0lqh8qVwI1BTGRz4B2RMBPmdwse 95m5rm5WPiG5gvpNKROZc3LBGS/QI/bjjzZLAAU7IA6waZeLF5UGh0BA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=EBT4MGIdJiI95KS2 m5CggXkzTl3/ih1xYW2STf6wBlQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=oI7CKeMJlXHhIxQUvOPMMuVNTq5b+SQDxIDLxv 39pn6x0QKeynXUC2D/lhnWCE0bJ7/cEF9aYG879S21jlfCiD6NzoPI0FLpyz9EBuJ75yp6 rScC8G4Pv6H8Y3DYumogJSXM6udkOE6pJQdcEFyHmNKre8iPtzwIXlVlH1VhLiLBE9Izo1 755limPo6fgwAqbKrUbT+hapxSj/gFQCXDUJPhsgp5JIEHOQHh9wAGN6UBjFmHXt2CppF8 4v8faQdN2ajpey5o+hZ/WEBN+7PVJRr17SVjirECnrGETUMQP1Iija3rggiN4n/SkS6PY9 NWqdmpC7HmTC3aB28AM99YPQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 563be87c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Mar 2023 20:16:10 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <83bkkpc2x6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Mar 2023 20:47:17 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> Date: Sat, 18 Mar 2023 20:16:08 +0100 Message-ID: <87mt49na4n.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I've tried it but I'm not able to come with such an example. With this >> patch, the auto-save file has always a mode of 0600 even for a file with >> a mode of 0006 not own by me. > > Did you try a different user? I've just tried but with sudo over TRAMP. I had a message about the lock that I stole and then Emacs created another auto-save file with TRAMP naming (this file is also mode 0600). I guess that using TRAMP is cheating here and that I should really be another user using Emacs and trying to open this same file... Then I guess I won't be able to recover from (or write to) this auto-save file. But does this kind of scenarios appear in real life? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 15:23:00 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 19:23:00 +0000 Received: from localhost ([127.0.0.1]:49090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdc8q-0004v6-G2 for submit@debbugs.gnu.org; Sat, 18 Mar 2023 15:23:00 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:10801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdc8n-0004ux-Uh for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 15:22:59 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=zDM76Qx9 FGV9i1S76eF8GOMKNTZGmrMuo+ITB9DKmCE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=goF9kG7GR+acnpMRj77lZehbt3jged FGyCYwU/2urPlWvw87gLVMKJHcAwReiX+eMJQrwwQc1VZVb8sTWtRMCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=zDM76Qx9FGV9i1S7 6eF8GOMKNTZGmrMuo+ITB9DKmCE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=PS+/NYwtblkWULJatYQIHcghmzw6WZSYAkEtBz tETa82jnDgYDWVdvo/m0PoSLJE3BUenLrUNJ5dgnjenq6uhAooVTtQxWcD2XEuHxkEjziM gOQP2eCsr5L2ZYmqrEWqb5tW9jvrDlO7ZF/Ia9o2UZla2DxLWzqjkO/clH3/Kr6SwJEoM7 zqUOaXECYsLmOFWTspVvztzUNLcW1nx4fBF7eyZBQMRu1uBtpEN7eMaMc6rbPwwWZiov0L 1pk7z4wdjUp8R4l3u/T6LZ36GzdXbeMo6Vhj+DqzVctyHu/jSVdSlQYSvOB3MxOPiOJAFS 9h3U5xP2Q2pfAkM3jGN5eAzQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9fe44878 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Mar 2023 20:22:57 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <83a609c2q7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Mar 2023 20:51:28 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> Date: Sat, 18 Mar 2023 20:22:55 +0100 Message-ID: <87ilexn9tc.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Did you try a different user? > > Actually, the right question is: what exactly did you try? As you can > see from the code, 0666 value is used only for buffers that don't > visit files. Did you try with such a buffer, and what exactly did you > try? I didn't with a buffer not visiting a file. I have tried with a file in /tmp that by default on my system is created with mode 0644. Then I write something into this file and do 'M-x do-auto-save'. With this patch, the /tmp directory now contains an auto-save file with mode 0600. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 16:00:40 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 20:00:40 +0000 Received: from localhost ([127.0.0.1]:49098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdcjH-0005vp-Ph for submit@debbugs.gnu.org; Sat, 18 Mar 2023 16:00:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdcjG-0005vd-1f for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 16:00:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdcjA-0006Ls-69; Sat, 18 Mar 2023 16:00:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+MaZKr7kWBgFB6Rs5rv2NjZlG2DNlqPVipffjDhqLEk=; b=A/2fpx5lzChL LDWe2j0nQCFBXSs/gDQY+j8HIVNdFEtxmdJCIK3lxeyi7rhYfedOstL/VEoVNEH/dnqanSIjNRSAx lnWOI9f324PuCuWe2oHEgNsgS7M5RM1MakK/M4TombeKyDwrxdd7GWEgBZQD83GKfUXNfE0NIlYfn EElbiMVufrzzmwQ0zVMUDorXP59jw1KVE13ekup545M1gxK0c5JXw+gan9H8/agAxF8alUHF1pY38 qetJG0Ic8H/EWSqeKcVhx4RpiY5Cz9ADuTz1qK7MBxNOMyzkecd21O7P8yoq3IcbvVH5XdFmIiwYO 5JBuSx+RwhnBCW5ZDGyjYg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdcj6-00010M-Rq; Sat, 18 Mar 2023 16:00:30 -0400 Date: Sat, 18 Mar 2023 22:00:32 +0200 Message-Id: <838rftbzj3.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87ilexn9tc.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 18 Mar 2023 20:22:55 +0100) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 62260@debbugs.gnu.org > Date: Sat, 18 Mar 2023 20:22:55 +0100 > > Eli Zaretskii writes: > > >> Did you try a different user? > > > > Actually, the right question is: what exactly did you try? As you can > > see from the code, 0666 value is used only for buffers that don't > > visit files. Did you try with such a buffer, and what exactly did you > > try? > > I didn't with a buffer not visiting a file. I have tried with a file in > /tmp that by default on my system is created with mode 0644. Then I > write something into this file and do 'M-x do-auto-save'. > > With this patch, the /tmp directory now contains an auto-save file with > mode 0600. When a buffer visits a file, its auto-save file should have the same mode bits as the file itself (modulo your umask). I see no need to affect that part in any case. If the file itself is not private, why should its auto-save file be private? Also, there's auto-save-visited-mode. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 16:21:10 2023 Received: (at 62260) by debbugs.gnu.org; 18 Mar 2023 20:21:10 +0000 Received: from localhost ([127.0.0.1]:49104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdd37-0006WG-PV for submit@debbugs.gnu.org; Sat, 18 Mar 2023 16:21:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdd35-0006W1-Kx for 62260@debbugs.gnu.org; Sat, 18 Mar 2023 16:21:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdd2z-00022k-MT; Sat, 18 Mar 2023 16:21:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2fMz31M8uOA6hlf0m7RsEflkCSZiDf4z/9JiYyHwJRA=; b=ehtQOpsY2ySl GMxHjnajxuyMolW4FQQt37PfDQx3Up9mXTwl1B22vyGhr1//Tb5LXD0uURJY+vSuY6j4ktlnRGTlH RCeES8d7GCaXySTuDJKHVmmJiKocCXUlV/27b/oJFwfrJQOocCmvLRDIkmV5HxvnSAi8ryXsT7AmR gjxESb749XAok/dgf7ZAo2RCLLK7fUxEay3ppt7Qm+qh0+E40Ixge8a/TYH27HTJQa5yeQLhtMs7b Trmk2Yv/ba3RpnF6IBPJJE4i0UEW/p4ZURv6tx3pKCPZN1451A4ZyfHkRjGIxQepWRA9fo8P4Rl16 JKZvDu+hpRq/kVLaERjgWQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdd2y-0004Lr-Vv; Sat, 18 Mar 2023 16:21:01 -0400 Date: Sat, 18 Mar 2023 22:21:03 +0200 Message-Id: <837cvdbykw.fsf@gnu.org> From: Eli Zaretskii To: manuel@ledu-giraud.fr In-Reply-To: <838rftbzj3.fsf@gnu.org> (message from Eli Zaretskii on Sat, 18 Mar 2023 22:00:32 +0200) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 62260@debbugs.gnu.org > Date: Sat, 18 Mar 2023 22:00:32 +0200 > From: Eli Zaretskii > > > With this patch, the /tmp directory now contains an auto-save file with > > mode 0600. > > When a buffer visits a file, its auto-save file should have the same > mode bits as the file itself (modulo your umask). I see no need to > affect that part in any case. If the file itself is not private, why > should its auto-save file be private? Also, there's > auto-save-visited-mode. More generally: what problems are you trying to solve here? If this code causes some problems, please describe them, and let's see whether and how we should fix them. This code is in its present shape for the last 25 years at least, and in all that time I don't think we ever had any complaints about the mode bits of the auto-save files. So if there's no real-life problem here, I see no reason to change code that is stable for so long. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 07:43:10 2023 Received: (at 62260) by debbugs.gnu.org; 19 Mar 2023 11:43:10 +0000 Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdrRO-0000Js-5l for submit@debbugs.gnu.org; Sun, 19 Mar 2023 07:43:10 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:32755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdrRL-0000Is-OQ for 62260@debbugs.gnu.org; Sun, 19 Mar 2023 07:43:08 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=QzBSNRAW msUzT7IR992vfcbswT6b3DAz3QHymqBY6PA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=2QQSopD/vPtJA2nt67EaGNnK+vw7VM Y23d5rtA5YTKLjj7YkeTF+kNUeeYgaoruejMHVnDJoiFFAGAOzrd8GCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=QzBSNRAWmsUzT7IR 992vfcbswT6b3DAz3QHymqBY6PA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=UBYLNV05jcSCllcS+2O9Van0FB6emY6cUzr/4D Jcwr6v9cgGpIGqnGWkeVafFBbKPmppd88Gx5jLav+ajyd+6xc+ZjSzwzYz+5yRzpeGAUlT RzIYqUrutyMhnU1FYzDP721yzY2N+fT+SPJQG4gOKLXMDuWyWSvk6Z1I8Lbqo2U0Y/x6Jf 40q2Om2wSRz8s2VdsdfVxq1VPFoLzfGdzJkWMMmrrYXPxwRAcH+u25n+Uy0gqmryCtAojt BUEqhDZEWQokThUX5DtxtkomqJ+fOA87JQaksIRCItZvL7CygsPbNIfbCHPcGA9AWoC2Mu Mrk1LbYVCEl5nU7DtHmSK1lw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 2597fbb9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 19 Mar 2023 12:43:05 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <837cvdbykw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Mar 2023 22:21:03 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> Date: Sun, 19 Mar 2023 12:43:02 +0100 Message-ID: <87edplm0ft.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: 62260@debbugs.gnu.org >> Date: Sat, 18 Mar 2023 22:00:32 +0200 >> From: Eli Zaretskii >> >> > With this patch, the /tmp directory now contains an auto-save file with >> > mode 0600. >> >> When a buffer visits a file, its auto-save file should have the same >> mode bits as the file itself (modulo your umask). I see no need to >> affect that part in any case. If the file itself is not private, why >> should its auto-save file be private? Also, there's >> auto-save-visited-mode. > > More generally: what problems are you trying to solve here? If this > code causes some problems, please describe them, and let's see whether > and how we should fix them. You're right. I should have start from here. So it all start with a recurring message I get from TRAMP whenever I access a root file (via sudo method) for the first time. It asks: "Autosave file on local temporary directory, do you want to continue?" I answer "yes" but it seems that it can potentially leak root data through auto-save files. Looking at the code that asks this question (tramp.el:6528), I see that I can set 'tramp-allow-unsafe-temporary-files' to t and I won't see the question again... but the leakage is still possible. So I guess what I want is an option to stop auto-save entirely in those cases. >From there, I've looked at how auto-save work and I ask myself: "maybe instead of such an option, I could limit others rights on auto-save files". And that's how I came up with this patch. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 08:19:52 2023 Received: (at 62260) by debbugs.gnu.org; 19 Mar 2023 12:19:52 +0000 Received: from localhost ([127.0.0.1]:49595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pds0t-0001IM-QL for submit@debbugs.gnu.org; Sun, 19 Mar 2023 08:19:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pds0r-0001I7-LD for 62260@debbugs.gnu.org; Sun, 19 Mar 2023 08:19:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pds0l-00032J-16; Sun, 19 Mar 2023 08:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HuS8oi/QKmGnex3rJ8cz5PSbDln15sWY0lHPou5ajXU=; b=oYutMsRlj0xB HBk/w4Q677h2OBtZ2Kb0dnBQva/l4lRWkJF3XTmAJxL1QP3SJ0NJgO9sXgHEg7AttIezrfcw3Ea0k oKkNVfvzdD7y8MUiwSHyk4O0N16QaGERRG8c4ihleRYL6KgrkMXPVvRph8fp3QMdxVxS4fZ2fRpqC 3KM8VS/bT4wgXxY+v1ckuPuMChFVZDcuWsDR6OTT2hUmPjranN23z3nxoSaNkLBcFwn9fFO3BXEGz xo8rlAQb2Ukzzc2q5KOE/hyhoutLofi8gZYq+JGNFQKQkwZrzKhzpZfiV43j6wp0GfOiQ0WiUihO1 rGtXDpDr2QUY10wMgNFztA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pds0k-0004LO-DS; Sun, 19 Mar 2023 08:19:42 -0400 Date: Sun, 19 Mar 2023 14:19:47 +0200 Message-Id: <83sfe19bmk.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud , Michael Albinus In-Reply-To: <87edplm0ft.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sun, 19 Mar 2023 12:43:02 +0100) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 62260@debbugs.gnu.org > Date: Sun, 19 Mar 2023 12:43:02 +0100 > > Eli Zaretskii writes: > > > More generally: what problems are you trying to solve here? If this > > code causes some problems, please describe them, and let's see whether > > and how we should fix them. > > You're right. I should have start from here. So it all start with a > recurring message I get from TRAMP whenever I access a root file (via > sudo method) for the first time. It asks: > > "Autosave file on local temporary directory, do you want to continue?" > > I answer "yes" but it seems that it can potentially leak root data > through auto-save files. Looking at the code that asks this question > (tramp.el:6528), I see that I can set > 'tramp-allow-unsafe-temporary-files' to t and I won't see the question > again... but the leakage is still possible. So I guess what I want is > an option to stop auto-save entirely in those cases. > > >From there, I've looked at how auto-save work and I ask myself: "maybe > instead of such an option, I could limit others rights on auto-save > files". And that's how I came up with this patch. So this is limited to Tramp and how it handles auto-saving? Adding Michael, in case he has ideas for how to solve this issue. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 08:40:40 2023 Received: (at 62260) by debbugs.gnu.org; 19 Mar 2023 12:40:40 +0000 Received: from localhost ([127.0.0.1]:49622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdsL1-0001tk-M4 for submit@debbugs.gnu.org; Sun, 19 Mar 2023 08:40:40 -0400 Received: from mout.gmx.net ([212.227.17.22]:39981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdsKz-0001tN-Ls for 62260@debbugs.gnu.org; Sun, 19 Mar 2023 08:40:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679229630; i=michael.albinus@gmx.de; bh=ZaGXRosxac+pmz8P3EO+V6i3QZbNbnz+JgNiTfLGhVg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=KF5C/89RMStR4cDCwQiWAEsqTIXhrHOn1bJIZtGaLqvNI3soN/lKtAHhhrLiU+/xO mbFe9ixKe4UeWALXii4arYmkECRf4SMZ6SIb9HYmkvvCupAlI2MojyxJ/wJX2FoQK6 UfTDDlxTr0sh9vYQEy+IMLpTTJHwNy0g2PvyvVVJfoq2ywlDCzhLEBnDlxd2JgLcZj IayDPnfCDpfpdObYNCDdTTIlFNXabKEdT8Up2OdLH6Z+KsDUESQIIyzPnq6vnRcVgf QAD4LSTlmRxUTophjd4Fyf7/0rWMDYthV2436CDekJPaS5mJrGga6Zy+u8lXmPDBUR 03dlFyf3TLvTA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbzyJ-1qDUrh2wZz-00dZ9g; Sun, 19 Mar 2023 13:40:30 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <83sfe19bmk.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Mar 2023 14:19:47 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> Date: Sun, 19 Mar 2023 13:40:29 +0100 Message-ID: <87r0tksyma.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:a4gMnIi98YUPiWSJ5tSIJz2y1Odep4jrPFlYdYw8MaPAk6Ay3qh bUDDWVqjw4ybsTAFa3jgB7ZTWBd9bGJ/gOaB4T6BlRursQRZwSR12tOKVt9lBFiZ2pl/4j+ d2cqz1wbEDVVfE6rR/UpukabM8BedvtR7p0HRqxq9sSAdGwc6alnL5/3R2pyvo0GeIRzunO z0ye4KhlwVP8YomSkfp3w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:d+2cXeK3dRU=;x3ey60xkEzmSSrUT1Pq6MQwVDT2 pemHYNCTzbBevao5BIQrLm/Qq6YbRnx+llD8O0/wFK1hPoBeVrxKBDJmBNkwJ4T5Omu5vqdZi iEPip0fjXyvl+T9s3WgNJUnUTtCmtZdB9oCmRG8a1UvoDOKSneC09KKthO2NAe0rWRqy0Pnfq +yaWXUn6ADF44ooQ9I8HAYnK/FEOXvjiDocxfWrHIihCfL87G7A8axqBLLXHswFwndVxL25v0 J9dt+RwDoHw9FM2fSqpliIYj43Fg7MW67/Z7RxMBwu1z930x89TEKhkRIjBsV8UYl4VlWFLDn sc6x3auVfxB4K/jCnyT3Ds/+HDUS6+rmeUFNevVpreSXlkzPOddBt2FTO1hcz2zAEOAfSzQgI 6NSe5U1u4ctCU0hTqZNCogr3+hXv83I+eXNUbtrLUkMemqFOS48pcchvm2kryVp87j3lcqV3C Xeoz9Njp6P7+/K2dQg9ZZTewxCyIl8VyexyQA6tkPezdTIlnoAqBhxORWgXg776HaUiuBShnX eCCyiPL36CeUKmfwOVHT54ck2lVtBGdizjXxCiZZsJTd2Hp918D11JxSLxUuoJPW/p5xICFVg d6qQ+vjar2YDg4D8Pgw2NXh4Ipk+0yxkwtPiqY1UBqonmPV7SsJeZvDI7flE+qnrjgJ49PB3L lzLsCwM2r6m81VMHtMFiZMlU/ht9EasGaB+c6/Rs00NuTq3f+8J2bx2KigQG8VjCIFtRxaN13 X8BdjK95mlR7XIKEQKWw70BOt/OFdyyU+Ow3Gy4lDe0GdNm7PLzx7f1fw11XtD0RXay6MuJMP a1YDsRb8gA2e/0uk+7zLow/MhyX4Q2gWvHRt7EK+e0t3+bXXwPx45xU5lqdbf6d66wcqsqNZb qiNspsTLOc7FLXnS2UGWd6QYjlG+7dU96zGRHVpClKLDqi19HbOh+h4OxP6UQb6cmmBJ24BTp oF9KvlyJsd90BXHXIFc0OuBzTF0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: Manuel Giraud , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi, >> From: Manuel Giraud >> Cc: 62260@debbugs.gnu.org >> Date: Sun, 19 Mar 2023 12:43:02 +0100 >> >> Eli Zaretskii writes: >> >> > More generally: what problems are you trying to solve here? If this >> > code causes some problems, please describe them, and let's see whether >> > and how we should fix them. >> >> You're right. I should have start from here. So it all start with a >> recurring message I get from TRAMP whenever I access a root file (via >> sudo method) for the first time. It asks: >> >> "Autosave file on local temporary directory, do you want to continue?" >> >> I answer "yes" but it seems that it can potentially leak root data >> through auto-save files. Looking at the code that asks this question >> (tramp.el:6528), I see that I can set >> 'tramp-allow-unsafe-temporary-files' to t and I won't see the question >> again... but the leakage is still possible. So I guess what I want is >> an option to stop auto-save entirely in those cases. >> >> >From there, I've looked at how auto-save work and I ask myself: "maybe >> instead of such an option, I could limit others rights on auto-save >> files". And that's how I came up with this patch. > > So this is limited to Tramp and how it handles auto-saving? Adding > Michael, in case he has ideas for how to solve this issue. Read the Tramp manual (info "(tramp) Auto-save File Lock and Backup") You can use auto-save-file-name-transforms or tramp-auto-save-directory in order to change the location of auto-saved files. This is the recommended way to protect sensible data. Tramp has no influence on the permissions of the auto-saved file. There's also bug#57395 with a related (but not identical) topic. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 09:56:22 2023 Received: (at 62260) by debbugs.gnu.org; 19 Mar 2023 13:56:22 +0000 Received: from localhost ([127.0.0.1]:52536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdtWI-0004ZD-8P for submit@debbugs.gnu.org; Sun, 19 Mar 2023 09:56:22 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:11024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdtWF-0004Z6-7z for 62260@debbugs.gnu.org; Sun, 19 Mar 2023 09:56:20 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=A7IgD34Q 6dnb/ROFJFQy5wQvcJ0TZsFhTKXm6LO/kFE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=tci8cQav+rSjSgik0XklcFq8kBwJJn Vue2G6W9hhlCVBTnfiKw0Xzw2nAZJZDikWy8597mgAECkH1Ep7XUkTBA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=A7IgD34Q6dnb/ROF JFQy5wQvcJ0TZsFhTKXm6LO/kFE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=tAFXa7Ke5/A2ZjbXkUwtJ3t9V8K0+CEXvNp2q3 38ELgZb7Lovp5BQRlwd0gBsmUj6Cv1evhG5N/mudMAcQ8LezwYlTRINZRCrlN05lp6KtMR ywBKnv/hyYaFaCWxNHP7vY0vnqo9fvQvD1GxG3bSA4s1mOAFusJ2xU93vILkEHN+q/pGzk TvgtMEqDCVsRe4opIMOM78CTNr5AIotFgM6wicIByaPj7w5ldkrtwaFPl5M7gV4xmxcPhD QttUFXcWnfj3tJ2Gld9prrJ7CWsLDeTza8CEyN4ZhsZ50eP2Ohsk2cTu8+tMhwHJvf16iP /PlLBlBepVo4y4o82WR6qYnQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 19156d5a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 19 Mar 2023 14:56:17 +0100 (CET) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87r0tksyma.fsf@gmx.de> (Michael Albinus's message of "Sun, 19 Mar 2023 13:40:29 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> Date: Sun, 19 Mar 2023 14:56:16 +0100 Message-ID: <87v8iw6e0v.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: [...] >> So this is limited to Tramp and how it handles auto-saving? Adding >> Michael, in case he has ideas for how to solve this issue. > > Read the Tramp manual (info "(tramp) Auto-save File Lock and Backup") > You can use auto-save-file-name-transforms or tramp-auto-save-directory > in order to change the location of auto-saved files. This is the > recommended way to protect sensible data. Hi Michael, Thanks for your inputs. I have tried with 'auto-save-file-name-transforms' like this: (add-to-list 'auto-save-file-name-transforms '("\\`/\\(?:doas\\|ksu\\|su\\(?:do\\)?\\):.*\\'" "/dev/null" nil)) But now, auto-save tries to create "/dev/#null#". How can I fix it to "/dev/null"? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 10:11:05 2023 Received: (at 62260) by debbugs.gnu.org; 19 Mar 2023 14:11:05 +0000 Received: from localhost ([127.0.0.1]:52546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdtkX-0004wc-6G for submit@debbugs.gnu.org; Sun, 19 Mar 2023 10:11:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdtkU-0004w7-Pr for 62260@debbugs.gnu.org; Sun, 19 Mar 2023 10:11:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdtkO-0005lK-L0; Sun, 19 Mar 2023 10:10:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yTNliXfTWcu827C8wuWeKrtZnTLp8F4mSCAGWSPa/KE=; b=Ok1rLMn3/w8R 2EXZOyZtnQSWhoOHSZ2EPHUoUNFJfqfQzc+N4jtehGOuhwhvRiOURBk5uHiWe01RcNNmsStYpf/Yj +fl9WBMp9/VQe9mmSwAjlZYsjSoez36d8VcH+mSPPI0YCYJd1Isd+rCDRxuYVA7xMGeLVUCnBUgdi DZqPl+0zWdwqV6ZYukqwcm87xoP6nLLeuQH9uSmt5jzg5xBU18ospcx49u4JL2H72hQx8LfUn88q4 j2N/fTRgm98AZK9plL3dwo77WcIZD2lu4YZ2pDYSx9rF4loIagira4a6GAiWwQFxSktYzvXG5qv7R VJdT1F85pYijlkD6uG9oVg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdtkO-0003XA-5r; Sun, 19 Mar 2023 10:10:56 -0400 Date: Sun, 19 Mar 2023 16:11:02 +0200 Message-Id: <83jzzcal1l.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87r0tksyma.fsf@gmx.de> (message from Michael Albinus on Sun, 19 Mar 2023 13:40:29 +0100) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: manuel@ledu-giraud.fr, 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Manuel Giraud , 62260@debbugs.gnu.org > Date: Sun, 19 Mar 2023 13:40:29 +0100 > > Tramp has no influence on the permissions of the auto-saved file. My reading of the code in auto_save_1 is that the permission modes of the auto-saved files for remote files are determined from their original files, by calling file-modes (which I believe Tramp implements?). See the 'else' branch of this part of auto_save_1: /* Get visited file's mode to become the auto save file's mode. */ if (! NILP (BVAR (current_buffer, filename))) { if (emacs_fstatat (AT_FDCWD, SSDATA (BVAR (current_buffer, filename)), &st, 0) == 0) /* But make sure we can overwrite it later! */ auto_save_mode_bits = (st.st_mode | 0600) & 0777; else if (modes = Ffile_modes (BVAR (current_buffer, filename), Qnil), FIXNUMP (modes)) /* Remote files don't cooperate with fstatat. */ auto_save_mode_bits = (XFIXNUM (modes) | 0600) & 0777; } If by "Tramp has no influence on the permissions of the auto-saved file" you mean the permissions are determined by the file, not by Tramp, then I agree. This simply follows what we do with local files, just by calling an Emacs primitive instead of fstatat. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 10:18:20 2023 Received: (at 62260) by debbugs.gnu.org; 19 Mar 2023 14:18:20 +0000 Received: from localhost ([127.0.0.1]:52551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdtrY-000584-4m for submit@debbugs.gnu.org; Sun, 19 Mar 2023 10:18:20 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:48498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdtrV-00057v-Ao for 62260@debbugs.gnu.org; Sun, 19 Mar 2023 10:18:18 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=E1zNADcj d30sOTSJBtDhO44aJeNn2k2FGukCq+EUzcQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=SjW19kmC6lTaAssHZsXCZM4ZtBIgti QL+YzAyvN1RkIuRMp4AKdBFpWL/Rp+tomcVKGy8cM8i5gEQ5kEB9YkDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=E1zNADcjd30sOTSJ BtDhO44aJeNn2k2FGukCq+EUzcQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=bZUnPpJFS1a8hb5H7Z2zS1jYA21uyT7gySCdgv X79UX8UQ3gZuRa5ZpUD3n/7N/6TX+yOIgDiBwM+RR4kewO7NthwPEJ1EJDGTPly9Ukg+xF AtCEu9Z3Z1u7rkmDS7Vp5MZ7NeuQyTLmN1B/WyCxHPlY1TmTEAW2xAHsd/ut8At2vx6YEr 37cFxiZXqbwp/Iuuxmi0d6oYgEU97Zjz073DK1ZDnv4DqlpvHCfyYW0hIR2G26twOZYQJD 57oMBj1Kv9ljOwuxJNEGsTMVL5DhYfWTwEjQ+OM7NAVM8IzeUO4ZiWzrboZZftqO4RBjYR EXE2PmgkXTf1M3nBJKko3Mag== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id b9b429a7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 19 Mar 2023 15:18:15 +0100 (CET) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87r0tksyma.fsf@gmx.de> (Michael Albinus's message of "Sun, 19 Mar 2023 13:40:29 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> Date: Sun, 19 Mar 2023 15:18:14 +0100 Message-ID: <87r0tk6d09.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > There's also bug#57395 with a related (but not identical) topic. I've read bug#57395 and it is related of what I try to achieve. It is even more precise about which files are dangerous and which are not. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 07:41:45 2023 Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 11:41:45 +0000 Received: from localhost ([127.0.0.1]:53818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDtZ-0003Mw-10 for submit@debbugs.gnu.org; Mon, 20 Mar 2023 07:41:45 -0400 Received: from mout.gmx.net ([212.227.15.18]:35561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDtW-0003Mi-TH for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 07:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679312496; i=michael.albinus@gmx.de; bh=Ov1piNDI6NQJ2Y+8Ze58g7+Dgcqh+WKGEsNJTDIu1jE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=erYbV2rf+IJN871PQv/63ziXT+SauUhe4TwgKLRQhAeFZTS8nt9zBruUEwaI3BZJW Gyy1DqWIAoVVWAU5XjmGybb1PWvFpEqP/Eh023kPhukVRQlm6RDm3/9aTHHfQyJ+58 aFzkGtKHcTw0RFx20Tp1xnG4Ib/+Ym9CzhmceI++Gqx2CR11nELZfD/zoDqwafz7Fl LoN+i9lKOBoAK2oImli8Y8zjWSEOddT1UUV+tmU1bdl5Nptpc7JMhgdJ2dbfCI6VJ9 CPTxHWnm2IowkqoUEX6GoGrGE9QQ5l4EwCNW1I0Zi5dBSFAFeYXzj8LEyk8Z0MMeRk 30febb/YPsDqA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N9dsV-1qaua245X3-015bX0; Mon, 20 Mar 2023 12:41:36 +0100 From: Michael Albinus To: Manuel Giraud Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87v8iw6e0v.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Sun, 19 Mar 2023 14:56:16 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87v8iw6e0v.fsf@ledu-giraud.fr> Date: Mon, 20 Mar 2023 12:41:34 +0100 Message-ID: <87zg871wgh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:R5fcGprUmmgZ+PWpUVLMiqnQlchW9yNcDw+g790th19mv7bb77c 46+0ikNEjkjBHhjw/7PrF0x6VZb/JyFAafWuLZEmOnO9v2R/qeJDrqRXNNbcNqieSX18qMr rkT6WB3X79+HSA1Ltk9fvMjeGiFRXFLUt48b48RdxcAMi82GjMG40imFny/BsdgE1WJT1n7 kddC2tV35bWgiCj8pLkRw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3nH4nBDZbt0=;ojz9Swj/Fahpt/qEoR2BQOND0Sq Q8LN/pW9jLmfe1Wz/g3CHGTyPMy6x4PVKmOAqwHRAW1hhG/lZ4z8d+IXVTbBKcKFilO81B0jL dsqoKTZUaF7znJifQ53HgXrfHeKX09AncKE1egiCAIJkxYl0yn2jekaO8AxrJvptdNy+kSvQg WMniV4oAriC3NSbwa11xIUV13GrBxVFN6vYvI1NNWlbbb0lY+TbLMFmHnJbfYbEYGiQOza+uk fXYLLuZcQjQLcOQlXRsNGf+0pnR6Vj75yZB0VCSLaan0A7APlZTfh9pf8SavK/MOyncx9bFbw JmHzG5ltyU1utvqy8+F0f5UHySGXm8K9lZ0gFTcd6Tfj7Xpjm8n/9OXTezO/dd9pMWOgbQ7zz gbBgKJcoXYwmHjHuR6lqu5IQPzgTRLg+sxx0ILl6Vq66aT9Cr9KqVh+ugc1ZcDa1zvNYOIPw3 XlYv9pZsLRMG7stUkQzU7G2JINrNoErJZ1SwxWSA+ShZi5GsKs1Md/BzPVcBfW9A2Lw1V5S9r WlAWz2tejDV8zMU+8s28M01cD5hFWx8aiRLpg33hWqYxbDZmPfXXfnzy9mDnB6HJiS+WZnpII hAggHwVkcwTS2qxgYziND9pklXXnxvBRjU7qbXtluuV/uYGL0sE+5YisQy70JQoRTge1AozPj YSa15014a3aTjL9OsTlhX1hXYMJREWtLMLlJ/SVxwcA2JeC0xVO9x7jvkusVFxk6gQRot8zWa w8p21MJI5D4ZYOnwxsIUE1UjgUDSv2GzAgke2dO67abrQYFi3piLnzuNdPfEvbyjMypAUNezK 3qdX9BzpOWWmVzKSoOlW8ipJyQcwN0mY0tyYZBLmzeLwvza0wrrVq8D5Z6KxhV53nW1KHPFbu Yr+ya/RVXLETnRdndD3MFQTIjB2tSHtHBDuZV+cmHQmPwBHZqnXpyRMFOhE8BmBKn67g6ciEx s0dkPA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Manuel Giraud writes: > Hi Michael, Hi Manuel, > Thanks for your inputs. I have tried with > 'auto-save-file-name-transforms' like this: > > (add-to-list 'auto-save-file-name-transforms > '("\\`/\\(?:doas\\|ksu\\|su\\(?:do\\)?\\):.*\\'" "/dev/null" nil)) > > But now, auto-save tries to create "/dev/#null#". How can I fix it to > "/dev/null"? auto-save-file-name-transforms does not know the meaning of "/dev/null", it handles it like an ordinary file name. The following code snippet shall do what you want instead (untested): --8<---------------cut here---------------start------------->8--- (defun my-find-file-hook () (and buffer-file-name (member (file-remote-p buffer-file-name 'method) '("doas" "ksu" "su" "sudo")) (auto-save-mode 0))) (add-hook 'find-file-hook 'my-find-file-hook) --8<---------------cut here---------------end--------------->8--- @Eli: We have already remote-file-name-inhibit-auto-save-visited. Shall we define another user option remote-file-name-inhibit-auto-save, which could be used similarly? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 07:43:21 2023 Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 11:43:21 +0000 Received: from localhost ([127.0.0.1]:53822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDv7-0003PX-EZ for submit@debbugs.gnu.org; Mon, 20 Mar 2023 07:43:21 -0400 Received: from mout.gmx.net ([212.227.17.20]:42073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDv6-0003PK-5K for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 07:43:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679312593; i=michael.albinus@gmx.de; bh=b6veIPy2IcB3zepA8PLMdPzNwK3eBHZgFBybZYnILE8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=DcWj+LEtIlbE7lxKUVEmMqhdkmdmnpL2SlRJLLBLE4NLGB5RQEpfPfDrikGZeE8mn 9l1ogvgXrZa/QZ1j4zfhq+WjENy9kABt2+oj8oJpi3sjZWD2CVetlWW/UwMwgGIslT QL7sPXd9MRbW7F8HA7LNbsBIKaJU4GFjDROzDfO8XxjOzhq5rDg9MNa9y3hPs1ellU jDPp7tfR2kHjhJeOJw6U+DgBAv53eveIcFUNs1NdRFAGP8Kp53MFhLFIDuKe0JMQiJ lBFr9SzhkYmy8BUmpCOk35Ovy3w5E3pZaUZiCACXkTto8jzm26wr/ubZMnc1V+9hen pJk/amQjFT62g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M9Fjb-1pblCw28vv-006PiR; Mon, 20 Mar 2023 12:43:13 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <83jzzcal1l.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Mar 2023 16:11:02 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <83jzzcal1l.fsf@gnu.org> Date: Mon, 20 Mar 2023 12:43:12 +0100 Message-ID: <87v8iv1wdr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:mtxVrllAk0SaRf+HbWpMmhK+mSX6WpWqKjoJqWSDRwCOHroiqyP wTqtUb3TdnF3ugr3pkFRRtKI1Rhg7XOSuTiuIQXzxInPLNpD8rtTKxRV3TzWNtXR9RUs9VR weA8GUaLhBjftl9Lu09ucAVG4AE1xX9xONrry5mpasNnEbN8IxO8zGWId5XOb/psj7WxW72 xxSVCyqKYijHPs7YcHrPg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:2PAK87C61EI=;G29SEWpH9Op1nH+G4W3AZmN4Vmr H6GXS8ZbIPrvi7VKWoW0b07skH8YYTQ+s14czo79xD6Pn5AvAE5zL1OeLkw8n2xasHplMRItF 2SczV3vDaAIpRbAh0cpD0Sx89AvcOFQaBeZeylG71ToWhEa0u1EAsk6+ahY+xxjyeizpo9tKH BGbHikGNQTOB2l7Vfz2rZya0xtfzm3pSEfHogOIqOsY0UhJbr/rm3mXABBWSgp4rFenjYEPo7 7FAhM6op8KZRly86aNc29uUk92STGu8cXfuX83ShpLJF8IW3a8zZwjXVaHlXjLqVANrMmsTKs 7j8vUhxJRp1L9cOo2HceIaPRsag51I9wOm8mvzPMYw51rX0CCY89xftea/jbEWKbDPVFi0Wpe W2i1TP/vXNEt+d2TeqJL088Sx6GXpBVzvZo8EY4QkSul4u22shhgRJ3dtX7bBzHENMspDfq9I pBvhl8YwnmnVkV8JkgOKZlgjcQPt1KFO8/WMOo9EEss4jiA/xuI8ppsHvM49NrQvbp59soZwY pvlROsLfmtkcgkUZzmP0yFdDOebTB6idwT2kHXzrzpqLbO/F/crb43f2c2WZ5Ar4FWs8KAV3C lMaSsIKzrgZPQ0OzzaSYNrHnPJGY4cExt/jgDMKfPKznkG7s1dPKLwvn105R46ocdlf2C8INL eYtSaP7b3tqRPxVzqsD++bXcUo31FP9VEZo0GhARHF523sv7ldaJNusqRcbGpgj+QuqWV14xf okeLSJ53lbTw3mBjzhxNd0PmgIwBAu1X7kuZpEVHl4l8Ob/jFGRURUBr83YfrqDBGq6//pnbY zN35KqKHwxEQ3rhRtx5JhU2gJc0mhnOh3gjDATkMbhkgNLmGrVi84uQ6m74uHSjfdKM6HlGCP qLfjXWN9RU9u+KX3DfUaL6VYT8HfPhV/FCncFZcBzvV2lzKGQ9VGbaPb4WB7qqpaclkLUD4xZ Bye6ziB9lWjYNCB/jTIVp2w+szw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: manuel@ledu-giraud.fr, 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, > If by "Tramp has no influence on the permissions of the auto-saved > file" you mean the permissions are determined by the file, not by > Tramp, then I agree. This simply follows what we do with local files, > just by calling an Emacs primitive instead of fstatat. That's what I mean, yes. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 07:44:36 2023 Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 11:44:36 +0000 Received: from localhost ([127.0.0.1]:53826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDwJ-0003RZ-RH for submit@debbugs.gnu.org; Mon, 20 Mar 2023 07:44:36 -0400 Received: from mout.gmx.net ([212.227.15.18]:37977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDwA-0003RD-Nb for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 07:44:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679312660; i=michael.albinus@gmx.de; bh=8p9iLESULWke20oB7AnLrIFApNrdDlOwhTlTEvjlLK0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=jZ3deFmrdtFUc4TumcojVkzxDsI/oQOaHgvOMQAeJWXJVHYv3UoULvh5G9NwX5Jvt kHcsku8X63MRur0Yl4u/J4RbXZpZ1f28No4gdzNCQPrOd3uBwioQxijpGxV7mUj6uf sQ8Gg/Lm9oUrD+7W90e2lH1vg7uJc0StWbvk0QLL/wU2dRn3vMBFcTTmiymW6ZEPbq 8fBrprci9QyDbRd2z0zxOWO4ZeBn4MDwyD9w1ciF307lwlmi4bKojJ/7D16DvjKbbF kwOHJ2Aa445BwUmW407WoRv+6AWPek3b/kZMfguU7kSUznRUQh4EknuPUJ7EFAnlJq 067WgWmQHAMLg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Ma20k-1q1IjQ2pJU-00W0f7; Mon, 20 Mar 2023 12:44:20 +0100 From: Michael Albinus To: Manuel Giraud Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87r0tk6d09.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Sun, 19 Mar 2023 15:18:14 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87r0tk6d09.fsf@ledu-giraud.fr> Date: Mon, 20 Mar 2023 12:44:20 +0100 Message-ID: <87r0tj1wbv.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:gucA1KJAFcHTAVb0YOsGHZgV+MTwdWAg8lmzSZDVCmnKANV2a+x hxQgdFzLLC8NVxiWb1PdLdrRq86zGW8AzYLS1qfm9E5oy4miTkzpqmHIm3NVcyzt6kIyMWL hWakbY7GtlAXXCkAa4PLmCNHil2fWZfm7RGgh+w/rFOwGfSeFv4/WpvF6Yp40RNT5Cj8MDt iW8Mriz0tOzgWlNgal5fQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rj8lNlb+7QU=;baZigRbSr1oqKy2PKSQkrVvN3tR NO+2vKTe+sSyWwUrs01h5S+I44CkUFs/iBLjVx4t6bFyGSfu5+j+Ayd5zE1D/yv56qln3BDqh s+jdmQrzro5O8+PaUqGlqBZMSUGkAEfcJoKMY+sgOnzQe+eLwwwIsl79GwDvsbdXb0GpcjWck NFexy0tAx5JBY0jocdvNCpLsy7YgZ191NoT+Yc0ig1JR9TQcgiwzCk2PFW/+jSLNSliMw/dqN L4zPetezzltJKHW6ecFrKuJwymRxnkgxf7aNn3hG+RsHKiF5yss1gEUkw16mz861RUhlxJr33 nmkBeCk+hKGT8/Lm+VNMO5WdBfjMtdz2y0QzoDzzSCAZFOhDpw5+zoU/U9zWT5Wv9XHC1n791 2mPenLQCjGdKlGg8wSxJImrG0nlqbN+ciXHZDYxYOo2vR1aapZ8U3Yk7crDYz509Qd0BNqgwu 8VaFa+vHi2Uws6d5utJdD8n3uasBZfMRkRmlkiVWoiXu9WuG4jdqhm8Xm6aNxoj8+FKxydRU8 1m+vSGEYSB+2KXwfxozJRtCd3c05AlTrrsfO5fFa0mdDT8tBoPCkGsdyzf7ekQkQMkb5NTCZd obJUId+qZU57u6ciM+JLHmB4TeaZydbmGbh4oVG79eqWiq5hz98AkuYbxadiD1zojTABAAm5H TSc0QCLTbQYJuRTCxH85IFDIONs50iG0m5c1MS8/kT9KPZ0sCvkqgHH17qq3ivua8XTCrb1XW XStXXmG+qwLpnBNC3ikoiyjhuv6XVAYtYW1ccwr/+kSEUYejtQCS9hD1IFaBPAWyFxrO7B9m1 uEoHIoLQq7mKIvgSYb8PL2uiBEXInFK9cNG/x/FrH6C57yxSNsYOqjE3WeFRs260HYv58xKdQ aaBN2FQVci5OSkbdLTquaKxnEzpqS5fHwpfEksNSdjetKXHlWuJJNjYy+tUTui2A/fwxi9ZY/ Y5DH8OS6m33s+nRZw/ensPNFlFg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Manuel Giraud writes: Hi Manual, >> There's also bug#57395 with a related (but not identical) topic. > > I've read bug#57395 and it is related of what I try to achieve. It is > even more precise about which files are dangerous and which are not. Thanks for the confirmation. I'll merge both bugs then. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 07:47:14 2023 Received: (at control) by debbugs.gnu.org; 20 Mar 2023 11:47:14 +0000 Received: from localhost ([127.0.0.1]:53830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDys-0003W2-HF for submit@debbugs.gnu.org; Mon, 20 Mar 2023 07:47:14 -0400 Received: from mout.gmx.net ([212.227.17.22]:48331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peDyr-0003Vp-4B for control@debbugs.gnu.org; Mon, 20 Mar 2023 07:47:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679312827; i=michael.albinus@gmx.de; bh=o3Gv5VMFLm6S2KvyNkmJXM1dwtQeIk4gB3AJlHo3Be4=; h=X-UI-Sender-Class:Date:To:From:Subject; b=o0s42jANV138zH9//4fDQBK1kN4rxYbZ0yXz1DHCY2b5LLNIt7Cn5/Y9cbaAQOs0Y /L7TnOwn8PDdkit9iOQiXpyXPWCuyqomAZsML3d3MPbcu1lX7dRyBW0QQLQN/wBmZk Sjay7LhUh6N70y1hSsUUKb9IsimV4Wiu5eAioKpaDJa2hhhp6mGRY6Vsgof2DcwRrW 0JyY9CXCPxCv6iweI193R8yDMfFe0qoDoP0B/zsDGhIn9m3xnMTfrzC+VV5LzWwTW+ jNPuIYN6Y9HZSmIDB1AHApXa/BW4pTTYL+v4lMQYUhn+1QHAoAjm2xFvwFeNMNDUvX rvB33oe7S2Lrg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mlf4c-1qMwNl0JUI-00imy4 for ; Mon, 20 Mar 2023 12:47:07 +0100 Date: Mon, 20 Mar 2023 12:47:06 +0100 Message-Id: <87pm931w79.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #62260 X-Provags-ID: V03:K1:Bmu9HPoxgdP1s9WuZJJoTILrOIYFuqaLeVMQ+iGcwFlevM0Sal+ SnmB32GpvIkTy7jgI92FQnF8Dp0TC2ApzRTQ8DHJZt8jDjmxKrYfwTG/1FysT0ga7o6NpHe G/mCAmZsmBX761l3ofrDPYUhcfUfz6aXEEZ2+g65XIB21vnTUzs9fIsS7ZpYf+ckz/lwzJ/ AJdvGP6eF7gwIz+yPhH/w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wDmXn5toDkc=;8PVoJoMWAGTcvuRC2gUt7rAvdh9 27Lzm21M5uwRMXiFS0TdCUQb4vH1tY4OVm/nNnKeXTvkq9t5oMgIo87tbxBLrCswiqT9VwnVB NI2TVn7viGZxbg8JV0JcaEHhtDizQ7S1+uo9/GPmb8vwjaz5l/RbIqyPqOz9lRLMZw3Ap/n/m WRMDPLx+Keg3X5EMi9oNsu7o84KpD4IMNQ316SVya/Eve5H+a1ZXFm1isMQC9yJ+I8Pj1823F qzIo+6wUH+XCZDZHlkzFSKuIu4ay7e0E2tAkmtc/eK6DC2gFo6s2EW8n9cQ85AenSR760HV90 qbgGFkIsY7nutUEF3pAAWdzaXyp74RMOMbqqVCUxt5w93gnBSbdKXoxLYNdRQKG0Bf+eDD9tL ZskI8JCUwQig3ecdgPg54eamAbv9/obAz06UCPdAvKQ7iHKrBVlSd1pb+s8grHFrA4nHj4Lni HDJYIlBHHq+xkpPSZ57HD2RoG95pYs/zwaOWVYEKaLW0Pmg43LIzOCOkznHVyG3jhGMWkXL/s C4dDKusprEn8lx/L/xORfR4aOJnmZaAScM7OdTiTrdwtJMQKAw/qGD3ZY2F+v1AbNF2lZBqfh ZDjHG4wx4voTA2ejVvRRBPruO3MdN6RjPwEqlgfJXWhTBSWfcjmfvdHMXsTo6NQ/liqRhajJ5 3T9TUxw7XBbhs1SbHJJrtQD4TmuYcOo2+/5Lzaw2YNENUxXkPOjwWeEl1yz1uZGueBHGmvkBU wiQQgIpsx6UlCqL1rqzJAQhEfHMiXmh/Kivcm3Q7gMz7cpWuZ9aVUFzg9HpO+hRAh3nfGowYs 3cJ2KJjdYrx2tEzpX+YI4iIfgJ84O2vN5O3iAuWlsyY2QMmJX18P7o1FFqRNUj0AgLp/0rQ8y YwytA3soh02ggV3p11EUqHBfVfU4B+1Cwq90JbniAMbUQj2y2xqJMFKZaJxx4y4abmmr5k+5p +A/hSLyxcSxpRiDnPhMPpbprvwU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) merge 62260 57395 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 08:22:40 2023 Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 12:22:40 +0000 Received: from localhost ([127.0.0.1]:53883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peEX9-0006qp-Pa for submit@debbugs.gnu.org; Mon, 20 Mar 2023 08:22:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peEX8-0006qd-7h for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 08:22:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peEX2-0008Uc-6D; Mon, 20 Mar 2023 08:22:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3JnicmzjS/oZ9hLEe9WiJ64667yDMaLHM2W4mQ9HHzQ=; b=HdL//etlzJVS 5VVt/0yqsLlCSopYtlW+PzTRFKx0oSkoJ5SkTNQ3OmCr8t5W/g6fUgaqWKnAXqKZdgU/W0sQwWdOu J10vDc2ArWgKacHAsIV5f4DrC5lgnosopyNc2lhKuxatUZIpk2xaSCLLXIwsItmgRkM1X4KVuRP/r bcJuMOKu89jLEdxLfZFWXR178VhC84pVMS0ybjuOR2ihOnDJ5CD3dn+BSBt2X678gMfjxkQrJMimI uHvvd/Wv04JvRIwvJG0PHeYIidKZ4zNeYG9BxvlPT73HrEJkPVT19Hi6Gy3b84BY85+7RfooPHOy7 Zs+s73SAqTZO4FxelygLnA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peEX1-0006Zq-IK; Mon, 20 Mar 2023 08:22:31 -0400 Date: Mon, 20 Mar 2023 14:22:40 +0200 Message-Id: <83edpj8ve7.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87zg871wgh.fsf@gmx.de> (message from Michael Albinus on Mon, 20 Mar 2023 12:41:34 +0100) Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87v8iw6e0v.fsf@ledu-giraud.fr> <87zg871wgh.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62260 Cc: manuel@ledu-giraud.fr, 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Eli Zaretskii , 62260@debbugs.gnu.org > Date: Mon, 20 Mar 2023 12:41:34 +0100 > > Manuel Giraud writes: > > > Thanks for your inputs. I have tried with > > 'auto-save-file-name-transforms' like this: > > > > (add-to-list 'auto-save-file-name-transforms > > '("\\`/\\(?:doas\\|ksu\\|su\\(?:do\\)?\\):.*\\'" "/dev/null" nil)) > > > > But now, auto-save tries to create "/dev/#null#". How can I fix it to > > "/dev/null"? > > auto-save-file-name-transforms does not know the meaning of "/dev/null", > it handles it like an ordinary file name. The following code snippet > shall do what you want instead (untested): > > --8<---------------cut here---------------start------------->8--- > (defun my-find-file-hook () > (and buffer-file-name > (member (file-remote-p buffer-file-name 'method) '("doas" "ksu" "su" "sudo")) > (auto-save-mode 0))) > (add-hook 'find-file-hook 'my-find-file-hook) > --8<---------------cut here---------------end--------------->8--- > > @Eli: We have already remote-file-name-inhibit-auto-save-visited. Shall > we define another user option remote-file-name-inhibit-auto-save, which > could be used similarly? Fine by me, but this is not for emacs-29. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 08:31:19 2023 Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 12:31:19 +0000 Received: from localhost ([127.0.0.1]:53894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peEfX-000752-7G for submit@debbugs.gnu.org; Mon, 20 Mar 2023 08:31:19 -0400 Received: from mout.gmx.net ([212.227.15.18]:53913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peEfU-00074n-4e for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 08:31:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679315469; i=michael.albinus@gmx.de; bh=gWvhjkIgsYLAEEUQjrpswRPSo79MRmTEnBTfFnxpCh8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Ul9/puQzp9L2EC6Ysj4xL1go79nPiIAZZVQzKt8eyQYur/bHdS89aCXayuOX3x4X3 eoN28FByqyVKQ2gnW/c14NsQH+uyuEZi9WG4mGry58WBD4cJc3mUI9kHdM0AospMdW aoQgsjA9YGXbkRmfxuzkpHyDiOZDaKy4l3qS3glgaaTTS3VW+HdGeO8AFNqBk39RZ0 lz/6gtgpjf3bDLgO+wmdMh3ab8/ojoVou25eS5CnsvcDrUEXiw6EGmmvu2PSEkXjBW TgnKpiKcq59WVbrA6j3gH+qKOUNfGVUBDQJ5AH5cMOMD7UMOGY5FbHmrIsfjjiCVMi QCVZLkvx8MiYA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8QS2-1pZop318jI-004Pe7; Mon, 20 Mar 2023 13:31:09 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <83edpj8ve7.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Mar 2023 14:22:40 +0200") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87v8iw6e0v.fsf@ledu-giraud.fr> <87zg871wgh.fsf@gmx.de> <83edpj8ve7.fsf@gnu.org> Date: Mon, 20 Mar 2023 13:31:08 +0100 Message-ID: <87fs9z1u5v.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DrUSIlXD61bilMzmGAXOQzQSwrzCsEHZXvE1/opPfghbw8PF+ZJ cIGd8KpQ0LFoY3ffQNwrUeLEF3UOuMin/3S3Cl/jyO+emHx9umPKg8Fy0edKfbgunjIybpQ 4QuM2ECiGu2YebcFL70uybb+5JCNFzNPCrLoh+MxwH70N86fJglSpZEkjmRL0jxhk+rg9Mr 4KNjR0/XKC3dYNeQjpH0g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:yHJQuNwe5pE=;OkXW77UVWUphPxy0uoIq2bVRUvV UD+O5VMPNXqmRSXW/gz4mRlF/iHmpIxMuEwZfLfxJ947TfuknI7mLTX7kDGOWVC3mxbg2zINv 9M6Qo8gGi+35c+D3RXkXk6Nk4fssJ4JtvrdPVyHzPShZq/UJP3JweXUJL5XzaeBlw4AC8vCoA IILLOvSgMntY64bcals2n8xsZ0FKm2opGuiXYiErvA8y5x/2/r4h7dpBGJUWKZJwxOahH49YI CJvybysZzQMZ1qMDavzXHQZcPyMz7MX8xKavzmZR+LMozRwLfyOzdRs8Gf9cz7csAZp4eKXuk 6OyuqjjJNr3gQGWoj58vKITQ0yyQXneel4YaltO8WbF4STeJFt1sjkuHP3zJ9vs+1qw6Z0SCj 58yBBV2hxbYLKcatUe6adZqrJ2i+yANlZc9CJ3AZ1jne7Ik2EnGhLzNBBS+cer42iRirNc4UJ hFN6sC4M2jn4gr6lL+4Bsdqe2g5RjlNgC4SDeFgWdvJI/ixnQ+FAK0alZaN5NPbB0Rjtpd258 y7zW0OsAC8n9gghglBbZkr3t6ZExTBBkhF0gKM2eYM3wnqvwtJJozoOK+wnSqyF4sSN9bXUmK 2MY+HAhWnmhFNJXhtCMbCUM0C7l/MLHBIVHikLX3/vV4KcFDTdxtRTxFG/JB/nMpqnUoUJi46 HnLt5oK0zgNYiEGAgvXGiVvRKrqvjs6M+z859f9sBm6/EhqTjb/7iMizlxDUbPLEiI3bQoGGN gFMh9IyECOjgKNeaRLFUd/WdrzHnH0ItGgKVTYYz9fBCNKoZTA9S+PZLjHF+Zj/0tp7PV6WDr meZjmvugknufZq4YaZlcHVyRGoG/At0grDKiU+XA535C//eUB0zJ/k1f1CmntL17QSqT99Bh3 L3qvPtTy98MGv92EMmRPumhyM3E9U5kNHHZQGJ6DKOOc6HFTbFk2oleDAP6eYSNep5jXzFKLd AHniru3Ujh0w6pmOi8CiyUUK6eM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: manuel@ledu-giraud.fr, 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, >> @Eli: We have already remote-file-name-inhibit-auto-save-visited. Shall >> we define another user option remote-file-name-inhibit-auto-save, which >> could be used similarly? > > Fine by me, but this is not for emacs-29. Sure. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 10:16:08 2023 Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 14:16:08 +0000 Received: from localhost ([127.0.0.1]:55460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peGIy-0006nO-4P for submit@debbugs.gnu.org; Mon, 20 Mar 2023 10:16:08 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:49147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peGIs-0006mk-5h for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 10:16:06 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=2dTW3fZ6 JocJVOeWPyR1KNFHuYaKoNs1zdTuTgMHF68=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=c2/pwTYvVKYzVeO3aNo4K5Wdba9p+U Dy2IWNs6P0GU3B356JJBstL1Baw5I5Kp24KtEe5vEup56a8G8f5LlACw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=2dTW3fZ6JocJVOeW PyR1KNFHuYaKoNs1zdTuTgMHF68=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=hRhfRS4KAUcKOQW1VT6nknbIppCZ95RR4M7yXw qHwxpxJHgKqRj7SVhoB4/+OlQj73oBLAPOUlT6/q2qze+y59bjNsTjJlIA24PCAEDZ0dmg 8r8/HIKOvI63OJHwLqxvNN+xjYUMtOCT07mpTL0otKQ4fAP08Te6tFGT+i+eseNxLr2ebL zKQRSZX1wiL4Yvhf5xQXWwsplgMSNzM8HuVRKBL+ttqgMdNkN+nG+KNy53xD0oAV0zjfJT 6AO0cfOGdBqCXI1Qifw2nEvT0THvf70iH1hHDmybln/hjorNmgVqzDUmHLv7G+FCwjraDd 19pA2U+2GQii5c2OXT00T86g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id cb647c1d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 20 Mar 2023 15:16:00 +0100 (CET) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87zg871wgh.fsf@gmx.de> (Michael Albinus's message of "Mon, 20 Mar 2023 12:41:34 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87v8iw6e0v.fsf@ledu-giraud.fr> <87zg871wgh.fsf@gmx.de> Date: Mon, 20 Mar 2023 15:15:59 +0100 Message-ID: <875yavmrts.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: [...] > (defun my-find-file-hook () > (and buffer-file-name > (member (file-remote-p buffer-file-name 'method) '("doas" "ksu" "s= u" "sudo")) > (auto-save-mode 0))) > (add-hook 'find-file-hook 'my-find-file-hook) Hi Michael, Thanks for this method, I'll try that. > @Eli: We have already remote-file-name-inhibit-auto-save-visited. Shall > we define another user option remote-file-name-inhibit-auto-save, which > could be used similarly? It is a good idea and will be more simple for the end user than the hook you proposed above. That said, I think an important aspect of bug#57395 is to consider what remote/sudo file is "dangerous" and what isn't. So maybe, it would be better to have an option 'dangerous-file-name-inhibit-auto-save' and have a "piece of code" (so easy to say =F0=9F=98=85) that check whether a file is a dangerous one or n= ot=E2=80=A6 Or maybe it is over engineering things. Best regards, --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 06:13:08 2023 Received: (at 62260) by debbugs.gnu.org; 22 Mar 2023 10:13:08 +0000 Received: from localhost ([127.0.0.1]:33583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pevSt-000861-LK for submit@debbugs.gnu.org; Wed, 22 Mar 2023 06:13:08 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:9057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pevSr-00085s-3u for 62260@debbugs.gnu.org; Wed, 22 Mar 2023 06:13:06 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ChskvKjQ x8QWUNZM4sAxspwyiqJC0TA3M6tmSLpO33g=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=JKT0u5KIWIqtyX3Lc9NAbCiRuNQYF3 Qf00Em/wqeyy4qdJq9YJbclHgowOy7AdbrjI4oEBh3Li9YD2KYAgXMAg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ChskvKjQx8QWUNZM 4sAxspwyiqJC0TA3M6tmSLpO33g=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=xMdQKZcTCo9KRsgrVia6RmU7I6cadIBApZKXc7 +jeZnU/CJoX9zmJdLocNQPGkiqEy7d956fW1+nUAjDMmEsapSbeJi0qkDpeM7btZpPFAaR 4PCGbibxW7SLv3nFSwQ1Uf1SzF0jFuvxzjD4Lcc9r/2HAW2eBDl7l57+/hHrg6gwVkm81t KoLgcKpglC4nFvI0miNHErmA9gRbVxsO1vAI433NSDsogavJIQI4aC+qx3iUDVoPvhgsYW dwzGxvYMmPcyxK2ojbVDp1+7VcW6zZ6giSXfQXolLYQgOIUPY0axmRoDOvejLcgatrDUGL tCuQalsbE9o9JZXiuGRgN+dw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 85410179 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 22 Mar 2023 11:13:03 +0100 (CET) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87r0tj1wbv.fsf@gmx.de> (Michael Albinus's message of "Mon, 20 Mar 2023 12:44:20 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87r0tk6d09.fsf@ledu-giraud.fr> <87r0tj1wbv.fsf@gmx.de> Date: Wed, 22 Mar 2023 11:13:03 +0100 Message-ID: <87lejpm6vk.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Michael, What do you think of the attached patch? I think it fixes point 2 and 4 of bug#57395. IMO point 3 (unsafe non-root-owned file) is not really solvable in a remote setup: local and remote uid can be any numbers. What I'd like to do then is to work on point 1. For this, my idea is to make 'tramp-allow-unsafe-temporary-files' a three states variable with the following possible values: - 'ask (default value): Prompt the user "Autosave file on local temporary directory, do you want to continue?" - nil: auto-save-mode should be disable on this file (same behaviour when answering "no" to the prompt) - t: auto-save-mode is on as usual (same behaviour when answering "yes" to the prompt) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Narrow-unsafe-auto-save.patch >From 2eaf3b2ef59868a349af8d5a1a1132ef1d1cbbe2 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Wed, 22 Mar 2023 10:46:23 +0100 Subject: [PATCH] Narrow unsafe auto-save * lisp/net/tramp.el (tramp-dangerous-auto-save-p): New function to determine dangerouness of an auto-save. (tramp-handle-make-auto-save-file-name): Use it. --- lisp/net/tramp.el | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index 6eff5b2ca60..c3ee0ae06a6 100644 --- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el @@ -6474,6 +6474,21 @@ tramp-delete-temp-file-function (remove-hook 'kill-buffer-hook #'tramp-delete-temp-file-function))) +(defun tramp-dangerous-auto-save-p (filename autosave) + (let ((attributes (file-attributes filename 'integer)) + (modes (file-modes filename 'nofollow))) + (and + ;; a file own by root and rwx only by root... + (and (= (or (file-attribute-user-id attributes) + tramp-unknown-id-integer) + tramp-root-id-integer) + (= modes (logand modes #o700))) + ;; ... into world readable autosave temporary + (and (file-in-directory-p autosave temporary-file-directory) + (/= (logand (file-modes temporary-file-directory 'nofollow) + #o006) + 0))))) + (defun tramp-handle-make-auto-save-file-name () "Like `make-auto-save-file-name' for Tramp files. Returns a file name in `tramp-auto-save-directory' for autosaving @@ -6516,11 +6531,7 @@ tramp-handle-make-auto-save-file-name ;; Protect against security hole. (when (and (not tramp-allow-unsafe-temporary-files) auto-save-default - (file-in-directory-p result temporary-file-directory) - (= (or (file-attribute-user-id - (file-attributes filename 'integer)) - tramp-unknown-id-integer) - tramp-root-id-integer) + (tramp-dangerous-auto-save-p filename result) (not (with-tramp-connection-property (tramp-get-process v) "unsafe-temporary-file" (yes-or-no-p -- 2.39.2 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 12:26:36 2023 Received: (at 62260) by debbugs.gnu.org; 23 Mar 2023 16:26:36 +0000 Received: from localhost ([127.0.0.1]:39211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfNls-0003o0-3k for submit@debbugs.gnu.org; Thu, 23 Mar 2023 12:26:36 -0400 Received: from mout.gmx.net ([212.227.17.22]:59151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfNlo-0003nl-QH for 62260@debbugs.gnu.org; Thu, 23 Mar 2023 12:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679588786; i=michael.albinus@gmx.de; bh=80GnWjRDQKUXxLgJT5LrHFPFkYMAzdSDq2AXmPuEds8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=HD1Jpp+rfEA2DX9nJHkBR8Bnx5du38MRlQVNyEbk/jrl0tXmSo36UP8MEOHd6EXMD c4TrQscLPwv2nqfmFB+MK0ybf+VDJrm/FoH/r+Hfpjq4hckLGP56y+yJgoPa1NbW5H WDYXuYK27FSvdFWj/sEtinqfSx8g2wCGt8GjRc1MpLGTWe9MHti8fdGd8zcMw2oYTD IKnZYQ6VKT+AG1HQWVg3uhsavmXEI4HTEDAJ3HUcrErVKdAjNDrxiJJuVBjCAA8gnI 4GO8YaKmOmC8TNaSgvj1YTw7rELRrjVpdrgai/LZ41GQvDGOR5c3otVm+8OzXaKJ+y ZNciRiMYLAYYg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmDEm-1qNTwg0d04-00iEyX; Thu, 23 Mar 2023 17:26:26 +0100 From: Michael Albinus To: Manuel Giraud Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87lejpm6vk.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Wed, 22 Mar 2023 11:13:03 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87r0tk6d09.fsf@ledu-giraud.fr> <87r0tj1wbv.fsf@gmx.de> <87lejpm6vk.fsf@ledu-giraud.fr> Date: Thu, 23 Mar 2023 17:26:25 +0100 Message-ID: <875yaro2mm.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:eqEPdFrrXppBewyg5KnCTAe8xEeq2f9wIu488+YyruH98Bn5HlK yCxhsP6g2aNGycB2zxfeg1PtXwObb9ONbLJdu+TaMV6Mnlt2sINY8eteUZ6W8A5WVnRvVqh q5B7WmdH9D773dZ4oiGO3QGYNTWral2QjS2J66pOYu8ltcautssH+2SzijZTjGevckx7pak S7P8Tvs8NFr/wVEkrRDFg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4qlGMfMrLlA=;QcFac0vxE0TYJNanuZbpvmrRTl2 h9HzhJxfvASe4QkPKqoaapTMTgtaYb8GJNR5YncSaKSi7JdE8T8PUp9UJQ8f4pu7yOQVBF683 mB7n7h9XSQtPPgoeK+D0fF2Fc88S5QtmT6NUklVhj/TvkyInAbgIDy8ijk8PJZlf5zZk7I2yI RixDbyUfNZhVTcwUXA+kpmlCJ9RI7fUq4qR+3F/h6LfCKugiKLb4dTEQI0tDEUeXGzdsVlnNo UwA62uh9ToRNH5jBno731TG/gwNYpmBuXYRl7FDGIIB8NR0m+dNET9M65P9hXj42514CN0H6r uPvhXuSTij4r5lWk8jPNvd2AZ7ZwrW5wQOx3CDQIgu6tqDT/aIXMtx4MkKsLHN1Cpw6ulrZNK p97X2Tnb30OCRfXfJgQLrHzDA3Hq0Ye4cGFbmJGl4ZEW9BGW4lXMrWOcsMTKcnJDGXo+TZQCM QWfnlXq3Azfy5s2RIDiRqt8fp20wqDdTJ4seGvFUTm4u01bji81lVrBSximJ9tfchj7lBnOok UqAvXhWHaopN4v4jQoQrx5nusTJNurQIHYl//xQ4bqz7D5OnzhbkIlIEI26ScEkUJ6CUBb/Tk 5JZ3EKa4GYngvYh2pWiCbccoYNxB/x3uadQZBxH6Mwj/zLRr5gLesD5Beq54wZ0jBYa07cd75 tnxjeUmsakPH1EIN0dwUuvv0nmczQQGS6Q3K5Bfr93dPGbRRBe18lDxrSxe05TglA6ex+OQYp PTTj7wSHeeoj0l27jqnYT7Z23wmxwOdX2Nw7nGy0U6+A6tJjVIRKhytKH9iTsQhQRyO2kANNl On4ZKzbvfKWLMQ9peRfyyBXqXiC3AAKIsp2ZxYCr+EJjQi8UR50YyECHysfdpv3xj9R23OFlQ sOkFed8NYexuwztM0ZJNFjkwHX9eig7kR9p+uy7m1MzkkUTbQet7BWBboPwisWTDp1rHljTbr r+bLbEg2Sywb15yho3nO0ILYzvk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Manuel Giraud writes: > Hi Michael, Hi Manuel, > What do you think of the attached patch? Honestly, I haven't had enough time to review it in detail. My gut feeling tells me that it looks to complicate and too much hard-coded, but I will need to review. I hope I could do it next days. > I think it fixes point 2 and 4 of bug#57395. IMO point 3 (unsafe > non-root-owned file) is not really solvable in a remote setup: local and > remote uid can be any numbers. > > What I'd like to do then is to work on point 1. For this, my idea is to > make 'tramp-allow-unsafe-temporary-files' a three states variable with > the following possible values: > > - 'ask (default value): Prompt the user "Autosave file on > local temporary directory, do you want to continue?" > > - nil: auto-save-mode should be disable on this file (same > behaviour when answering "no" to the prompt) >=20=20=20=20=20=20=20=20=20=20=20=20=20 > - t: auto-save-mode is on as usual (same behaviour when > answering "yes" to the prompt) Please take into account, that tramp-allow-unsafe-temporary-files is not only for auto-save files. It is used also for backup and file locks. See functions tramp-handle-find-backup-file-name, tramp-handle-lock-file and tramp-handle-make-auto-save-file-name. For the time being, I have added the possibility to suppress auto-save for remote files. The Tramp manual says now: --8<---------------cut here---------------start------------->8--- =E2=88=92 Keep auto-save files local. This is already the default configuration in Emacs, don=E2=80=99t change it. If you want to disable auto-saving for remote files at all, set =E2=80=98remote-file-name-inhibit-auto-save=E2=80=99 to =E2=80=98= t=E2=80=99, but think about the consequences! If you want to disable auto-saving just for selected connections, for example due to security considerations, use connection-local variables in order to set =E2=80=98buffer-auto-save-file-name=E2=80=99. If you, for exampl= e, want to disable auto-saving for all =E2=80=98sudo=E2=80=99 connections, a= pply the following code. *Note (emacs)Connection Variables::. (connection-local-set-profile-variables 'my-auto-save-profile '((buffer-auto-save-file-name . nil))) (connection-local-set-profiles '(:application tramp :protocol "sudo") 'my-auto-save-profile) --8<---------------cut here---------------end--------------->8--- Pushed to master. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 03:34:42 2023 Received: (at 62260) by debbugs.gnu.org; 24 Mar 2023 07:34:42 +0000 Received: from localhost ([127.0.0.1]:39740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfbwg-0005SE-4u for submit@debbugs.gnu.org; Fri, 24 Mar 2023 03:34:42 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:17285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfbwQ-0005Rg-Aa for 62260@debbugs.gnu.org; Fri, 24 Mar 2023 03:34:40 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=hXyWVwyx vKjcaDuguwHnJMkEzTy9A7WD1A8E1m8tfNA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=A2OCZ8v0zIMsAbof3rmSJuTVXb7CLz botufQ1j0lEqDZQDNJ4Ro89GnQHna53OWb0oHXsboX2jpGLBhn51DOBg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=hXyWVwyxvKjcaDug uwHnJMkEzTy9A7WD1A8E1m8tfNA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=nKArKtuBGVBvdjfUjJcTRc9/aPSS6gssKvc+TO 3z8UrGHN5QZ4ayBfkkGXg+9V5eMNdMDbRE4ASGj9PuOC+mrwbipFGA4WW2K7SbcUZ8OAwg Q4n/ajQMBg0/76SsCA563TeHvzD0TTH/rVpBqiZVp1I+tOV9GqAKUvU+qdVS1cyEOvSMIm 7EuvNWtvV4F/SrL4m12Gq9wdJfqiBuNUoGnUehp9imkOXtc0zVyLR3df0ey0gtjqEOrl9V hBMTTpgDhAmXUnvqZZiTn5h/XHYbWhEFQIgEsTDvzUVegmwR7FSKVD/jkPpNY2IA2tVxH9 YTD8+Vci9R88D7pfhJ/1KuQw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 28545d20 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 24 Mar 2023 08:34:10 +0100 (CET) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <875yaro2mm.fsf@gmx.de> (Michael Albinus's message of "Thu, 23 Mar 2023 17:26:25 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87r0tk6d09.fsf@ledu-giraud.fr> <87r0tj1wbv.fsf@gmx.de> <87lejpm6vk.fsf@ledu-giraud.fr> <875yaro2mm.fsf@gmx.de> Date: Fri, 24 Mar 2023 08:34:08 +0100 Message-ID: <87sfduy55b.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > Manuel Giraud writes: > >> Hi Michael, > > Hi Manuel, > >> What do you think of the attached patch? > > Honestly, I haven't had enough time to review it in detail. My gut > feeling tells me that it looks to complicate and too much hard-coded, > but I will need to review. I hope I could do it next days. Hi Michael, Ok, I understand that. My patch is a bit hard-coded you're right but I think it will reduce false positive triggering the user prompt about unsafe auto-save. [...] > Please take into account, that tramp-allow-unsafe-temporary-files is not > only for auto-save files. It is used also for backup and file locks. See > functions tramp-handle-find-backup-file-name, tramp-handle-lock-file and > tramp-handle-make-auto-save-file-name. Ok so it might not be possible to have this three state 'tramp-allow-unsafe-temporary-files' I propose. > For the time being, I have added the possibility to suppress auto-save > for remote files. The Tramp manual says now: Thanks. That looks great. IIUC, with this, one can disable only auto-save (not locking nor backup) on a per connection basis. I guess that it could replace what I was proposing then. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 06:35:35 2023 Received: (at 62260) by debbugs.gnu.org; 24 Mar 2023 10:35:35 +0000 Received: from localhost ([127.0.0.1]:39913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfelj-0002af-CR for submit@debbugs.gnu.org; Fri, 24 Mar 2023 06:35:35 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:10740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfelb-0002a9-3W for 62260@debbugs.gnu.org; Fri, 24 Mar 2023 06:35:34 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=i8vxRBC+ qYVYht1WEOIvI0CGB4UuFc0B2W0wJspqHXc=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=+gILFaFOIh6sA3AgvgzUOSVP6sdtKD N2M0Qc1X9s83aoaX8Ap6rG+KOduEpJn1U9+i6YZKHiV1z2xV7qUwZTDg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=i8vxRBC+qYVYht1W EOIvI0CGB4UuFc0B2W0wJspqHXc=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=TkoIVEKJCCjteAh3SrlJe6F0OQDhod9goBTio4 YzWJIj/LZxoIOZ5RBIVMjoeLarx7hKXh05DsJE2IyJOPl0ieXAUUkNAkLELFfgx7MXUQ+s QSnyfMWaJwQMLwn4qoXimD7DHgsZ1XP3RdSxOxd0WZQ7PIgqPeFtJxk0hDR2VuAIFhB0bw c3NpxPQZ/0aB8LLG7JIumAiU4Vu20OdDS+3ULcT2SPDsrwWY6H+er9SUemhBdo45lakGE7 Rqq4ppxmkGqtEFQonE1m6gcE1FBD+TGl3OEQx+oy1LVN7vYxmnHOdWtjzof87UI8sRu13r Kf/HBQHghfCsgGIg0Bbgn+Dg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1259e93e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 24 Mar 2023 11:35:09 +0100 (CET) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <875yaro2mm.fsf@gmx.de> (Michael Albinus's message of "Thu, 23 Mar 2023 17:26:25 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87r0tk6d09.fsf@ledu-giraud.fr> <87r0tj1wbv.fsf@gmx.de> <87lejpm6vk.fsf@ledu-giraud.fr> <875yaro2mm.fsf@gmx.de> Date: Fri, 24 Mar 2023 11:35:07 +0100 Message-ID: <87h6uaphd0.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: [...] > For the time being, I have added the possibility to suppress auto-save > for remote files. The Tramp manual says now: > > =E2=88=92 Keep auto-save files local. This is already the default > configuration in Emacs, don=E2=80=99t change it. If you want to > disable auto-saving for remote files at all, set > =E2=80=98remote-file-name-inhibit-auto-save=E2=80=99 to =E2=80= =98t=E2=80=99, but think about > the consequences! > > If you want to disable auto-saving just for selected > connections, for example due to security considerations, use > connection-local variables in order to set > =E2=80=98buffer-auto-save-file-name=E2=80=99. If you, for exam= ple, want to > disable auto-saving for all =E2=80=98sudo=E2=80=99 connections,= apply the > following code. *Note (emacs)Connection Variables::. > > (connection-local-set-profile-variables > 'my-auto-save-profile > '((buffer-auto-save-file-name . nil))) > > (connection-local-set-profiles > '(:application tramp :protocol "sudo") > 'my-auto-save-profile) Hi again Michael, Just a quick "heads-up". I've tried this new feature and it works great. But I still think we could reduce the false positives (as enumerated by Trent) that are triggering the user prompt with my patch or something along the line. There is also still the issue of what should be done when the user answers "no" to this prompt. Should we not open the file? Disable auto-save for this file? Best regards, --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 13:56:56 2023 Received: (at 62260) by debbugs.gnu.org; 24 Mar 2023 17:56:56 +0000 Received: from localhost ([127.0.0.1]:41312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pflep-0000SC-Kt for submit@debbugs.gnu.org; Fri, 24 Mar 2023 13:56:55 -0400 Received: from mout.gmx.net ([212.227.17.21]:39543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pflen-0000Rz-KP for 62260@debbugs.gnu.org; Fri, 24 Mar 2023 13:56:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679680600; i=michael.albinus@gmx.de; bh=PlkuHyuYzWgjPXczgyw5vsIQdqho5eTqEMR9PB+wv2I=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=GLrZazKurfmjOf9xangbppiyrrD0ouqJvieoAdAKFaqP89pKslLMQ2QiljKrAl7mt 5hmVR4dr1ZNfxzWvGDj+4JbQvYFrmk9/Du9W+fK3zPmjWqTtOSRISjQPVcrqrZqj1W A1nW3irmaXvBwWFD1l9ihNeWLB7nnbhwuvlSaHqSiR8M+TOM4LJ35+PnYsPMEuIeYG tlEGjZUK+6McdxgC73KlyZGNSoGLqtvFeCPHTuw2GrUabxNBqYZaJ5aozt6uuVQ5ul g0O6XV8fP1lS2JjPivYWZ6js0BUWMbHEMGZvKniCMnD6vkhNzTaNNJSuzH+XoMMikg 4+38+Nlfnyf8g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MkYbu-1qKqm61LtG-00m2tW; Fri, 24 Mar 2023 18:56:40 +0100 From: Michael Albinus To: Manuel Giraud Subject: Re: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode In-Reply-To: <87h6uaphd0.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Fri, 24 Mar 2023 11:35:07 +0100") References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87r0tk6d09.fsf@ledu-giraud.fr> <87r0tj1wbv.fsf@gmx.de> <87lejpm6vk.fsf@ledu-giraud.fr> <875yaro2mm.fsf@gmx.de> <87h6uaphd0.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Fri, 24 Mar 2023 18:56:37 +0100 Message-ID: <87y1nmhw2y.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:+6JvlCvg1T4ejF1zVv9C7WGNAwtSKnrHhOnGPfhksuFRUYMkQ4p tmzwQXshgipElM/A/fg9iTa/5OHwQhRzOJyJYM7LHAjWS1WErQftC4gcXu62PQpshTv0Dp+ ukAZ065zug2A9KJOdAhFJRG6zK1XuAcN3HZVkjs09xxGqmkATUGbWtgq48OjZYrSOaNSMAU t+dE62XPhxRygARomxttQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ySSiQuc7yPA=;vXbCaFIBsXVp/1JbnGUw6jglbAm 4o6rb8W7ZxpzaJVE02N/xarTsK3+fAFekPv6mceQHlklNjWN+GW05C7Lttt0VCYGpcZay1tZj RarrS8zPlb2G2m9UNE0LmGqAVYhkZnnDDrZZofrm0kK7rcjGFeg+tNUdblTGSg9EMJhdAWjor 7RrA/7KPMhM9fJEVn23ndde9ZBK7/LNEvLy+TSodYg0RFMY06DhEJhppgWYYKM6tzNrarpjN7 qxdyNjzstmpbXSlKyri7xKB01uDq+gfa3uRyywKd1KhYsbXD7u/yc4jJp/B3sXybZq/HR1tY0 9v7JK5zaLC02qZL/yHiFifvGOVoHglavUzrhbWwy1K/BM/Km46Gs/dtFkT226fh9WTuQKON1f N5hyMmcLjm3XEzB2g1z8bzdMpvH3ZzlYwXe3LFx7zCLn77CcSpreRLs6wRWLYUcE4AFaxvSGe YgRsI/O8cOMXW1VmM2IILG44T1YJ7i+X3SNmtP7VAhNyuJg80/QfJ3x7llfdfb/AKRlSBRCJ5 LTH9hEcjXY48JPVzgYMDEFx68D6L4m3q8D1mAcSRwcQsU5tBcTA52e+9l3jTQQk/jnJqCeXHi TD5c13wk3GC7eWN3lr47aWcwU/uxwVUMDVSmIGA12Xi/NmWb/8cO400/2rhR1+T8AiRq47uZV 5pL2lEKlhnadA+37EBFpZhK+2O9cBCTaxlbbRebOHb0Wv8/ngR13+wO2Uf/iF9t7Pn8875LcZ yQMWoJ0mbEXU8LsKvdbZKaMw4iVVMtZnja+A+BrGCqJ2QpVFPGUIXp2XMlBzwSR7z1pgfVQmW wetgBY5XZMmhR6tHBXNYG8uRBXjXuHkCtGWxv0iFbe4S2rv3gYvoCEJp5aeHYH9du6+N3/QOc nFByIZmfAAkj90hlNoF8+qcjZJVo9y57LqPO+6b+tPlx9YnEZnrjcTP5xKupWfZLKls5eS2v0 sZVzo5WQPkzyxvBJWZ6aoikmrDg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62260 Cc: Eli Zaretskii , 62260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Manuel Giraud writes: > Hi again Michael, Hi Manuel, > Just a quick "heads-up". I've tried this new feature and it works > great. But I still think we could reduce the false positives (as > enumerated by Trent) that are triggering the user prompt with my patch > or something along the line. > > There is also still the issue of what should be done when the user > answers "no" to this prompt. Should we not open the file? Disable > auto-save for this file? Yes and yes, these problems must be solved. But I need another free time slot in order to work on this. > Best regards, Best regards, Michael.