GNU bug report logs - #6226
Please add a customizable option to NOT call tramp for every sudo command

Previous Next

Package: emacs;

Reported by: Ken Hori <fplemma <at> gmail.com>

Date: Thu, 20 May 2010 04:44:02 UTC

Severity: normal

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6226 in the body.
You can then email your comments to 6226 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Thu, 20 May 2010 04:44:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ken Hori <fplemma <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 20 May 2010 04:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Hori <fplemma <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Please add a customizable option to NOT call tramp for every sudo 
	command
Date: Wed, 19 May 2010 21:42:59 -0700
I've recently noticed Eshell is now calling tramp for every sudo
command. Tramp is very slow, and I believe for most cases tramp
intermediation is unnecessary.

Could we please add a customizable switch to enable/disable
eshell/sudo? Disabling eshell/sudo by default would be even better.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Thu, 20 May 2010 06:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Hori <fplemma <at> gmail.com>
Cc: 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Thu, 20 May 2010 08:43:07 +0200
Ken Hori <fplemma <at> gmail.com> writes:

> I've recently noticed Eshell is now calling tramp for every sudo
> command. Tramp is very slow, and I believe for most cases tramp
> intermediation is unnecessary.
>
> Could we please add a customizable switch to enable/disable
> eshell/sudo? Disabling eshell/sudo by default would be even better.

All built-in commands of eshell can be disabled by prepending "*". See

  (info "(eshell)Built-ins")

That means, you shall call

~ $ *sudo command

Best regards, Michael.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Sat, 22 May 2010 03:51:02 GMT) Full text and rfc822 format available.

Message #11 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Ken Hori <fplemma <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for 
	every sudo command
Date: Fri, 21 May 2010 20:50:12 -0700
Yes, I am aware of that. Thank you. And I'm also aware
I can just remove eshell-unix from eshell-modules-list.

Inside em-unix.el are

  eshell/agrep
  eshell/cat
  eshell/cp
  eshell/diff
  eshell/du
  eshell/egrep
  eshell/fgrep
  eshell/glimpse
  eshell/grep
  eshell/info
  eshell/ln
  eshell/locate
  eshell/make
  eshell/man
  eshell/mkdir
  eshell/mv
  eshell/occur
  eshell/rm
  eshell/rmdir
  eshell/su
  eshell/sudo
  eshell/time
  eshell/whoami

Some are beneficial, but many command wrappers are not -- at
least to me.

I think it's a good idea to give the users freedom
of choosing which eshell commands to opt-in or out.


On Wed, May 19, 2010 at 11:43 PM, Michael Albinus
<michael.albinus <at> gmx.de> wrote:
> Ken Hori <fplemma <at> gmail.com> writes:
>
>> I've recently noticed Eshell is now calling tramp for every sudo
>> command. Tramp is very slow, and I believe for most cases tramp
>> intermediation is unnecessary.
>>
>> Could we please add a customizable switch to enable/disable
>> eshell/sudo? Disabling eshell/sudo by default would be even better.
>
> All built-in commands of eshell can be disabled by prepending "*". See
>
>  (info "(eshell)Built-ins")
>
> That means, you shall call
>
> ~ $ *sudo command
>
> Best regards, Michael.
>




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Sat, 22 May 2010 22:05:02 GMT) Full text and rfc822 format available.

Message #14 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Hori <fplemma <at> gmail.com>
Cc: 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Sun, 23 May 2010 00:03:51 +0200
Ken Hori <fplemma <at> gmail.com> writes:

> Yes, I am aware of that. Thank you. And I'm also aware
> I can just remove eshell-unix from eshell-modules-list.
>
> Inside em-unix.el are
>
>   eshell/agrep
>   eshell/cat
>   eshell/cp
>   eshell/diff
>   eshell/du
>   eshell/egrep
>   eshell/fgrep
>   eshell/glimpse
>   eshell/grep
>   eshell/info
>   eshell/ln
>   eshell/locate
>   eshell/make
>   eshell/man
>   eshell/mkdir
>   eshell/mv
>   eshell/occur
>   eshell/rm
>   eshell/rmdir
>   eshell/su
>   eshell/sudo
>   eshell/time
>   eshell/whoami
>
> Some are beneficial, but many command wrappers are not -- at
> least to me.
>
> I think it's a good idea to give the users freedom
> of choosing which eshell commands to opt-in or out.

(eval-after-load "em-unix"
  (progn
    (unintern "eshell/su")
    (unintern "eshell/sudo")))

Best regards, Michael.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Sun, 23 May 2010 13:23:02 GMT) Full text and rfc822 format available.

Message #17 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Ken Hori <fplemma <at> gmail.com>, 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Sun, 23 May 2010 09:22:20 -0400
> (eval-after-load "em-unix"
>   (progn
>     (unintern "eshell/su")
>     (unintern "eshell/sudo")))

FWIW, I think `unintern' is a bit drastic.  `makfunbound' would be my
preferred choice.


        Stefan




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Sun, 23 May 2010 17:17:01 GMT) Full text and rfc822 format available.

Message #20 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Ken Hori <fplemma <at> gmail.com>, 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Sun, 23 May 2010 19:15:59 +0200
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> (eval-after-load "em-unix"
>>   (progn
>>     (unintern "eshell/su")
>>     (unintern "eshell/sudo")))
>
> FWIW, I think `unintern' is a bit drastic.  `makfunbound' would be my
> preferred choice.

Thanks. Just another function I didn't know.

>         Stefan

Best regards, Michael.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Sun, 23 May 2010 18:55:02 GMT) Full text and rfc822 format available.

Message #23 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for 
	every sudo command
Date: Sun, 23 May 2010 20:54:03 +0200
On Sun, May 23, 2010 at 19:15, Michael Albinus <michael.albinus <at> gmx.de> wrote:
> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> FWIW, I think `unintern' is a bit drastic.  `makfunbound' would be my
>> preferred choice.
>
> Thanks. Just another function I didn't know.

`fmakunbound', I hope :-)

    Juanma




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Mon, 24 May 2010 08:17:01 GMT) Full text and rfc822 format available.

Message #26 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Ken Hori <fplemma <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Michael Albinus <michael.albinus <at> gmx.de>, 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for 
	every sudo command
Date: Mon, 24 May 2010 01:16:40 -0700
fmakunbound does the job, yes. But i just think providing a defcustom interface

> to give the users freedom
> of choosing which eshell commands to opt-in or out.

is better rather than manual enable/disable through a raw function call.
I'm speaking from user's perspective, not elisp programmer's. It's
just me though.

On Sun, May 23, 2010 at 11:54 AM, Juanma Barranquero <lekktu <at> gmail.com> wrote:
> On Sun, May 23, 2010 at 19:15, Michael Albinus <michael.albinus <at> gmx.de> wrote:
>> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>>> FWIW, I think `unintern' is a bit drastic.  `makfunbound' would be my
>>> preferred choice.
>>
>> Thanks. Just another function I didn't know.
>
> `fmakunbound', I hope :-)
>
>    Juanma
>
>
>
>




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Mon, 24 May 2010 14:07:02 GMT) Full text and rfc822 format available.

Message #29 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ken Hori <fplemma <at> gmail.com>
Cc: Juanma Barranquero <lekktu <at> gmail.com>,
	Michael Albinus <michael.albinus <at> gmx.de>, 6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Mon, 24 May 2010 10:05:56 -0400
>> `fmakunbound', I hope :-)

Yes, thanks.

> fmakunbound does the job, yes. But i just think providing a defcustom
> interface

Agreed.


        Stefan




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Wed, 26 May 2010 03:27:01 GMT) Full text and rfc822 format available.

Message #32 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Ken Hori <fplemma <at> gmail.com>, Juanma Barranquero <lekktu <at> gmail.com>,
	6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Wed, 26 May 2010 05:26:19 +0200
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> fmakunbound does the job, yes. But i just think providing a defcustom
>> interface
>
> Agreed.

I don't know, whether another defcustom is needed. Eshell gives you
already configuration hooks, for example:

(add-hook 'eshell-named-command-hook
          (lambda (command args)
            (if (member command '("su" "sudo"))
                (throw 'eshell-replace-command
	               (eshell-parse-command (concat "*" command) args)))))

Alternatively, one could disable the alias commands interactively in
eshell, without further configuration:

~ $ fmakunbound (quote eshell/su)
~ $ fmakunbound (quote eshell/sudo)

I will document both approches in eshell.texi.

>         Stefan

Best regards, Michael.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Wed, 26 May 2010 05:59:01 GMT) Full text and rfc822 format available.

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Wed, 26 May 2010 07:55:16 +0200
Michael Albinus <michael.albinus <at> gmx.de> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>>> fmakunbound does the job, yes. But i just think providing a defcustom
>>> interface
>>
>> Agreed.
>
> I don't know, whether another defcustom is needed. Eshell gives you
> already configuration hooks, for example:
>
> (add-hook 'eshell-named-command-hook
>           (lambda (command args)
>             (if (member command '("su" "sudo"))
>                 (throw 'eshell-replace-command
> 	               (eshell-parse-command (concat "*" command) args)))))
>
> Alternatively, one could disable the alias commands interactively in
> eshell, without further configuration:
>
> ~ $ fmakunbound (quote eshell/su)
> ~ $ fmakunbound (quote eshell/sudo)
>
> I will document both approches in eshell.texi.
OTOH adding an alias to su/sudo can solve problem:

alias sudo *sudo -p Password: $*
alias su LC_ALL=C *su -l

(if you enter the alias from eshell, you have to escape $)

-- 
Thierry Volpiatto
Gpg key: http://pgp.mit.edu/





Reply sent to Michael Albinus <michael.albinus <at> gmx.de>:
You have taken responsibility. (Wed, 26 May 2010 10:24:02 GMT) Full text and rfc822 format available.

Notification sent to Ken Hori <fplemma <at> gmail.com>:
bug acknowledged by developer. (Wed, 26 May 2010 10:24:02 GMT) Full text and rfc822 format available.

Message #40 received at 6226-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 6226-done <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Wed, 26 May 2010 12:16:28 +0200
Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

> OTOH adding an alias to su/sudo can solve problem:
>
> alias sudo *sudo -p Password: $*
> alias su LC_ALL=C *su -l

Excellent. Aliases stay persistent, so it is the complete solution. I've
added this to eshell.texi.

Best regards, Michael.




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6226; Package emacs. (Wed, 26 May 2010 13:32:02 GMT) Full text and rfc822 format available.

Message #43 received at 6226 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Ken Hori <fplemma <at> gmail.com>, Juanma Barranquero <lekktu <at> gmail.com>,
	6226 <at> debbugs.gnu.org
Subject: Re: bug#6226: Please add a customizable option to NOT call tramp for
	every sudo command
Date: Wed, 26 May 2010 09:30:57 -0400
>>> fmakunbound does the job, yes. But i just think providing a defcustom
>>> interface
>> Agreed.
> I don't know, whether another defcustom is needed.

I'm not sure either.  But fmakunbound is clearly not good enough since
it can't easily be undone.

> alias sudo *sudo -p Password: $*
> alias su LC_ALL=C *su -l

That's a better solution, yes.


        Stefan




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Jun 2010 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 15 years and 77 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.