Subject: bug#62254: closed (Re: [bug#62254] [PATCH] guix: Shorten URL for home page in texlive importer.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 30 Mar 2023 16:24:02 +0000

Your bug report

#62254: [PATCH] guix: Shorten URL for home page in texlive importer.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
62254: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62254
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#62254] [PATCH] guix: Shorten URL for home page in texlive importer.
From: Nicolas Goaziou <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Thu, 30 Mar 2023 18:22:56 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Ludovic Courtès <[email-masked]> writes:

>> +        ,@(or (and=> (assoc-ref data 'name)
>> +                     (lambda (name)
>> +                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
>> +                                                    name)))))
>
> Are there cases where ‘data’ might be missing ‘name’?

I don't think so. And even if assoc-ref returns #false, the template
would get the default home page.

> If not, please push!

Done. Thanks for the feedback

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] guix: Shorten URL for home page in texlive importer.
From: Nicolas Goaziou <[email-masked]>
To: [email-masked]
Date: Sat, 18 Mar 2023 14:13:19 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/import/texlive.scm (tlpdb->package): Use short URL for home page.
---
 guix/import/texlive.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/guix/import/texlive.scm b/guix/import/texlive.scm
index 82014ee568..e77b2a3f9a 100644
--- a/guix/import/texlive.scm
+++ b/guix/import/texlive.scm
@@ -286,9 +286,10 @@ (define (tlpdb->package name version package-database)
                                            (string->symbol name)))
                                        inputs))))))
               '())
-        ,@(or (and=> (assoc-ref data 'catalogue-ctan)
-                     (lambda (url)
-                       `((home-page ,(string-append "https://ctan.org" url)))))
+        ,@(or (and=> (assoc-ref data 'name)
+                     (lambda (name)
+                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
+                                                    name)))))
               '((home-page "https://www.tug.org/texlive/")))
         (synopsis ,(assoc-ref data 'shortdesc))
         (description ,(beautify-description

base-commit: 3893758dac76fc30b23d4715e849e262306f268d
-- 
2.39.2