GNU bug report logs - #62234
Toolbar does not work properly (with Emacs 29 or 30)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62234: closed (Toolbar does not work properly (with Emacs 29
 or 30))
Date: Thu, 23 Mar 2023 08:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 23 Mar 2023 10:10:10 +0200
with message-id <838rfn6g7x.fsf <at> gnu.org>
and subject line Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
has caused the debbugs.gnu.org bug report #62234,
regarding Toolbar does not work properly (with Emacs 29 or 30)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62234: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62234
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Konrad Podczeck <konrad.podczeck <at> univie.ac.at>
To: bug-gnu-emacs <at> gnu.org
Subject: Toolbar does not work properly (with Emacs 29 or 30)
Date: Fri, 17 Mar 2023 08:55:54 +0100

To reproduce:

Build a fresh Emacs app.

Start the app. The save icon is grayed out only after a mouse movement (which can be as small as you like).
 

Konrad

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: luangruo <at> yahoo.com, 62234-done <at> debbugs.gnu.org,
 konrad.podczeck <at> univie.ac.at
Subject: Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
Date: Thu, 23 Mar 2023 10:10:10 +0200

> From: Daniel Martín <mardani29 <at> yahoo.es>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  62234 <at> debbugs.gnu.org,  Konrad Podczeck
>  <konrad.podczeck <at> univie.ac.at>
> Date: Sat, 18 Mar 2023 11:25:51 +0100
> 
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
> >> +{
> >> +    return [toolbarItem isEnabled];
> >> +}
> >> +
> >
> > This does no harm on GNUstep.  However, please indent with two spaces,
> > and place spaces after -, :, and ):
> >
> > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> > {
> >   return [toolbarItem isEnabled];
> > }
> >
> > Otherwise, LGTM.  Thanks.
> 
> OK, I've attached a new version of the patch.  Konrad, could you check
> if with this patch the Emacs toolbar works as you expect?  Thanks.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.