GNU bug report logs - #62234
Toolbar does not work properly (with Emacs 29 or 30)

Previous Next

Full log

Message #41 received at 62234 <at> debbugs.gnu.org (full text, mbox):

From: Konrad Podczeck <konrad.podczeck <at> univie.ac.at>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: Po Lu <luangruo <at> yahoo.com>, Eli Zaretskii <eliz <at> gnu.org>,
 62234 <at> debbugs.gnu.org
Subject: Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
Date: Sat, 18 Mar 2023 12:07:39 +0100

After playing around a little bit, I confirm that Emacs now works as expected.

Thanks for your effort,

konrad

> Am 18.03.2023 um 11:25 schrieb Daniel Martín <mardani29 <at> yahoo.es>:
> 
> Po Lu <luangruo <at> yahoo.com> writes:
> 
>>> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
>>> +{
>>> +    return [toolbarItem isEnabled];
>>> +}
>>> +
>> 
>> This does no harm on GNUstep.  However, please indent with two spaces,
>> and place spaces after -, :, and ):
>> 
>> - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
>> {
>>  return [toolbarItem isEnabled];
>> }
>> 
>> Otherwise, LGTM.  Thanks.
> 
> OK, I've attached a new version of the patch.  Konrad, could you check
> if with this patch the Emacs toolbar works as you expect?  Thanks.
> 
> <0001-Fix-toolbar-item-validation-in-the-NS-port.patch>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.