GNU bug report logs - #62234
Toolbar does not work properly (with Emacs 29 or 30)

Previous Next

Package: emacs;

Reported by: Konrad Podczeck <konrad.podczeck <at> univie.ac.at>

Date: Fri, 17 Mar 2023 08:12:02 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #38 received at 62234 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 62234 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck <at> univie.ac.at>
Subject: Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
Date: Sat, 18 Mar 2023 11:25:51 +0100

[Message part 1 (text/plain, inline)]
Po Lu <luangruo <at> yahoo.com> writes:

>> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
>> +{
>> +    return [toolbarItem isEnabled];
>> +}
>> +
>
> This does no harm on GNUstep.  However, please indent with two spaces,
> and place spaces after -, :, and ):
>
> - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> {
>   return [toolbarItem isEnabled];
> }
>
> Otherwise, LGTM.  Thanks.

OK, I've attached a new version of the patch.  Konrad, could you check
if with this patch the Emacs toolbar works as you expect?  Thanks.


[0001-Fix-toolbar-item-validation-in-the-NS-port.patch (text/x-patch, attachment)]
This bug report was last modified 2 years and 60 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.