Subject: Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)

From: Eli Zaretskii <[email-masked]>
Date: Thu, 23 Mar 2023 10:10:10 +0200

> From: Daniel Martín <[email-masked]>
> Cc: Eli Zaretskii <[email-masked]>,  [email-masked],  Konrad Podczeck
>  <[email-masked]>
> Date: Sat, 18 Mar 2023 11:25:51 +0100
> 
> Po Lu <[email-masked]> writes:
> 
> >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
> >> +{
> >> +    return [toolbarItem isEnabled];
> >> +}
> >> +
> >
> > This does no harm on GNUstep.  However, please indent with two spaces,
> > and place spaces after -, :, and ):
> >
> > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> > {
> >   return [toolbarItem isEnabled];
> > }
> >
> > Otherwise, LGTM.  Thanks.
> 
> OK, I've attached a new version of the patch.  Konrad, could you check
> if with this patch the Emacs toolbar works as you expect?  Thanks.

Thanks, installed on the emacs-29 branch, and closing the bug.