Subject: bug#62234: closed (Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30))

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 23 Mar 2023 08:11:02 +0000

Your bug report

#62234: Toolbar does not work properly (with Emacs 29 or 30)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
62234: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62234
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
From: Eli Zaretskii <[email-masked]>
To: Daniel Martín <[email-masked]>
Cc: [email-masked], [email-masked], [email-masked]
Date: Thu, 23 Mar 2023 10:10:10 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Daniel Martín <[email-masked]>
> Cc: Eli Zaretskii <[email-masked]>,  [email-masked],  Konrad Podczeck
>  <[email-masked]>
> Date: Sat, 18 Mar 2023 11:25:51 +0100
> 
> Po Lu <[email-masked]> writes:
> 
> >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
> >> +{
> >> +    return [toolbarItem isEnabled];
> >> +}
> >> +
> >
> > This does no harm on GNUstep.  However, please indent with two spaces,
> > and place spaces after -, :, and ):
> >
> > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> > {
> >   return [toolbarItem isEnabled];
> > }
> >
> > Otherwise, LGTM.  Thanks.
> 
> OK, I've attached a new version of the patch.  Konrad, could you check
> if with this patch the Emacs toolbar works as you expect?  Thanks.

Thanks, installed on the emacs-29 branch, and closing the bug.

Subject: Toolbar does not work properly (with Emacs 29 or 30)
From: Konrad Podczeck <[email-masked]>
To: [email-masked]
Date: Fri, 17 Mar 2023 08:55:54 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

To reproduce:

Build a fresh Emacs app.

Start the app. The save icon is grayed out only after a mouse movement (which can be as small as you like).

Konrad