GNU bug report logs - #62229
29.0.60; It's no longer possible to customize the xref ring size

Previous Next

Full log

Message #14 received at 62229 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62229 <at> debbugs.gnu.org
Subject: Re: bug#62229: 29.0.60; It's no longer possible to customize the xref
 ring size
Date: Fri, 17 Mar 2023 08:02:22 -0400

[Message part 1 (text/plain, inline)]

On Fri, Mar 17, 2023, 04:17 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Spencer Baugh <sbaugh <at> janestreet.com>
> > Date: Thu, 16 Mar 2023 18:11:06 -0400
> >
> >
> > Emacs 28 had the function xref-set-marker-ring-length and the
> > customizable variable xref-marker-ring-length which allowed growing
> > the amount of history kept by xref.
> >
> > This feature has been lost in Emacs 29; that variable has been
> > obsoleted with no replacement.
> >
> > It's not clear, looking at the change, whether this is because the
> > size is now infinite or not.  The same commit that obsoleted that
> > variable added the similar tags-location-ring-length.  However that
> > variable has no docstring, no customize hooks, and setting it has no
> > effect unless tags-reset-tags-tables is called.
> >
> > At the very least, all this should be documented better, and the
> > obsoleting of this function and variable should be mentioned in NEWS.
> > If the history is indeed infinite now, that should be mentioned in
> > NEWS as well.
>
> Indeed, that change paid very little attention to documenting the
> important aspects of adding Xref history and using it instead of a
> limited-size ring.  We should do better.
>
> I've now attempted to add the missing documentation; please take a
> look at the latest emacs-29 branch.
>

Yes, looks great! Covers all my concerns!

>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.