Subject: Re: [bug#62228] [PATCH v4 3/3] gnu: Add sgt-puzzles.

From: Liliana Marie Prikler <[email-masked]>
Date: Tue, 12 Mar 2024 08:50:34 +0100

Am Dienstag, dem 12.03.2024 um 08:28 +0100 schrieb Sergey Trofimov:
> * gnu/packages/games.scm (sgt-puzzles): New variable.
> ---
>  gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 9ff08e5e74..94aa9e9140 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -938,6 +938,40 @@ (define-public rogue
>      (home-page "https://github.com/Davidslv/rogue")
>      (license license:bsd-3)))
>  
> +(define-public sgt-puzzles
> +  (package
> +    (name "sgt-puzzles")
> +    (version "20240302.80aac31")
It is still unclear where this version string comes from.  See section
22.5.3 Version Numbers in the manual for the correct layout.
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url
> "https://git.tartarus.org/simon/puzzles.git")
> +                    (commit
> "80aac3104096aee4057b675c53ece8e60793aa90")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "0z4clv0xi98q28riz323ppn165cm62gj1c6h3xdd2sym4v8gy65z"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list #:tests? #f ;No tests.
> +           #:configure-flags #~(list "-DNAME_PREFIX=sgt-")
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'set-xdg-open-path
> +                          (lambda _
> +                            (substitute* "gtk.c"
> +                              (("(#define HELP_BROWSER_PATH ).+" all
> define)
> +                               (string-append define "\""
> +                                              #$(this-package-input
> +                                                 "xdg-utils")
> +                                              "/bin/xdg-
> open\"\n"))))))))
Use search-input-file instead.  You might also want to dedent this
whole thing a little to save some horizontal real-estate and fit one-
liners into one line, actually.
> +    (inputs (list gtk+ xdg-utils))
> +    (native-inputs (list pkg-config perl imagemagick halibut))
> +    (home-page
> "https://www.chiark.greenend.org.uk/~sgtatham/puzzles/")
> +    (synopsis "Simon Tatham's portable puzzle collection")
> +    (description
> +     "Simon Tatham's Portable Puzzle Collection contains a number of
> +popular puzzle games for one player.")
> +    (license license:expat)))
Cheers