Subject: Re: [PATCH 1/2] gnu: Add halibut.

From: Liliana Marie Prikler <[email-masked]>
Date: Fri, 17 Mar 2023 08:50:32 +0100

Am Donnerstag, dem 16.03.2023 um 22:24 +0100 schrieb Sergey Trofimov:
> * gnu/packages/documentation.scm (halibut): New variable.
Split the cosmetic changes (prefixing guix licenses with license:) and
functional (adding halibut) changes into two: First the prefixing, then
adding halibut.

> +(define-public halibut
> +  (package
> +    (name "halibut")
> +    (version "1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +            
> "https://www.chiark.greenend.org.uk/~sgtatham/halibut/halibut-"
> +             version "/halibut-" version ".tar.gz"))
> +       (sha256
> +        (base32
> "0ciikn878vivs4ayvwvr63nnhpcg12m8023xv514zxqpdxlzg85a"))))
> +    (build-system cmake-build-system)
> +    (native-inputs (list pkg-config perl))
> +    (arguments
> +     '(#:tests? #f)) ; No tests.
Normally, arguments come after build-system and before any inputs.
> +    (home-page
> "https://www.chiark.greenend.org.uk/~sgtatham/halibut/")
> +    (synopsis "Documentation production system for software
> manuals")
> +    (description "This is yet another text formatting system,
> intended primarily for
Use "Halibut" instead of "this".  "yet another" is a little
superfluous.
> +writing software documentation.  It accepts a single source format
> and outputs any or
> +all of text, HTML, Windows Help, man pages, GNU info, PostScript, or
> PDF.  
any or all of => any combination of
text => plain text,
Windows Help => delete, we don't advocate unfree software here
man pages, GNU info => Unix man or info pages
I'd also add the word "document" to plain text, HTML, PostScript and
PDF.  Feel free to regroup them.

Cheers