From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 12:11:58 2023 Received: (at submit) by debbugs.gnu.org; 16 Mar 2023 16:11:58 +0000 Received: from localhost ([127.0.0.1]:42787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcqCs-0004nF-3Y for submit@debbugs.gnu.org; Thu, 16 Mar 2023 12:11:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:53334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcqCn-0004n1-8B for submit@debbugs.gnu.org; Thu, 16 Mar 2023 12:11:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcqCn-0003vu-2J for guix-patches@gnu.org; Thu, 16 Mar 2023 12:11:53 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pcqCk-0004fw-Q8 for guix-patches@gnu.org; Thu, 16 Mar 2023 12:11:52 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4PcshQ08gBz9sWs for ; Thu, 16 Mar 2023 17:11:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1678983094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QrG4wVVFrFINzuH3Xa9oPZjQ8k+9NS4olBxZ42o9SI0=; b=KJzf6n3/RkB6IhOzMQV6Q1KlgMFcEhiPk5LKWztEl7fJlcyrzp2kjKrpfZQNm+VToJRJHp c41xQYFD2WKII0wSz5QRsHgPpnChiA+7w1TJATrAIFa8L7MztI9oILt2UmE3dxU/+Q2HRI 7voWvaSWgHQ33Bl7vU60uWlUM/yVihhDo90XWBjIMxW48BzIof56T0Q/uTK/VFNUFG1OH2 Fr3NOkasqGb5bThXJrt5ZoNe6aWdg2vjHkkY2+E4aTupMlNf8kMVov04jXLT3MweXwJ5on 51Li3nb9N5b6jRYqH7lw1cdzyj9f6QYxgiYh59+Ql5en5oQMLiaGG6cyU2mmKA== From: Antero Mejr To: guix-patches@gnu.org Subject: [PATCH] ui: format 'display-hint' output when no arguments are passed. Date: Thu, 16 Mar 2023 16:11:20 +0000 Message-Id: <20230316161120.9294-1-antero@mailbox.org> MIME-Version: 1.0 X-Debbugs-Cc: zimon.toutoune@gmail.com X-Debbugs-Cc: dev@jpoiret.xyz X-Debbugs-Cc: mail@cbaines.net X-Debbugs-Cc: rekado@elephly.net X-Debbugs-Cc: othacehe@gnu.org X-Debbugs-Cc: me@tobias.gr X-Debbugs-Cc: ludo@gnu.org Content-Transfer-Encoding: 8bit X-MBO-RS-ID: 60a82df04c0bf2fdfbe X-MBO-RS-META: iw93staomtw7gcscs8p6yrtyg6qqaap9 Received-SPF: pass client-ip=80.241.56.171; envelope-from=antero@mailbox.org; helo=mout-p-201.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When display-hint is given format specifiers such as "~%" but no arguments, it does not format the output, causing the specifiers to be visible in the displayed text. * guix/ui.scm (display-hint): Format output when no arguments are passed. --- Steps to reproduce the issue this fixes: $ guix build -s whatever hello guix build: error: 'whatever' is not a supported system hint: Try `--list-systems' to view available system types.~% guix/ui.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/ui.scm b/guix/ui.scm index b6c3bd04ba..7540e2194f 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -323,7 +323,7 @@ (define colorize ;; XXX: We should arrange so that the initial indent is wider. (parameterize ((%text-width (max 15 (- (terminal-columns) 5)))) (texi->plain-text (match arguments - (() message) + (() (format #f message)) (_ (apply format #f message (map (match-lambda ((? string? str) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 17:08:21 2023 Received: (at 62222-done) by debbugs.gnu.org; 17 Mar 2023 21:08:21 +0000 Received: from localhost ([127.0.0.1]:45770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdHJF-0006oy-Hm for submit@debbugs.gnu.org; Fri, 17 Mar 2023 17:08:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdHJE-0006ol-8Q for 62222-done@debbugs.gnu.org; Fri, 17 Mar 2023 17:08:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdHJ8-0001Oj-83; Fri, 17 Mar 2023 17:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/C53YWT0DqBF1fkviJJJRSAhEh84zsrE4nX+S0dagh4=; b=nLS8mMLM9ZBMSlATFuD+ XtGmQyOo9VVP+qThDhRWMheSbDJwfNueOcvRkQfg+wpaFxpgJOy6o+jGwijAy5iZGCATlTQMlduVc 1lte5m6wLMDramv6MG31Rc5ZyTx8fGkD1s0jHjsnd8j8I2snXnoqGWPM26WRkpiL0wZ0/eH8JwIuq EZ4izhenkQO4B8vnaUAaVAUehxT5BJm4Tj5I3BO9pnu6ASiTmhLijhaMfM2pT/7pI/Lvr8KSy14Dj pwT/9efG/DgIC+kk4u6BmLw8euKtEw8cAEBUVQJxUwFXOnHQM14XxWdDqT+jB67SVhHx5F0YSkmKQ H5dsN/7yIC5k4A==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdHJ7-00082l-EP; Fri, 17 Mar 2023 17:08:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Antero Mejr Subject: Re: [bug#62222] [PATCH] ui: format 'display-hint' output when no arguments are passed. References: <20230316161120.9294-1-antero@mailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?utf-8?Q?Vent=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Sylvie X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 17 Mar 2023 22:08:11 +0100 In-Reply-To: <20230316161120.9294-1-antero@mailbox.org> (Antero Mejr's message of "Thu, 16 Mar 2023 16:11:20 +0000") Message-ID: <87y1nvw0g4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62222-done Cc: 62222-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Antero Mejr skribis: > When display-hint is given format specifiers such as "~%" but no argument= s, > it does not format the output, causing the specifiers to be visible in the > displayed text. > > * guix/ui.scm (display-hint): Format output when no arguments are passed. Oops, good catch! Applied, thanks. Ludo=E2=80=99. From unknown Sat Aug 16 16:07:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 15 Apr 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator