GNU bug report logs - #62208
30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62208: closed (30.0.50; [PATCH] save-some-buffers repeatedly
 asks for saving abbrev file)
Date: Wed, 06 Sep 2023 01:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 5 Sep 2023 18:55:11 -0700
with message-id <CADwFkmmsq8cFan3CsCZajVpzw5THLgoQkN-ybUhXS9ANk6CE3A <at> mail.gmail.com>
and subject line Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file
has caused the debbugs.gnu.org bug report #62208,
regarding 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62208: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62208
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Filipp Gunbin <fgunbin <at> fastmail.fm>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving
 abbrev file
Date: Wed, 15 Mar 2023 20:42:31 +0300

- emacs -Q
- Define an abbrev using C-x a g
- C-x s, answer "yes"
- Repeat C-x s, it again asks to save abbrevs

This is a regression since 28.1.


diff --git a/lisp/abbrev.el b/lisp/abbrev.el
index ef8ef1ab5a6..1a665efb0a5 100644
--- a/lisp/abbrev.el
+++ b/lisp/abbrev.el
@@ -1250,17 +1250,17 @@ abbrev--possibly-save
     ;; asked to.
     (and save-abbrevs
          abbrevs-changed
-         (progn
-	   (if (or arg
-		   (eq save-abbrevs 'silently)
-		   (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name)))
-	       (progn
-                 (write-abbrev-file nil)
-                 nil)
-	     ;; Don't keep bothering user if they say no.
-	     (setq abbrevs-changed nil)
-             ;; Inhibit message in `save-some-buffers'.
-	     t)))))
+         (prog1
+	     (if (or arg
+		     (eq save-abbrevs 'silently)
+		     (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name)))
+	         (progn
+                   (write-abbrev-file nil)
+                   nil)
+               ;; Inhibit message in `save-some-buffers'.
+	       t)
+           ;; Don't ask again whether saved or user said no.
+           (setq abbrevs-changed nil)))))
 
 (add-hook 'save-some-buffers-functions #'abbrev--possibly-save)



In GNU Emacs 30.0.50 (build 3, x86_64-apple-darwin20.6.0, NS
 appkit-2202.70 Version 11.7 (Build 20G817)) of 2023-03-15 built on
 fgunbin.local
Repository revision: 67a660eb13818a620b301775065c4819a2178428
Repository branch: master
System Description:  macOS 11.7

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Filipp Gunbin <fgunbin <at> fastmail.fm>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 62208-done <at> debbugs.gnu.org
Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for
 saving abbrev file
Date: Tue, 5 Sep 2023 18:55:11 -0700

Filipp Gunbin <fgunbin <at> fastmail.fm> writes:

> fixed 62208 29.1
> quit
>
> On 16/03/2023 22:10 +0200, Eli Zaretskii wrote:
>
>>> From: Filipp Gunbin <fgunbin <at> fastmail.fm>
>>> Cc: bug-gnu-emacs <at> gnu.org
>>> Date: Thu, 16 Mar 2023 22:14:01 +0300
>>>
>>> On 16/03/2023 07:12 +0200, Eli Zaretskii wrote:
>>>
>>> > Also, would it be possible to add a test for this issue?
>>>
>>> Now added test, full patch is below.
>>>
>>> If/when it's fine, where should I install this?
>>
>> Thanks, please install on the emacs-29 branch.
>
> Installed and closing this bug, thanks.

This seems ho have accidentally been left open, so I'm closing it now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.