GNU bug report logs - #62208
30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file

Previous Next

Full log

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Filipp Gunbin <fgunbin <at> fastmail.fm>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks
 for saving abbrev file
Date: Thu, 16 Mar 2023 17:48:07 +0300

On 16/03/2023 07:12 +0200, Eli Zaretskii wrote:

>> From: Filipp Gunbin <fgunbin <at> fastmail.fm>
>> Date: Wed, 15 Mar 2023 20:42:31 +0300
>> 
>> 
>> - emacs -Q
>> - Define an abbrev using C-x a g
>> - C-x s, answer "yes"
>> - Repeat C-x s, it again asks to save abbrevs
>> 
>> This is a regression since 28.1.
>
> Thanks, but do you happen to know which change introduced this
> regression?  If so, can you point to that change?

It was in 1cfb89dc79b76923c1c93cb44e3e4836b6a8c2bf, here's the previous code:

-          (and save-abbrevs abbrevs-changed
-	       (progn
-	         (if (or arg
-		         (eq save-abbrevs 'silently)
-		         (y-or-n-p (format "Save abbrevs in %s? "
-                                           abbrev-file-name)))
-		     (write-abbrev-file nil))
-	         ;; Don't keep bothering user if he says no.
-	         (setq abbrevs-changed nil)
-	         (setq abbrevs-done t)))

Note (setq abbrevs-changed nil) is outside of if.

> Also, would it be possible to add a test for this issue?

Yeah, I'll try to.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.