From unknown Fri Jun 20 07:11:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62208 <62208@debbugs.gnu.org> To: bug#62208 <62208@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file Reply-To: bug#62208 <62208@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:48 +0000 retitle 62208 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving= abbrev file reassign 62208 emacs submitter 62208 Filipp Gunbin severity 62208 normal tag 62208 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 13:42:45 2023 Received: (at submit) by debbugs.gnu.org; 15 Mar 2023 17:42:45 +0000 Received: from localhost ([127.0.0.1]:40507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcV9B-0004T7-8s for submit@debbugs.gnu.org; Wed, 15 Mar 2023 13:42:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:42088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcV99-0004Sz-KK for submit@debbugs.gnu.org; Wed, 15 Mar 2023 13:42:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcV96-0001kV-S7 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:42:42 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcV94-0000QB-R0 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:42:40 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A0849320092E for ; Wed, 15 Mar 2023 13:42:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 15 Mar 2023 13:42:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1678902155; x=1678988555; bh=n8D0LhuDSPBxTwLmtRZdSLkcD RjXq4pWgBrJgwKCyhA=; b=hKn+QSB05kPN+v7D9SDYb4d9F/ScslfLtYYVetxTC oOc+4cnjkUF5QOyOS/aWsHZHH+EAyQM51swpnk0F6l+nFokEBD7Wjj2BXeF8ip3P F60yITCzXfrwC+sFQVxmVFVLZIPqFNnAoVgCAtyafO4SLJa1OFAX9mdoEOkfFCb2 LjTva4FQF1SlO286mVvmqlTMIxyvkISCIe4t3MGBQRnSRLPZNQx00hXBbDq2ip5t onnL5P80KJTIJNBzsDJzSXaaaQwWnxcoWNnscw1xSfwuM2Bo4Ph95eNH0LwlkqIA iOXw3kxhxFWYTYBW3EswhJQJUfTBiQ4FV7+5R0tJsdMUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678902155; x=1678988555; bh=n8D0LhuDSPBxTwLmtRZdSLkcDRjXq4pWgBr JgwKCyhA=; b=TWLXy0L5jMu7BjjEfJJk06Mjm6Bw2jNvGeQH4UDyekDKfzjMOUZ kt1copTKZJGhowbJ/Lbpwg87HuRGshQWccACsLQTrxHu+9eFryg83QMZdGKkxOiv ivdlkx7KIkRpTOFznPjBLVJA1/XFRbU8IhToFoxA7OyGlpU0qIuGgj/Fsmw7ACJF 8uivyIFoULQ6L/BSbkt2+2OEb65dAMx68rkilDquq9fxeVM6un7eoxQVM7kPk9YU xlnELbS9MytkqF2e3Hwv4H9S/xuhrVYaA7yNZ1Ml446T0dwKildnyFBgIfExpQEv WfhVmc47g+jjYTGx1SOVIBF3pmFe8EZP/Pw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvkedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehttdertd dtredtnecuhfhrohhmpefhihhlihhpphcuifhunhgsihhnuceofhhguhhnsghinhesfhgr shhtmhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepteekgffgjedujeekveehudetff duffejuedtveevfeeuvefgieeiueeuleekuddunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 15 Mar 2023 13:42:34 -0400 (EDT) From: Filipp Gunbin To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file User-Agent: Gnus/5.13 (Gnus v5.13) Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Wed, 15 Mar 2023 20:42:31 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.24; envelope-from=fgunbin@fastmail.fm; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) - emacs -Q - Define an abbrev using C-x a g - C-x s, answer "yes" - Repeat C-x s, it again asks to save abbrevs This is a regression since 28.1. diff --git a/lisp/abbrev.el b/lisp/abbrev.el index ef8ef1ab5a6..1a665efb0a5 100644 --- a/lisp/abbrev.el +++ b/lisp/abbrev.el @@ -1250,17 +1250,17 @@ abbrev--possibly-save ;; asked to. (and save-abbrevs abbrevs-changed - (progn - (if (or arg - (eq save-abbrevs 'silently) - (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name))) - (progn - (write-abbrev-file nil) - nil) - ;; Don't keep bothering user if they say no. - (setq abbrevs-changed nil) - ;; Inhibit message in `save-some-buffers'. - t))))) + (prog1 + (if (or arg + (eq save-abbrevs 'silently) + (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name))) + (progn + (write-abbrev-file nil) + nil) + ;; Inhibit message in `save-some-buffers'. + t) + ;; Don't ask again whether saved or user said no. + (setq abbrevs-changed nil))))) (add-hook 'save-some-buffers-functions #'abbrev--possibly-save) In GNU Emacs 30.0.50 (build 3, x86_64-apple-darwin20.6.0, NS appkit-2202.70 Version 11.7 (Build 20G817)) of 2023-03-15 built on fgunbin.local Repository revision: 67a660eb13818a620b301775065c4819a2178428 Repository branch: master System Description: macOS 11.7 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 15 14:13:09 2023 Received: (at submit) by debbugs.gnu.org; 15 Mar 2023 18:13:09 +0000 Received: from localhost ([127.0.0.1]:40551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcVcb-0005Jl-3u for submit@debbugs.gnu.org; Wed, 15 Mar 2023 14:13:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:33754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcVcZ-0005Je-6t for submit@debbugs.gnu.org; Wed, 15 Mar 2023 14:13:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcVcY-0005up-Fa for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 14:13:06 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcVcW-0006cc-El for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 14:13:06 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B1C075C0121 for ; Wed, 15 Mar 2023 14:13:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 15 Mar 2023 14:13:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678903983; x=1678990383; bh=jN BMNjOU1Ukc7E0rb7geCzcA39lLVYmChxrEYRU3Ot4=; b=ik/YgaxQDjorOgaM/m 3T9cFZWK84Di8qKzknEoonghcMhY9crns61McSziEUOlIwqekU63rSkW/7OufXeF S+zujEukiQg73TV+qDbWoQcNB4WdIZY457Gaf+yeRVkIOGRs9nwrjOx/h9BsPSuZ J2Y3AKmnoA8pnbhOB9xabrfC5Ab/1Fsnk1+0HCYO7Fi52ifBqfqqueNYMcoj7VO2 IKHK6lIx3IfK6i0QIbJSyUKSGr5PPlbwo3RKsTDBFpcJm/zyI02+5tjk6WKQopJx Es0iGjNreSbH+tCKRsrlWoZ0juLwJH5BMres96TMM9uUmP9FjmNU6yLlfON5KrTA iW3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678903983; x=1678990383; bh=jNBMNjOU1Ukc7 E0rb7geCzcA39lLVYmChxrEYRU3Ot4=; b=emmGYLLjsjm8Jbz8/sFWvCb642U71 I75RhsQgXjcDn2ybyLduBU+oaVgYnHVgGP5NYPNh2VcDt4Z4ubCtFO4uApoJTYMG tWvEU0ZGVEgxG3wSSs2dQjOa/YNKTuoEbEy2JqrvKOyRhY6cEg1KLmnescW75wG+ A7V27IrhGejoK8B6/Y5YSk8xVMrQsltFW1OmKl8OP/WpGUHGHo1njZYbo06/m8Je AsltMTG6tzJPROBV6cJGkCT+eu0ynGSenHuK/iDxuxLqSH/2shzts1O6EsPAWr55 fcl3eYH7xipNaphxJnHix7htjQisgFEhsx3qZKy5HDFXfnUKlR3ho8APg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvkedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehttd ertddtredtnecuhfhrohhmpefhihhlihhpphcuifhunhgsihhnuceofhhguhhnsghinhes fhgrshhtmhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepvdevkeffvdeuvefhuddtje ehkedvueefveettddtveduudfgieffieevieevhfdtnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrd hfmh X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 15 Mar 2023 14:13:03 -0400 (EDT) From: Filipp Gunbin To: bug-gnu-emacs@gnu.org Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file In-Reply-To: (Filipp Gunbin's message of "Wed, 15 Mar 2023 20:42:31 +0300") References: User-Agent: Gnus/5.13 (Gnus v5.13) Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Wed, 15 Mar 2023 21:12:59 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.26; envelope-from=fgunbin@fastmail.fm; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 15/03/2023 20:42 +0300, Filipp Gunbin wrote: > This is a regression since 28.1. Sorry, since 28.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 01:12:46 2023 Received: (at submit) by debbugs.gnu.org; 16 Mar 2023 05:12:46 +0000 Received: from localhost ([127.0.0.1]:41004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcfuw-0006lD-As for submit@debbugs.gnu.org; Thu, 16 Mar 2023 01:12:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:42824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcfuu-0006l5-Em for submit@debbugs.gnu.org; Thu, 16 Mar 2023 01:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcfuu-0005RN-3D for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 01:12:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcfut-0000Ei-JY; Thu, 16 Mar 2023 01:12:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hl+uGKbCD+Hew/1twZiU/bqb/0cWdfOPW+K+/W1yC8Y=; b=C0fHePNF++HG fxfn7u2lX9dIo/Y1k6oaGr4zBSVC2O7sgbi8j7mcNgnjJkeyxv4oiwQRs0aOkj1nHBcJmImksgPS9 Pj1V8TupjjmegsYqJnBpSv5L0EoR0ENwXdhmLGcqBbsaYn8zIEvzo/a3KwEPFm3Gx9olyFNkkkO/k 38XByg3yov83Os2lRk16nqjR9CwlVAwIxz7dhQi+uV1SlDsQr1JXMe0gqeicdDmtVHMkXm9h16DD3 Jsot5y/TVCAN12a6zkclKp4JqhY7E3dk1K1gQZkzSbfPYBsPb05QOi/DMMmjN8s8maPKl9B22pa/+ UlAo92QNeSuoxwwaVXHP+w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcfus-0006rJ-Pw; Thu, 16 Mar 2023 01:12:43 -0400 Date: Thu, 16 Mar 2023 07:12:41 +0200 Message-Id: <83o7otqnxy.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-Reply-To: (message from Filipp Gunbin on Wed, 15 Mar 2023 20:42:31 +0300) Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Filipp Gunbin > Date: Wed, 15 Mar 2023 20:42:31 +0300 > > > - emacs -Q > - Define an abbrev using C-x a g > - C-x s, answer "yes" > - Repeat C-x s, it again asks to save abbrevs > > This is a regression since 28.1. Thanks, but do you happen to know which change introduced this regression? If so, can you point to that change? Also, would it be possible to add a test for this issue? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 10:48:18 2023 Received: (at submit) by debbugs.gnu.org; 16 Mar 2023 14:48:19 +0000 Received: from localhost ([127.0.0.1]:42716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcotu-000297-At for submit@debbugs.gnu.org; Thu, 16 Mar 2023 10:48:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:36334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcots-00028n-3m for submit@debbugs.gnu.org; Thu, 16 Mar 2023 10:48:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcotr-0002OU-MC for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 10:48:15 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcotp-00011h-Tr; Thu, 16 Mar 2023 10:48:15 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A25F55C0114; Thu, 16 Mar 2023 10:48:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 16 Mar 2023 10:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678978091; x=1679064491; bh=/b rXulQmM6cdvtgXzMvD+MWIvIMZrPMA136c2iarEn8=; b=saRlg73dT61DQSM0BB FXZpAccXxT0DE5KzjegRCYx0X63F/O3g3ffS+rZtDqGAf9eiEyIFzjmAJVEkphcU LWHjr+IIwYpQhVEQk1s7ULRwhHAnhFQiE/iaubYBVofaWsZCoQWKp3RYXiq9RVdb AfZdolLDzkrKn60et03D5OFBr/JUKsQDgFjowQ4DaZisfFq+Yj2u4Fs4rx6YdvtR gmh5l6YkrVJzXUrEd8i7PAt0yakkYr54Lxr6KeNKqA+z6RHSsys2MEL3cGlINAf3 psrTz0TDSoKcWJS+PK2xOLRe8KkyCmy8vyq5YdybPCzl/jJAgmCUftfCWaRA63D6 9vGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678978091; x=1679064491; bh=/brXulQmM6cdv tgXzMvD+MWIvIMZrPMA136c2iarEn8=; b=iKIIs3cDjiivUe0+OzK7FdgorkKy1 DIzExjCRnuRhvv1KrAGpvERq46upzj7b0ZM0noh61qVqewFfZc/vLeBG+pvw13fP X9CfoUZeyyfqF6Hc1X8d/wJv2vX1BpwdnqSbmTPVHPVFKi+RXE4M+ZWF9zSseMDw IgMomMXE5bCTA93xfIdbx/d7Pcfd01J7YLihxWthNKacKnC0xPAVAjk7Gb3S25Mo 76iuNdjKszVu0c2jMWTzwdEmdFfrGMaa/rLwN/JanFae2bRvL0UmbkwEWhRExzlF 7QWCRW22lebgc9v2yck1NGmLEC51jWcs/YcnbLGX39z9VenZ5dP8eLTQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdtredttdertdenucfhrhhomhephfhilhhi phhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghsthhmrghilhdrfhhmqeenucggtf frrghtthgvrhhnpeffhfejveeiieeiudetgfehffelieevfeeffedtkeelheeludefueeu udehveeiffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehfghhunhgsihhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 10:48:10 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file In-Reply-To: <83o7otqnxy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 07:12:41 +0200") References: <83o7otqnxy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Mail-Followup-To: Eli Zaretskii , bug-gnu-emacs@gnu.org Date: Thu, 16 Mar 2023 17:48:07 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.29; envelope-from=fgunbin@fastmail.fm; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 16/03/2023 07:12 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Date: Wed, 15 Mar 2023 20:42:31 +0300 >> >> >> - emacs -Q >> - Define an abbrev using C-x a g >> - C-x s, answer "yes" >> - Repeat C-x s, it again asks to save abbrevs >> >> This is a regression since 28.1. > > Thanks, but do you happen to know which change introduced this > regression? If so, can you point to that change? It was in 1cfb89dc79b76923c1c93cb44e3e4836b6a8c2bf, here's the previous code: - (and save-abbrevs abbrevs-changed - (progn - (if (or arg - (eq save-abbrevs 'silently) - (y-or-n-p (format "Save abbrevs in %s? " - abbrev-file-name))) - (write-abbrev-file nil)) - ;; Don't keep bothering user if he says no. - (setq abbrevs-changed nil) - (setq abbrevs-done t))) Note (setq abbrevs-changed nil) is outside of if. > Also, would it be possible to add a test for this issue? Yeah, I'll try to. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 15:14:13 2023 Received: (at submit) by debbugs.gnu.org; 16 Mar 2023 19:14:13 +0000 Received: from localhost ([127.0.0.1]:43096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pct3E-0001I0-US for submit@debbugs.gnu.org; Thu, 16 Mar 2023 15:14:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:57216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pct3D-0001Ht-HB for submit@debbugs.gnu.org; Thu, 16 Mar 2023 15:14:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pct3D-00021d-AJ for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 15:14:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pct3B-0001XM-HW; Thu, 16 Mar 2023 15:14:11 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 907775C0197; Thu, 16 Mar 2023 15:14:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 16 Mar 2023 15:14:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678994046; x=1679080446; bh=Wc +4o7gtao24cxc15/8r5xAM86W0xKA/ApTknUcmLgo=; b=ya2l8EE+jL14JHYv2Q /A8VvCbQ7N1BhzCyl12r0Ed9ZXrkwnOeOMFu2pMmIjwNqSSP2mTou4g+QLk+E7bX S0f1vLu0LeaoZwYOXKKEyxM1JFO/V/WWJA4UqgNfsld/XvgbTaX/Pny0QW0ToVDI G/sjBewuhYsM678CsdvXZz2UQtm9rFGvcJalxOw65EK1ILGHE7BmSztyI5mRs6GI Ckt5hLL4mJp4BediXkoTo/i+fSMeI1CjfJ5dLCoWX9khctr4R/GiyrOO/Vvap+qg GM3jPFqz+i6HILtC+21JARpspMpLElfLzKChpEBmCnzHZ6Q77L+d5DbMVnU2/4Ih 2u1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678994046; x=1679080446; bh=Wc+4o7gtao24c xc15/8r5xAM86W0xKA/ApTknUcmLgo=; b=lx4aWljmU+2lv91Uc8lF2Er0lY7DG jFkjGIgx+g2awR0W53dWdEERFZWoJVjf8Jw5T57ERzPqI61GGy+fKFOajIyj9bFF XDG8Zfxow9XtQGjARXUExiFSaYdbei3IRUuFLysZMj4bz1cFZoimXekeGnNNuTQK v4xhG6/DcQzMPK7hI2zh6kd+e3isGBMWkInFEG8ajY5KMoaCNiExVkO/WpbVS+yz 1Vla2WHylwEdg7lNIvgkVwUYAo1tkTbBVN8fkUxSsneub1WqIgGnDay1eCPg7b56 du2BZB9+GRmjvNwy9PohOnZZ6nxu1oyPSWKoHMyjcjpUbApZhasFc5P+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhl ihhpphcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecugg ftrfgrthhtvghrnhepfffhjeevieeiiedutefgheffleeiveeffeeftdekleehledufeeu ueduheevieffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 15:14:05 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file In-Reply-To: <83o7otqnxy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 07:12:41 +0200") References: <83o7otqnxy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Mail-Followup-To: Eli Zaretskii , bug-gnu-emacs@gnu.org Date: Thu, 16 Mar 2023 22:14:01 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.25; envelope-from=fgunbin@fastmail.fm; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 16/03/2023 07:12 +0200, Eli Zaretskii wrote: > Also, would it be possible to add a test for this issue? Now added test, full patch is below. If/when it's fine, where should I install this? Thanks. diff --git a/lisp/abbrev.el b/lisp/abbrev.el index ef8ef1ab5a6..1a665efb0a5 100644 --- a/lisp/abbrev.el +++ b/lisp/abbrev.el @@ -1250,17 +1250,17 @@ abbrev--possibly-save ;; asked to. (and save-abbrevs abbrevs-changed - (progn - (if (or arg - (eq save-abbrevs 'silently) - (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name))) - (progn - (write-abbrev-file nil) - nil) - ;; Don't keep bothering user if they say no. - (setq abbrevs-changed nil) - ;; Inhibit message in `save-some-buffers'. - t))))) + (prog1 + (if (or arg + (eq save-abbrevs 'silently) + (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name))) + (progn + (write-abbrev-file nil) + nil) + ;; Inhibit message in `save-some-buffers'. + t) + ;; Don't ask again whether saved or user said no. + (setq abbrevs-changed nil))))) (add-hook 'save-some-buffers-functions #'abbrev--possibly-save) diff --git a/test/lisp/abbrev-tests.el b/test/lisp/abbrev-tests.el index ecca21df4bc..79ec51ba4d0 100644 --- a/test/lisp/abbrev-tests.el +++ b/test/lisp/abbrev-tests.el @@ -305,6 +305,22 @@ test-abbrev-table-p (should-not (abbrev-table-p translation-table-vector)) (should (abbrev-table-p (make-abbrev-table)))) +(ert-deftest abbrev--possibly-save-test () + "Test that `abbrev--possibly-save' propertly resets +`abbrevs-changed'." + (ert-with-temp-file temp-test-file + (let ((abbrev-file-name temp-test-file) + (save-abbrevs t)) + ;; Save + (let ((abbrevs-changed t)) + (should-not (abbrev--possibly-save nil t)) + (should-not abbrevs-changed)) + ;; Don't save + (let ((abbrevs-changed t)) + (ert-simulate-keys '(?n) + (should (abbrev--possibly-save nil))) + (should-not abbrevs-changed))))) + (provide 'abbrev-tests) ;;; abbrev-tests.el ends here From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 16:11:07 2023 Received: (at submit) by debbugs.gnu.org; 16 Mar 2023 20:11:07 +0000 Received: from localhost ([127.0.0.1]:43148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pctwJ-0002iM-0F for submit@debbugs.gnu.org; Thu, 16 Mar 2023 16:11:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:38676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pctwH-0002iE-8m for submit@debbugs.gnu.org; Thu, 16 Mar 2023 16:11:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pctwH-0008FC-0Z for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 16:11:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pctwG-0001c8-OT; Thu, 16 Mar 2023 16:11:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VYbM1UMoIDUdMoFihGxS15dAYP0MGKdYxW81xhHPIRg=; b=c/VFNHyKkRdd HFrj1/O08HTO4EhPkdjnAFSycjhLWv6HheJkR2r30P1MgpO50ejITO55i78SUQjEl5D9IUzYfDVjy N5nFrzRL02zSHfhQA+6e/QYZy9uBrk3h+Fc3Mhl0unaWjY+/ZuK4CTUNp1SPcKR1JcQ/Yecrj8BnU PpO6m60clQ3251Bl6bl9Tjsilf1rVPKh3U7+xPFf9wD/y01oCCbZg6iE9dCteyPFuiWtvyQnAKXcH yjFjpbN6l/UjABlkcqYXFcr1+8em+mxkgbZq+IUdQ9EjLZdhiCkWJ8+YDWsjM2lRwsTj153ZjJGh+ YL6uXgGs5LvMko2Ds9uyaw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pctwE-0006PE-FE; Thu, 16 Mar 2023 16:11:04 -0400 Date: Thu, 16 Mar 2023 22:10:48 +0200 Message-Id: <83ttykpid3.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-Reply-To: (message from Filipp Gunbin on Thu, 16 Mar 2023 22:14:01 +0300) Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file References: <83o7otqnxy.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Filipp Gunbin > Cc: bug-gnu-emacs@gnu.org > Date: Thu, 16 Mar 2023 22:14:01 +0300 > > On 16/03/2023 07:12 +0200, Eli Zaretskii wrote: > > > Also, would it be possible to add a test for this issue? > > Now added test, full patch is below. > > If/when it's fine, where should I install this? Thanks, please install on the emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 10:18:20 2023 Received: (at 62208) by debbugs.gnu.org; 17 Mar 2023 14:18:21 +0000 Received: from localhost ([127.0.0.1]:45354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdAuS-0007ra-Hs for submit@debbugs.gnu.org; Fri, 17 Mar 2023 10:18:20 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:40095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdAuQ-0007rI-Ou; Fri, 17 Mar 2023 10:18:19 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D8D13320030E; Fri, 17 Mar 2023 10:18:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 17 Mar 2023 10:18:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679062692; x=1679149092; bh=m1 AeSJYjipS/W/r7TB92iVCeSOydLfFqWNgFVczXPoE=; b=EYSI/q/BTmEgZXxmsa /aqu7st6mge/qgBJ5kPe/oqS0XxrRhOn5kOTGjKkmAr+zMx64rdJ7m5g0MIvCTnk JKamS+XQUYZEqUJYTF74wjSz4UpzhZ4r3W91STF9kFih9Of3XbtVLEU39/3mveFM z9rsxbtISGAsdGWVkQ6XWVgvSYFaE6245sGn/DexH5KPJEcO5matiu2yGt4C3FsB 36DuqJ4wb40T4g5ykWNQBb7v97NfSI1O8iOnyZOLO5Cwj8OFm3UsOqVoK3T7AKCR C8Rwa45mLZ3Drwed5lewQ/5BFtGTHBb7R5lSWd0WS8feFFTWpfEjLCyeniCeHWol ojhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679062692; x=1679149092; bh=m1AeSJYjipS/W /r7TB92iVCeSOydLfFqWNgFVczXPoE=; b=snEyBkc8p4h+OK/x3dDjuRuPActBT 38+INcGBDYrcDwoVsJ6T3O/CZUFwbecYzDXrU2+7DMUfNG2UvKO/ptKk86gflKS4 VC6ydVYVhUAb+/9xdQLFEvICv7iiHFFkFpo2uVBF9mr/USJyODwe08gqYnBWm+KB TDoIDapzXgrdOy1CaacT1BOeUyIOBiZWzWaM1hbkCW2+Mqx7AzzVDylwAsCTuG75 EBqB0P/0kLIhMkCB8zbv748DgI82yFVR9FA470HvGsudN0NYStF5TWvUytL/RH3X RJv3/S6NST5lMJZH8xBSv4R+wF/I3ahu/E7X9uxHcfR+IEY9A97WaoDbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefvddgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdtredttdertdenucfhrhhomhephfhilhhi phhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghsthhmrghilhdrfhhmqeenucggtf frrghtthgvrhhnpeffhfejveeiieeiudetgfehffelieevfeeffedtkeelheeludefueeu udehveeiffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehfghhunhgsihhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Mar 2023 10:18:11 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file In-Reply-To: <83ttykpid3.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 22:10:48 +0200") References: <83o7otqnxy.fsf@gnu.org> <83ttykpid3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Fri, 17 Mar 2023 17:18:08 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62208 Cc: 62208@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) fixed 62208 29.1 quit On 16/03/2023 22:10 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: bug-gnu-emacs@gnu.org >> Date: Thu, 16 Mar 2023 22:14:01 +0300 >> >> On 16/03/2023 07:12 +0200, Eli Zaretskii wrote: >> >> > Also, would it be possible to add a test for this issue? >> >> Now added test, full patch is below. >> >> If/when it's fine, where should I install this? > > Thanks, please install on the emacs-29 branch. Installed and closing this bug, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 21:55:27 2023 Received: (at 62208-done) by debbugs.gnu.org; 6 Sep 2023 01:55:27 +0000 Received: from localhost ([127.0.0.1]:60234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdhlM-0005yj-8d for submit@debbugs.gnu.org; Tue, 05 Sep 2023 21:55:27 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:61950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdhlH-0005yR-BT for 62208-done@debbugs.gnu.org; Tue, 05 Sep 2023 21:55:23 -0400 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5007616b756so5468392e87.3 for <62208-done@debbugs.gnu.org>; Tue, 05 Sep 2023 18:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693965312; x=1694570112; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yHj69TDhavP9hXc2pvffiljnXd0K6uyH5rUqy04UT4Y=; b=f/dfZJJ3zSAUVkY9jJ0pmhm+mRRut8AycqkdNfG0kwdybAkNTvmymGe2hT+hSG4inZ ++PITmRc8Y2oY0nnCLPEwBuxSvpy2YLcPUQxI03mJYuuy765KubvACvslt1pSI/EtW6z EKpejThTS48F2Irm2beGtYK/io7+D3geFkLgRe3vkJj1sUYYiHd4Bl8B+M5ZWuYtB528 ExbSnhZFBmPxSto7cXNuNI8taYqvKOUp/L8WzEP+CCGBX4QsLmRL9Fzvxd7G5cb5bCKE WgUUV7PsfBwqpFLbsIT2BCs+l8j3EMyJh30syNRHiZnjhKFvJReOF6VK9V61zvJRK2Dd ezhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693965312; x=1694570112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yHj69TDhavP9hXc2pvffiljnXd0K6uyH5rUqy04UT4Y=; b=lrj0zsyKQFOxgLrIcouBec1XNIaliBphwALgys7O94SmjE0NoeoxqNX+5qmpUBp4uE /7tSz+MlQ3YQfWMkmrc7IPOR46bvNBDA0Xm+eHGrcKuO6AtKpTo/S1D2iDKJ5wqwoC9H kxn2bzhw3R5AYQ/KLfS68npErc6+3rIV+5qorU9zvbEJOMUuo3epenFbsCDduyBRji43 thyx9zKx/742BeYR1pvnIZO8FGBVUjO6pslQe5Hd84QKjc1z1vF6lneGvmI3pYTKF0pU Lbnnol0LQxeQB1+xex2yUTX9LmlRthnHfdonlWAGKvYupLcBYcTISlA/iO3ORYICN1pL BKjQ== X-Gm-Message-State: AOJu0YydBEFA8iitIyfgkvoR2bZBKMUx3e/Pks0EwGEZV3X4dfzeB1p0 f79m/4qDBb5TxN3FG0y37brIUKI369uSQEtVJNQ= X-Google-Smtp-Source: AGHT+IH+AluP4qv9DSYP2HKRe3nZreaYUa0oejsbpk410zNZ7jdn4bHXzs6/EwKRRVgo+vS8Ll8H5ByHDwpchGqm9NE= X-Received: by 2002:a19:3852:0:b0:500:ac0b:8d52 with SMTP id d18-20020a193852000000b00500ac0b8d52mr1095103lfj.7.1693965312305; Tue, 05 Sep 2023 18:55:12 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 18:55:11 -0700 From: Stefan Kangas In-Reply-To: (Filipp Gunbin's message of "Fri, 17 Mar 2023 17:18:08 +0300") References: <83o7otqnxy.fsf@gnu.org> <83ttykpid3.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 5 Sep 2023 18:55:11 -0700 Message-ID: Subject: Re: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file To: Filipp Gunbin Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62208-done Cc: Eli Zaretskii , 62208-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > fixed 62208 29.1 > quit > > On 16/03/2023 22:10 +0200, Eli Zaretskii wrote: > >>> From: Filipp Gunbin >>> Cc: bug-gnu-emacs@gnu.org >>> Date: Thu, 16 Mar 2023 22:14:01 +0300 >>> >>> On 16/03/2023 07:12 +0200, Eli Zaretskii wrote: >>> >>> > Also, would it be possible to add a test for this issue? >>> >>> Now added test, full patch is below. >>> >>> If/when it's fine, where should I install this? >> >> Thanks, please install on the emacs-29 branch. > > Installed and closing this bug, thanks. This seems ho have accidentally been left open, so I'm closing it now. From unknown Fri Jun 20 07:11:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Oct 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator