GNU bug report logs - #62199
[PATCH] gnu: Add emacs-fdroid.

Previous Next

Full log

Message #29 received at 62199 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: conses <contact <at> conses.eu>
Cc: 62199 <at> debbugs.gnu.org, Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: Re: [bug#62199] [PATCH v3] gnu: Add emacs-fdroid.
Date: Tue, 21 Mar 2023 10:30:47 +0100

conses <contact <at> conses.eu> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fdroid): New variable.

> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'unpack 'patch-file-name
> +                     (lambda _
> +                       (emacs-substitute-variables "fdroid.el"
> +                         ("fdroid-program"
> +                          (string-append #$(this-package-input "fdroidcl")
> +                                         "/bin/fdroidcl"))))))))

Thanks.

I suggest to use `search-input-file' instead of of `this-package-input'
as it can find errors in the executable name at build time (e.g., if it
ever changes). It is also shorter.

Could you provide another update?

Otherwise, LGTM.

Regards,

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.