GNU bug report logs - #62199
[PATCH] gnu: Add emacs-fdroid.

Previous Next

Package: guix-patches;

Reported by: conses <contact <at> conses.eu>

Date: Wed, 15 Mar 2023 12:15:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: conses <contact <at> conses.eu>
Cc: 62199 <at> debbugs.gnu.org, Sergey Trofimov <sarg <at> sarg.org.ru>
Subject: [bug#62199] [PATCH v3] gnu: Add emacs-fdroid.
Date: Tue, 21 Mar 2023 10:30:47 +0100

conses <contact <at> conses.eu> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fdroid): New variable.

> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'unpack 'patch-file-name
> +                     (lambda _
> +                       (emacs-substitute-variables "fdroid.el"
> +                         ("fdroid-program"
> +                          (string-append #$(this-package-input "fdroidcl")
> +                                         "/bin/fdroidcl"))))))))

Thanks.

I suggest to use `search-input-file' instead of of `this-package-input'
as it can find errors in the executable name at build time (e.g., if it
ever changes). It is also shorter.

Could you provide another update?

Otherwise, LGTM.

Regards,
This bug report was last modified 1 year and 93 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.