GNU bug report logs - #62198
[PATCH] Eglot: Send clientInfo during the initialize request

Previous Next

Full log

Message #47 received at 62198 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62198 <at> debbugs.gnu.org, Felician Nemeth <felician.nemeth <at> gmail.com>,
 adonovan <at> google.com
Subject: Re: bug#62198: eglot feature request: set Initialize.ClientInfo.{Name, 
 Version}
Date: Thu, 3 Aug 2023 11:15:50 +0100

Sorry,

I think Felicián's patch looks good, and we should push it to master.

João

On Thu, Aug 3, 2023 at 8:39 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > Cc: 62198 <at> debbugs.gnu.org, Alan Donovan <adonovan <at> google.com>
> > From: Felician Nemeth <felician.nemeth <at> gmail.com>
> > Date: Sat, 15 Jul 2023 12:18:11 +0200
> >
> > >> If Eglot is installed, then it is byte-compiled as well.  The earlier
> > >> patch in this bug report made sure that the helper library ('lisp-mnt)
> > >> was required only at compile time.  However, the patch worked even if
> > >> Eglot was not installed with package.el (but Eglot still needed to be
> > >> byte-compiled).
> >
> > > I thinkt the lisp-mnt-at-compile-time solution is preferable, as I'm
> > > not sure 'eglot always lives in package-alist (sometimes it is a
> > > built-in and that is a royal pain).  Can you show an
> > > updated patch for it, when you have time, Felicián?
> >
> > I've attached the updated patch.
>
> Ping!  João, how should we proceed with this issue?
>
> Thanks.



-- 
João Távora

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.