GNU bug report logs - #62194
30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: miha <at> kamnitnik.top
Cc: Michael Albinus <michael.albinus <at> gmx.de>, 62194 <at> debbugs.gnu.org
Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29
Date: Thu, 16 Mar 2023 23:38:49 +0000

On Thu, Mar 16, 2023 at 9:57 PM João Távora <joaotavora <at> gmail.com> wrote:
>
>   On Thu, Mar 16, 2023 at 9:14 PM <miha <at> kamnitnik.top> wrote:
> >
> > João Távora <joaotavora <at> gmail.com> writes:
>
> > > +    (dolist (p (delq proc (process-list)))
> > > +      (when (tramp-file-name-equal-p v (process-get p 'vector))
> > > +     (while (accept-process-output p 0)))))
> >
> > I think that accept-process-output with JUST-THIS-ONE=nil is dangerous
> > here. We are now allowing 'file-exists-p', 'expand-file-name' and all
> > other functions listed in 'tramp-sh-file-name-handler-alist' to call any
> > timer or process filter,
>
> That's exactly what we want.  We _don't_ want to stop other
> output to be inhibited from going into the filter.

Doh, this is a silly double negative.  I meant "we don't want to
inhibit other output from going into the filters".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.