From unknown Sat Aug 16 16:55:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62177: [PATCH] [WIP] update node to version 16 Resent-From: "Dr. Arne Babenhauserheide" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Mar 2023 06:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62177 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: 62177@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167877397624860 (code B ref -1); Tue, 14 Mar 2023 06:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Mar 2023 06:06:16 +0000 Received: from localhost ([127.0.0.1]:36039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbxnZ-0006Sp-DQ for submit@debbugs.gnu.org; Tue, 14 Mar 2023 02:06:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:45384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbxnW-0006Sg-Mr for submit@debbugs.gnu.org; Tue, 14 Mar 2023 02:06:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbxnW-0000y4-7H for bug-guix@gnu.org; Tue, 14 Mar 2023 02:06:10 -0400 Received: from mout.web.de ([212.227.17.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbxnR-0005Pk-Gv for bug-guix@gnu.org; Tue, 14 Mar 2023 02:06:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1678773963; i=arne_bab@web.de; bh=oiz7CbU//C0u1IpJ97izfoT0imOAMoPxZY0UJ773zLc=; h=X-UI-Sender-Class:From:To:Subject:Date; b=kqwqVMcnYmFM8Yd5tewUgxpkGjMZtdJN/R61GAdpENy/sHD0S+ix0B4u4Xax0Zs70 VmaBtanIrsXFPVF+Xnm6YehiZ3ZTO0Wa4QcWyCUU2ahXgquy40nIsVYDGTVzzyaMLW 5FwzOjPTGPc1bv1T+53wzC2lbyXLUCtXH8LRFwR/Aj2CGqyS4IUe/SEgxQ9UrXArVo MJLTL3sjrDo2CMn23Hy8PaHl7wbEq4A7UVoLgYgv684L4REByGjdD3+q7WrUYFStYk Nj/0Xx7UV9PqfGyjNrLGxD0p5Rw4+I3qWpYvc1u99z+59/cWM3tbuFyQ3IRd6Qh+sz BzhQIbY4XMvSg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from fluss ([84.149.95.143]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MkEhH-1qMbDu0Z4b-00kOdc; Tue, 14 Mar 2023 07:06:03 +0100 User-agent: mu4e 1.8.13; emacs 28.2 From: "Dr. Arne Babenhauserheide" Date: Tue, 14 Mar 2023 07:02:14 +0100 Message-ID: <87h6unc1fb.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:ejIjE6lKSii51A9pVLkgsJst6WRay+mtfYeL6A1T/NzAxllfQZh uP/svToqksrhUMjWyjFnqyHTqmNNAdGlizbxcgocCPb03g1mGUDJwTSACBIS51JXjbFMuIp wDjWwImIPuGJ/n83XwaHDKzCEdK8qwQG05WZ5JaCoCp+CDyXvbTDfG9u9MKbL6ejA9tqmgv aMGs4LVArqpsPrjN7l7fw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3MXceFqEEGY=;VoQWs764RGimfxvC67eIKtjxrch fUN2ZtD3Y74t/TkvoCxIsoKaXrT6D0f53dzrq3XQ8d60D8odmNzpfgqA/jV+m9K6JNYVL20MR ywDlqahLi7BnLapHYuyIfy/Qju4viJDuqqMurir/Cmo3rq4CxX1uvQf/pRFmA25uuVzm0gjQP EIWK8umhlF5lXKxdwyUX56j5leSIoxXojSaSQqgCOl9QvQnE7YquSJw1D58J7GzCXZJ4MJ7ie W7Vj1mtO4Qbna44ULqHPH2OW8p+QmpfdsHm+cEC/CNMk3scX0UNvL705rC4nMsJLBWiHsyo+f Y3tMexKcKnGMHY6TtnPRhbgjwD/XvpGfYge0kTcC1tcOV4iDHxZv2zW9F2EWkAGFDsc0BPbA0 lRZiDaeG6rVPwFp4d35Z5RHrVw4ldT+FCfV9xQOwcMZdtLrCNJDyhfwb2P6J3KdSMeLF4qbYh TY/LQ8onEp/xvONaaAcbYGLY0BBwh1FfgCVinNrEDBWYtBAUS0Epq9/3zoNicPE3xYCGYvnUT SVTACF3W3TAIU099u+htVeMe1SirFMQaNDRFj84owlis6W6LY3GeZfEUmBHLZe8riA3qBaid5 tTTWA2nS4mIVMKs0J/vTfD607U1i/KQaJobrpPseq+iQT+LtoILLPlf/QWJ2osnDKIsoVbABt nJU0AGhAIeJMs2qV0O82qq7ojVFSq61+g13F6cxxlGTB6BTFBqtuekNhplJ//VFgvH1rGf06y 1FRd37xvRqBHLl4ksvFTPlb4stSKc5sGyQmu41M/6CeWyZtNsmRKWrumVFxBYA01RCKgClarO fxmQfNzOs9heORWbmBH9VsyJBIdTVPdEUvThEiVzrV+hDhYh9IdsUy++j9gz1FC8p8djEFwrI r6I9on6CfC/T40N2GDVUX2MDROh73IQX302b2uv7g1DaspD5sTzCHnUk3cjELcYpfENC9SIpQ lqBAmg== Received-SPF: pass client-ip=212.227.17.11; envelope-from=arne_bab@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, this is an initial stab at getting node to version 16. It is far from perfect, but I hope it gives someone a good starting point to move forward. The llhttp bootstrap fixes are currently commented out =E2=80=94 I=E2=80=99m not sure what these should be doing and= how they interact with node =E2=80=94 so this cannot be merged as is. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-WIP-try-to-update-node-to-16.19.0.patch Content-Transfer-Encoding: quoted-printable From=2014d58ab181c9087420a5f955d28d72cb086884fc Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Sat, 28 Jan 2023 20:45:16 +0100 Subject: [PATCH] WIP try to update node to 16.19.0 =2D-- gnu/packages/node.scm | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index be39f3b25a..34d13d849c 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -668,7 +668,7 @@ (define-public node-llparse-bootstrap (define-public llhttp-bootstrap (package (name "llhttp") =2D (version "2.1.4") + (version "8.1.0") (source (origin (method git-fetch) (uri (git-reference @@ -677,7 +677,7 @@ (define-public llhttp-bootstrap (file-name (git-file-name name version)) (sha256 (base32 =2D "115mwyds9655p76lhglxg2blc1ksgrix6zhigaxnc2q6syy3pa6x")) + "1cq3q3jybibppjhhiymdfmnqgbvn77j7b4ks7lil0lrc3vnnp87f")) (patches (search-patches "llhttp-bootstrap-CVE-2020-8287.pat= ch")) (modules '((guix build utils))) (snippet @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap (define-public node-lts (package (inherit node) =2D (version "14.19.3") + (version "16.19.0") (source (origin (method url-fetch) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.xz")) (sha256 (base32 =2D "15691j5zhiikyamiwwd7f282g6d9acfhq91nrwx54xya38gmpx2w")) + "01k72p0hp4lhlpz1syd9cbkm2gpfww0hn10xdpmzd4i3x8dfq7sg")) (modules '((guix build utils))) (snippet `(begin @@ -808,9 +808,12 @@ (define-public node-lts ;; FIXME: These tests fail in the build container, but they= don't ;; seem to be indicative of real problems in practice. (for-each delete-file =2D '("test/parallel/test-cluster-master-error.js" =2D "test/parallel/test-cluster-master-kill.js")) + '("test/parallel/test-cluster-primary-error.js" + "test/parallel/test-cluster-primary-kill.js")) =20 + ;; requires /bin/sh + (delete-file "test/parallel/test-stdin-from-file-spawn.js") +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 ;; These require a DNS resolver. (for-each delete-file '("test/parallel/test-dns.js" @@ -818,8 +821,7 @@ (define-public node-lts =20 ;; These tests require networking. (for-each delete-file =2D '("test/parallel/test-https-agent-unref-socket.= js" =2D "test/parallel/test-corepack-yarn-install.js"= )) + '("test/parallel/test-https-agent-unref-socket.js= ")) =20 ;; This test is timing-sensitive, and fails sporadically on ;; slow, busy, or even very fast machines. @@ -847,21 +849,21 @@ (define-public node-lts ;; TLS certificates that are bundled with the source. We w= ant this ;; package to be reproducible forever, so remove those. ;; TODO: Regenerate certs instead. =2D (for-each delete-file + (for-each (=CE=BB(x)(display x)(delete-file x)) '("test/parallel/test-tls-passphrase.js" "test/parallel/test-tls-server-verify.js")))) (add-after 'delete-problematic-tests 'replace-llhttp-sources =2D (lambda* (#:key inputs #:allow-other-keys) + (lambda* (#:key inputs #:allow-other-keys) #f)))))) ;; Replace pre-generated llhttp sources =2D (let ((llhttp (assoc-ref inputs "llhttp"))) =2D (copy-file (string-append llhttp "/src/llhttp.c") =2D "deps/llhttp/src/llhttp.c") =2D (copy-file (string-append llhttp "/src/api.c") =2D "deps/llhttp/src/api.c") =2D (copy-file (string-append llhttp "/src/http.c") =2D "deps/llhttp/src/http.c") =2D (copy-file (string-append llhttp "/include/llhttp.h") =2D "deps/llhttp/include/llhttp.h")))))))) + ;;(let ((llhttp (assoc-ref inputs "llhttp"))) + ;; (copy-file (string-append llhttp "/src/llhttp.c") + ;; "deps/llhttp/src/llhttp.c") + ;; (copy-file (string-append llhttp "/src/api.c") + ;; "deps/llhttp/src/api.c") + ;; (copy-file (string-append llhttp "/src/http.c") + ;; "deps/llhttp/src/http.c") + ;; (copy-file (string-append llhttp "/include/llhttp.h") + ;; "deps/llhttp/include/llhttp.h")))))))) (native-inputs (list ;; Runtime dependencies for binaries used as a bootstrap. c-ares-for-node =2D-=20 2.39.2 --=-=-= Content-Type: text/plain Updating llhttp also needs the CVE-2020-8287 patch to be removed (it is fixed upstream). --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-do-not-patch-llhttp-bootstrap-CVE-2020-8287-is-f.patch Content-Transfer-Encoding: quoted-printable From=204e9e7905a9a8792b164e96aa31e0dcf3945283d2 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Tue, 14 Mar 2023 06:48:38 +0100 Subject: [PATCH] gnu: do not patch llhttp-bootstrap: CVE-2020-8287 is fixed= in node 16 upstream. =2D-- gnu/local.mk | 1 - gnu/packages/node.scm | 1 - .../llhttp-bootstrap-CVE-2020-8287.patch | 100 ------------------ 3 files changed, 102 deletions(-) delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.pat= ch diff --git a/gnu/local.mk b/gnu/local.mk index 403c5f483e..0efa292322 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1492,7 +1492,6 @@ dist_patch_DATA =3D \ %D%/packages/patches/linuxdcpp-openssl-1.1.patch \ %D%/packages/patches/lirc-localstatedir.patch \ %D%/packages/patches/lirc-reproducible-build.patch \ =2D %D%/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch \ %D%/packages/patches/llvm-3.5-fix-clang-build-with-gcc5.patch \ %D%/packages/patches/llvm-3.6-fix-build-with-gcc-10.patch \ %D%/packages/patches/llvm-3.x.1-fix-build-with-gcc.patch \ diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 34d13d849c..774c0b3ae8 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -678,7 +678,6 @@ (define-public llhttp-bootstrap (sha256 (base32 "1cq3q3jybibppjhhiymdfmnqgbvn77j7b4ks7lil0lrc3vnnp87f")) =2D (patches (search-patches "llhttp-bootstrap-CVE-2020-8287.p= atch")) (modules '((guix build utils))) (snippet '(begin diff --git a/gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch b/gn= u/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch deleted file mode 100644 index 215c920e53..0000000000 =2D-- a/gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch +++ /dev/null @@ -1,100 +0,0 @@ =2DThis patch comes from upstream. It corresponds to a patch applied to =2Dthe generated C source code for llhttp included in Node.js 14.16.0 =2D(see commit 641f786bb1a1f6eb1ff8750782ed939780f2b31a). That commit =2Dfixes CVE-2020-8287. With this patch, the output of our =2Dllhttp-bootstrap package matches the files included in Node.js 14.16.0 =2Dexactly. =2D =2Dcommit e9b36ea64709c35ca66094d5cf3787f444029601 =2DAuthor: Fedor Indutny =2DDate: Sat Oct 10 19:56:01 2020 -0700 =2D =2D http: unset `F_CHUNKED` on new `Transfer-Encoding` =2D=20=20=20=20 =2D Duplicate `Transfer-Encoding` header should be a treated as a single, =2D but with original header values concatenated with a comma separator.= In =2D the light of this, even if the past `Transfer-Encoding` ended with =2D `chunked`, we should be not let the `F_CHUNKED` to leak into the next =2D header, because mere presence of another header indicates that `chun= ked` =2D is not the last transfer-encoding token. =2D =2Ddiff --git a/src/llhttp/http.ts b/src/llhttp/http.ts =2Dindex f4f1a6e..0a0c365 100644 =2D--- a/src/llhttp/http.ts =2D+++ b/src/llhttp/http.ts =2D@@ -460,11 +460,19 @@ export class HTTP { =2D .match([ ' ', '\t' ], n('header_value_discard_ws')) =2D .otherwise(checkContentLengthEmptiness); =2D=20 =2D+ // Multiple `Transfer-Encoding` headers should be treated as one, b= ut with =2D+ // values separate by a comma. =2D+ // =2D+ // See: https://tools.ietf.org/html/rfc7230#section-3.2.2 =2D+ const toTransferEncoding =3D this.unsetFlag( =2D+ FLAGS.CHUNKED, =2D+ 'header_value_te_chunked'); =2D+ =2D n('header_value_start') =2D .otherwise(this.load('header_state', { =2D [HEADER_STATE.UPGRADE]: this.setFlag(FLAGS.UPGRADE, fallback), =2D [HEADER_STATE.TRANSFER_ENCODING]: this.setFlag( =2D- FLAGS.TRANSFER_ENCODING, 'header_value_te_chunked'), =2D+ FLAGS.TRANSFER_ENCODING, toTransferEncoding), =2D [HEADER_STATE.CONTENT_LENGTH]: n('header_value_content_length_o= nce'), =2D [HEADER_STATE.CONNECTION]: n('header_value_connection'), =2D }, 'header_value')); =2D@@ -847,6 +855,11 @@ export class HTTP { =2D return span.start(span.end(this.node(next))); =2D } =2D=20 =2D+ private unsetFlag(flag: FLAGS, next: string | Node): Node { =2D+ const p =3D this.llparse; =2D+ return p.invoke(p.code.and('flags', ~flag), this.node(next)); =2D+ } =2D+ =2D private setFlag(flag: FLAGS, next: string | Node): Node { =2D const p =3D this.llparse; =2D return p.invoke(p.code.or('flags', flag), this.node(next)); =2Ddiff --git a/test/request/transfer-encoding.md b/test/request/transfer-e= ncoding.md =2Dindex a7d1681..b0891d6 100644 =2D--- a/test/request/transfer-encoding.md =2D+++ b/test/request/transfer-encoding.md =2D@@ -353,6 +353,38 @@ off=3D106 headers complete method=3D3 v=3D1/1 flags= =3D200 content_length=3D0 =2D off=3D106 error code=3D15 reason=3D"Request has invalid `Transfer-Encod= ing`" =2D ``` =2D=20 =2D+## POST with `chunked` and duplicate transfer-encoding =2D+ =2D+ =2D+```http =2D+POST /post_identity_body_world?q=3Dsearch#hey HTTP/1.1 =2D+Accept: */* =2D+Transfer-Encoding: chunked =2D+Transfer-Encoding: deflate =2D+ =2D+World =2D+``` =2D+ =2D+```log =2D+off=3D0 message begin =2D+off=3D5 len=3D38 span[url]=3D"/post_identity_body_world?q=3Dsearch#hey" =2D+off=3D44 url complete =2D+off=3D54 len=3D6 span[header_field]=3D"Accept" =2D+off=3D61 header_field complete =2D+off=3D62 len=3D3 span[header_value]=3D"*/*" =2D+off=3D67 header_value complete =2D+off=3D67 len=3D17 span[header_field]=3D"Transfer-Encoding" =2D+off=3D85 header_field complete =2D+off=3D86 len=3D7 span[header_value]=3D"chunked" =2D+off=3D95 header_value complete =2D+off=3D95 len=3D17 span[header_field]=3D"Transfer-Encoding" =2D+off=3D113 header_field complete =2D+off=3D114 len=3D7 span[header_value]=3D"deflate" =2D+off=3D123 header_value complete =2D+off=3D125 headers complete method=3D3 v=3D1/1 flags=3D200 content_lengt= h=3D0 =2D+off=3D125 error code=3D15 reason=3D"Request has invalid `Transfer-Encod= ing`" =2D+``` =2D+ =2D ## POST with `chunked` before other transfer-coding (lenient) =2D=20 =2D TODO(indutny): should we allow it even in lenient mode? (Consider disab= ling =2D-=20 2.39.2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmQQDsoQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD664rD/sFuUe3EqmYFZ3dkj2232qAnGJQXgck1weI vuwzGKOVTy1DrwakK1uj8X4m5dVd3yUb6yeznr/+2X3EEK5JQK0Oo6i909SeVGbh cniSm+J1gcuJOiCNwFrIzL8pcNV9L0uGzIMilx2xi4yfHMVl1KA/s4luMSgMuIDw nlSXM40CKLMgDR3Avgeo5oe7KO6k4Mda2vwkEEJaNfrtPpgnyedybep1Ou7TwdGy 81+rn62T0kXHJOYb2I2sI1YxL1hbPDDo547UGNKe7ilJk0iQYEZi7j8/8ASgKJr4 du3ESQ2/6XScStmvZ8IsYsJ2XtCL8Nz/eMk/T84yTgPwwe8AHgLF6ElxwvJ77gCA Hkr0P7Fo7rct1N2sJV6BoV5MV3lnLnI7TdpvSRR9c5VxOopBP5OG6F5eWY1G1NTA Axm9w5bRAUuIkA6liGz6eLk5lX93jce4mBJJEdDnltVnJURuo5TpgyiBS3Mp4ozM nUPHQr2Oxn9Thoi9+6wHOufAvm5O2N2PcBHWiBykVgkblBZi8s6yhxR0izl6lvRm djnB+tfYoavrwFA0PwcXT/bFLA7sqqw1Q+qljY3VEqQCmD5jxjOZcMnrcau3ss8D G+qTM7+a3EFQulpLFgZhNx/0vWjzUw3sjYuqIwwaJ70JZiOv4Tx7ZnuPinYNcnsU Oe2q/u4liYjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmQQDsoQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSLt2A/4ug8diHMvTNt+FQwPHecQvO0FS TEeOLIRArcCB1yCFVlssWXpE/1gQM59XGg7WYBMEqd8Mtif+qJTjZ6CTpwxeesWd zUnQTn/IFmd1fwP9/HRZVTsFuTBs/GrrF1DwodkGNyYqnH2MBzV9Yy2wD+sCn+w3 A2Xrjvir8Ou7rYto5A== =r2eL -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Aug 16 16:55:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62177: [PATCH] [WIP] update node to version 16 Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Mar 2023 10:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62177 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: "Dr. Arne Babenhauserheide" , 62177@debbugs.gnu.org Received: via spool by 62177-submit@debbugs.gnu.org id=B62177.167879023521251 (code B ref 62177); Tue, 14 Mar 2023 10:38:02 +0000 Received: (at 62177) by debbugs.gnu.org; 14 Mar 2023 10:37:15 +0000 Received: from localhost ([127.0.0.1]:36341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pc21r-0005Wh-HE for submit@debbugs.gnu.org; Tue, 14 Mar 2023 06:37:15 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:54016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pc21p-0005WW-Mi for 62177@debbugs.gnu.org; Tue, 14 Mar 2023 06:37:14 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1678790231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m5f4tN28uWw48/KL1p6FnmV5y9fmBp//osCfofpBAY8=; b=kSRd9w/SIeis48SIutx6vxYKz/9d6TmXbJloEsx5ECMqJBSIP7m3El0YELm4jd5cp5AKIO 0u4eS8hJXCANfZ6rLW5930SsGYzI4pLDZx00Gz5UVzQ90NXIP6eQ6hn7KvF1uOIh16ylLg HqdjZsl3p956Mx5ZTPZt+17HHy6v8vA= In-Reply-To: <87h6unc1fb.fsf@web.de> References: <87h6unc1fb.fsf@web.de> Date: Tue, 14 Mar 2023 11:37:11 +0100 Message-ID: <87h6unbovc.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dr. Arne, "Dr. Arne Babenhauserheide" writes: > Hi, > > > this is an initial stab at getting node to version 16. [snip] Issue 59188 (https://issues.guix.gnu.org/59188) already updates node to the 18.X LTS series. Would that version also work for you, or do you have a specific need for the 16.X series? I ask because the "active" LTS version is 18, while the 16 "maintenance" LTS window already closes on 2023-09-11, which is (IMHO) pretty soon. - Jelle From unknown Sat Aug 16 16:55:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62177: [PATCH] [WIP] update node to version 16 Resent-From: "Dr. Arne Babenhauserheide" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Mar 2023 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62177 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Jelle Licht Cc: 62177@debbugs.gnu.org Received: via spool by 62177-submit@debbugs.gnu.org id=B62177.16788101742599 (code B ref 62177); Tue, 14 Mar 2023 16:10:02 +0000 Received: (at 62177) by debbugs.gnu.org; 14 Mar 2023 16:09:34 +0000 Received: from localhost ([127.0.0.1]:38308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pc7DS-0000fr-EB for submit@debbugs.gnu.org; Tue, 14 Mar 2023 12:09:34 -0400 Received: from mout.web.de ([212.227.17.11]:41349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pc7DQ-0000fZ-HF for 62177@debbugs.gnu.org; Tue, 14 Mar 2023 12:09:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1678810163; i=arne_bab@web.de; bh=kfwH7WLnuBV1xXrWEnGZMsasgjsqNnXYS26BGWFzF/M=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=EMi8H9L0js5t6EIHc70Y/0Cmc+hxqLKY2ANLBKXIGfNsqnjA4zkOcnx8Mt5u3HLbr 3qpgzfjb1+WAf9i7143V9d3y5YADFEc9fjLpKJtZj8633luMS/wzo/Z0WVk6RYyEAM QO/duf+O0n66P+9WrRzrqxWHo13LoGZlVKwA25rGHbyraXupPjoN5vBKMo27PMOSed oVKYbdOj1rqIiVWsnzi9RZbRtEciSBwUJ9RabexaA4OG8TiESchyOfti1LVXOfecvA ZirGn4NcPrs7odsZ7sEh3kHvg5CR2OfJgCfZA6dLhfXgsUAcfWdXXO68hPMXnkKmQm 0clE6bSVg2Raw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from fluss ([84.149.95.143]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N0Igv-1qQLob3n4p-00xLe2; Tue, 14 Mar 2023 17:09:22 +0100 References: <87h6unc1fb.fsf@web.de> <87h6unbovc.fsf@fsfe.org> User-agent: mu4e 1.8.13; emacs 28.2 From: "Dr. Arne Babenhauserheide" Date: Tue, 14 Mar 2023 17:08:54 +0100 In-reply-to: <87h6unbovc.fsf@fsfe.org> Message-ID: <87edpr1fim.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:wFm5Z4svAEV65IblaFp/m21b2qaslBwY5E9NyQBQponASnfj8Xi Paohmry2EC5UhWaLa2q+mpQRZWsDcT2GmxNlLQknX0195+HdZpybqZv+uX8+VQOO4DRtK0G uO721fcllbOwl8IArpfhLTFXTUpGLynMFqavyXVdMHQCkNOv1bOZ9ymy/jG25fXJIiNmz0Y s+tpkF6Ew8bjpQgu3zLAA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:sIK9nMwF4P0=;U0Yh+eDpxZbmIWkpqkltf0P/WmE W730BDpbGCTVtMAP05C+4MRo4B7XqD5lPzGk65NbJUCQ2vbVzuuTaVukFNzwielJ7hRzTzyYj O5AIgav1uylchvAqB3R8C4H0k2qx/auc4QYphFTDonhTkT/1jizskSZEfQcTE9ytoPkCs3lls L25ykE60ja1fMC4yEKkWTDeBEO+0R/ityjtQEflWR7Ob1og4fTY6nNszVAhCDVxUdWk3SWDbT Du+khjyFpAn3LXZ6npBlwSNsTcCs4OlVkgtXLtsQrENl4hF+ScjuhGW811aI2mXNr7ArpltSs HOsFeZlEioCnOOZaFwyr+kf52wu5kDMY+QVNcXGtHJEmAXx2NPbLdQw19Kw1/KVpJVXuH/kEu orS9OypHQ1kqqbpOe+E+ZFgrN75Xfzq9H8RH1AnWGV5DaU2jx0LL2u/oSRtEe6qvHTFiDesYn qdnhm6/RYHughfE+DdpmhEsdh3U2yE6c9n2c306OtItLo+ZGb2wQDNVuEYRW154BtXrvUIfft 3154hcDoHcBVPWXbDEmAp2s2lzcRyG+Ia/yPCzqjh4yRP0bZJS5mTwgrK9pKZ1Lcoh7lGhwhB Om1rXzI4VAnpKS6dRSe2WFENOrB05WBxoXN/mVvtEqIiL0IMmCVGZBIxCrxuMrrP68Tb2P/fE srMWa3y2EzAF3oVb7WIyJFmVcTBsk7D2i5q9oJiLv94NtZwdyjbXw6VEtf54vR6JGrWcFD5ek 5j5CMVXOzVLktkC6kdbAxbRXFBySCzSh8SbJiBsxq0cBLIQfjTy6fD/SnOjDumOQH6hjsz1y/ lxU85eGq4Z0bfqlD/7gLCOTqSMO62C8LLcc8eCU+JnvT/eAXvqy8PmrpVpWkKXBTBG5RlAq79 ne2Sk0rTtQzs11pPsHm3eSeFSbVll01GA1wuzxpacJGmNOT0+myotcBBWeYqE1qnavCC2cg21 s75acf4y7XJrgeSbkZD2++FrqhQ= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jelle, Jelle Licht writes: > Issue 59188 (https://issues.guix.gnu.org/59188) already updates node to > the 18.X LTS series. Would that version also work for you, or do you > have a specific need for the 16.X series? I ask because the "active" LTS > version is 18, while the 16 "maintenance" LTS window already closes on > 2023-09-11, which is (IMHO) pretty soon. Version 18 is even better :-) Thank you! Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmQQnDIQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD69d9D/oC7A4QB3+6189+g/H0CoggbtWgqfDcjSwm lexRjNHnIUnySON9weEM9qMYWEUYMjzr6sn14btLh2Q2x05VOsuvJ4qIEf0511mn lguPNDee5l4Rw/6EAgV8UffgYuB012o+7UdxjZvjhRbC+MiKbTchz/evDxaLhmMp ccusHZXYtN9fRUG7J5xo8xs22hNwaG8nzdl2f/UwYIkwo6TuvkCaurvrqbfder9Q UJ+CLX9dVdVjAF9LNiJ9mm0JVI+pbepRMpUb1gLbq6oEGOF5nH8U9o6YMlG4bkvi jNqK/zvhwAB1PcJHKPFD0trw673VT26MejI+3f9u1N9/pERZsjHLnwQRoj+56uKM i4yELEUqwisV09u9ng8HJEmFVTNgukS/4hhLV2c+GoyXvFw8w9R4FJtmCrJjNqXM ztBVw8cZty/iOk1dIRzUCCKOTUMbkXF6h2UUZ5l5X+it4cXGme8EO46gxHP5Rggt AyRCnTGxs8yeLh3RNJxOT1IV6p7ffyXX4CmIcmLfZX4D4ox9psXLIlkocrsMQKqH LQgI37qQ0qS1xpZij9gGdHACWE6ieE5YF/eYe/MdWNMD2ukxbZJAo26PNqt5cl4K HUeR4bpQRfZ4V3HuRMqebzVqXNTzCHXVvoBQnOucdyZIdFkXNIyvuuGL7uuHwuL7 enkh1zapvIjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmQQnDIQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSCc4BACNjgpfZH3Qyj2KjG8PNrmzdTix GKlaIPweI0/Oto4MDL89ltDrMy9pnqXNIMpbUEYPjPy1/rqv0EYVcPjePiaPUICw SJJcVf5AZnJ0tudOxxaNq/3/eXShbP3iProjfo2BgUnjnpF2xCxphyYpYk/iwFcj Bl3nW8u144W8hm+E0w== =3alT -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 16:55:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Dr. Arne Babenhauserheide" Subject: bug#62177: closed (Re: [PATCH] [WIP] update node to version 16) Message-ID: References: <874j0dc9i2.fsf@nicolasgoaziou.fr> <87h6unc1fb.fsf@web.de> X-Gnu-PR-Message: they-closed 62177 X-Gnu-PR-Package: guix X-Gnu-PR-Keywords: patch Reply-To: 62177@debbugs.gnu.org Date: Sat, 01 Mar 2025 10:49:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1740826142-27501-1" This is a multi-part message in MIME format... ------------=_1740826142-27501-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62177: [PATCH] [WIP] update node to version 16 which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62177@debbugs.gnu.org. --=20 62177: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62177 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1740826142-27501-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62177-done) by debbugs.gnu.org; 1 Mar 2025 10:48:32 +0000 Received: from localhost ([127.0.0.1]:33754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toKOW-00077G-CF for submit@debbugs.gnu.org; Sat, 01 Mar 2025 05:48:32 -0500 Received: from msg-3.mailo.com ([213.182.54.8]:53390 helo=mailo.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1toKOT-00076O-EH for 62177-done@debbugs.gnu.org; Sat, 01 Mar 2025 05:48:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1740826102; bh=pesOKHosLxEPXEC6YCceT0DYw9wyzcfNltTmTCrHpYc=; h=X-EA-Auth:From:To:Subject:In-Reply-To:Date:Message-ID: MIME-Version:Content-Type; b=LhYfFuiZEDl2OJseBAzBzIyvDkXzvuvDrNR2lTeSfE6NMZkJhVba1nQKWunJdWvFP a9bndpWRBmGU7q7ZBi06rSkkuF5IGYOXd/U7ng/IFVqKluIKFF8SOZvERwWZ9JKuQM mUSSzpYh6/q53Bis3N/ePttk6BPE8e5/eT2lgN+0= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Sat, 1 Mar 2025 11:48:21 +0100 (CET) X-EA-Auth: 54iFPyThnRPiQabUTpwlEVLS8Sw/pmoLGSDrA7qPuAO/97IbN825/RL9FHj9czlwwpSIkhx9xZcu83xpRQyAC9B0rr7CNeI2Tgqump650h8= From: Nicolas Goaziou To: 62177-done@debbugs.gnu.org Subject: Re: [PATCH] [WIP] update node to version 16 In-Reply-To: <87edpr1fim.fsf@web.de> Date: Sat, 01 Mar 2025 11:48:05 +0100 Message-ID: <874j0dc9i2.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62177-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Closing as node is currently at a higher version. ------------=_1740826142-27501-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Mar 2023 06:06:16 +0000 Received: from localhost ([127.0.0.1]:36039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbxnZ-0006Sp-DQ for submit@debbugs.gnu.org; Tue, 14 Mar 2023 02:06:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:45384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbxnW-0006Sg-Mr for submit@debbugs.gnu.org; Tue, 14 Mar 2023 02:06:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbxnW-0000y4-7H for bug-guix@gnu.org; Tue, 14 Mar 2023 02:06:10 -0400 Received: from mout.web.de ([212.227.17.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbxnR-0005Pk-Gv for bug-guix@gnu.org; Tue, 14 Mar 2023 02:06:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1678773963; i=arne_bab@web.de; bh=oiz7CbU//C0u1IpJ97izfoT0imOAMoPxZY0UJ773zLc=; h=X-UI-Sender-Class:From:To:Subject:Date; b=kqwqVMcnYmFM8Yd5tewUgxpkGjMZtdJN/R61GAdpENy/sHD0S+ix0B4u4Xax0Zs70 VmaBtanIrsXFPVF+Xnm6YehiZ3ZTO0Wa4QcWyCUU2ahXgquy40nIsVYDGTVzzyaMLW 5FwzOjPTGPc1bv1T+53wzC2lbyXLUCtXH8LRFwR/Aj2CGqyS4IUe/SEgxQ9UrXArVo MJLTL3sjrDo2CMn23Hy8PaHl7wbEq4A7UVoLgYgv684L4REByGjdD3+q7WrUYFStYk Nj/0Xx7UV9PqfGyjNrLGxD0p5Rw4+I3qWpYvc1u99z+59/cWM3tbuFyQ3IRd6Qh+sz BzhQIbY4XMvSg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from fluss ([84.149.95.143]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MkEhH-1qMbDu0Z4b-00kOdc; Tue, 14 Mar 2023 07:06:03 +0100 User-agent: mu4e 1.8.13; emacs 28.2 From: "Dr. Arne Babenhauserheide" To: bug-guix@gnu.org Subject: [PATCH] [WIP] update node to version 16 Date: Tue, 14 Mar 2023 07:02:14 +0100 Message-ID: <87h6unc1fb.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:ejIjE6lKSii51A9pVLkgsJst6WRay+mtfYeL6A1T/NzAxllfQZh uP/svToqksrhUMjWyjFnqyHTqmNNAdGlizbxcgocCPb03g1mGUDJwTSACBIS51JXjbFMuIp wDjWwImIPuGJ/n83XwaHDKzCEdK8qwQG05WZ5JaCoCp+CDyXvbTDfG9u9MKbL6ejA9tqmgv aMGs4LVArqpsPrjN7l7fw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3MXceFqEEGY=;VoQWs764RGimfxvC67eIKtjxrch fUN2ZtD3Y74t/TkvoCxIsoKaXrT6D0f53dzrq3XQ8d60D8odmNzpfgqA/jV+m9K6JNYVL20MR ywDlqahLi7BnLapHYuyIfy/Qju4viJDuqqMurir/Cmo3rq4CxX1uvQf/pRFmA25uuVzm0gjQP EIWK8umhlF5lXKxdwyUX56j5leSIoxXojSaSQqgCOl9QvQnE7YquSJw1D58J7GzCXZJ4MJ7ie W7Vj1mtO4Qbna44ULqHPH2OW8p+QmpfdsHm+cEC/CNMk3scX0UNvL705rC4nMsJLBWiHsyo+f Y3tMexKcKnGMHY6TtnPRhbgjwD/XvpGfYge0kTcC1tcOV4iDHxZv2zW9F2EWkAGFDsc0BPbA0 lRZiDaeG6rVPwFp4d35Z5RHrVw4ldT+FCfV9xQOwcMZdtLrCNJDyhfwb2P6J3KdSMeLF4qbYh TY/LQ8onEp/xvONaaAcbYGLY0BBwh1FfgCVinNrEDBWYtBAUS0Epq9/3zoNicPE3xYCGYvnUT SVTACF3W3TAIU099u+htVeMe1SirFMQaNDRFj84owlis6W6LY3GeZfEUmBHLZe8riA3qBaid5 tTTWA2nS4mIVMKs0J/vTfD607U1i/KQaJobrpPseq+iQT+LtoILLPlf/QWJ2osnDKIsoVbABt nJU0AGhAIeJMs2qV0O82qq7ojVFSq61+g13F6cxxlGTB6BTFBqtuekNhplJ//VFgvH1rGf06y 1FRd37xvRqBHLl4ksvFTPlb4stSKc5sGyQmu41M/6CeWyZtNsmRKWrumVFxBYA01RCKgClarO fxmQfNzOs9heORWbmBH9VsyJBIdTVPdEUvThEiVzrV+hDhYh9IdsUy++j9gz1FC8p8djEFwrI r6I9on6CfC/T40N2GDVUX2MDROh73IQX302b2uv7g1DaspD5sTzCHnUk3cjELcYpfENC9SIpQ lqBAmg== Received-SPF: pass client-ip=212.227.17.11; envelope-from=arne_bab@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, this is an initial stab at getting node to version 16. It is far from perfect, but I hope it gives someone a good starting point to move forward. The llhttp bootstrap fixes are currently commented out =E2=80=94 I=E2=80=99m not sure what these should be doing and= how they interact with node =E2=80=94 so this cannot be merged as is. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-WIP-try-to-update-node-to-16.19.0.patch Content-Transfer-Encoding: quoted-printable From=2014d58ab181c9087420a5f955d28d72cb086884fc Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Sat, 28 Jan 2023 20:45:16 +0100 Subject: [PATCH] WIP try to update node to 16.19.0 =2D-- gnu/packages/node.scm | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index be39f3b25a..34d13d849c 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -668,7 +668,7 @@ (define-public node-llparse-bootstrap (define-public llhttp-bootstrap (package (name "llhttp") =2D (version "2.1.4") + (version "8.1.0") (source (origin (method git-fetch) (uri (git-reference @@ -677,7 +677,7 @@ (define-public llhttp-bootstrap (file-name (git-file-name name version)) (sha256 (base32 =2D "115mwyds9655p76lhglxg2blc1ksgrix6zhigaxnc2q6syy3pa6x")) + "1cq3q3jybibppjhhiymdfmnqgbvn77j7b4ks7lil0lrc3vnnp87f")) (patches (search-patches "llhttp-bootstrap-CVE-2020-8287.pat= ch")) (modules '((guix build utils))) (snippet @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap (define-public node-lts (package (inherit node) =2D (version "14.19.3") + (version "16.19.0") (source (origin (method url-fetch) (uri (string-append "https://nodejs.org/dist/v" version "/node-v" version ".tar.xz")) (sha256 (base32 =2D "15691j5zhiikyamiwwd7f282g6d9acfhq91nrwx54xya38gmpx2w")) + "01k72p0hp4lhlpz1syd9cbkm2gpfww0hn10xdpmzd4i3x8dfq7sg")) (modules '((guix build utils))) (snippet `(begin @@ -808,9 +808,12 @@ (define-public node-lts ;; FIXME: These tests fail in the build container, but they= don't ;; seem to be indicative of real problems in practice. (for-each delete-file =2D '("test/parallel/test-cluster-master-error.js" =2D "test/parallel/test-cluster-master-kill.js")) + '("test/parallel/test-cluster-primary-error.js" + "test/parallel/test-cluster-primary-kill.js")) =20 + ;; requires /bin/sh + (delete-file "test/parallel/test-stdin-from-file-spawn.js") +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 ;; These require a DNS resolver. (for-each delete-file '("test/parallel/test-dns.js" @@ -818,8 +821,7 @@ (define-public node-lts =20 ;; These tests require networking. (for-each delete-file =2D '("test/parallel/test-https-agent-unref-socket.= js" =2D "test/parallel/test-corepack-yarn-install.js"= )) + '("test/parallel/test-https-agent-unref-socket.js= ")) =20 ;; This test is timing-sensitive, and fails sporadically on ;; slow, busy, or even very fast machines. @@ -847,21 +849,21 @@ (define-public node-lts ;; TLS certificates that are bundled with the source. We w= ant this ;; package to be reproducible forever, so remove those. ;; TODO: Regenerate certs instead. =2D (for-each delete-file + (for-each (=CE=BB(x)(display x)(delete-file x)) '("test/parallel/test-tls-passphrase.js" "test/parallel/test-tls-server-verify.js")))) (add-after 'delete-problematic-tests 'replace-llhttp-sources =2D (lambda* (#:key inputs #:allow-other-keys) + (lambda* (#:key inputs #:allow-other-keys) #f)))))) ;; Replace pre-generated llhttp sources =2D (let ((llhttp (assoc-ref inputs "llhttp"))) =2D (copy-file (string-append llhttp "/src/llhttp.c") =2D "deps/llhttp/src/llhttp.c") =2D (copy-file (string-append llhttp "/src/api.c") =2D "deps/llhttp/src/api.c") =2D (copy-file (string-append llhttp "/src/http.c") =2D "deps/llhttp/src/http.c") =2D (copy-file (string-append llhttp "/include/llhttp.h") =2D "deps/llhttp/include/llhttp.h")))))))) + ;;(let ((llhttp (assoc-ref inputs "llhttp"))) + ;; (copy-file (string-append llhttp "/src/llhttp.c") + ;; "deps/llhttp/src/llhttp.c") + ;; (copy-file (string-append llhttp "/src/api.c") + ;; "deps/llhttp/src/api.c") + ;; (copy-file (string-append llhttp "/src/http.c") + ;; "deps/llhttp/src/http.c") + ;; (copy-file (string-append llhttp "/include/llhttp.h") + ;; "deps/llhttp/include/llhttp.h")))))))) (native-inputs (list ;; Runtime dependencies for binaries used as a bootstrap. c-ares-for-node =2D-=20 2.39.2 --=-=-= Content-Type: text/plain Updating llhttp also needs the CVE-2020-8287 patch to be removed (it is fixed upstream). --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-do-not-patch-llhttp-bootstrap-CVE-2020-8287-is-f.patch Content-Transfer-Encoding: quoted-printable From=204e9e7905a9a8792b164e96aa31e0dcf3945283d2 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Tue, 14 Mar 2023 06:48:38 +0100 Subject: [PATCH] gnu: do not patch llhttp-bootstrap: CVE-2020-8287 is fixed= in node 16 upstream. =2D-- gnu/local.mk | 1 - gnu/packages/node.scm | 1 - .../llhttp-bootstrap-CVE-2020-8287.patch | 100 ------------------ 3 files changed, 102 deletions(-) delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.pat= ch diff --git a/gnu/local.mk b/gnu/local.mk index 403c5f483e..0efa292322 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1492,7 +1492,6 @@ dist_patch_DATA =3D \ %D%/packages/patches/linuxdcpp-openssl-1.1.patch \ %D%/packages/patches/lirc-localstatedir.patch \ %D%/packages/patches/lirc-reproducible-build.patch \ =2D %D%/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch \ %D%/packages/patches/llvm-3.5-fix-clang-build-with-gcc5.patch \ %D%/packages/patches/llvm-3.6-fix-build-with-gcc-10.patch \ %D%/packages/patches/llvm-3.x.1-fix-build-with-gcc.patch \ diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 34d13d849c..774c0b3ae8 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -678,7 +678,6 @@ (define-public llhttp-bootstrap (sha256 (base32 "1cq3q3jybibppjhhiymdfmnqgbvn77j7b4ks7lil0lrc3vnnp87f")) =2D (patches (search-patches "llhttp-bootstrap-CVE-2020-8287.p= atch")) (modules '((guix build utils))) (snippet '(begin diff --git a/gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch b/gn= u/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch deleted file mode 100644 index 215c920e53..0000000000 =2D-- a/gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch +++ /dev/null @@ -1,100 +0,0 @@ =2DThis patch comes from upstream. It corresponds to a patch applied to =2Dthe generated C source code for llhttp included in Node.js 14.16.0 =2D(see commit 641f786bb1a1f6eb1ff8750782ed939780f2b31a). That commit =2Dfixes CVE-2020-8287. With this patch, the output of our =2Dllhttp-bootstrap package matches the files included in Node.js 14.16.0 =2Dexactly. =2D =2Dcommit e9b36ea64709c35ca66094d5cf3787f444029601 =2DAuthor: Fedor Indutny =2DDate: Sat Oct 10 19:56:01 2020 -0700 =2D =2D http: unset `F_CHUNKED` on new `Transfer-Encoding` =2D=20=20=20=20 =2D Duplicate `Transfer-Encoding` header should be a treated as a single, =2D but with original header values concatenated with a comma separator.= In =2D the light of this, even if the past `Transfer-Encoding` ended with =2D `chunked`, we should be not let the `F_CHUNKED` to leak into the next =2D header, because mere presence of another header indicates that `chun= ked` =2D is not the last transfer-encoding token. =2D =2Ddiff --git a/src/llhttp/http.ts b/src/llhttp/http.ts =2Dindex f4f1a6e..0a0c365 100644 =2D--- a/src/llhttp/http.ts =2D+++ b/src/llhttp/http.ts =2D@@ -460,11 +460,19 @@ export class HTTP { =2D .match([ ' ', '\t' ], n('header_value_discard_ws')) =2D .otherwise(checkContentLengthEmptiness); =2D=20 =2D+ // Multiple `Transfer-Encoding` headers should be treated as one, b= ut with =2D+ // values separate by a comma. =2D+ // =2D+ // See: https://tools.ietf.org/html/rfc7230#section-3.2.2 =2D+ const toTransferEncoding =3D this.unsetFlag( =2D+ FLAGS.CHUNKED, =2D+ 'header_value_te_chunked'); =2D+ =2D n('header_value_start') =2D .otherwise(this.load('header_state', { =2D [HEADER_STATE.UPGRADE]: this.setFlag(FLAGS.UPGRADE, fallback), =2D [HEADER_STATE.TRANSFER_ENCODING]: this.setFlag( =2D- FLAGS.TRANSFER_ENCODING, 'header_value_te_chunked'), =2D+ FLAGS.TRANSFER_ENCODING, toTransferEncoding), =2D [HEADER_STATE.CONTENT_LENGTH]: n('header_value_content_length_o= nce'), =2D [HEADER_STATE.CONNECTION]: n('header_value_connection'), =2D }, 'header_value')); =2D@@ -847,6 +855,11 @@ export class HTTP { =2D return span.start(span.end(this.node(next))); =2D } =2D=20 =2D+ private unsetFlag(flag: FLAGS, next: string | Node): Node { =2D+ const p =3D this.llparse; =2D+ return p.invoke(p.code.and('flags', ~flag), this.node(next)); =2D+ } =2D+ =2D private setFlag(flag: FLAGS, next: string | Node): Node { =2D const p =3D this.llparse; =2D return p.invoke(p.code.or('flags', flag), this.node(next)); =2Ddiff --git a/test/request/transfer-encoding.md b/test/request/transfer-e= ncoding.md =2Dindex a7d1681..b0891d6 100644 =2D--- a/test/request/transfer-encoding.md =2D+++ b/test/request/transfer-encoding.md =2D@@ -353,6 +353,38 @@ off=3D106 headers complete method=3D3 v=3D1/1 flags= =3D200 content_length=3D0 =2D off=3D106 error code=3D15 reason=3D"Request has invalid `Transfer-Encod= ing`" =2D ``` =2D=20 =2D+## POST with `chunked` and duplicate transfer-encoding =2D+ =2D+ =2D+```http =2D+POST /post_identity_body_world?q=3Dsearch#hey HTTP/1.1 =2D+Accept: */* =2D+Transfer-Encoding: chunked =2D+Transfer-Encoding: deflate =2D+ =2D+World =2D+``` =2D+ =2D+```log =2D+off=3D0 message begin =2D+off=3D5 len=3D38 span[url]=3D"/post_identity_body_world?q=3Dsearch#hey" =2D+off=3D44 url complete =2D+off=3D54 len=3D6 span[header_field]=3D"Accept" =2D+off=3D61 header_field complete =2D+off=3D62 len=3D3 span[header_value]=3D"*/*" =2D+off=3D67 header_value complete =2D+off=3D67 len=3D17 span[header_field]=3D"Transfer-Encoding" =2D+off=3D85 header_field complete =2D+off=3D86 len=3D7 span[header_value]=3D"chunked" =2D+off=3D95 header_value complete =2D+off=3D95 len=3D17 span[header_field]=3D"Transfer-Encoding" =2D+off=3D113 header_field complete =2D+off=3D114 len=3D7 span[header_value]=3D"deflate" =2D+off=3D123 header_value complete =2D+off=3D125 headers complete method=3D3 v=3D1/1 flags=3D200 content_lengt= h=3D0 =2D+off=3D125 error code=3D15 reason=3D"Request has invalid `Transfer-Encod= ing`" =2D+``` =2D+ =2D ## POST with `chunked` before other transfer-coding (lenient) =2D=20 =2D TODO(indutny): should we allow it even in lenient mode? (Consider disab= ling =2D-=20 2.39.2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmQQDsoQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD664rD/sFuUe3EqmYFZ3dkj2232qAnGJQXgck1weI vuwzGKOVTy1DrwakK1uj8X4m5dVd3yUb6yeznr/+2X3EEK5JQK0Oo6i909SeVGbh cniSm+J1gcuJOiCNwFrIzL8pcNV9L0uGzIMilx2xi4yfHMVl1KA/s4luMSgMuIDw nlSXM40CKLMgDR3Avgeo5oe7KO6k4Mda2vwkEEJaNfrtPpgnyedybep1Ou7TwdGy 81+rn62T0kXHJOYb2I2sI1YxL1hbPDDo547UGNKe7ilJk0iQYEZi7j8/8ASgKJr4 du3ESQ2/6XScStmvZ8IsYsJ2XtCL8Nz/eMk/T84yTgPwwe8AHgLF6ElxwvJ77gCA Hkr0P7Fo7rct1N2sJV6BoV5MV3lnLnI7TdpvSRR9c5VxOopBP5OG6F5eWY1G1NTA Axm9w5bRAUuIkA6liGz6eLk5lX93jce4mBJJEdDnltVnJURuo5TpgyiBS3Mp4ozM nUPHQr2Oxn9Thoi9+6wHOufAvm5O2N2PcBHWiBykVgkblBZi8s6yhxR0izl6lvRm djnB+tfYoavrwFA0PwcXT/bFLA7sqqw1Q+qljY3VEqQCmD5jxjOZcMnrcau3ss8D G+qTM7+a3EFQulpLFgZhNx/0vWjzUw3sjYuqIwwaJ70JZiOv4Tx7ZnuPinYNcnsU Oe2q/u4liYjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmQQDsoQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSLt2A/4ug8diHMvTNt+FQwPHecQvO0FS TEeOLIRArcCB1yCFVlssWXpE/1gQM59XGg7WYBMEqd8Mtif+qJTjZ6CTpwxeesWd zUnQTn/IFmd1fwP9/HRZVTsFuTBs/GrrF1DwodkGNyYqnH2MBzV9Yy2wD+sCn+w3 A2Xrjvir8Ou7rYto5A== =r2eL -----END PGP SIGNATURE----- --==-=-=-- ------------=_1740826142-27501-1--