From unknown Wed Jun 18 23:13:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62169 <62169@debbugs.gnu.org> To: bug#62169 <62169@debbugs.gnu.org> Subject: Status: [PATCH 0/3] services: mcron: Make log-file and date-format configurable. Reply-To: bug#62169 <62169@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:16 +0000 retitle 62169 [PATCH 0/3] services: mcron: Make log-file and date-format co= nfigurable. reassign 62169 guix-patches submitter 62169 Bruno Victal severity 62169 normal tag 62169 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:19:38 2023 Received: (at submit) by debbugs.gnu.org; 13 Mar 2023 19:19:38 +0000 Received: from localhost ([127.0.0.1]:35639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnhq-0002yc-En for submit@debbugs.gnu.org; Mon, 13 Mar 2023 15:19:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:40278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnhp-0002yV-5Q for submit@debbugs.gnu.org; Mon, 13 Mar 2023 15:19:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbnho-0000dZ-PX for guix-patches@gnu.org; Mon, 13 Mar 2023 15:19:36 -0400 Received: from smtpm4.myservices.hosting ([185.26.105.235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbnhn-0006sH-AV for guix-patches@gnu.org; Mon, 13 Mar 2023 15:19:36 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm4.myservices.hosting (Postfix) with ESMTP id 611A520D42 for ; Mon, 13 Mar 2023 20:19:29 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 7C283800A5; Mon, 13 Mar 2023 20:03:02 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id b79pB_FcvMNI; Mon, 13 Mar 2023 20:03:02 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 13B05800A4; Mon, 13 Mar 2023 20:03:02 +0100 (CET) From: Bruno Victal To: guix-patches@gnu.org Subject: [PATCH 0/3] services: mcron: Make log-file and date-format configurable. Date: Mon, 13 Mar 2023 19:02:57 +0000 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.105.235; envelope-from=mirai@makinata.eu; helo=smtpm4.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tested with 'make check-system TESTS=mcron'. Bruno Victal (3): services: mcron: Restyle mcron-configuration. services: mcron: Use match-record. services: mcron: Add log-file and date-format fields. doc/guix.texi | 8 +++- gnu/services/mcron.scm | 104 +++++++++++++++++++++++++---------------- 2 files changed, 71 insertions(+), 41 deletions(-) -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:30:57 2023 Received: (at 62169) by debbugs.gnu.org; 13 Mar 2023 19:30:57 +0000 Received: from localhost ([127.0.0.1]:35660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnsm-0003H3-HZ for submit@debbugs.gnu.org; Mon, 13 Mar 2023 15:30:56 -0400 Received: from smtpmciv5.myservices.hosting ([185.26.107.241]:60244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnsl-0003Gu-8s for 62169@debbugs.gnu.org; Mon, 13 Mar 2023 15:30:55 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv5.myservices.hosting (Postfix) with ESMTP id A3B7620D93 for <62169@debbugs.gnu.org>; Mon, 13 Mar 2023 20:30:53 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 3F8CA800A5; Mon, 13 Mar 2023 20:30:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Q7FeGqCIykyO; Mon, 13 Mar 2023 20:30:53 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id C3F20800A1; Mon, 13 Mar 2023 20:30:52 +0100 (CET) From: Bruno Victal To: 62169@debbugs.gnu.org Subject: [PATCH 2/3] services: mcron: Use match-record. Date: Mon, 13 Mar 2023 19:30:49 +0000 Message-Id: <691ab538c6a9ea4d62b9113416114d12ddca0d54.1678735825.git.mirai@makinata.eu> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62169 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/mcron.scm (mcron-shepherd-services): Use match-record. --- gnu/services/mcron.scm | 68 ++++++++++++++++++++---------------------- 1 file changed, 33 insertions(+), 35 deletions(-) diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm index 6ee333f253..9f3afecf62 100644 --- a/gnu/services/mcron.scm +++ b/gnu/services/mcron.scm @@ -143,41 +143,39 @@ (define (shepherd-schedule-action mcron files) (display line) (loop))))))))) -(define mcron-shepherd-services - (match-lambda - (($ mcron ()) ;nothing to do! - '()) - (($ mcron jobs log? log-format) - (let ((files (job-files mcron jobs))) - (list (shepherd-service - (provision '(mcron)) - (requirement '(user-processes)) - (modules `((srfi srfi-1) - (srfi srfi-26) - (ice-9 popen) ;for the 'schedule' action - (ice-9 rdelim) - (ice-9 match) - ,@%default-modules)) - (start #~(make-forkexec-constructor - (list (string-append #$mcron "/bin/mcron") - #$@(if log? - #~("--log" "--log-format" #$log-format) - #~()) - #$@files) - - ;; Disable auto-compilation of the job files and set a - ;; sane value for 'PATH'. - #:environment-variables - (cons* "GUILE_AUTO_COMPILE=0" - "PATH=/run/current-system/profile/bin" - (remove (cut string-prefix? "PATH=" <>) - (environ))) - - #:log-file "/var/log/mcron.log")) - (stop #~(make-kill-destructor)) - - (actions - (list (shepherd-schedule-action mcron files))))))))) +(define (mcron-shepherd-services config) + (match-record config (mcron jobs log? log-format) + (if (eq? jobs '()) + '() ; nothing to do + (let ((files (job-files mcron jobs))) + (list (shepherd-service + (provision '(mcron)) + (requirement '(user-processes)) + (modules `((srfi srfi-1) + (srfi srfi-26) + (ice-9 popen) ;for the 'schedule' action + (ice-9 rdelim) + (ice-9 match) + ,@%default-modules)) + (start #~(make-forkexec-constructor + (list (string-append #$mcron "/bin/mcron") + #$@(if log? + #~("--log" "--log-format" #$log-format) + #~()) + #$@files) + + ;; Disable auto-compilation of the job files and + ;; set a sane value for 'PATH'. + #:environment-variables + (cons* "GUILE_AUTO_COMPILE=0" + "PATH=/run/current-system/profile/bin" + (remove (cut string-prefix? "PATH=" <>) + (environ))) + + #:log-file "/var/log/mcron.log")) + (stop #~(make-kill-destructor)) + (actions + (list (shepherd-schedule-action mcron files))))))))) (define mcron-service-type (service-type (name 'mcron) -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:30:59 2023 Received: (at 62169) by debbugs.gnu.org; 13 Mar 2023 19:30:59 +0000 Received: from localhost ([127.0.0.1]:35663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnsp-0003HM-0u for submit@debbugs.gnu.org; Mon, 13 Mar 2023 15:30:59 -0400 Received: from smtpm3.myservices.hosting ([185.26.105.234]:59588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnsm-0003H2-QS for 62169@debbugs.gnu.org; Mon, 13 Mar 2023 15:30:57 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 4275F20FB2 for <62169@debbugs.gnu.org>; Mon, 13 Mar 2023 20:30:56 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id E4A3E800A4; Mon, 13 Mar 2023 20:30:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id too7TPuiRYE9; Mon, 13 Mar 2023 20:30:52 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 6E30B800A0; Mon, 13 Mar 2023 20:30:52 +0100 (CET) From: Bruno Victal To: 62169@debbugs.gnu.org Subject: [PATCH 1/3] services: mcron: Restyle mcron-configuration. Date: Mon, 13 Mar 2023 19:30:48 +0000 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62169 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * doc/guix.texi (Scheduled Job Execution): Sync doc with source. * gnu/services/mcron.scm (mcron-configuration): Restyle. [log-format]: Fix incorrectly formatted text. --- doc/guix.texi | 2 +- gnu/services/mcron.scm | 15 +++++++++++---- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 39932d5aad..45d96b8fbb 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -19349,7 +19349,7 @@ Scheduled Job Execution @item @code{log-format} (default: @code{"~1@@*~a ~a: ~a~%"}) (type: string) @code{(ice-9 format)} format string for log messages. The default value -produces messages like "@samp{@var{pid} @var{name}: @var{message}"} +produces messages like @samp{@var{pid} @var{name}: @var{message}} (@pxref{Invoking mcron, Invoking,, mcron,GNU@tie{}mcron}). Each message is also prefixed by a timestamp by GNU Shepherd. diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm index 52332d6123..6ee333f253 100644 --- a/gnu/services/mcron.scm +++ b/gnu/services/mcron.scm @@ -56,18 +56,25 @@ (define list-of-gexps? (list-of gexp?)) (define-configuration/no-serialization mcron-configuration - (mcron (file-like mcron) "The mcron package to use.") + (mcron + (file-like mcron) + "The mcron package to use.") + (jobs (list-of-gexps '()) "This is a list of gexps (@pxref{G-Expressions}), where each gexp corresponds to an mcron job specification (@pxref{Syntax, mcron job specifications,, mcron, GNU@tie{}mcron}).") - (log? (boolean #t) "Log messages to standard output.") + + (log? + (boolean #t) + "Log messages to standard output.") + (log-format (string "~1@*~a ~a: ~a~%") "@code{(ice-9 format)} format string for log messages. The default value -produces messages like \"@samp{@var{pid} @var{name}: -@var{message}\"} (@pxref{Invoking mcron, Invoking,, mcron, GNU@tie{}mcron}). +produces messages like @samp{@var{pid} @var{name}: @var{message}} +(@pxref{Invoking mcron, Invoking,, mcron, GNU@tie{}mcron}). Each message is also prefixed by a timestamp by GNU Shepherd.")) (define (job-files mcron jobs) -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 15:31:03 2023 Received: (at 62169) by debbugs.gnu.org; 13 Mar 2023 19:31:03 +0000 Received: from localhost ([127.0.0.1]:35667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnss-0003Hq-Dr for submit@debbugs.gnu.org; Mon, 13 Mar 2023 15:31:03 -0400 Received: from smtpm5.myservices.hosting ([185.26.105.236]:48642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbnsr-0003HV-50 for 62169@debbugs.gnu.org; Mon, 13 Mar 2023 15:31:01 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm5.myservices.hosting (Postfix) with ESMTP id 71ECB20D7B for <62169@debbugs.gnu.org>; Mon, 13 Mar 2023 20:30:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id C6539800A1; Mon, 13 Mar 2023 20:30:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dCwzaShlIdUd; Mon, 13 Mar 2023 20:30:53 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 21A4A800A0; Mon, 13 Mar 2023 20:30:53 +0100 (CET) From: Bruno Victal To: 62169@debbugs.gnu.org Subject: [PATCH 3/3] services: mcron: Add log-file and date-format fields. Date: Mon, 13 Mar 2023 19:30:50 +0000 Message-Id: <93b9d69cf03ecb9933072b0911c1b291b4788bd6.1678735825.git.mirai@makinata.eu> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62169 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * doc/guix.texi (Scheduled Job Execution): Document it. * gnu/services/mcron.scm (mcron-configuration)[log-file, date-format]: New field. (mcron-shepherd-services): Add log-file and date-format support. Use file-append instead of string-append. --- doc/guix.texi | 6 ++++++ gnu/services/mcron.scm | 31 +++++++++++++++++++++++++------ 2 files changed, 31 insertions(+), 6 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 45d96b8fbb..6d47d36d22 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -19347,12 +19347,18 @@ Scheduled Job Execution @item @code{log?} (default: @code{#t}) (type: boolean) Log messages to standard output. +@item @code{log-file} (default: @code{"/var/log/mcron.log"}) (type: string) +Log file location. + @item @code{log-format} (default: @code{"~1@@*~a ~a: ~a~%"}) (type: string) @code{(ice-9 format)} format string for log messages. The default value produces messages like @samp{@var{pid} @var{name}: @var{message}} (@pxref{Invoking mcron, Invoking,, mcron,GNU@tie{}mcron}). Each message is also prefixed by a timestamp by GNU Shepherd. +@item @code{date-format} (type: maybe-string) +@code{(srfi srfi-19)} format string for date. + @end table @end deftp @c %end of fragment diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm index 9f3afecf62..dac213358c 100644 --- a/gnu/services/mcron.scm +++ b/gnu/services/mcron.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Ludovic Courtès ;;; Copyright © 2022 Maxim Cournoyer +;;; Copyright © 2023 Bruno Victal ;;; ;;; This file is part of GNU Guix. ;;; @@ -33,7 +34,9 @@ (define-module (gnu services mcron) mcron-configuration-mcron mcron-configuration-jobs mcron-configuration-log? + mcron-configuration-log-file mcron-configuration-log-format + mcron-configuration-date-format mcron-service-type)) @@ -55,6 +58,8 @@ (define-module (gnu services mcron) (define list-of-gexps? (list-of gexp?)) +(define-maybe/no-serialization string) + (define-configuration/no-serialization mcron-configuration (mcron (file-like mcron) @@ -70,12 +75,20 @@ (define-configuration/no-serialization mcron-configuration (boolean #t) "Log messages to standard output.") + (log-file + (string "/var/log/mcron.log") + "Log file location.") + (log-format (string "~1@*~a ~a: ~a~%") "@code{(ice-9 format)} format string for log messages. The default value produces messages like @samp{@var{pid} @var{name}: @var{message}} (@pxref{Invoking mcron, Invoking,, mcron, GNU@tie{}mcron}). -Each message is also prefixed by a timestamp by GNU Shepherd.")) +Each message is also prefixed by a timestamp by GNU Shepherd.") + + (date-format + maybe-string + "@code{(srfi srfi-19)} format string for date.")) (define (job-files mcron jobs) "Return a list of file-like object for JOBS, a list of gexps." @@ -144,7 +157,9 @@ (define (shepherd-schedule-action mcron files) (loop))))))))) (define (mcron-shepherd-services config) - (match-record config (mcron jobs log? log-format) + (match-record config (mcron jobs + log? log-file log-format + date-format) (if (eq? jobs '()) '() ; nothing to do (let ((files (job-files mcron jobs))) @@ -158,10 +173,14 @@ (define (mcron-shepherd-services config) (ice-9 match) ,@%default-modules)) (start #~(make-forkexec-constructor - (list (string-append #$mcron "/bin/mcron") + (list #$(file-append mcron "/bin/mcron") #$@(if log? - #~("--log" "--log-format" #$log-format) - #~()) + `("--log" "--log-format" ,log-format + ,@(if (maybe-value-set? date-format) + (list "--date-format" + date-format) + '())) + '()) #$@files) ;; Disable auto-compilation of the job files and @@ -172,7 +191,7 @@ (define (mcron-shepherd-services config) (remove (cut string-prefix? "PATH=" <>) (environ))) - #:log-file "/var/log/mcron.log")) + #:log-file #$log-file)) (stop #~(make-kill-destructor)) (actions (list (shepherd-schedule-action mcron files))))))))) -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:45:09 2023 Received: (at 62169) by debbugs.gnu.org; 21 Mar 2023 18:45:09 +0000 Received: from localhost ([127.0.0.1]:60599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegyr-0005C5-K0 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:45:09 -0400 Received: from mail-qv1-f41.google.com ([209.85.219.41]:44853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pegyp-0005BZ-N3 for 62169@debbugs.gnu.org; Tue, 21 Mar 2023 14:45:08 -0400 Received: by mail-qv1-f41.google.com with SMTP id 59so4567646qva.11 for <62169@debbugs.gnu.org>; Tue, 21 Mar 2023 11:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679424301; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BOvIZuP/bmDdjpccT5eF+xngfTndh0LTHgVw4lBZ1Ko=; b=b+vZKheNP4ctVJotOUyuLtI/7iL2n2MlTBfsfMD70gmR9QkVzWhf6Uwr0Wc/71z/Tn RTr56FHq9VakolQxd0Z3B8cli+GTFmsWkGrjBFqf6Tl0Gongsn5yI7YENNo2tvR4BZji AdIbki5CyMOr1NS3JJN0qXBI2xT/o7ge/o7OfA1zyvTv8kcsamTfHRkbHsUsO96T7UhX qG3F+HmWdvfpSi2hRzvmyvwtcS7HbfGyl23FgtKmCz4QrpOAKmbaLgEUe9iBn8xRthsY 9LnUOrumitQOpdRvyVwdwdIztjYxkVTtgz673njSE5n0UgrTpW5vghe9CV9VWaeMpHKD JTZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679424301; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BOvIZuP/bmDdjpccT5eF+xngfTndh0LTHgVw4lBZ1Ko=; b=yQqQl+Jujo+URbhlcNnI6GFl7sO/2PwOwlum2Xav56mxbujdcwsAMY1gQq39UmZYoL Mzau3FOpqAdcqnJHIFXZdYJI7neoWDhPqNRdEJQbTOeqQlE118nUba8X/iIyyAAOP7GY Z02BRyReK2JqYAV4WcUJM842nlPlcty7GEu5sXZVtZ6UAxyK9+z6RwNWBNtrv3BARZAg 5J7d/oXBvpAv1K7rkIxhdYC9w6+dI/3YIAjglvp1umkbRFriRQkmnioE8//KgSowSfIs 0JnzPijGxm6LyUdY9xtbttn/K/J/BvTRgo4TfMlxIXzNTdhKouaCYwKBeKLFGyX6BuaC 4ZqA== X-Gm-Message-State: AO0yUKVU8OG+6nxpsgIPVxtzBVeNSZMk8cuA8NyARkGbai7G/LgB9ODg RJt2bPaWjJDkBop1+jejASfRXGL06m8fjw== X-Google-Smtp-Source: AK7set926Nh32EHjvCGLNvRgThCZ9++85eBIN0SA9iHgbP584D4TQojEyMcit9TyQUIRsBbUIZUztQ== X-Received: by 2002:ad4:5ccd:0:b0:5a9:c758:ba0e with SMTP id iu13-20020ad45ccd000000b005a9c758ba0emr1915147qvb.16.1679424301716; Tue, 21 Mar 2023 11:45:01 -0700 (PDT) Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195]) by smtp.gmail.com with ESMTPSA id ay16-20020a05620a179000b007461e8efacbsm9839357qkb.69.2023.03.21.11.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 11:45:01 -0700 (PDT) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#62169: [PATCH 0/3] services: mcron: Make log-file and date-format configurable. References: <93b9d69cf03ecb9933072b0911c1b291b4788bd6.1678735825.git.mirai@makinata.eu> Date: Tue, 21 Mar 2023 14:45:00 -0400 In-Reply-To: <93b9d69cf03ecb9933072b0911c1b291b4788bd6.1678735825.git.mirai@makinata.eu> (Bruno Victal's message of "Mon, 13 Mar 2023 19:30:50 +0000") Message-ID: <87bkkmndub.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62169 Cc: 62169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Bruno Victal writes: > * doc/guix.texi (Scheduled Job Execution): Document it. > * gnu/services/mcron.scm (mcron-configuration)[log-file, date-format]: New field. > (mcron-shepherd-services): Add log-file and date-format support. > Use file-append instead of string-append. I've installed the first 2 patches, but was wondering about the use case for having a configurable log-file for mcron? It seems it'd be very niche to me, so perhaps it's not necessary? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 14:51:20 2023 Received: (at 62169-done) by debbugs.gnu.org; 21 Mar 2023 18:51:20 +0000 Received: from localhost ([127.0.0.1]:60614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peh4q-0005RB-49 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 14:51:20 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:36708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peh4o-0005Qy-OC for 62169-done@debbugs.gnu.org; Tue, 21 Mar 2023 14:51:19 -0400 Received: by mail-qt1-f173.google.com with SMTP id hf2so14977489qtb.3 for <62169-done@debbugs.gnu.org>; Tue, 21 Mar 2023 11:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679424673; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=nyYpiQyTZOhgMiIXBZEeRJIlu7+5u2JDNAvHNs2M6DU=; b=hFJLgtax8aIM3mchCDCNFsh7Ugf+cUBBeo3N55Tmn64ePr+/M5JJT3KxBZcZfn2Uny 3sOoPKr2tK7n2ef/NVob39b7kolt+ZWCFlMCC2UFVvsMZwSGk63PgQZHgeaf25x4IrpH PM61DcjJU1M/skCLKaYgBOVXFSBgfwGh1K+i0p0+NeJHgdRnWIZMADCrTbvNfXedMIpI Oe8Guwj7Hud46ASmqVhfkA/fhOtyqBdnOczVPSFjI0Xdpqp/LnnQpqqyvoESKZ7AkxtF 5zpV02H8C/yaT67XYYcGhDjWBWDfVoP0yYOgmvRovJtFIapjnIoeDiKN6ItxAy3VsFNa cxGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679424673; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nyYpiQyTZOhgMiIXBZEeRJIlu7+5u2JDNAvHNs2M6DU=; b=6RD95oX73RD61R5Ijnc11NLJXgwLubu2JPcR+7xHkAhRhBxb/WJz0LT+r/KCbEHxNg V+uoDO8Ox/OkvAIRw93avt9zh+kUDx1181Vtn1ZZzgcnOJPI+rjrsASqjRZkAwzh3IyX Z1amKiuo9i6uQa2YeCI8IDOXc1SC6NlwlC5Yyo0bB5TNDOkPQA1QWCJ2Ecsx/mp6a0dK OFTxO9CArKgatfKputB2NGZAzr4OLAgQ5a3uk/8out3baVSmp3FMH/C1S7+8dhsLqjrH Pk2GfH7l5Pdt5AqtowdU0vZziM6SqITas/p3KlTyQuL9uZotyWa8lGx2q024Q84R10Rs 7yUg== X-Gm-Message-State: AO0yUKUEwmSlZJO6bmRUeUqkWunxkhfXY9NRffxBM0wGnpNNpAsyMrSs YPh00lqsW6wp5g2zq8N5mUyuwp8ZdH9d/g== X-Google-Smtp-Source: AK7set/n+baDoQraF30zZj++BF2GkQB0xT4yA1Kiq3+UVHxztN35hP8Er5p33FJSie+WBnOclD081g== X-Received: by 2002:a05:622a:1a28:b0:3bf:e034:5f53 with SMTP id f40-20020a05622a1a2800b003bfe0345f53mr1485170qtb.59.1679424673002; Tue, 21 Mar 2023 11:51:13 -0700 (PDT) Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195]) by smtp.gmail.com with ESMTPSA id jr28-20020a05622a801c00b003bd0f0b26b0sm8628383qtb.77.2023.03.21.11.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 11:51:12 -0700 (PDT) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#62169: [PATCH 0/3] services: mcron: Make log-file and date-format configurable. References: <93b9d69cf03ecb9933072b0911c1b291b4788bd6.1678735825.git.mirai@makinata.eu> <87bkkmndub.fsf_-_@gmail.com> Date: Tue, 21 Mar 2023 14:51:11 -0400 In-Reply-To: <87bkkmndub.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Tue, 21 Mar 2023 14:45:00 -0400") Message-ID: <877cvandk0.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62169-done Cc: 62169-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Maxim Cournoyer writes: > Hello, > > Bruno Victal writes: > >> * doc/guix.texi (Scheduled Job Execution): Document it. >> * gnu/services/mcron.scm (mcron-configuration)[log-file, date-format]: New field. >> (mcron-shepherd-services): Add log-file and date-format support. >> Use file-append instead of string-append. > > I've installed the first 2 patches, but was wondering about the use case > for having a configurable log-file for mcron? It seems it'd be very > niche to me, so perhaps it's not necessary? Thanks for confirming the use case on #guix (see: https://logs.guix.gnu.org/guix/2023-03-21.log#194137). Installed that one as well. -- Thanks, Maxim From unknown Wed Jun 18 23:13:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Apr 2023 11:24:18 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator