GNU bug report logs - #62164
29.0.60; ediff behaves poorly by default on tiling window managers

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> janestreet.com>

Date: Mon, 13 Mar 2023 16:45:02 UTC

Severity: normal

Found in version 29.0.60

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: luangruo <at> yahoo.com, sbaugh <at> catern.com, Eli Zaretskii <eliz <at> gnu.org>, 62164 <at> debbugs.gnu.org
Subject: bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers
Date: Wed, 28 Jun 2023 15:40:55 +0200

>>>>> On Wed, 28 Jun 2023 08:55:13 -0400, Spencer Baugh <sbaugh <at> janestreet.com> said:

    Spencer> * lisp/vc/ediff-wind.el (ediff-floating-control-frame): Add
    Spencer> defcustom.
    Spencer> (ediff-frame-make-utility, ediff-setup-control-frame): Allow setting
    Spencer> the control frame up as a utility window under X. (bug#62164)

Two spaces after full stop. And I think the convention is to
capitalize 'Bug', but we donʼt follow that very consistently.

I think the new user option warrants an entry in etc/NEWS

    Spencer> ---
    Spencer>  lisp/vc/ediff-wind.el | 22 ++++++++++++++++++++++
    Spencer>  1 file changed, 22 insertions(+)

    Spencer> diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el
    Spencer> index eb903f093f9..74e0e1f9b9f 100644
    Spencer> --- a/lisp/vc/ediff-wind.el
    Spencer> +++ b/lisp/vc/ediff-wind.el
    Spencer> @@ -69,6 +69,16 @@ ediff-window-setup-function
    Spencer>  		 (function :tag "Other function"))
    Spencer>    :version "24.3")
 
    Spencer> +(defcustom ediff-floating-control-frame nil
    Spencer> +  "If not-nil, try making the control frame be floating rather than tiled.
    Spencer> +

Style: the description of the option should state the action that
follows from a non-nil value:

"Whether to request a floating control frame rather than a tiled one."

Robert
--
This bug report was last modified 1 year and 323 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.