GNU bug report logs - #62164
29.0.60; ediff behaves poorly by default on tiling window managers

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: luangruo <at> yahoo.com, sbaugh <at> catern.com, 62164 <at> debbugs.gnu.org
Subject: bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers
Date: Tue, 06 Jun 2023 14:29:10 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: luangruo <at> yahoo.com,  sbaugh <at> catern.com,  62164 <at> debbugs.gnu.org
> Date: Mon, 05 Jun 2023 17:56:38 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> Cc: Po Lu <luangruo <at> yahoo.com>, 62164 <at> debbugs.gnu.org
> >> From: Spencer Baugh <sbaugh <at> janestreet.com>
> >> Date: Tue, 09 May 2023 14:27:11 -0400
> >> 
> >> +(defcustom ediff-x-utility-control-frame nil
> >> +  "If non-nil, the control frame is a utility window under X.
> >> +
> >> +This is useful in tiling window managers, where this will cause
> >> +the control frame to be floating rather than tiled.  It should be
> >> +harmless on other well-behaved window managers."
> >
> > If this option causes the control frame to be floating rather than
> > tiled, the name of the option should reflect that.  Using "utility" in
> > the name of the variable makes the option less self-explanatory,
> > because that technical terms is not relevant on the user level.
> >
> > Thanks.
> 
> Agreed. Revised patch attached:

Thanks, but I think the first line of the doc string should also be
modified to explain better what the option does.  The rest of the doc
string could then mention "utility window", if doing so will help
someone to understand what happens and why.  But the first line should
be a concise summary, because the various apropos commands show only
that one line.

>      (modify-frame-parameters ctl-frame adjusted-parameters)
> +    (when (and ediff-x-floating-control-frame (eq window-system 'x))
> +      (ediff-frame-make-utility ctl-frame))       ^^^^^^^^^^^^^

I think it is better to use window-system the function here, since
you are talking about a specific frame.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.