From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 03:21:26 2023 Received: (at submit) by debbugs.gnu.org; 13 Mar 2023 07:21:26 +0000 Received: from localhost ([127.0.0.1]:33511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbcUn-0001wr-Mz for submit@debbugs.gnu.org; Mon, 13 Mar 2023 03:21:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:34604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbcUm-0001wg-AE for submit@debbugs.gnu.org; Mon, 13 Mar 2023 03:21:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbcUi-00064L-91 for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 03:21:20 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbcUg-0005t9-Lo for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 03:21:20 -0400 Received: by mail-ed1-x531.google.com with SMTP id er25so16496475edb.5 for ; Mon, 13 Mar 2023 00:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678692075; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=hxublV4NJjGSg7pVuZfzyH7FxcvAFKgyW+yqdFQ5+e8=; b=Rt9UU9WwBXKFOXmS8sxslCLqTEXp/7ncVQGMc1Vain/5vF5fdYFF6igSRVuCsEL00b oxlyRLmd3WU4PIhwgQAsKlk5rxB38X36s4Rt+ATXq+vlI0hQAx+FWirmcCOVEByiUHmg /e//CwcAafSYGi41IeL8srZOe9h7leCptcrDk6RGJgYTuNp3bG0Yy45WWErnkCW74Jp0 5v8Y4YWnYnrlFVKLl6p/1TonlNyMKDNqC19FyRdk1oZVlBFAilYthJzSKL2fGDXHAFuE ycKHG8B/jFha4aNxK+yoNzf3UI7stptRv/23frEn4NWM+zwQ7gJ1g0rAvLi47PU25z9m xsMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678692075; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hxublV4NJjGSg7pVuZfzyH7FxcvAFKgyW+yqdFQ5+e8=; b=Smvs8lgHEWiSD4jkGTb8i8fh8N/ywT8M3hCevKEs+YxitdcX10xdwvD5Mci2F2Rrwb Bj9DVGEZ7f0UcuRAJvfi79ZmW2ykJ+G8XPt5rpHnyqwpG7WFqr+HVagi0k8Xy7EUy40C 4vXVAXWRIai0nL86TdrgsIcWp3PFtXEcAQOBLiVyUPqhFCpHATmqMtNZRCimngTILS3Q tjrzn3/w6t+GfUoEmjYIJSeUbw6KwwDjKtq1s3HNMuE38s+ExfM2DZmBhOx7WjoW5NKg 2hbufnI/5WW+rL67ymqFzwh0rQHMxuPOm2ThKgDzqYujxbkf7/3B1/t5pVuhtsAMf2X6 ABXA== X-Gm-Message-State: AO0yUKU7tG8qa/aFhT6RaI/fX0yqfjtV12afgG47LGLWdngfdc2gS0zg yiQikw+faIz2Ru2oTyC7PUPjXKNniEVLFOMkaEv6WCQd9rQ= X-Google-Smtp-Source: AK7set/VrM50eMDlV015x2LhSnDNTFTTt0lUVDeebXiHhTeBQVzSulupajG3REIIpOCeNtyBHln4r0EbhKX2Tz7HjhU= X-Received: by 2002:a17:906:618:b0:8a6:91d9:c7ac with SMTP id s24-20020a170906061800b008a691d9c7acmr17297432ejb.5.1678692075036; Mon, 13 Mar 2023 00:21:15 -0700 (PDT) MIME-Version: 1.0 From: Pedro Andres Aranda Gutierrez Date: Mon, 13 Mar 2023 08:20:48 +0100 Message-ID: Subject: More control over the mouse behaviour in eglot To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=paaguti@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When I edit Python with eglot, mouse-1-down opens the eglot code actions menu when over a place where there is a possible action. I'd like to be able to define the mouse event to open the menu myself. In the same line, I'd like to control the items on the code actions mouse menu. -- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 11:47:57 2023 Received: (at 62157) by debbugs.gnu.org; 13 Mar 2023 15:47:57 +0000 Received: from localhost ([127.0.0.1]:35451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkOz-0003N0-3i for submit@debbugs.gnu.org; Mon, 13 Mar 2023 11:47:57 -0400 Received: from mail-oa1-f52.google.com ([209.85.160.52]:38842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkOx-0003M8-Li for 62157@debbugs.gnu.org; Mon, 13 Mar 2023 11:47:55 -0400 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-176d1a112bfso14194477fac.5 for <62157@debbugs.gnu.org>; Mon, 13 Mar 2023 08:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678722470; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WpXBpghD+BmcSovFoIwsvcbcERM8SXZYVKBEzMKA9PU=; b=WCaUbtP5178VhahvjKjXqdJUayE8Uij9Dj4RLJZFQBRwyJCAMUSXku5Pp9TFNeJ6ZM SfYKTPJEbeW0zklCcZbP0f/1ilZIcAD8zOGjRtgLeCqfU5D9UTYT6m8O+wv+Zoc2PvuG p0aIZdvkDHOlpzxszfx5aWaYw5poe44X2vvLqm3NqB8Ja6jsSRmxTTHmL/gqQ0/Ge396 H314nYOmFBQffGHiCEezSsNPNsoEuTvbbW9QSJcK+L+4/IzqPio3Cag54vBAASfscjlw kj+0X2YywDHRwVNzxbBUid4OKpuz6aHlepM5qBklcn4WwJ8C1vl5dlmw9j8N/wrkYwCu qKVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678722470; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WpXBpghD+BmcSovFoIwsvcbcERM8SXZYVKBEzMKA9PU=; b=0/OR3C6HHavtozAUMdCTQ5wA0oP7ZYr5IkTmnBSdhC7Kqds31qfjlPaPyZHa4yW+RF VwmYAqQHWz57RccOBmxGneP+dC/2Js4egvAtyEP8HJoBg7MtwzuD3Yj68ceQi/XnSECR QuyP3of6SlKGlnSKwfZs6gXFKtX+okcSyu2pDY2DCqD045bnDyozPyOu2Bdmp2xyXa8c 31sO3GbfhJhdkXDyH2J+DUHL2EypRu/s1UbOAAXLqKqm09boJxdTWHNZYD94swT/yyma 63H1pd/zk9hH5Slk73gU21cLsXKN19xCWxZ9ZJ5/H1DQtVGUtzpQPraBEB+wanYecYZb P41Q== X-Gm-Message-State: AO0yUKVKme60PhsaBu13tgmc3RITN/74DXhrfhh+9so+Ubriaq86kUas 1hWTRKJueP/t0XHRSR28cCtKj41te857XglAYqI= X-Google-Smtp-Source: AK7set+miJxT/mbHu6mnnS2YIseJIjTmDj+pku12+7EoAsbkfm+TvQ+7sItq3IJf11FbWHPF8w3Rwk7JRBpjKXeOOQM= X-Received: by 2002:a05:6870:7729:b0:176:3897:6928 with SMTP id dw41-20020a056870772900b0017638976928mr12535887oab.5.1678722469844; Mon, 13 Mar 2023 08:47:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 13 Mar 2023 15:47:38 +0000 Message-ID: Subject: Re: bug#62157: More control over the mouse behaviour in eglot To: Pedro Andres Aranda Gutierrez Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157 Cc: 62157@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Mar 13, 2023 at 7:22=E2=80=AFAM Pedro Andres Aranda Gutierrez wrote: > > When I edit Python with eglot, mouse-1-down opens the eglot code > actions menu when over a place where there is a possible action. I'd > like to be able to define the mouse event to open the menu myself. In > the same line, I'd like to control the items on the code actions mouse > menu. These are two separate requests. I'll focus on the first one, as the second one is obscure. It probablyneeds its own separate issue describing a reproducible observable example of what "item control" is desired. So, having mouse-1 for the binding to get code actions in diagnostics is indeed not good, because it prevents point from being put on a certain character using mouse-1, which should really nothappen. Currently, to configure it, the user must place a certain property on the symbols eglot-note eglot-warning eglot-error, which is not easy at all. Can you try this patch? It also changes the default binding to [mouse-2]. diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 2491c86ea5b..256b4cd93ba 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2084,15 +2084,18 @@ eglot--mode-line-format (defalias 'eglot--make-diag 'flymake-make-diagnostic) (defalias 'eglot--diag-data 'flymake-diagnostic-data) +(defvar eglot-diagnostics-map + "Map active in Eglot-backed Flymake diagnostic overlays." + (let ((map (make-sparse-keymap))) + (define-key map [mouse-1] 'eglot-code-actions-at-mouse) + map)) + (cl-loop for i from 1 for type in '(eglot-note eglot-warning eglot-error) do (put type 'flymake-overlay-control `((mouse-face . highlight) (priority . ,(+ 50 i)) - (keymap . ,(let ((map (make-sparse-keymap))) - (define-key map [mouse-1] - (eglot--mouse-call 'eglot-code-actions)) - map))))) + (keymap . ,eglot-diagnostics-map)))) ;;; Protocol implementation (Requests, notifications, etc) @@ -3335,6 +3338,9 @@ eglot-code-actions (eglot--read-execute-code-action actions server action-kind) actions))) +(defalias 'eglot-code-actions-at-mouse (eglot--mouse-call 'eglot-code-acti= ons) + "Like `eglot-code-actions', but intended for mouse events.") + (defun eglot--read-execute-code-action (actions server &optional action-ki= nd) "Helper for interactive calls to `eglot-code-actions'." (let* ((menu-items Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 12:00:00 2023 Received: (at 62157) by debbugs.gnu.org; 13 Mar 2023 16:00:00 +0000 Received: from localhost ([127.0.0.1]:35481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkad-0003gX-WF for submit@debbugs.gnu.org; Mon, 13 Mar 2023 12:00:00 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:45725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkab-0003gJ-RB for 62157@debbugs.gnu.org; Mon, 13 Mar 2023 11:59:58 -0400 Received: by mail-wm1-f46.google.com with SMTP id m18-20020a05600c3b1200b003ed2a3d635eso495942wms.4 for <62157@debbugs.gnu.org>; Mon, 13 Mar 2023 08:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678723191; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3zg9Ysl223qYHdc8NtjgZTapvZYdEN890HA3i7l/Ldw=; b=U1MRABgdd1jWPfmhLo1ddNDhEdHN5z5JWcPZ9J+62pSlhSFhxwHnJbwxSpNsndojJI Zr88qCH9XSXGwKiXV2Z1tAEU4+kW1JLky+ASZl3FWKHqMKkil+i7QWE8U/pd+hF/pP9I YG+ssteo/uLhdEPe385a1fRBNB1SUGUSwDe1V4Kl+vcxIaC1dkHTgYYQCk1K0FBic1Kf p459KOeYEkmEio7EcIu2RreNEqrFBerIW4oXUcNt2W5eHruIfPYgalMlHejXOT+owtOg s4l7t8KcrQsgaNCKXG5qj+XK0xSTdJnsdTIrRoSYgxZDDhiVm1uj0L+NN9DFY376hFmC 8RYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678723191; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3zg9Ysl223qYHdc8NtjgZTapvZYdEN890HA3i7l/Ldw=; b=QnyXUjvUQdGPp4Sd2ebhp2ZzdK6Js1dgtsN0Wzo8rnps3mfrf0QY7PnbnCdsKcyvOc XmG/dWL8z+iSgxLiAnvbLlyrFUNgyySFEMOFiVVNMnemnfOjfKpnR+w9IrU3Rw5n9LEl NePZmBNNFjjxL/J3RkLQwAtGugVRVTgOXv+9pxZffLFqn1fyTaelpSEPwUVNkb112YFU N/A9LZloo5wvpHj2BradT1P6o/4zkk6GHEzYkkmvRkE9C3neGFo9rnEZrctPaeCgkArA ll+qRvXuCBbEisUvCatFwBx93Pn5uwq59m4xFD1Vd40BdTED2pSx0CpM2BG7ec+vw9El o4rQ== X-Gm-Message-State: AO0yUKULD1sekeXTrhd8HppUxPprXgRXzxJW4UNAZi8BjB4cP90bQn6i 0EWntz7tAvx49vQdpc6oVKQn5Ajg2sA= X-Google-Smtp-Source: AK7set/6ZyDeF7ab11YrQLZaN01H8l6U9wu+R53QYiX7BpvvTaDKDQ7NT+JajtNLUHLco/mr+7MGqA== X-Received: by 2002:a05:600c:4e4f:b0:3eb:2de8:b74e with SMTP id e15-20020a05600c4e4f00b003eb2de8b74emr11231767wmq.27.1678723191278; Mon, 13 Mar 2023 08:59:51 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v6-20020a05600c444600b003df7b40f99fsm162411wmn.11.2023.03.13.08.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 08:59:50 -0700 (PDT) From: Robert Pluim To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#62157: More control over the mouse behaviour in eglot In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 13 Mar 2023 15:47:38 +0000") References: Date: Mon, 13 Mar 2023 16:59:50 +0100 Message-ID: <87lek0vdzd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157 Cc: 62157@debbugs.gnu.org, Pedro Andres Aranda Gutierrez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 13 Mar 2023 15:47:38 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> Can you try this patch? It also changes the default binding= to Jo=C3=A3o> [mouse-2]. I think you meant 'mouse-2', but you typed 'mouse-1' in the patch. Jo=C3=A3o> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.= el Jo=C3=A3o> index 2491c86ea5b..256b4cd93ba 100644 Jo=C3=A3o> --- a/lisp/progmodes/eglot.el Jo=C3=A3o> +++ b/lisp/progmodes/eglot.el Jo=C3=A3o> @@ -2084,15 +2084,18 @@ eglot--mode-line-format Jo=C3=A3o> (defalias 'eglot--make-diag 'flymake-make-diagnostic) Jo=C3=A3o> (defalias 'eglot--diag-data 'flymake-diagnostic-data) Jo=C3=A3o> +(defvar eglot-diagnostics-map Jo=C3=A3o> + "Map active in Eglot-backed Flymake diagnostic overlays." Jo=C3=A3o> + (let ((map (make-sparse-keymap))) Jo=C3=A3o> + (define-key map [mouse-1] 'eglot-code-actions-at-mouse) Jo=C3=A3o> + map)) Jo=C3=A3o> + I=CA=BCm guessing eglot is not yet using `defvar-keymap' because of backwards compatibility? In any case, this doesn=CA=BCt make the binding easily changable, you have to manually unset/set the `eglot-code-actions-at-mouse' binding. My attempt to fix this descended into a circular dependency spiral between the keymap and the key defcustom, so I=CA=BCm hoping you know a good way to do it :-) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 12:10:19 2023 Received: (at 62157) by debbugs.gnu.org; 13 Mar 2023 16:10:19 +0000 Received: from localhost ([127.0.0.1]:35497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkkd-0003xt-1n for submit@debbugs.gnu.org; Mon, 13 Mar 2023 12:10:19 -0400 Received: from mail-oa1-f41.google.com ([209.85.160.41]:45950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkkZ-0003xf-Rv for 62157@debbugs.gnu.org; Mon, 13 Mar 2023 12:10:17 -0400 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-17711f56136so14242420fac.12 for <62157@debbugs.gnu.org>; Mon, 13 Mar 2023 09:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678723810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8mZLTpSbkRPG+bKx2Ya5JhG5Ex+/vDHNdtzI7frjpl4=; b=UrEdKqkBh62elOS9HxQpyK4AA7sMgLPIopJu+B4yO7UWa35JgJtixhsDO8W1zukFLZ /EmaopI/nwMCo7s3IJjK650gzOqJtlKZcSsxKeYY8kkYXfaEdlv8hedKoDgOT613P5NW wILQMHCMKvrMm4GcEDTICFg/b3WGAQD/vBy6yZNYsPoXRrypP/0aiNvhMat1uLRdCvu2 Q0E3qVWSjGDHHOpoQLfW3Im8FG9NNuvhj3Yo6neqJwW1zId7LLg5gvo7/hLLEZhjhcaf ybEUyEeL3fPQ62GOok0paVcVegD46FAvveBxY183H8SZ1fNJAmD6xTnvEzyTLpqSbRVb C+cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678723810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8mZLTpSbkRPG+bKx2Ya5JhG5Ex+/vDHNdtzI7frjpl4=; b=wLtTGzNbyo9rcozSspph5nIliVlXrh2u9KZrrTBED1wuMTL29OUZVMvpyA5LG8zFrE vufo/dYd7XuJ2DIdfc45i/N3fqe0cYDlZYMJsPN51ZV28YyxplgHrET8CWivWgrXQMci 9d6SGMxEFQI38GkRFQjGOcQ+QRyNrIyKhQ+rPQL8UiWU/hc7Kx7qmtyB1tPw6UWhJ0KB CaSKfLAxEorIplW74gRxgHdkQf0GuPb8nfbsNi+hbFYIgSoaWfwmiFUIezaY6BH+RuqA D3YNJP5uzpH1YrPcxClplavfJZYh5tCM6halOwezOCpWElgLih7vekgj8CzP+dL2mvaN qqkA== X-Gm-Message-State: AO0yUKU1+bHuaiX5rVE0yGnjN9jkx1YkUrKdo1k3dANgNwM/Su+eHIPT S/L+cCiPSifFEWb9ZPU813bxLEQgliGlOuVT5bA= X-Google-Smtp-Source: AK7set8REEgr2i0MqefXR5pbSYmLoOZbuxbM/WTITGd0xMclSZs1MWGVe/FH0JbQ3VlVPLTJVa5jyx/SE/oo6GUQD4o= X-Received: by 2002:a05:6871:6bb0:b0:176:2915:6451 with SMTP id zh48-20020a0568716bb000b0017629156451mr12475349oab.5.1678723810081; Mon, 13 Mar 2023 09:10:10 -0700 (PDT) MIME-Version: 1.0 References: <87lek0vdzd.fsf@gmail.com> In-Reply-To: <87lek0vdzd.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 13 Mar 2023 16:09:59 +0000 Message-ID: Subject: Re: bug#62157: More control over the mouse behaviour in eglot To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157 Cc: 62157@debbugs.gnu.org, Pedro Andres Aranda Gutierrez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Mar 13, 2023 at 3:59=E2=80=AFPM Robert Pluim wro= te: > > >>>>> On Mon, 13 Mar 2023 15:47:38 +0000, Jo=C3=A3o T=C3=A1vora said: > Jo=C3=A3o> Can you try this patch? It also changes the default bindi= ng to > Jo=C3=A3o> [mouse-2]. > > I think you meant 'mouse-2', but you typed 'mouse-1' in the patch. Yes, sorry. > Jo=C3=A3o> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglo= t.el > Jo=C3=A3o> index 2491c86ea5b..256b4cd93ba 100644 > Jo=C3=A3o> --- a/lisp/progmodes/eglot.el > Jo=C3=A3o> +++ b/lisp/progmodes/eglot.el > Jo=C3=A3o> @@ -2084,15 +2084,18 @@ eglot--mode-line-format > Jo=C3=A3o> (defalias 'eglot--make-diag 'flymake-make-diagnostic) > Jo=C3=A3o> (defalias 'eglot--diag-data 'flymake-diagnostic-data) > > Jo=C3=A3o> +(defvar eglot-diagnostics-map > Jo=C3=A3o> + "Map active in Eglot-backed Flymake diagnostic overlays= ." > Jo=C3=A3o> + (let ((map (make-sparse-keymap))) > Jo=C3=A3o> + (define-key map [mouse-1] 'eglot-code-actions-at-mous= e) > Jo=C3=A3o> + map)) > Jo=C3=A3o> + > > I=CA=BCm guessing eglot is not yet using `defvar-keymap' because of > backwards compatibility? I'd think so yes. > In any case, this doesn=CA=BCt make the binding easily changable, you hav= e > to manually unset/set the `eglot-code-actions-at-mouse' binding. My > attempt to fix this descended into a circular dependency spiral > between the keymap and the key defcustom, so I=CA=BCm hoping you know a > good way to do it :-) A key defcustom isn't needed IMO. You may even want multiple bindings there. 99% percent of users will like the default bindings, the others can (define-key eglot-diagnostics-map [mouse-2] nil) or (unbind-key [mouse-1] eglot-diagnostics-map) which I don't know if exists in older Emacsen. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 12:37:07 2023 Received: (at 62157) by debbugs.gnu.org; 13 Mar 2023 16:37:07 +0000 Received: from localhost ([127.0.0.1]:35517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pblAZ-0004cA-9g for submit@debbugs.gnu.org; Mon, 13 Mar 2023 12:37:07 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:35534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pblAX-0004bg-Ed for 62157@debbugs.gnu.org; Mon, 13 Mar 2023 12:37:06 -0400 Received: by mail-wm1-f43.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso11392305wmb.0 for <62157@debbugs.gnu.org>; Mon, 13 Mar 2023 09:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678725419; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eDJ0NUVnCbUCyT4leGF57M/W6BtUK/B0+PJhHHyn99Q=; b=ikdnXMba0hDL81fJibcbKqjHgN8J302S3sMT4zHmBmIZPAdE0PmLkPxtAv7ckwD5vZ zOjTYUbruGX+P7NWkYmaRQmkiX6HVCd1+FlLwg5NHudTfA2c37a95opdDDUlduo6RU09 VLAOeFvToCALiVaKDqjsZB/Rt2NS2WVnyh8uehwGSc9ZTmUyKJpBPB49mt+Sls4AAAp4 axcHWWwenhK3oX4ifTaAGrzz5H4EoRCd2Z3V/pTNI7kvKhA3CXH5myahstFPUGIPM5II ucrs69YrrDtjaP1cFsjTERJq7srzoJLhoUGRM080OOoa7UGhiXwK6//Fs04nOXugWyQI afFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678725419; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eDJ0NUVnCbUCyT4leGF57M/W6BtUK/B0+PJhHHyn99Q=; b=iXrGIHJ1zu/QndwO0BFzVNoGIDYFiTvG3/T0OJVCvi+QumIUwofNVZaI8MEg8jNPM+ kuS+SCFgoOdWCt8TPBWsPuVul+IAMjaMdjrJFPce8LUMzLSOdNuPTqpRbbrQVJFRXlY+ GPLtA1Vc+h8SsiAFy2ru9fZuCYz/AcZJOm3dVWsihBrJ0a82hkY+/0FTLnOHtpcAmLlD uF0R8l/aHcY4P6eKmSYCBFKDZsh/m/zEc38wwh0ztzKkZrPomHLGM/zMMQxy4/AVJ3ni 28b3iObSKGpuRTKFiyNGIJnW1ebe/bL1OUGTYH1uLjAAP8fyhoI9MCA2YFnEcQjnbv1j jIoQ== X-Gm-Message-State: AO0yUKVEkeB6CyVoRPor1Cvnihfq0rYF7aYhwr7ZKg6GkAlvykRR9qZ7 MzMA/qepoXJQl+F1TbjUaGk= X-Google-Smtp-Source: AK7set/DheLdQWuYcjp8Uczv2sOjI09pFXYZJqHTrDMK4fFEABdCHph0RW5EJOzpFbOW8Weq7h3EcA== X-Received: by 2002:a1c:f213:0:b0:3ea:d611:f8 with SMTP id s19-20020a1cf213000000b003ead61100f8mr12351209wmc.38.1678725419156; Mon, 13 Mar 2023 09:36:59 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id k28-20020a05600c1c9c00b003e209b45f6bsm262527wms.29.2023.03.13.09.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 09:36:58 -0700 (PDT) From: Robert Pluim To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#62157: More control over the mouse behaviour in eglot In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 13 Mar 2023 16:09:59 +0000") References: <87lek0vdzd.fsf@gmail.com> Date: Mon, 13 Mar 2023 17:36:58 +0100 Message-ID: <87h6uovc9h.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157 Cc: 62157@debbugs.gnu.org, Pedro Andres Aranda Gutierrez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 13 Mar 2023 16:09:59 +0000, Jo=C3=A3o T=C3=A1vora said: >> In any case, this doesn=CA=BCt make the binding easily changable, yo= u have >> to manually unset/set the `eglot-code-actions-at-mouse' binding. My >> attempt to fix this descended into a circular dependency spiral >> between the keymap and the key defcustom, so I=CA=BCm hoping you kno= w a >> good way to do it :-) Jo=C3=A3o> A key defcustom isn't needed IMO. You may even want multiple Jo=C3=A3o> bindings there. 99% percent of users will like the default Jo=C3=A3o> bindings, the others can OK. We can always add it if people ask for it. Jo=C3=A3o> (define-key eglot-diagnostics-map [mouse-2] nil) Jo=C3=A3o> or Jo=C3=A3o> (unbind-key [mouse-1] eglot-diagnostics-map) Jo=C3=A3o> which I don't know if exists in older Emacsen. I think it=CA=BCs an emacs-29 thing. Although it does look kind of redundant with `keymap-unset' (which is also new in emacs-29) :-) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 20:22:58 2023 Received: (at 62157-done) by debbugs.gnu.org; 12 Sep 2023 00:22:59 +0000 Received: from localhost ([127.0.0.1]:55392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfrBC-0001Dt-Ho for submit@debbugs.gnu.org; Mon, 11 Sep 2023 20:22:58 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:54555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfrB6-0001DX-Be for 62157-done@debbugs.gnu.org; Mon, 11 Sep 2023 20:22:57 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bce552508fso83166301fa.1 for <62157-done@debbugs.gnu.org>; Mon, 11 Sep 2023 17:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694478162; x=1695082962; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=EdTD9RoolnVOy4ipKRuaZ4SWBS3jQerPf6tF/ouMJB8=; b=rdCSGt+cKo15TcBxv9f8uKASPlW9dvw3dRj2mB0dvWteckWhbJ2wy87qfYrio3LYR2 +PGPSnDIeqMj2Zh6BmkCzoBpcX2Pxziwi/2JPM6L+YIVG87TjwUs3GqeBBWnRem4b0ER JtLtliV0vh4tN8/NqS7k7iTRoMiJ/w8ZeaWUEdjBSjMJhFc+frwinPCI9WXViJGxa8f8 Xp8EwOdJSxq7ktdkOUR5rO8L8hqgOObjwgm+v+dhJkBWbfmfwvbwl/0TCbaHV98VLP8p PA53kbzJkGup4H60q8JoexLAV8ZtNFP+YrZAea0MJHFZlTPGT9nmKxbGADW0xn9BgrHR LU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694478162; x=1695082962; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EdTD9RoolnVOy4ipKRuaZ4SWBS3jQerPf6tF/ouMJB8=; b=Z2M4VajnKnpRZ0BNBtx5DZBhDL7MDV17hZQFnrm+YkflDi/mho7RdUipTQeRDes/hQ gUygbTeelLaMCFLh1LybyMM8fMgaRcJz8uxkSGr8xHPjdAzLLbvIsHU3wH98D4gl8lZ6 WEOxaFDKbalsWyKBADdCN7VnBboqfg/Q9TE/HdwkaGPnnQmA7XnusJNRLr1fNhRQGQ4A z8a/n8dWEhCC4iT/7VmQJsy0Gegi+xBwkb/kVRN4Mi9MNujwbT2yhAkYMDADzyx+qdB2 IJT8gfeZqCgPrxt5AfpKAU61y3sLeF/8SCZoSHeHkE2r7Ms5A9PeOIwK/nvRGl2i5EXJ zB3w== X-Gm-Message-State: AOJu0Yyg2OSUGEPZG78ef0HhT95W4PMzoPnjSY8JM6f96g3TA3I4Dfpn NEiH1G1Akq/MQpFIHA9MbtpPZtEYnkj5G9qB9mU= X-Google-Smtp-Source: AGHT+IHExOh3FK1/M1iZ8yLjKdXuwg2uKjTnET3Nb7Z2OM3f61hhk8SqkbNDwCZIF/Wk8Bi6BnQa9pGpDb39xbF6yQU= X-Received: by 2002:a2e:9ecd:0:b0:2ba:7fc2:cc4c with SMTP id h13-20020a2e9ecd000000b002ba7fc2cc4cmr8306459ljk.24.1694478161827; Mon, 11 Sep 2023 17:22:41 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Sep 2023 17:22:41 -0700 From: Stefan Kangas In-Reply-To: =?UTF-8?Q?=3CCALDnm51QuXJwkJqMq4ZtLAz2i=2DVOeF=2DFYxO4cvtP5r=2B2gP?= =?UTF-8?Q?BXnA=40mail=2Egmail=2Ecom=3E_=28=22Jo=C3=A3o_T=C3=A1vora=22=27s_message_of_=22Mon=2C_13_?= =?UTF-8?Q?Mar_2023_15=3A47=3A38_=2B0000=22=29?= References: MIME-Version: 1.0 Date: Mon, 11 Sep 2023 17:22:41 -0700 Message-ID: Subject: Re: bug#62157: More control over the mouse behaviour in eglot To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157-done Cc: 62157-done@debbugs.gnu.org, Pedro Andres Aranda Gutierrez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > On Mon, Mar 13, 2023 at 7:22=E2=80=AFAM Pedro Andres Aranda Gutierrez > wrote: >> >> When I edit Python with eglot, mouse-1-down opens the eglot code >> actions menu when over a place where there is a possible action. I'd >> like to be able to define the mouse event to open the menu myself. In >> the same line, I'd like to control the items on the code actions mouse >> menu. > > These are two separate requests. I'll focus on the first one, > as the second one is obscure. It probablyneeds its own separate > issue describing a reproducible observable example of what "item > control" is desired. > > So, having mouse-1 for the binding to get code actions in diagnostics > is indeed not good, because it prevents point from being put on > a certain character using mouse-1, which should really nothappen. > > Currently, to configure it, the user must place a certain property on > the symbols eglot-note eglot-warning eglot-error, which is not > easy at all. > > Can you try this patch? It also changes the default binding to > [mouse-2]. > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 2491c86ea5b..256b4cd93ba 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -2084,15 +2084,18 @@ eglot--mode-line-format > (defalias 'eglot--make-diag 'flymake-make-diagnostic) > (defalias 'eglot--diag-data 'flymake-diagnostic-data) > > +(defvar eglot-diagnostics-map > + "Map active in Eglot-backed Flymake diagnostic overlays." > + (let ((map (make-sparse-keymap))) > + (define-key map [mouse-1] 'eglot-code-actions-at-mouse) > + map)) > + > (cl-loop for i from 1 > for type in '(eglot-note eglot-warning eglot-error) > do (put type 'flymake-overlay-control > `((mouse-face . highlight) > (priority . ,(+ 50 i)) > - (keymap . ,(let ((map (make-sparse-keymap))) > - (define-key map [mouse-1] > - (eglot--mouse-call > 'eglot-code-actions)) > - map))))) > + (keymap . ,eglot-diagnostics-map)))) > > > ;;; Protocol implementation (Requests, notifications, etc) > @@ -3335,6 +3338,9 @@ eglot-code-actions > (eglot--read-execute-code-action actions server action-kind) > actions))) > > +(defalias 'eglot-code-actions-at-mouse (eglot--mouse-call 'eglot-code-ac= tions) > + "Like `eglot-code-actions', but intended for mouse events.") > + > (defun eglot--read-execute-code-action (actions server &optional action-= kind) > "Helper for interactive calls to `eglot-code-actions'." > (let* ((menu-items > > Jo=C3=A3o It seems like the fix was the patch above, which IIUC has been installed. I'm therefore closing this bug report. If this conclusion is incorrect and this is still an issue, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 01:23:24 2023 Received: (at 62157-done) by debbugs.gnu.org; 12 Sep 2023 05:23:24 +0000 Received: from localhost ([127.0.0.1]:55706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfvrv-0000Ox-TD for submit@debbugs.gnu.org; Tue, 12 Sep 2023 01:23:24 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:49595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfvrq-0000Of-A5 for 62157-done@debbugs.gnu.org; Tue, 12 Sep 2023 01:23:22 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-31f737b8b69so4716857f8f.3 for <62157-done@debbugs.gnu.org>; Mon, 11 Sep 2023 22:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694496188; x=1695100988; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PLJjUcBqQ48zCehbSnx6jdD5W0AYGamyWPu90hGnIAU=; b=DlOMINCC36mq3Y8ZEVdmeLpHjZiO6dFXgLVBvHvlIFwCPv9ohvlGIykALmyVPEPo17 wg3Hb1wAZAmZV1czSs4/G1zMsYpz+Gm/GVTJnolsTEx1xtFvH+AyNDixeqWlNSyc6ktW t6yKRTXFaCnIz8KORfYj0x3ZSIUdiGRMd6WWMJU9wUcdA2IUzj0FRZBowVcOhsvghDi2 3xGy+FdE/Mgdt8LZiOgRIax4/YgkB3qqMSZAL4m2z/MklNVuGtqy/SpKBlNefgXDW5vY eU3pkMSM+C8xQfVTXIjb77huX3Fb64R9It28GG/A3esYunX9dFVOuxtUTa/n6QnmGK94 rZpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694496188; x=1695100988; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PLJjUcBqQ48zCehbSnx6jdD5W0AYGamyWPu90hGnIAU=; b=cq2d0nZZQEJMmoFr8egNnLbduh355SnQGm7QxJpV2PBgw7jrdjgf9x8PVOsFRiw5Hn M35OURtyKXDfPB10LOOpTqKs2Yrx5JvNJ3ZJkjw4vzWOOAoamTdxbvNFYprgblrHgeEu UwJVxYOzewe1p2WpTExdQnvjnbVwT54lMYwTNjgC2cQcMDeyjMj25PchGb41ml6woPVj Ef6dHqlPoRDYsxQd1yIXg/lkzfzSBykKvcY9El15jV0HORpeh3dn/m70Q2p2KM5kHXsH BeaqyOLuDPz56tW5RXHD4ZwOb2QLuArkbbtXncf1rkZ+iBGdbEyFCBkq9uD9S/6SKK8p CBSQ== X-Gm-Message-State: AOJu0YwPJFjqI2hwIMeTc4xk53s2/+rvQiwM4FhVtg5stmblzZKYUBx2 aS5NNj40McacMsZUjY1Yabw= X-Google-Smtp-Source: AGHT+IEHMgWuItPRUzE2+XjXPeXxXK7cUEWZPeLb1m7xz9PW7TEDiiXfwgy9E/Pz4gLjKnIIFJdtog== X-Received: by 2002:a5d:6184:0:b0:314:32b6:af3 with SMTP id j4-20020a5d6184000000b0031432b60af3mr8892086wru.5.1694496187491; Mon, 11 Sep 2023 22:23:07 -0700 (PDT) Received: from smtpclient.apple (138.red-79-148-94.dynamicip.rima-tde.net. [79.148.94.138]) by smtp.gmail.com with ESMTPSA id d10-20020adfe84a000000b003177f57e79esm11811789wrn.88.2023.09.11.22.23.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2023 22:23:07 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_F60F27EC-9DE2-4DCC-B90C-8A7577990972"; protocol="application/pkcs7-signature"; micalg=sha-256 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: bug#62157: More control over the mouse behaviour in eglot From: Pedro Andres Aranda Gutierrez In-Reply-To: Date: Tue, 12 Sep 2023 07:23:05 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Stefan Kangas X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157-done Cc: 62157-done@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_F60F27EC-9DE2-4DCC-B90C-8A7577990972 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Just to confirm that the issue was solved (at least for me) /PA > El 12 sept 2023, a las 2:22, Stefan Kangas = escribi=C3=B3: >=20 > Jo=C3=A3o T=C3=A1vora writes: >=20 >> On Mon, Mar 13, 2023 at 7:22=E2=80=AFAM Pedro Andres Aranda Gutierrez >> wrote: >>>=20 >>> When I edit Python with eglot, mouse-1-down opens the eglot code >>> actions menu when over a place where there is a possible action. I'd >>> like to be able to define the mouse event to open the menu myself. = In >>> the same line, I'd like to control the items on the code actions = mouse >>> menu. >>=20 >> These are two separate requests. I'll focus on the first one, >> as the second one is obscure. It probablyneeds its own separate >> issue describing a reproducible observable example of what "item >> control" is desired. >>=20 >> So, having mouse-1 for the binding to get code actions in diagnostics >> is indeed not good, because it prevents point from being put on >> a certain character using mouse-1, which should really nothappen. >>=20 >> Currently, to configure it, the user must place a certain property on >> the symbols eglot-note eglot-warning eglot-error, which is not >> easy at all. >>=20 >> Can you try this patch? It also changes the default binding to >> [mouse-2]. >>=20 >> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el >> index 2491c86ea5b..256b4cd93ba 100644 >> --- a/lisp/progmodes/eglot.el >> +++ b/lisp/progmodes/eglot.el >> @@ -2084,15 +2084,18 @@ eglot--mode-line-format >> (defalias 'eglot--make-diag 'flymake-make-diagnostic) >> (defalias 'eglot--diag-data 'flymake-diagnostic-data) >>=20 >> +(defvar eglot-diagnostics-map >> + "Map active in Eglot-backed Flymake diagnostic overlays." >> + (let ((map (make-sparse-keymap))) >> + (define-key map [mouse-1] 'eglot-code-actions-at-mouse) >> + map)) >> + >> (cl-loop for i from 1 >> for type in '(eglot-note eglot-warning eglot-error) >> do (put type 'flymake-overlay-control >> `((mouse-face . highlight) >> (priority . ,(+ 50 i)) >> - (keymap . ,(let ((map (make-sparse-keymap))) >> - (define-key map [mouse-1] >> - (eglot--mouse-call >> 'eglot-code-actions)) >> - map))))) >> + (keymap . ,eglot-diagnostics-map)))) >>=20 >>=20 >> ;;; Protocol implementation (Requests, notifications, etc) >> @@ -3335,6 +3338,9 @@ eglot-code-actions >> (eglot--read-execute-code-action actions server action-kind) >> actions))) >>=20 >> +(defalias 'eglot-code-actions-at-mouse (eglot--mouse-call = 'eglot-code-actions) >> + "Like `eglot-code-actions', but intended for mouse events.") >> + >> (defun eglot--read-execute-code-action (actions server &optional = action-kind) >> "Helper for interactive calls to `eglot-code-actions'." >> (let* ((menu-items >>=20 >> Jo=C3=A3o >=20 > It seems like the fix was the patch above, which IIUC has been > installed. I'm therefore closing this bug report. >=20 > If this conclusion is incorrect and this is still an issue, please = reply > to this email (use "Reply to all" in your email client) and we can > reopen the bug report. --Apple-Mail=_F60F27EC-9DE2-4DCC-B90C-8A7577990972 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCDmcw ggbaMIIEwqADAgECAhBFXzrhXCHNulRPgqpHUevbMA0GCSqGSIb3DQEBCwUAMDsxCzAJBgNVBAYT AkVTMREwDwYDVQQKDAhGTk1ULVJDTTEZMBcGA1UECwwQQUMgUkFJWiBGTk1ULVJDTTAeFw0xNDEw MjgxMTQ4NThaFw0yOTEwMjgxMTQ4NThaMEsxCzAJBgNVBAYTAkVTMREwDwYDVQQKDAhGTk1ULVJD TTEOMAwGA1UECwwFQ2VyZXMxGTAXBgNVBAMMEEFDIEZOTVQgVXN1YXJpb3MwggEiMA0GCSqGSIb3 DQEBAQUAA4IBDwAwggEKAoIBAQCdIAQmLfstaTDL2ZN/peWu1HBy75S+RWvlj7IL+bozhiWvhvHA 2Nu2P77xvokFpv3DIeGS1VIgFr52JiF+wexZVaCQ6VLM0g+pM8o6aNi0vdQm6hbcBukM1kkRUWAS iWQKDnXBcoyM7s7kJ8nAgDeJXZ9t55HhgA6az/WaqbQtKStaLDCVgX1Wfxqqv94CdP93wp1gLln/ 0xzVrNYdY3vMnoxN25n09xWMybvSK+IdqiGARS73v1vLbdpzHr2ruos+MeRigaF/Z+3W1CpiaOz2 JyDA+GvMvLLXPNdjLQeh4WezhuLY34wFOal/+Lwdk4roHLcxLZSUKyNeEeHNqbBHAgMBAAGjggLI MIICxDASBgNVHRMBAf8ECDAGAQH/AgEAMA4GA1UdDwEB/wQEAwIBBjAdBgNVHQ4EFgQUsdRPxCN5 +kQFCcbrOc/oNbC4IGQwgZgGCCsGAQUFBwEBBIGLMIGIMEkGCCsGAQUFBzABhj1odHRwOi8vb2Nz cGZubXRyY21jYS5jZXJ0LmZubXQuZXMvb2NzcGZubXRyY21jYS9PY3NwUmVzcG9uZGVyMDsGCCsG AQUFBzAChi9odHRwOi8vd3d3LmNlcnQuZm5tdC5lcy9jZXJ0cy9BQ1JBSVpGTk1UUkNNLmNydDAf BgNVHSMEGDAWgBT3fcX9xOiaG3dkp/UdoMy/h2CabTCB6wYDVR0gBIHjMIHgMIHdBgRVHSAAMIHU MCkGCCsGAQUFBwIBFh1odHRwOi8vd3d3LmNlcnQuZm5tdC5lcy9kcGNzLzCBpgYIKwYBBQUHAgIw gZkMgZZTdWpldG8gYSBsYXMgY29uZGljaW9uZXMgZGUgdXNvIGV4cHVlc3RhcyBlbiBsYSBEZWNs YXJhY2nDs24gZGUgUHLDoWN0aWNhcyBkZSBDZXJ0aWZpY2FjacOzbiBkZSBsYSBGTk1ULVJDTSAo IEMvIEpvcmdlIEp1YW4sIDEwNi0yODAwOS1NYWRyaWQtRXNwYcOxYSkwgdQGA1UdHwSBzDCByTCB xqCBw6CBwIaBkGxkYXA6Ly9sZGFwZm5tdC5jZXJ0LmZubXQuZXMvQ049Q1JMLE9VPUFDJTIwUkFJ WiUyMEZOTVQtUkNNLE89Rk5NVC1SQ00sQz1FUz9hdXRob3JpdHlSZXZvY2F0aW9uTGlzdDtiaW5h cnk/YmFzZT9vYmplY3RjbGFzcz1jUkxEaXN0cmlidXRpb25Qb2ludIYraHR0cDovL3d3dy5jZXJ0 LmZubXQuZXMvY3Jscy9BUkxGTk1UUkNNLmNybDANBgkqhkiG9w0BAQsFAAOCAgEAjD0otOB+DfNu XNpcdz2AZB5O6RK4yeay/yuAoHg9hEwsZYsv3PFjK+fdUkHbr/wXC4yahPIJ1F1Wop75gmbAhV6c XuqD53xGjn5f5mPtq2LvRk4nYZWBvU0CPak0D5n55mtWlQOffUv7fOJOEu+kC0S1PHoBMVsmYSCS lHUCdtbO+6zDBQgxQGylHTaeIIjOoIlWba7ZTL2QfD52IElG7BVimkFlq+CfsQI0768p4gApmZ75 Yx3RlBOGQNFgjEUXBiFYWhzVMT4t/SdVsRrmP+/qhVxq4/7Z3IuMf+tN1WGHgucj8Mo8Yod25Dyp e6FvGBsiK7yMFP/Sfd1ZA8UHei736weWVP25JRUau0r4rKOAYsfmh7yLgY5sfsYlS2GRTARjMaKO D9aYq+b6ODSCeVZPseJTQrh8RaV0gGX2c1qHXbJI9U3rer/yQJdLclHxwzzZl6zMtWe0+zriK1XZ YquSs0D4u27hn9RNjiW4f4hF6+j2t5Prv3QxC9isLCNKy40Ph9cjzr+YYRIa+FvAQKamF7wv+NXS 5nTXIjmaaCF50Gvlaoq/rgSYhc0VVnbf6aHxEUKCo9mxq1VpWgFCrUV686E8yMS/GIyDM9e97YDe BKaeD9QoNwobMVvIv695JmF0/zniY+Tcg8QJhkQ2oBhZeMGW2bxQNGZQG3XCmBEwggeFMIIGbaAD AgECAhBym0P6CZbA1l2Rrl7nrL+xMA0GCSqGSIb3DQEBCwUAMEsxCzAJBgNVBAYTAkVTMREwDwYD VQQKDAhGTk1ULVJDTTEOMAwGA1UECwwFQ2VyZXMxGTAXBgNVBAMMEEFDIEZOTVQgVXN1YXJpb3Mw HhcNMTkwOTMwMDcyNzI2WhcNMjMwOTMwMDcyNzI2WjCBjTELMAkGA1UEBhMCRVMxGDAWBgNVBAUT D0lEQ0VTLTAyODY5NjI0WTEVMBMGA1UEKgwMUEVEUk8gQU5EUkVTMRkwFwYDVQQEDBBBUkFOREEg R1VUSUVSUkVaMTIwMAYDVQQDDClBUkFOREEgR1VUSUVSUkVaIFBFRFJPIEFORFJFUyAtIDAyODY5 NjI0WTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALKIWd1HAN85o1tewI1uNPYNC6sX R6Xgf2Gm+qJcf7aoWmFK7k+Ae2R4x5cWi44vNt+kjfZzvE4EB9TCN89N1YVggUy4jX8gUQ3vsD5W 7ldpSquSSqIt8lKrjHqzEKvkpOHMZCzmwFjVRvnTTJyW3Yzug0gYH2+yKLzC0KSKt6SFGnro3dBW zan27FU7rzlIL8cw4x/c0wrWCXW4I7uNFyMYpSLmL/mFlUCRcU3pLAZQsTFvasenqV6CXEFj/EMu 1t0wpOcSHOqzJ03h4605klNGdcfjFkzvzobOERlAdn609RNSGJxlsBIQ/VjXEqfb3o0z3VRSIOB9 vw4hB7ffc1sCAwEAAaOCBCAwggQcMIGJBgNVHREEgYEwf4ERcGFhZ3V0aUBnbWFpbC5jb22kajBo MRgwFgYJKwYBBAGsZgEEDAkwMjg2OTYyNFkxGDAWBgkrBgEEAaxmAQMMCUdVVElFUlJFWjEVMBMG CSsGAQQBrGYBAgwGQVJBTkRBMRswGQYJKwYBBAGsZgEBDAxQRURSTyBBTkRSRVMwDAYDVR0TAQH/ BAIwADAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMCMB0GA1Ud DgQWBBSkIHic+505pugVyHm98OzsXW/3eDAfBgNVHSMEGDAWgBSx1E/EI3n6RAUJxus5z+g1sLgg ZDCBggYIKwYBBQUHAQEEdjB0MD0GCCsGAQUFBzABhjFodHRwOi8vb2NzcHVzdS5jZXJ0LmZubXQu ZXMvb2NzcHVzdS9PY3NwUmVzcG9uZGVyMDMGCCsGAQUFBzAChidodHRwOi8vd3d3LmNlcnQuZm5t dC5lcy9jZXJ0cy9BQ1VTVS5jcnQwggEVBgNVHSAEggEMMIIBCDCB+gYKKwYBBAGsZgMKATCB6zAp BggrBgEFBQcCARYdaHR0cDovL3d3dy5jZXJ0LmZubXQuZXMvZHBjcy8wgb0GCCsGAQUFBwICMIGw DIGtQ2VydGlmaWNhZG8gY3VhbGlmaWNhZG8gZGUgZmlybWEgZWxlY3Ryw7NuaWNhLiBTdWpldG8g YSBsYXMgY29uZGljaW9uZXMgZGUgdXNvIGV4cHVlc3RhcyBlbiBsYSBEUEMgZGUgbGEgRk5NVC1S Q00gY29uIE5JRjogUTI4MjYwMDQtSiAoQy9Kb3JnZSBKdWFuIDEwNi0yODAwOS1NYWRyaWQtRXNw YcOxYSkwCQYHBACL7EABADCBugYIKwYBBQUHAQMEga0wgaowCAYGBACORgEBMAsGBgQAjkYBAwIB DzATBgYEAI5GAQYwCQYHBACORgEGATB8BgYEAI5GAQUwcjA3FjFodHRwczovL3d3dy5jZXJ0LmZu bXQuZXMvcGRzL1BEU0FDVXN1YXJpb3NfZXMucGRmEwJlczA3FjFodHRwczovL3d3dy5jZXJ0LmZu bXQuZXMvcGRzL1BEU0FDVXN1YXJpb3NfZW4ucGRmEwJlbjCBtQYDVR0fBIGtMIGqMIGnoIGkoIGh hoGebGRhcDovL2xkYXB1c3UuY2VydC5mbm10LmVzL2NuPUNSTDI3OTIsY249QUMlMjBGTk1UJTIw VXN1YXJpb3Msb3U9Q0VSRVMsbz1GTk1ULVJDTSxjPUVTP2NlcnRpZmljYXRlUmV2b2NhdGlvbkxp c3Q7YmluYXJ5P2Jhc2U/b2JqZWN0Y2xhc3M9Y1JMRGlzdHJpYnV0aW9uUG9pbnQwDQYJKoZIhvcN AQELBQADggEBADJCLEsiuQvdfPDhg8wgZpOfzm2pJ/k67Ti+nlqKeExYI7YO/gxuTRKURcjHWDHl 1rS+/GS4aolio4LM/pD266c/yK2DjRc4nQHsyDLIV/jMLd4qiKVKJckqixzD/OIhAXBJ2Cwqv4Lv rjdPHxeQJDhX91wJvKG7/rTJAabxovSvvoCe61WON82Nvx2hghmP1wZ1/Volqv8Ly60cfQTE2QV5 SIpSIh2ffPEUVcJ9V0MnZw8mWm47nK/PVY5HsZTe0OU/qWtRAjILtXzedk0jmi7zyQzqzJEMFKmM kWFB0lIImiinlCdgZaB9ejZfHarWymXVroLeSCYEhZQmt1Ij0cgxggLZMIIC1QIBATBfMEsxCzAJ BgNVBAYTAkVTMREwDwYDVQQKDAhGTk1ULVJDTTEOMAwGA1UECwwFQ2VyZXMxGTAXBgNVBAMMEEFD IEZOTVQgVXN1YXJpb3MCEHKbQ/oJlsDWXZGuXuesv7EwDQYJYIZIAWUDBAIBBQCgggFLMBgGCSqG SIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIzMDkxMjA1MjMwNVowLwYJKoZI hvcNAQkEMSIEIN9zw0LT8MMqpKk13Tc6mipS7SESSVJIoAvIVmr6xr6sMG4GCSsGAQQBgjcQBDFh MF8wSzELMAkGA1UEBhMCRVMxETAPBgNVBAoMCEZOTVQtUkNNMQ4wDAYDVQQLDAVDZXJlczEZMBcG A1UEAwwQQUMgRk5NVCBVc3VhcmlvcwIQcptD+gmWwNZdka5e56y/sTBwBgsqhkiG9w0BCRACCzFh oF8wSzELMAkGA1UEBhMCRVMxETAPBgNVBAoMCEZOTVQtUkNNMQ4wDAYDVQQLDAVDZXJlczEZMBcG A1UEAwwQQUMgRk5NVCBVc3VhcmlvcwIQcptD+gmWwNZdka5e56y/sTANBgkqhkiG9w0BAQsFAASC AQCs+PeVxW/atM/MPT90TLdNgS3xw47cBVWmF/QScKLtOs8of0XPvmnwOxUnVY7diEM0SrYzTAPF GlLxJQHJ65hO2iaW/EYLgtrukCWTRCWq8N4EG28eXKXRKAQyWMCxRdWI4NskwzCRjw/CNqdkKtw8 Nb+QjTOoUM+caqRAofHcsb6oiNL0yhmZ0cpJ/vUuJ3By6GC7xJmSEYBWZ9RNbGADQKMJVaFOyAZQ 4FFzw8zVXS166p4bdAfOdvjBJLO8+iK3490uSlkYG6DpSni/URD3XRgs10ImmK5qraBj1toQFxHr sEl/vU1xiKNHvCpPf0N1iTyHYOGKIHX0Zh/dfSo3AAAAAAAA --Apple-Mail=_F60F27EC-9DE2-4DCC-B90C-8A7577990972-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 12 03:05:42 2023 Received: (at 62157-done) by debbugs.gnu.org; 12 Sep 2023 07:05:42 +0000 Received: from localhost ([127.0.0.1]:55920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfxSr-0005qp-IX for submit@debbugs.gnu.org; Tue, 12 Sep 2023 03:05:42 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:49425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfxSm-0005qY-GZ for 62157-done@debbugs.gnu.org; Tue, 12 Sep 2023 03:05:36 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-502984f5018so7281605e87.3 for <62157-done@debbugs.gnu.org>; Tue, 12 Sep 2023 00:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694502322; x=1695107122; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fk6XdnsXYbhlIT45fdfbMFWaklzCQQYVuEovXFbEoqo=; b=iA+0SOMVJbu8JyI/jl/YKPTX1LODV0jVwMNvFpMKgwJoKCgzr7FLxP4JR9dHYxa34N sMTqX3Y7I+UH+7lQmrXaPB0ET70P+pT7PKoAADJXWVKbN7VLkfEo4SI/hyJF107qNgq0 agJ3wkJRC8WZpKATMtQc+x4gLhxjHpcWtY6MXSsjXf9NYBqSl3FqVwbXHd3OFFHJgmgo Q8i5H0M96SHfq7RJWoUqfU0X77AP19W2he5N4VRxwGkr8wWUvryD6xd7aWjPn/c5Jv1/ Ws9qmXOVaLwrwynjdSnFQYhgK3HhDZsuTWB9eBYuL5MtDx0GqUh7ahyuXKw3cgpQnpuf AxkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694502322; x=1695107122; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fk6XdnsXYbhlIT45fdfbMFWaklzCQQYVuEovXFbEoqo=; b=sjxoiMgH6zrJTju542jrj5B6zQaadrH3zGw+8yVvlLv/HvBE+UGJSFmn8hL5SSS6Zs 0HB5pdqND6SeG+pYfPF6e3djuvJzoAeLJqMW6BS+QiopWAhFt9Cg9SAbV4x+Lf60hTu8 RbrMbiJGSrtyuAv1OljfQb1b4C0lkZgwVujjFuCN5Cfj4NtKhPQLzAreZNGrFlddI801 ZxBTasmdTfEJ9EvQ2lj8mdLYautrvb/s+C6lYzUUBYL26c7GLKcTqx1fvNisWAwQdhtA 5q0SYEej0CIStVD7oHEFTHJM1C7GgbG4AgzA4enoq/+EYVHbuo9QGh7ul+udoSyTPsjQ ZUPg== X-Gm-Message-State: AOJu0YwkWcxt593MJu6N6xwIW+egNIMSXEnbJnW0OQKGTTQZVddMB/v2 sFG05Ar4Ot38Iq5tO8bzN4qB/2Yo27j6Mrcav1hH05G0/60= X-Google-Smtp-Source: AGHT+IHSQ0ZWEb9OfeK3jpyaLEIfdQo0xgqLRdrr9GAgmaR80WQvhgi+h3/gdJVRBzcyyAh7WTplImEi2sqprSpSqa4= X-Received: by 2002:a05:6512:2015:b0:4fb:c028:d76f with SMTP id a21-20020a056512201500b004fbc028d76fmr8057096lfb.35.1694502321697; Tue, 12 Sep 2023 00:05:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 12 Sep 2023 08:07:56 +0100 Message-ID: Subject: Re: bug#62157: More control over the mouse behaviour in eglot To: Stefan Kangas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157-done Cc: 62157-done@debbugs.gnu.org, Pedro Andres Aranda Gutierrez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Sep 12, 2023 at 1:22=E2=80=AFAM Stefan Kangas wrote: > It seems like the fix was the patch above, which IIUC has been > installed. I'm therefore closing this bug report. > > If this conclusion is incorrect and this is still an issue, please reply > to this email (use "Reply to all" in your email client) and we can > reopen the bug report. The conclusion is quite correct, and I earlier meant to close the bug, but due to typical incompetence when copy-pasting in my brain sent mail to 61257-done@debbugs.gnu.org instead. So maybe check if that other bug hasn't been closed in error :-) Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 13 12:12:27 2023 Received: (at 62157-done) by debbugs.gnu.org; 13 Sep 2023 16:12:27 +0000 Received: from localhost ([127.0.0.1]:35764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgSTb-0001CX-EN for submit@debbugs.gnu.org; Wed, 13 Sep 2023 12:12:27 -0400 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:45235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgSTZ-0001CH-3M for 62157-done@debbugs.gnu.org; Wed, 13 Sep 2023 12:12:25 -0400 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2bfb1167277so23357791fa.2 for <62157-done@debbugs.gnu.org>; Wed, 13 Sep 2023 09:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694621534; x=1695226334; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=O/ZH+CMaBs9MSXHlrCg1YQGqCjkAMCHpf5xGUVE2VTU=; b=VS5f6W3sOm8kuUrm/Oa2MuAF0CpGPWpoCx9rXyROLiCmrtNM1xI2Ij1BkzvtfNX3/Y t7aoxHBhDE4oU+dSBn+3NQ5z7CGhWwsGVXrooPFuABNhab1NblVa9yYDTyxhlkOwYvtw 3CmMC9gEIqRJtFdpkw4lx3NBHJJQECz1LuUyFtOu4spVX4uy2aK6r1DfLCImeXDLEtJL Xrn9LzmXfkZF36Zbn/+4A6wHPMGFfeK+MC+Nj3FjeQ0Ld0SBIEYoP9m43TxlPyKQBOPl jMgN1Tqa0aVsrYOUZwZMHzDUGf/QsAhENYBhS+kH8NKPCr3ezKmnOkEGQqQdDN1QGrax xmzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694621534; x=1695226334; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=O/ZH+CMaBs9MSXHlrCg1YQGqCjkAMCHpf5xGUVE2VTU=; b=WrsIaTzq6PQXHw8SjI0oks6v1sxFfa9NhIGqpi9VfO6ac15KY2DDzg9ba0109AGQii SwUIHYjH0P9VrXMu1xtWhsnefF4MScEiu8SF8pWhxh/Hj4YLtx9O+XHAAqEkK3YONdtt o/ox6q3t0UzPIT1TrVT32pJISkWr8nL3AqmEKKA295tTQhTmB0/84Vyt3IQEQDLgFd6z PsWO+wIIJPWQdl87fp2RrO0EIbqlTUnVcAiljZLH7e00gN3LCYLfqvenbZf0cijVV0ey d+sOBXbSU5n+HNY/oIBJ1Zdo7cK/J5u+XHwDuXtv94pkh6hd1MI+WKPpiyGJy78jW7Yf T8PQ== X-Gm-Message-State: AOJu0Yzt9K6U6NZfydyoQhWtcqFjD2mG57n9lFaWgGBcl4aCYs+vnH1t SG7qp7iHFw1IVGHYujssWU1ZRjyyAblvUzOtSMU= X-Google-Smtp-Source: AGHT+IHaVStQMGQccXTeSyCW3ihvW/8HCgSFAkAmxAUbdR2LjZaXE38zs0LpIuAEiAvRowlLyNVIxkHh4ZAcPerw69M= X-Received: by 2002:a2e:3205:0:b0:2bc:c557:84a0 with SMTP id y5-20020a2e3205000000b002bcc55784a0mr3122990ljy.30.1694621533635; Wed, 13 Sep 2023 09:12:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 09:12:13 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Wed, 13 Sep 2023 09:12:13 -0700 Message-ID: Subject: Re: bug#62157: More control over the mouse behaviour in eglot To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62157-done Cc: 62157-done@debbugs.gnu.org, Pedro Andres Aranda Gutierrez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > The conclusion is quite correct, and I earlier meant to close the bug, > but due to typical incompetence when copy-pasting in my brain > sent mail to 61257-done@debbugs.gnu.org instead. So maybe check > if that other bug hasn't been closed in error :-) I took a look and that bug seems to be fine. It belongs to guix-patches. From unknown Sun Jun 22 07:59:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Oct 2023 11:24:19 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator