GNU bug report logs - #62156
[PATCH 0/1] gnu: Add atftp.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62156: closed ([PATCH 0/1] gnu: Add atftp.)
Date: Mon, 27 Mar 2023 16:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 27 Mar 2023 18:49:19 +0200
with message-id <87pm8uf8c0.fsf_-_ <at> gnu.org>
and subject line Re: bug#62156: [PATCH 0/1] gnu: Add atftp.
has caused the debbugs.gnu.org bug report #62156,
regarding [PATCH 0/1] gnu: Add atftp.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62156: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62156
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: guix-patches <at> gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH 0/1] gnu: Add atftp.
Date: Sun, 12 Mar 2023 21:41:38 -0700

Hi,

I am not sure whether the mirror:// URL is right. It works, but there are two
lint warnings:

gnu/packages/networking.scm:2946:15: atftp <at> 0.8.0: URI https://www.gnu.org/software/atftp/ not reachable: 404 ("Not Found")
gnu/packages/networking.scm:2921:12: atftp <at> 0.8.0: source not archived on Software Heritage and missing from the Disarchive database

Kind regards,
Felix Lechner

* * *

Felix Lechner (1):
  gnu: Add atftp.

 gnu/packages/networking.scm | 41 +++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)


base-commit: 9584b1daa687d1212550841d1c5f62e7ffa44ffc
-- 
2.39.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Felix Lechner <felix.lechner <at> lease-up.com>
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>, 62156-done <at> debbugs.gnu.org
Subject: Re: bug#62156: [PATCH 0/1] gnu: Add atftp.
Date: Mon, 27 Mar 2023 18:49:19 +0200

Hi,

Felix Lechner <felix.lechner <at> lease-up.com> skribis:

> * gnu/packages/networking.scm (atftp): New variable.
>
> Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
> reviews of this item!

I tweaked the description (to start with a full sentence) and passed it
through ‘guix style’.

> For the atftp package added in the preceeding commit, lint produced this
> warning:
>
>   gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
>     URI https://git.code.sf.net/p/atftp/code not reachable:
>       404 ("Not Found")
>
> Thanks to Sergey Trofimov for suggesting a fix! [1]
>
>   [1]  https://issues.guix.gnu.org/62156#3
>
> It was implemented here, and the warning disappeared.
>
> * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
>
> Co-authored-by: Sergey Trofimov <sarg <at> sarg.org.ru>

Nice.  I adjusted ‘tests/lint.scm’ accordingly.

Applied both; thank you, and thanks to the reviewers!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.