GNU bug report logs - #62156
[PATCH 0/1] gnu: Add atftp.

Previous Next

Full log

Message #26 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>,
 Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url.
Date: Mon, 20 Mar 2023 21:25:41 -0700

For the atftp package added in the preceeding commit, lint produced this
warning:

  gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
    URI https://git.code.sf.net/p/atftp/code not reachable:
      404 ("Not Found")

Thanks to Sergey Trofimov for suggesting a fix! [1]

  [1]  https://issues.guix.gnu.org/62156#3

It was implemented here, and the warning disappeared.

* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.

Co-authored-by: Sergey Trofimov <sarg <at> sarg.org.ru>
---
 guix/lint.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index a1a27873d9..8d0887739d 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,7 +1224,14 @@ (define (warnings-for-uris uris)
                 '())))
          ((git-reference? (origin-uri origin))
           (warnings-for-uris
-           (list (string->uri (git-reference-url (origin-uri origin))))))
+           ;; for atftp, lint produced a warning:
+           ;;   gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
+           ;;     URI https://git.code.sf.net/p/atftp/code not reachable:
+           ;;     404 ("Not Found")
+           ;; fix from here:  https://issues.guix.gnu.org/62156#3
+           (list (string->uri (string-append
+                               (git-reference-url (origin-uri origin))
+                               "/info/refs")))))
          ((or (svn-reference? (origin-uri origin))
               (svn-multi-reference? (origin-uri origin)))
           (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
-- 
2.39.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.