GNU bug report logs - #62153
[PATCH 0/2] Add Docker layered image for pack and system

Previous Next

Full log

View this message in rfc822 format

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Simon Tournier <zimon.toutoune <at> gmail.com>, Ludovic Courtès <ludo <at> gnu.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>, Christopher Baines <guix <at> cbaines.net>, 62153 <at> debbugs.gnu.org
Subject: [bug#62153] [PATCH 4/5] guix: pack: Build layered images.
Date: Wed, 27 Dec 2023 21:25:02 +0100

> +If MAX-LAYERS is not false, the image will with many of the store paths being
> +on their own layer to improve sharing between images."

Same comment as in previous patch, "many" is a bit vague. "the image
will be splitted in up to MAX-LAYERS layers" or so could work.

> +         (check   (gexp->derivation "check-tarball"
> +                                    (with-imported-modules '((guix build utils))

You could rearrange as:

--8<---------------cut here---------------start------------->8---
(check   (gexp->derivation
          "check-tarball"
          (with-imported-modules '((guix build utils))
--8<---------------cut here---------------end--------------->8---

to reduce the indentation of this block:

> +                                      #~(begin
> +                                          (use-modules (guix build utils)
> +                                                       (ice-9 match))

...

> +                                                   (string=? (string-append #$%bootstrap-guile "/bin")
> +                                                             (pk 'binlink (readlink bin)))
> +                                                   (string=? (string-append #$profile "/bin/guile")
> +                                                             (pk 'guilelink (readlink "bin/Guile"))))

Left over pk's?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.