From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 04:39:48 2023 Received: (at submit) by debbugs.gnu.org; 12 Mar 2023 08:39:48 +0000 Received: from localhost ([127.0.0.1]:59117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbHF5-0003MN-RU for submit@debbugs.gnu.org; Sun, 12 Mar 2023 04:39:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:59342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbHF3-0003MF-Cs for submit@debbugs.gnu.org; Sun, 12 Mar 2023 04:39:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbHF2-0006yF-TL for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2023 04:39:45 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbHF0-0006mS-Ll for bug-gnu-emacs@gnu.org; Sun, 12 Mar 2023 04:39:44 -0400 Received: by mail-pl1-x633.google.com with SMTP id x11so9865282pln.12 for ; Sun, 12 Mar 2023 00:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678610380; h=mime-version:user-agent:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=Br34rrRux/sGLAvr2IWO4loOIlYH9yjKA7MruXmOdwE=; b=dn3K990mI/wF05JoINXIdtZ/3nUvvemGrJvGkx6D9RJG0+3xWF1E58AIsWbI5S928W jNIH2Iuv3SXkrn/Ds4AZ3h4EE7s7BDnxMPAReNOzlhObNbPCZyQWKTv+v7zUpP0kLZRD iakd6g2Hfeg2ScpIXZlJFMY1epRH04brSZWYIxyea+hBGDXiRtGKeMlIxVDhjVwhGNLW nFVM5JLQe337BLEPRikUJW751rKu1b/N3I8ucPSwfIm0IYjHT0gBtolvDl5Ht8rlvkqX JHlvmLfJR4zs2ECjnQ+RNCszHuZNyEPypzyOq/9X2m/E0xuuQ6glMCGXitakN4XOOQjo y4QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678610380; h=mime-version:user-agent:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Br34rrRux/sGLAvr2IWO4loOIlYH9yjKA7MruXmOdwE=; b=ctT0m1fbbnJQzjrYKZP4+tXNzCRa+7Xh52g52khIjMbyrT2DrTaUl/qi96OL/Fn2pl RWRBXYqcltueHx5MR8Mx9ywpPLYw32jOpyxhSgIDF+Mxu8XeCGcSb1rKW0jVeC193bdd JE+ZWqZE00z0v3w0K2ESWlwwo1H1uxKXRfZ9MiE9IxAsscLCjB7h2CjFmjaSfUqOzbYk KDPnOEx/wXKVK0EjlSbiO86z2p02f7pQLpBaNOw8HK4/FM6NrfIKiPPq76Oa1Qlqkpu+ irTjH6TKeZF/A0FcqGYCkg/rzLXn0tuulqjM3gClzw2u2oj9Ej0/FozhR2RG2sOr2O8c x9kg== X-Gm-Message-State: AO0yUKXyUcOvCqnjQIw4jx27jh7dtGtepmryMVADCyii8DUUaoWXsaGZ b/Gm/VL63vmtrw/XDuqWN4Bs/1hW0lf10w== X-Google-Smtp-Source: AK7set84g6l4ygAg6vU/Hs2s5rW0ekPtwWid1U935wlwOFi+2KFF9/atA4wsvuGn7RnPn7KL/ItPuQ== X-Received: by 2002:a17:903:22cc:b0:19c:ff35:35d1 with SMTP id y12-20020a17090322cc00b0019cff3535d1mr35324150plg.6.1678610380166; Sun, 12 Mar 2023 00:39:40 -0800 (PST) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id 201-20020a6301d2000000b00502e20b4777sm2574077pgb.9.2023.03.12.00.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 00:39:39 -0800 (PST) Date: Sun, 12 Mar 2023 17:39:37 +0900 Message-ID: From: kobarity To: bug-gnu-emacs@gnu.org Subject: 30.0.50; python-fill-paragraph problems on filling strings User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Sun_Mar_12_17:39:37_2023-1" Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=kobarity@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier , =?ISO-8859-1?Q?Jo=E3o_T=E1v?= =?ISO-8859-1?Q?ora?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Multipart_Sun_Mar_12_17:39:37_2023-1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, There are some problems in filling Python's strings, which are caused by the same portion of the code. Here are the steps to reproduce the first problem: 1. emacs -Q 2. C-x C-f somefile1.py 3. Enter the following program: #+begin_src python s1 =3D 'abc' s2 =3D 'def' #+end_src 4. Place point within the first string (abc). 6. M-q The lines will be merged into a single line. #+begin_src python s1 =3D 'abc' s2 =3D 'def' #+end_src This problem occurs in Emacs 27 and later. Second problem can be reproduced with the following steps: 1. emacs -Q 2. C-x C-f somefile2.py 3. Enter the following program: #+begin_src python s =3D '''abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz abcdefghijkl= mnopqrstuvwxyz''' #+end_src 4. Place point at the first or third quote of the starting triple quotes. 5. M-q The line is not filled. However, if the point is placed at the second quote or within the string, the line will be filled as follows: #+begin_src python s =3D '''abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz''' #+end_src When the point is placed at the ending triple quotes, the line will be filled if the point is at the first or third quote. This problem occurs in Emacs 28 and later. Third problem can be reproduced with the following steps: 1. emacs -Q 2. C-x C-f somefile3.py 3. Enter the following program: #+begin_src python s =3D 'abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz abcdefghijklmn= opqrstuvwxyz' #+end_src 4. Place point within the string. 5. M-q The line will be split into 2 lines. #+begin_src python s =3D 'abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz' #+end_src This is not a correct Python program anymore because a single quoted string can not span multiple lines unless the end of line is escaped using a backslash. The docstring of `python-fill-paragraph' says: `fill-paragraph-function' handling multi-line strings and possibly comments. Although it is possible to make a multi-line single quoted string by escaping the end of line using backslash, triple quoted strings are usually used for multi-line strings. So I think `python-fill-paragraph' should not do anything with single quoted strings. The cause of the first problem is similar to Bug#58780. In `python-fill-string', the string is searched for with the following code: (or (python-syntax-context 'string) (and (equal (string-to-syntax "|") (syntax-after (point))) (point))))) and the end of the string is searched for with the following code: (or (re-search-forward (rx (syntax string-delimiter)) nil t) (goto-char (point-max))) These codes used to be appropriate, but it is not correct after the following commit which is included in Emacs 27 and later: commit 4b39b741f1949ebad1dfccc5032dfce521bedc2a Author: Stefan Monnier Date: Tue Apr 9 15:08:21 2019 -0400 python.el: don't syntax-propertize single/double quoted strings * lisp/progmodes/python.el (python-syntax-propertize-function): Only mark triple-quoted strings, let the normal syntax-table handle the rest. (python-syntax-stringify): Adjust accordingly. =46rom this commit, single quoted strings can not be identified by string-delimiter and can only be identified by string-quote. In the fix of Bug#58780, I added `forward-sexp' to search for the end of single quoted string. However, considering the third problem, I would prefer to have `python-fill-paragraph' and `python-fill-string' search only for triple quoted strings in this case. The second problem occurs after the following commit included in Emacs 28 and later: commit 0646c6817139aa905a2f6079fdc82eb4be944de0 Author: Jo=E3o T=E1vora Date: Sun Sep 19 11:42:20 2021 +0100 Make syntax-ppss more accurate for Python triple quotes (bug#49518) By putting delimiter syntax on the last character of Python triple-quoted strings, this makes syntax-ppss be more accurate. This commit narrows the range of string-delimiter from outermost quotes to innermost quotes, and results in `python-fill-paragraph' not recognizing the string when point is at some quotes. Attached is a patch to fix these problems. Main changes are: 1. single-quoted-string and triple-quoted-string are added as a TYPE argument of `python-syntax-context'. 2. New helper function `python-info-triple-quoted-string-p' is added to detect triple quoted strings including quotes. 3. `python-fill-paragraph' and `python-fill-string' use `python-info-triple-quoted-string-p' to detect triple quoted strings only. I look forward to your comments. -- In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-03-10 built on ubuntu Repository revision: 8ee205d232574e12921b052c7e93b7e16d6f1187 Repository branch: master System Description: Ubuntu 22.04.2 LTS Configured features: ACL CAIRO FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Python Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils python json subr-x map rx project pcase treesit cl-seq comint ansi-osc ring cl-loaddefs cl-lib ansi-color term/screen term/xterm xterm byte-opt gv bytecomp byte-compile rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 60054 7620) (symbols 48 7362 0) (strings 32 20143 1278) (string-bytes 1 593570) (vectors 16 11583) (vector-slots 8 139242 9455) (floats 8 30 11543) (intervals 56 239 0) (buffers 984 12)) --Multipart_Sun_Mar_12_17:39:37_2023-1 Content-Type: application/octet-stream; type=patch; name="0001-Fix-python-fill-paragraph-problems-on-filling-string.patch" Content-Disposition: attachment; filename="0001-Fix-python-fill-paragraph-problems-on-filling-string.patch" Content-Transfer-Encoding: 7bit >From aaa9b08f231bf3c9c9c5afcefe5903e5962183f3 Mon Sep 17 00:00:00 2001 From: kobarity Date: Sun, 12 Mar 2023 17:05:54 +0900 Subject: [PATCH] Fix python-fill-paragraph problems on filling strings * lisp/progmodes/python.el (python-syntax--context-compiler-macro) (python-syntax-context): Add single-quoted-string and triple-quoted-string as TYPE argument. (python-info-triple-quoted-string-p): New helper function. (python-fill-paragraph) (python-fill-string): Use it. * test/lisp/progmodes/python-tests.el (python-syntax-context-1) (python-fill-paragraph-single-quoted-string-1) (python-fill-paragraph-single-quoted-string-2) (python-fill-paragraph-triple-quoted-string-1) (python-info-triple-quoted-string-p-1) (python-info-triple-quoted-string-p-2) (python-info-triple-quoted-string-p-3): New tests. --- lisp/progmodes/python.el | 35 ++++++-- test/lisp/progmodes/python-tests.el | 119 ++++++++++++++++++++++++++++ 2 files changed, 146 insertions(+), 8 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index 630250c15c3..4763c5308ab 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -511,19 +511,28 @@ python-rx (''string `(let ((ppss (or ,syntax-ppss (syntax-ppss)))) (and (nth 3 ppss) (nth 8 ppss)))) + (''single-quoted-string + `(let ((ppss (or ,syntax-ppss (syntax-ppss)))) + (and (characterp (nth 3 ppss)) (nth 8 ppss)))) + (''triple-quoted-string + `(let ((ppss (or ,syntax-ppss (syntax-ppss)))) + (and (eq t (nth 3 ppss)) (nth 8 ppss)))) (''paren `(nth 1 (or ,syntax-ppss (syntax-ppss)))) (_ form)))) (defun python-syntax-context (type &optional syntax-ppss) "Return non-nil if point is on TYPE using SYNTAX-PPSS. -TYPE can be `comment', `string' or `paren'. It returns the start +TYPE can be `comment', `string', `single-quoted-string', +`triple-quoted-string' or `paren'. It returns the start character address of the specified TYPE." (declare (compiler-macro python-syntax--context-compiler-macro)) (let ((ppss (or syntax-ppss (syntax-ppss)))) (pcase type ('comment (and (nth 4 ppss) (nth 8 ppss))) ('string (and (nth 3 ppss) (nth 8 ppss))) + ('single-quoted-string (and (characterp (nth 3 ppss)) (nth 8 ppss))) + ('triple-quoted-string (and (eq t (nth 3 ppss)) (nth 8 ppss))) ('paren (nth 1 ppss)) (_ nil)))) @@ -4806,9 +4815,7 @@ python-fill-paragraph ((python-syntax-context 'comment) (funcall python-fill-comment-function justify)) ;; Strings/Docstrings - ((save-excursion (or (python-syntax-context 'string) - (equal (string-to-syntax "|") - (syntax-after (point))))) + ((python-info-triple-quoted-string-p) (funcall python-fill-string-function justify)) ;; Decorators ((equal (char-after (save-excursion @@ -4834,10 +4841,7 @@ python-fill-string (let* ((str-start-pos (set-marker (make-marker) - (or (python-syntax-context 'string) - (and (equal (string-to-syntax "|") - (syntax-after (point))) - (point))))) + (python-info-triple-quoted-string-p))) ;; JT@2021-09-21: Since bug#49518's fix this will always be 1 (num-quotes (python-syntax-count-quotes (char-after str-start-pos) str-start-pos)) @@ -6041,6 +6045,21 @@ python-info-docstring-p ((python-info-looking-at-beginning-of-defun)) (t nil)))))) +(defun python-info-triple-quoted-string-p () + "Check if point is in a triple quoted string including quotes. +It returns the position of the third quote character of the start +of the string." + (save-excursion + (let ((pos (point))) + (cl-loop + for offset in '(0 3 -2 2 -1 1) + if (let ((check-pos (+ pos offset))) + (and (>= check-pos (point-min)) + (<= check-pos (point-max)) + (python-syntax-context + 'triple-quoted-string (syntax-ppss check-pos)))) + return it)))) + (defun python-info-encoding-from-cookie () "Detect current buffer's encoding from its coding cookie. Returns the encoding as a symbol." diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 6928e313dc4..83e7fdd3eaa 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -255,6 +255,27 @@ python-tests-look-at-2 ;;; Font-lock and syntax +(ert-deftest python-syntax-context-1 () + (python-tests-with-temp-buffer + " +# Comment +s = 'Single Quoted String' +t = '''Triple Quoted String''' +p = (1 + 2) +" + (python-tests-look-at "Comment") + (should (= (python-syntax-context 'comment) (pos-bol))) + (python-tests-look-at "Single") + (should (= (python-syntax-context 'string) (1- (point)))) + (should (= (python-syntax-context 'single-quoted-string) (1- (point)))) + (should-not (python-syntax-context 'triple-quoted-string)) + (python-tests-look-at "Triple") + (should (= (python-syntax-context 'string) (1- (point)))) + (should-not (python-syntax-context 'single-quoted-string)) + (should (= (python-syntax-context 'triple-quoted-string) (1- (point)))) + (python-tests-look-at "1 + 2") + (should (= (python-syntax-context 'paren) (1- (point)))))) + (ert-deftest python-syntax-after-python-backspace () ;; `python-indent-dedent-line-backspace' garbles syntax (python-tests-with-temp-buffer @@ -2023,6 +2044,54 @@ python-fill-docstring (fill-paragraph) (should (= (current-indentation) 0)))) +(ert-deftest python-fill-paragraph-single-quoted-string-1 () + "Single quoted string should not be filled." + (let ((contents " +s = 'abc def ghi jkl mno pqr stu vwx yz' +") + (fill-column 20)) + (python-tests-with-temp-buffer + contents + (python-tests-look-at "abc") + (fill-paragraph) + (should (string= (buffer-substring-no-properties (point-min) (point-max)) + contents))))) + +(ert-deftest python-fill-paragraph-single-quoted-string-2 () + "Ensure no fill is performed after the end of the single quoted string." + (let ((contents " +s1 = 'abc' +s2 = 'def' +")) + (python-tests-with-temp-buffer + contents + (python-tests-look-at "abc") + (fill-paragraph) + (should (string= (buffer-substring-no-properties (point-min) (point-max)) + contents))))) + +(ert-deftest python-fill-paragraph-triple-quoted-string-1 () + "Triple quoted string should be filled." + (let ((contents " +s = '''abc def ghi jkl mno pqr stu vwx yz''' +") + (expected " +s = '''abc def ghi +jkl mno pqr stu vwx +yz''' +") + (fill-column 20)) + (dolist (look-at '("'''abc" "z'''")) + (dolist (offset '(0 1 2 3)) + (python-tests-with-temp-buffer + contents + (python-tests-look-at look-at) + (forward-char offset) + (fill-paragraph) + (should (string= + (buffer-substring-no-properties (point-min) (point-max)) + expected))))))) + ;;; Mark @@ -6418,6 +6487,56 @@ python-info-docstring-p-6 (python-tests-look-at "'''Not a method docstring.'''") (should (not (python-info-docstring-p))))) +(ert-deftest python-info-triple-quoted-string-p-1 () + "Test triple quoted string." + (python-tests-with-temp-buffer + " +t = '''Triple''' +" + (python-tests-look-at " '''Triple") + (should-not + (python-tests-should-not-move + #'python-info-triple-quoted-string-p)) + (forward-char) + (let ((start-pos (+ (point) 2)) + (eol (pos-eol))) + (while (< (point) eol) + (should (= (python-tests-should-not-move + #'python-info-triple-quoted-string-p) + start-pos)) + (forward-char))) + (dolist (pos `(,(point) ,(point-min) ,(point-max))) + (goto-char pos) + (should-not + (python-tests-should-not-move + #'python-info-triple-quoted-string-p))))) + +(ert-deftest python-info-triple-quoted-string-p-2 () + "Test empty triple quoted string." + (python-tests-with-temp-buffer + " +e = '''''' +" + (python-tests-look-at "''''''") + (let ((start-pos (+ (point) 2)) + (eol (pos-eol))) + (while (< (point) eol) + (should (= (python-tests-should-not-move + #'python-info-triple-quoted-string-p) + start-pos)) + (forward-char))))) + +(ert-deftest python-info-triple-quoted-string-p-3 () + "Test single quoted string." + (python-tests-with-temp-buffer + " +s = 'Single' +" + (while (< (point) (point-max)) + (should-not (python-tests-should-not-move + #'python-info-triple-quoted-string-p)) + (forward-char)))) + (ert-deftest python-info-encoding-from-cookie-1 () "Should detect it on first line." (python-tests-with-temp-buffer -- 2.34.1 --Multipart_Sun_Mar_12_17:39:37_2023-1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 14:03:57 2023 Received: (at 62142) by debbugs.gnu.org; 12 Mar 2023 18:03:57 +0000 Received: from localhost ([127.0.0.1]:33070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbQ33-0005LL-IA for submit@debbugs.gnu.org; Sun, 12 Mar 2023 14:03:57 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:46732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbQ31-0005L9-RZ for 62142@debbugs.gnu.org; Sun, 12 Mar 2023 14:03:56 -0400 Received: by mail-wr1-f43.google.com with SMTP id r29so1299029wra.13 for <62142@debbugs.gnu.org>; Sun, 12 Mar 2023 11:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678644229; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mtdA0JEa8I0yOlWK/o3Ogij5gBH4lxup+viMBpIEGko=; b=Nge54g0gulklVnbsqzbgeygLZcf4OK9ugZjaeht4VICjJCG3EW3p9OF0KOYi1JnCil sbfT2HgQ+k6sDwzLAhZJWosMzFXGLJ+q5hJMoz3Rwj4VIff9F0sZUABMVv/zmuq9hkrt 6yiDqolfXC2eLa3IF8AyCycSHpJ4W0z6vvYkwOGXoDHNFc3PxqlUv4Mwa1XYW7kuakqS EV0COtC1Bh2pld6p3toxXEyW5+ThCsW1y2xnNjikE1/lyCVQXwXe7sLJz6EABYDu22+X Vs0b395T2JTTDAZTpdlRIkOVvb2T43/GaZcILSjY2AqFwFYwiVaIXkXwAxVa9zPN6jDM Y7MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678644229; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mtdA0JEa8I0yOlWK/o3Ogij5gBH4lxup+viMBpIEGko=; b=a/OIANTrHqfdugpGl0iND7zlGZFc1C/npOgNkDx1DFimLeKxq8Rs1SnK0x//eey++e SNNxxc3INErxEebTT4Iv6yhdvtSDzf9j5+TbWkanqp9vXbVyOAhktPNVWhRjv/+RjHZE vqilI7x9LaTiVz9s7CCXARHYi6WtOQJ6VBl1LPUy0Tdg1XFkmsDwItc+8y4yOvu/KgLV ksoNeZDJdvDCqQM8LPvWvfzaoEB0MBjFqzNLwRHmX/E+6j/6k+XIJvWLXgS0GWwwAeiH u53VJuE6JhplIMsNLq3gF8ZrRwfxixt7kji+7+4WXxTdA/5hb2mInHnfxWu/wEB6K+Oz RtQg== X-Gm-Message-State: AO0yUKV0wCnSUVBzJnSHMCDrkl5V5kqqiwAkpp9BpGE/raI4Gz/3RQXf RmA3HLcbnu2R1isEEPsvuHk= X-Google-Smtp-Source: AK7set8ELRt/sZjo5ovVeI3qSPnvHbzkC5eSFkuxiiL7HbX03H9n2y50l+Z4YfIcf2jYUoqqLrI+Dw== X-Received: by 2002:a5d:6a88:0:b0:2c7:832:8cce with SMTP id s8-20020a5d6a88000000b002c708328ccemr21016573wru.49.1678644229548; Sun, 12 Mar 2023 11:03:49 -0700 (PDT) Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id p10-20020adfe60a000000b002cda9aa1dc1sm5728240wrm.111.2023.03.12.11.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 11:03:49 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: kobarity Subject: Re: 30.0.50; python-fill-paragraph problems on filling strings In-Reply-To: (kobarity@gmail.com's message of "Sun, 12 Mar 2023 17:39:37 +0900") References: Date: Sun, 12 Mar 2023 18:05:48 +0000 Message-ID: <87v8j5rgjn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62142 Cc: 62142@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) kobarity writes: > Attached is a patch to fix these problems. Main changes are: > > 1. single-quoted-string and triple-quoted-string are added as a TYPE > argument of `python-syntax-context'. > 2. New helper function `python-info-triple-quoted-string-p' is added > to detect triple quoted strings including quotes. > 3. `python-fill-paragraph' and `python-fill-string' use > `python-info-triple-quoted-string-p' to detect triple quoted > strings only. > > I look forward to your comments. Hi kobarity,=20 I suppose the test suite still passes. Did also enable electric-pair-mode and play around and find acceptable behaviour? Does bug#49518 stay solved? If so, this is fine with me, and let's let Stefan chime in. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 10:17:59 2023 Received: (at 62142) by debbugs.gnu.org; 13 Mar 2023 14:17:59 +0000 Received: from localhost ([127.0.0.1]:35309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbizv-0000LK-Gy for submit@debbugs.gnu.org; Mon, 13 Mar 2023 10:17:59 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:39703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbizt-0000Kt-Is for 62142@debbugs.gnu.org; Mon, 13 Mar 2023 10:17:57 -0400 Received: by mail-pg1-f178.google.com with SMTP id h31so6984326pgl.6 for <62142@debbugs.gnu.org>; Mon, 13 Mar 2023 07:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678717071; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=ZQ48P4YPwsvb7Ol6vZM/jD3TYBR9DbHC818OjRAoU5k=; b=hRJcGT0uOUVeCZynGlZh8zNXJ97JkkM5wjFKd6twDxrEEojQzEfL/CDCncATa2+Do4 tfUzVn/29UF4c0fsy/ijH0+Lu1vV8Kz18Yjf/flSHvdMDGNeH+H+cUOP9rHpyHOPuuhd dp0Ziwks5JhroHE9hdHN6KF51/PbIxpHCnPwz/XkMGfAAXTSGf6vckaEgsysiKYrPgrt h/7/Hj/Bkt8NJcJVkdsegImEyAXvQgt1NvQq2U+0JK/i3MCDFsPdpu79D0vmQUFn1WN6 cDTD0wvDZ6kjf0k8GOqlFA4YoeGaSdZbrb1ch18jJQ6SdxRexOGAqykGZj6uNVdE9AKC 4kjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678717071; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZQ48P4YPwsvb7Ol6vZM/jD3TYBR9DbHC818OjRAoU5k=; b=d8CFXsC4qTzrsup0TFEHNoj6IL+8MgEg41s5R0lI+RN7fAawcp0pHt2laUvi23Rhyu TKqlNuH2ZQTe2w56fQkXud3npfiTObsDlioBH+5ybXWtHoLuucjwD3qgrnLpKoqkVQv9 DPSUoFQ6Mnwl+9mrBu/wq97HDKmVYB9hSe01T47IzUTbeQIZpC5KMgwH2bdegHGdX/OS f5nng8eyE0PDbOEXrloBau5i1Y1+Yt0lG8RDYszWCD+JNEcFUASUTyjDVeqqoJPGEHgJ Q8GMA922SqumxPV0gyBPm9CLBF9n5h+bvNa2B272SNhYCAa5jqw/EIOriSpkdoA5HG9U HQCg== X-Gm-Message-State: AO0yUKV4Q9hSS7L3fE+dDMOFge65imH9i1qRAChlfSEfmrwjQHzP6WE7 ppaGLEg2JUbvUbOm2Esx8aE= X-Google-Smtp-Source: AK7set+qOBrn+1r3p2Cflp7o6+ygfy7J3iUeIV/KW2/3/6QWw6oxk7yIZth/+v8sB1svaSJkjLxtUA== X-Received: by 2002:aa7:9f81:0:b0:60b:81ae:c6d2 with SMTP id z1-20020aa79f81000000b0060b81aec6d2mr30666970pfr.27.1678717071590; Mon, 13 Mar 2023 07:17:51 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id l22-20020a62be16000000b005821c109cebsm4429387pff.199.2023.03.13.07.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 07:17:51 -0700 (PDT) Date: Mon, 13 Mar 2023 23:17:48 +0900 Message-ID: From: kobarity To: =?ISO-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: 30.0.50; python-fill-paragraph problems on filling strings In-Reply-To: <87v8j5rgjn.fsf@gmail.com> References: <87v8j5rgjn.fsf@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62142 Cc: 62142@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=E3o T=E1vora wrote: > I suppose the test suite still passes. Did also enable > electric-pair-mode and play around and find acceptable behaviour? Does > bug#49518 stay solved? Hi Jo=E3o, As far as running some of the basic checks described in Bug#49518, I don't see any problems. Except for adding new argument values and a new helper, my patch only modifies `python-fill-paragraph' and `python-fill-string', which are not supposed to be called by electric-pair-mode, so it should not affect electric-pair-mode. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 03:20:14 2023 Received: (at 62142) by debbugs.gnu.org; 16 Mar 2023 07:20:14 +0000 Received: from localhost ([127.0.0.1]:41098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pchuH-0001ka-Lr for submit@debbugs.gnu.org; Thu, 16 Mar 2023 03:20:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pchuF-0001kJ-H0 for 62142@debbugs.gnu.org; Thu, 16 Mar 2023 03:20:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pchuA-0006gd-9A; Thu, 16 Mar 2023 03:20:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Qk5OIL4cDF8zug8/t9Lfu7DDoHFcXehXmPA69moUoB4=; b=Y//YYb4uVr+x94pZlGBV JCEY0SiHmY0Wx3BdenVgAD97Ug4KpPsurWnttBgVxfmSNwYJ1XlVORpQoPz2pH5Ul6t4vCo6ZZQNe 40grfROqy8catNE7QphKozJZemeXvfpm5flclYLa8ZHXEYYgRSZCMKRPl5+CiarEh8Jf10G6xvcKt t517wTjJNOdrUr4cpHkQjlTQ6G1eQEkjkfXhdpwBpdi4bGcZXlA6cI8ef/l9yrghdcBW8DUNbvPh6 8zm+ZiV87mll955Ss+Kr6Ug74USaerY9FZALHMbCAv6JZ2euTP4OR039ULdPC8ww14GWZBqqtGiel kfIm8s5zF4tceg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pchu9-0007nP-LC; Thu, 16 Mar 2023 03:20:05 -0400 Date: Thu, 16 Mar 2023 09:20:04 +0200 Message-Id: <83bkktqi1n.fsf@gnu.org> From: Eli Zaretskii To: kobarity In-Reply-To: (message from kobarity on Sun, 12 Mar 2023 17:39:37 +0900) Subject: Re: bug#62142: 30.0.50; python-fill-paragraph problems on filling strings References: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62142 Cc: 62142@debbugs.gnu.org, monnier@iro.umontreal.ca, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Stefan Monnier , > Joćo Tįvora > Date: Sun, 12 Mar 2023 17:39:37 +0900 > From: kobarity > > The cause of the first problem is similar to Bug#58780. In > `python-fill-string', the string is searched for with the following > code: > > (or (python-syntax-context 'string) > (and (equal (string-to-syntax "|") > (syntax-after (point))) > (point))))) > > and the end of the string is searched for with the following code: > > (or (re-search-forward (rx (syntax string-delimiter)) nil t) > (goto-char (point-max))) > > These codes used to be appropriate, but it is not correct after the > following commit which is included in Emacs 27 and later: > > commit 4b39b741f1949ebad1dfccc5032dfce521bedc2a > Author: Stefan Monnier > Date: Tue Apr 9 15:08:21 2019 -0400 > > python.el: don't syntax-propertize single/double quoted strings > > * lisp/progmodes/python.el (python-syntax-propertize-function): > Only mark triple-quoted strings, let the normal syntax-table handle > the rest. > (python-syntax-stringify): Adjust accordingly. > > From this commit, single quoted strings can not be identified by > string-delimiter and can only be identified by string-quote. > > In the fix of Bug#58780, I added `forward-sexp' to search for the end > of single quoted string. However, considering the third problem, I > would prefer to have `python-fill-paragraph' and `python-fill-string' > search only for triple quoted strings in this case. > > > The second problem occurs after the following commit included in Emacs > 28 and later: > > commit 0646c6817139aa905a2f6079fdc82eb4be944de0 > Author: Joćo Tįvora > Date: Sun Sep 19 11:42:20 2021 +0100 > > Make syntax-ppss more accurate for Python triple quotes (bug#49518) > > By putting delimiter syntax on the last character of Python > triple-quoted strings, this makes syntax-ppss be more accurate. > > This commit narrows the range of string-delimiter from outermost > quotes to innermost quotes, and results in `python-fill-paragraph' not > recognizing the string when point is at some quotes. > > > Attached is a patch to fix these problems. Main changes are: > > 1. single-quoted-string and triple-quoted-string are added as a TYPE > argument of `python-syntax-context'. > 2. New helper function `python-info-triple-quoted-string-p' is added > to detect triple quoted strings including quotes. > 3. `python-fill-paragraph' and `python-fill-string' use > `python-info-triple-quoted-string-p' to detect triple quoted > strings only. > > I look forward to your comments. Stefan and Joćo, any comments? If not, I'd like to install this on emacs-29 soon. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 04:55:34 2023 Received: (at 62142) by debbugs.gnu.org; 16 Mar 2023 08:55:35 +0000 Received: from localhost ([127.0.0.1]:41157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcjOY-0004DH-FS for submit@debbugs.gnu.org; Thu, 16 Mar 2023 04:55:34 -0400 Received: from mail-oa1-f43.google.com ([209.85.160.43]:37589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcjOX-0004D2-0j for 62142@debbugs.gnu.org; Thu, 16 Mar 2023 04:55:33 -0400 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-17aa62d0a4aso1387089fac.4 for <62142@debbugs.gnu.org>; Thu, 16 Mar 2023 01:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678956927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2nQxdJMVjIs0jS55UYpN3XCgG2gKKMk5XhZ4XxFYQ3w=; b=B4p+BM4TwuIGf8XaP3tFjFR1raslzoWpN4pBWJFiFD65UP8nFpv5QQnnNgKU8qxdp5 3ypYi/kD3/NLe1d6Fsvath3susO1FI3l7HRnhDy84EcEXPWrCcjNpqnuqkeJIAUlPw3f hZe8fQW9gE7UfTi2NdASBxEeMoXUQQSvsER/L0U6ogMFilGUAGJXDwoEsdX+4OM6251+ VJ6XIC/lJ9ajvCCXc7zXRTjoSa/Tl+0YARsRjLyhwXWQqYGKlo5zWZ3tO+7UfF1HdwX7 XDlgQjZpZqV5lXSzlj8aKFj5p2OOwE1ZSNDYm2xlZkZ5sjDYjpl+0MJ6n+oHIl5CN4Wf sjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678956927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2nQxdJMVjIs0jS55UYpN3XCgG2gKKMk5XhZ4XxFYQ3w=; b=I0qLzc26tAgYTFPHNhcY8QapGGe+lCTyNEnBn9jeUix3ic6df7kXLsOjXWiQiPy0wU 1rSF+dczDyWiI4JUcxH+Tm3mj5NMLEnbrDwLLffb5khotI+4Ld61uVFjoex8N65MWW67 cwt/oQnWiZ37Velzcbeu4Ae8dL7gpJOGOugtUv8WStMjD2G63Xz0GGDC27RdIdTXVFe2 TQCjMF3N69tpeN2dVk/qzV1SlPFDHFVrtLgt7OWrCS8FEBVVtyWKIGxLQg6eDi/sL+K5 OKb3WhMC/eXNYWLDxIJxNbY34ausPEyDPocLzeKXNqSv67/IAHJ9e3ITtbOL4hBVrBo8 Aa0Q== X-Gm-Message-State: AO0yUKXXUJXflEKITtCW5myqjVtnVEq0JqO2oi8FTjzH8BL4faUTjk9r 9AiMxHasy84Zc6iHmAPcY/tVwQxxmaI3tga3pu0= X-Google-Smtp-Source: AK7set9oMXX86E545K7D6BmZkk6c3f+GXAvBVC4Q076I/bg/Zbh7MRZ6D0WTgvaWM12yMbG/lEDo7HtsLfhxYVsd6b8= X-Received: by 2002:a05:6871:f8c:b0:17a:f324:850a with SMTP id vn12-20020a0568710f8c00b0017af324850amr172788oab.5.1678956927145; Thu, 16 Mar 2023 01:55:27 -0700 (PDT) MIME-Version: 1.0 References: <83bkktqi1n.fsf@gnu.org> In-Reply-To: <83bkktqi1n.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 16 Mar 2023 08:55:16 +0000 Message-ID: Subject: Re: bug#62142: 30.0.50; python-fill-paragraph problems on filling strings To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62142 Cc: 62142@debbugs.gnu.org, kobarity , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Mar 16, 2023, 07:20 Eli Zaretskii wrote: > > > > 3. `python-fill-paragraph' and `python-fill-string' use > > `python-info-triple-quoted-string-p' to detect triple quoted > > strings only. > > > > I look forward to your comments. > > Stefan and Jo=C3=A3o, any comments? If not, I'd like to install this on > emacs-29 soon. If electric-pair-mode integration is unaffected (which kobarity reports it is), LGTM (but I didn't really "look"). Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 09:27:56 2023 Received: (at 62142) by debbugs.gnu.org; 16 Mar 2023 13:27:56 +0000 Received: from localhost ([127.0.0.1]:41491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcne8-00084N-71 for submit@debbugs.gnu.org; Thu, 16 Mar 2023 09:27:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcne6-000847-Go for 62142@debbugs.gnu.org; Thu, 16 Mar 2023 09:27:54 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2103C8089E; Thu, 16 Mar 2023 09:27:49 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9E2368024C; Thu, 16 Mar 2023 09:27:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1678973267; bh=vx4ki1v3bYDKrqGoZ3sEfvTfr/EyGvTk2DmlSGekglU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CpIpUOI82Xecpd7MtW/vgdRtOP7t0k2LPJ5rdvNnGNyn6ZQZ2hStTsfnEAEogQ2C0 a6GxKRGuYob19XenbeAya6juS8+yPuVYDj9SCpLgul3nWn7YS9dZr0DboD41nCO6Ud mTza+Lr5F80PV6Wke+THzdSkSh932yWIlEUyjUSH/GMPanBFU0p5rNJlpZnehWxRKF Ya8R0711Hepl7c42MzpOHVwnJDxQGR77G2EO/GLlKip0qdlLFSWkwo5FQGq1FLC0g7 upATTl2s5bBZophcYTYSwLE1Z7TViDounMMOGvs5B/TtWnboybUg7ioJfFGENJfoKO fRqMAXQYvNsTA== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4D180122550; Thu, 16 Mar 2023 09:27:47 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62142: 30.0.50; python-fill-paragraph problems on filling strings In-Reply-To: <83bkktqi1n.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 09:20:04 +0200") Message-ID: References: <83bkktqi1n.fsf@gnu.org> Date: Thu, 16 Mar 2023 09:27:45 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62142 Cc: 62142@debbugs.gnu.org, kobarity , joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan and Jo=E3o, any comments? If not, I'd like to install this on > emacs-29 soon. I haven't had time to look deeply, but it looks sane, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 16 11:00:25 2023 Received: (at 62142-done) by debbugs.gnu.org; 16 Mar 2023 15:00:25 +0000 Received: from localhost ([127.0.0.1]:42744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcp5d-0002Uj-0b for submit@debbugs.gnu.org; Thu, 16 Mar 2023 11:00:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcp5b-0002UT-76 for 62142-done@debbugs.gnu.org; Thu, 16 Mar 2023 11:00:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcp5U-0003X3-UE; Thu, 16 Mar 2023 11:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=WSDtauihOdjDOS/1u7mUsiFJpQ1uodP5sg+cwHna+VA=; b=Z/5bmGloAQ3En/N8IaGc u6iCaUHEgh90ZqTku+tnq3rLbxKZZkXCOUOwhJZzl/zlcbb/PTV6v1zq06obZyopS0/gsab6zSmoH NQ2ZhlAq+bQJ8YvdadYs6aBshClsWPpm7jMAXK9f7rpL51Hl2mZmokI4WyiTc0EkKnMRdWRbnv0Gw ssIvbfmo+pX3YQ9oVuHG7diGNJ0ZerLP5rb9zevfDEzkz/ea/FBoiaArZLFFwUhYypW9rPU7dJGwZ nkyiXi3d14H5NhqXQUDw1Mt7R/tit0h2bOuNcF7/yR+St+RURB2jUD9cz6+1tA6Vg5ic1ffGZqJGn OFHHuVeQ1xXw4w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcp5T-0001aF-TM; Thu, 16 Mar 2023 11:00:16 -0400 Date: Thu, 16 Mar 2023 17:00:07 +0200 Message-Id: <831qlorbbc.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 16 Mar 2023 09:27:45 -0400) Subject: Re: bug#62142: 30.0.50; python-fill-paragraph problems on filling strings References: <83bkktqi1n.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62142-done Cc: 62142-done@debbugs.gnu.org, kobarity@gmail.com, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: kobarity , 62142@debbugs.gnu.org, > joaotavora@gmail.com > Date: Thu, 16 Mar 2023 09:27:45 -0400 > > > Stefan and Joćo, any comments? If not, I'd like to install this on > > emacs-29 soon. > > I haven't had time to look deeply, but it looks sane, Thanks, installed on the emacs-29 branch, and closing the bug. From unknown Mon Jun 23 18:30:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Apr 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator