From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 12 03:17:00 2023 Received: (at submit) by debbugs.gnu.org; 12 Mar 2023 07:17:01 +0000 Received: from localhost ([127.0.0.1]:59014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbFwx-0001GU-77 for submit@debbugs.gnu.org; Sun, 12 Mar 2023 03:17:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:43630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pb3Xq-00040b-6L for submit@debbugs.gnu.org; Sat, 11 Mar 2023 13:02:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb3Xp-00077V-Nr for bug-guix@gnu.org; Sat, 11 Mar 2023 13:02:14 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb3Xn-00085q-56 for bug-guix@gnu.org; Sat, 11 Mar 2023 13:02:13 -0500 Received: (Authenticated sender: manu@beffara.org) by mail.gandi.net (Postfix) with ESMTPSA id 3EABD60007 for ; Sat, 11 Mar 2023 18:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beffara.org; s=gm1; t=1678557728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=Z7pAdoMzgy44cGcaULrwBUG9kSc+B7Onj728cfgQ0Aw=; b=AIHjOcVaMlYXtVgmsM6/H+Gr1JIjutwwOI2r5p7yGgAwWGPC5aNvoDapGlCEaJ4YYbHzcA TLHiVaZXSA6iGKyNGDYCmL2FtRpdADZf0LLP2v44rkWdezdIuug0CKiQQaRJMFqDXbC2Mu EbKIeTDly5aUoAMC5kgNe7v2ncH9kAUXCCKlfY4mH9SfgwzuLeXCbac3C61/mT5r6oSHvk irA2cys6a/kcjhLbz4FfiXZ3tutahU8412tzI7HzDgMURsIyT1P1Cb74c1kCNvLeYv27mx QwmNCO+wHhFmJXxs/ed+nIPj80Cd005/8FYbZmM1UpGLbRKH59RDMw4ju10mpg== Date: Sat, 11 Mar 2023 19:02:06 +0100 Message-ID: <20230311190206.GD20567@beffara.org> From: Emmanuel Beffara To: bug-guix@gnu.org Subject: enable LVM in Grub References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=217.70.183.195; envelope-from=manu@beffara.org; helo=relay3-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 12 Mar 2023 03:16:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Guix, Unless I missed something in the configuration process, the `grub.cfg` generated by `guix system reconfigure` does not enable LVM, even if the store is in an LVM volume. The immediate consequence is that Grub cannot load its data files nor boot the system. The fix is as simple as adding `insmod lvm` in `grub.cfg` before any `search` command, which I do by hand on each `reconfigure`, but obviously Guix itself should do that. I looked at `grub.scm` to see where things happen, and I see no mention of LVM in this file. This surprises me because I am probably not the only one using it. Actually, I use LVM on LUKS for full-system encryption, but this is probably not rare either. -- Emmanuel From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 13 09:58:32 2023 Received: (at 62140) by debbugs.gnu.org; 13 Mar 2023 13:58:32 +0000 Received: from localhost ([127.0.0.1]:35236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbih6-0005hn-3g for submit@debbugs.gnu.org; Mon, 13 Mar 2023 09:58:32 -0400 Received: from sxb1nlsmtp04.prod.sxb1.secureserver.net ([92.204.71.242]:59068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbih4-0005hR-JC for 62140@debbugs.gnu.org; Mon, 13 Mar 2023 09:58:30 -0400 Received: from 122.164.205.92.host.secureserver.net ([92.205.164.122]) by : HOSTING RELAY : with ESMTP id bifxpYjCd0pCibifxpwgmW; Mon, 13 Mar 2023 06:57:22 -0700 X-SECURESERVER-ACCT: 92.205.164.122 x-originating-ip: 92.205.164.122 X-CMAE-Analysis: v=2.4 cv=K4PkXQaI c=1 sm=1 tr=0 ts=640f2bc2 a=B/z3iHJ5y0TSvJOmeNZOnw==:117 a=k__wU0fu6RkA:10 a=mDV3o1hIAAAA:8 a=DPhktE-f66EncVhs4UgA:9 a=QEXdDO2ut3YA:10 a=idiw4t6ShAqVqCx07NwA:9 a=FfaGCDsud1wA:10 a=_FVE-zBwftR9WsbkzFJk:22 Received: from [192.168.1.3] (helo=micha) by 122.164.205.92.host.secureserver.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pbif0-00GYFo-FC; Mon, 13 Mar 2023 14:57:21 +0100 From: Michael Rohleder To: Emmanuel Beffara Subject: Re: bug#62140: enable LVM in Grub In-Reply-To: <20230311190206.GD20567@beffara.org> (Emmanuel Beffara's message of "Sat, 11 Mar 2023 19:02:06 +0100") References: <20230311190206.GD20567@beffara.org> Date: Mon, 13 Mar 2023 14:56:15 +0100 Message-ID: <87sfe8n4ao.fsf@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CMAE-Envelope: MS4xfNh22RsKObPUHSIF+O6STVfN8LB882kiK0oIDlraFDMtRWOFlDrMUnMq3BONF/Tc2tk3ecAODqp3jDln34ydG9QGD7cHntZ71FD2dHSL1LlpRiQzsEIT x7JxieGdydH260hhsvLoZg83UgNPbC3i230bJ0pCJ/8xVbIT726J58TTLJ2PcqofUWALD+je0YSqtXKn5xeNpQnuhFfVYmNpmQ+WNlMpcB4vyxc0LQ6qh8Qd H8iop/64S/s7FC+Esd1dksYJucd8uZzAgarmbutgTv8= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Emmanuel! Thx for the report! I think this is bug 44877, maybe we can/should merge it. Here [1] is a patch (and testcase). [1] https://issues.guix.gnu.org/60442 =2D-=20 Man braucht zwei Jahre, um sprechen zu lernen, und f=C3=BCnfzig, um schweigen zu lernen. E.Hemingway --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAmQPK38RHG1pa2VAcm9o bGVkZXIuZGUACgkQfHr/vv7yyyV20Af/Y60a+oenaXE+D8/VWjvHjxtSoBkkMCeV lwCiNFWRVogvjdDr+YeF2Rbr9xT1WhXcdkKkoucYol9ViQ6MB2D89q4TNo0+PtaD FfJDh3SV9hb6aRHDnKU4jcXgcVVzSxKViyaTuiLblHCiPZ3ehBNh6cdNvDrP38S9 loYexndXef57MZ3ceFSK/i4ot/HzOePovQeRoVsY7ArXDK29xzrfsywqiVnfo9RF Zdf6w2aPy69vJfBW84CRIrGTS+idq8A2ZRFxI5VsjYXxnZ8fX6R0SVOXZyHaVtPH imFn+fqOqm0muIlNPKuB06xcB1iye4/unAVv6FdXHu13+1G3wwy4jg== =ywS/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 14 17:26:40 2023 Received: (at 62140) by debbugs.gnu.org; 14 Mar 2023 21:26:40 +0000 Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcCAK-0004Tf-14 for submit@debbugs.gnu.org; Tue, 14 Mar 2023 17:26:40 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:35661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcCAH-0004TL-VJ; Tue, 14 Mar 2023 17:26:38 -0400 Received: (Authenticated sender: manu@beffara.org) by mail.gandi.net (Postfix) with ESMTPSA id 84D6A100003; Tue, 14 Mar 2023 21:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beffara.org; s=gm1; t=1678829191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FtvQWVe1f0t4x8rlUEr2TOrlDGgXj5+/u6PwMu4J79U=; b=cc4ypsipy0KM1mFrBh7gDXa30L70em/KDYrjiasHlhtfpaFTJ6Ps2J6h3Um8Ol3a0h4oFP 3e+SKWhb5vvHKkKJK1vLvBVcizAaSl2KmqzyFHlV9nrA2UDxBlqKBkb2tFZhhBWla5Mmf+ C8BUCGDHkKbvTsUjA2rYIljMILx/inp8qHA3WMeMvbOpMupMYacpEEntuL+jf5RZFhQE3Q FW9tjV9aPY0AeimLFk4LkeKq/+hqWZkOPMLKuscNGWu2g5ST/R09DfXonWlNQ4cGipA2jo R1jeR4VuTaUDgaAFEDCjgebZ8p+IUbnmQcnZKPjEH3Y149QOZG+ZT4VUnAPgrg== Date: Tue, 14 Mar 2023 22:26:28 +0100 Message-ID: <20230314222628.GE14391@beffara.org> From: Emmanuel Beffara To: Michael Rohleder Subject: Re: bug#62140: enable LVM in Grub In-Reply-To: <87sfe8n4ao.fsf@rohleder.de> References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) De Michael Rohleder le 13/03/2023 à 14:56: > Hello Emmanuel! > > Thx for the report! > > I think this is bug 44877, maybe we can/should merge it. > Here [1] is a patch (and testcase). > > > [1] https://issues.guix.gnu.org/60442 Indeed, it seems to be the same issue. However, the patch sets the value of `GRUB_PRELOAD_MODULES`, which afaik is used by `grub-mkconfig` to produce `grub.cfg`, but there seems to be code in `grub.scm` that also produces `grub.cfg`, and no call to `grub-mkconfig` there. I'm not sure I understand how all this works anyway… -- Emmanuel From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 08:49:01 2023 Received: (at 62140) by debbugs.gnu.org; 23 Mar 2023 12:49:01 +0000 Received: from localhost ([127.0.0.1]:37481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfKNJ-0006HQ-0Q for submit@debbugs.gnu.org; Thu, 23 Mar 2023 08:49:01 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:37806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfKNB-0006Gw-V8; Thu, 23 Mar 2023 08:48:54 -0400 Received: by mail-qt1-f179.google.com with SMTP id r5so26311743qtp.4; Thu, 23 Mar 2023 05:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679575728; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=6K4nx2aBuMp0k7wAFlXjb0WR+7ZyQPN3BJ1cVIV6Qi0=; b=nkBfz7YwvjFEPMVrIPFUDu2V7hJqSwVmoBxrj9Dfd3oNF3SCeP+qNJ924UYexu4VRT 7kFvEOENfY2WkAK0cL2Yv4N86xDAVEjXY7TpRjKkOayk3Z4GbgjFQCquwi4CxUNdDrPC CHGTaiWM7kX6n2dtbXCaCfValgakQgOHqdycjVrsF9/m5g0f4DZ/R5lBAIVFtTf1XnDG RSqjuyW/tZkT8SiHzXryr9UtpZlpXOftH0upUlGVcpHPmrK+b/oIuwSXbtd4wvryixZp gQjMaBDjcKTSqc+8srHniZxeyCz4WJHL3rUzn21eaQ0NzSNg1K9NQs9aYi9DnPYQ0AR1 VcfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679575728; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6K4nx2aBuMp0k7wAFlXjb0WR+7ZyQPN3BJ1cVIV6Qi0=; b=wRFJFf8jxc3yIMK6MU9GW3VEwUcEMQ8H0ZTIL1w+hFiXv78mIONPKb+EnzrlUfAE7j v7pXxgLsIlgx5nXVzY1X0ddVU4Q5qUY44Z68EG9mE0h3wi9PppOtsrF290fNqoHD+uw5 zsW29abu3eIU0911oXZW/f4j66Oter/EUwRRiSnRlfGrVxN/7WgmfX5yZTlS4zEdBGuf 7YuCMVWy7o74nlseeR6ZXKeghbjJ+E/bscsURR9qZP2lhW8KeSVr03g9XbzwZ58DjebR wQn3rL1SDV/KOfecxKMgGLzBCFY5FmTe6hK5rQ0HhwYO7NhyKgSaiuc8vMtB4zFap/BR OAeA== X-Gm-Message-State: AO0yUKVjzUrPjscMLbtkDfzUKa239DZ8qEoBog3dnBYG7wU7FDI9CfpF LDyb2xbexHaFgHoqGabEbDWT+vnlNaB3Nw== X-Google-Smtp-Source: AK7set+WLZS1BHkRYGbYpvxIw9IQAPuMHDWiifp70k6fhKsnpUjas7OUSrotDXvJ6xH15zPyyzaslA== X-Received: by 2002:a05:622a:4:b0:3e1:78b5:7198 with SMTP id x4-20020a05622a000400b003e178b57198mr8647999qtw.8.1679575728085; Thu, 23 Mar 2023 05:48:48 -0700 (PDT) Received: from hurd (dsl-155-54.b2b2c.ca. [66.158.155.54]) by smtp.gmail.com with ESMTPSA id b2-20020ac84f02000000b003e39721fd41sm368090qte.84.2023.03.23.05.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:48:47 -0700 (PDT) From: Maxim Cournoyer To: Emmanuel Beffara Subject: Re: bug#62140: enable LVM in Grub References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> <20230314222628.GE14391@beffara.org> Date: Thu, 23 Mar 2023 08:48:46 -0400 In-Reply-To: <20230314222628.GE14391@beffara.org> (Emmanuel Beffara's message of "Tue, 14 Mar 2023 22:26:28 +0100") Message-ID: <87v8ireiq9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, Michael Rohleder , 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Emmanuel Beffara writes: > De Michael Rohleder le 13/03/2023 =C3=A0 14:56: >> Hello Emmanuel! >>=20 >> Thx for the report! >>=20 >> I think this is bug 44877, maybe we can/should merge it. >> Here [1] is a patch (and testcase). >>=20 >>=20 >> [1] https://issues.guix.gnu.org/60442 > > Indeed, it seems to be the same issue. > > However, the patch sets the value of `GRUB_PRELOAD_MODULES`, which afaik = is > used by `grub-mkconfig` to produce `grub.cfg`, but there seems to be code= in > `grub.scm` that also produces `grub.cfg`, and no call to `grub-mkconfig` > there. I'm not sure I understand how all this works anyway=E2=80=A6 Guix indeed takes care to generate the grub.cfg itself, via the make-grub-configuration procedure from (gnu bootloader grub), and grub-mkconfig is *not* used. grub-install is used though, so perhaps GRUB_PRELOAD_MODULES could be honored by it (although it's not documented so I doubt it). It seems to me that since we produce grub.cfg ourselves if there's something to add there for LVM support (which I'm not sure there is -- apparently it already works for you ?), it should be explicitly coded in (gnu bootloader grub). info '(grub) Changes from GRUB Legacy' mentions that "* GRUB 2 can read files directly from LVM and RAID devices.", so I would think there's nothing special to do? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 04:23:47 2023 Received: (at 62140) by debbugs.gnu.org; 24 Mar 2023 08:23:48 +0000 Received: from localhost ([127.0.0.1]:39776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfciB-0006yj-D7 for submit@debbugs.gnu.org; Fri, 24 Mar 2023 04:23:47 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:44899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfci3-0006yF-9I; Fri, 24 Mar 2023 04:23:46 -0400 Received: (Authenticated sender: manu@beffara.org) by mail.gandi.net (Postfix) with ESMTPSA id A8503240008; Fri, 24 Mar 2023 08:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beffara.org; s=gm1; t=1679646205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fJJ1aQu8JY9hkYlltb1z/a2SPuXVzbW8bmNjmbgNKD4=; b=JlOH77JUQnVpbKl2mQCAVb3yz0/eDCamwkYPUNjbKkU/iRn2/3EQ22pVQjOmzM0c0dSG44 74CDIbPDkMkjGx8i0KvdmlAwZs+9MOIQ430ApZ+R6heFTxZDbBRSye7t1+DGVeNXqhZ7sH /AVmuFANq7TZ+BNbkz7687IMCiGWl9i0I/+pExtOBSZy+rmuw9/HK9JDQF8oY0uay5mfAN LCtOC7P0W39/tdWBmjJ9iIfvfBmY69KRlBiQOG3arvCrX6IscVATgfm/a9yCchHcwy9MqU uV1tTQj0sUvFGM2Czoq48n4874J8upBqSKioi829ZmAnbo5u3F8muIy319j8ag== Date: Thu, 23 Mar 2023 15:58:19 +0100 Message-ID: <20230323155819.GC5268@beffara.org> From: Emmanuel Beffara To: Maxim Cournoyer Subject: Re: bug#62140: enable LVM in Grub In-Reply-To: <87v8ireiq9.fsf@gmail.com> References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> <20230314222628.GE14391@beffara.org> <87v8ireiq9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, Michael Rohleder , 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Hello, De Maxim Cournoyer le 23/03/2023 à 13:48: > It seems to me that since we produce grub.cfg ourselves if there's something > to add there for LVM support (which I'm not sure there is -- apparently it > already works for you ?), it should be explicitly coded in (gnu bootloader > grub). It does not work for me, that is why I reported this! The system does not boot unless I manually add `insmod lvm` in `grub.cfg` because Grub does not find the partition that contains the store. So I agree something has to be done there. > info '(grub) Changes from GRUB Legacy' mentions that "* GRUB 2 can read > files directly from LVM and RAID devices.", so I would think there's nothing > special to do? As I understand it, this just means that Grub 2 has a module for reading LVM devices and a module for reading RAID devices. But it still has to load them somehow (unless there is a way to include them statically so they are available from the beginning). -- Emmanuel From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 12:30:13 2023 Received: (at 62140) by debbugs.gnu.org; 24 Mar 2023 16:30:13 +0000 Received: from localhost ([127.0.0.1]:41259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfkIv-0006Zn-B8 for submit@debbugs.gnu.org; Fri, 24 Mar 2023 12:30:13 -0400 Received: from mail-ua1-f53.google.com ([209.85.222.53]:45872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfkIq-0006YI-KG; Fri, 24 Mar 2023 12:30:12 -0400 Received: by mail-ua1-f53.google.com with SMTP id x33so1770290uaf.12; Fri, 24 Mar 2023 09:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679675403; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=OQa7D/mlEsd+FSBfoZWGlsX3gw9kCPH5EoIxvX5g0jI=; b=TIC6Da20RxX5VKecMhHIicUEgCNsMjlV8rICa8QQ6smh02z/ZQcKpbHeG2V94sOQfX RJtuhFb4J236zA2KeGaXy4TVL4tenEM+BSpSMaYT2RB0LVR2Xmae1zYUGrzNiFM0yBsh Atb7LFfawiMapgjEsdAcDj6Q/vofOYV/5nrSExFeEj54iCcnonyMyGCMtsZLyn3lpqU3 h9nLyX3rj6ES4ZPHJZDdZHLGz4X3kxhZalZpS1k0fcVCHQD+sPUvj5d8Aglnum3oFU0f JXMcwUNqkfhiTNb+Dz41eT+5yzNcHYAjxawWFthlXWNfCA7vTeWgwOZhF31vZ+3bC0pV QUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679675403; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OQa7D/mlEsd+FSBfoZWGlsX3gw9kCPH5EoIxvX5g0jI=; b=H9jdgN6Xud49m3Vmspqg6GatJd85DANKDFZGcugauNpVFUWcE2xyJVoCm36VUWHEG3 0sOBrwX8lLNKfnoROldFdnXz2Dirr9lcbgcTqcLbO0MUVYBiAcZ1DAdCktT39B6WgmIA KjAoJUxtTU9KIqed/kuFkbXziEZeagdVGP8HdrbINezG1hm3AkIGKB484fs3N5ytat4W lxtGiRaDvTnm04A4zTJA/8lXy5zCFGIh2XZMyBRtmZo+yQnxTUspT4pfozszNIg8Nx+u Dc5j3cTXUqn2x5aFHpnNzhLNZNT2vUKkVnpicoiMI8/yKax5yBb/f0CgHhBO1HqMaxux xYiQ== X-Gm-Message-State: AAQBX9fDL2auE1bO+D/bj7DXwEQTu9lYGQZzmFQ0rjriF2dlQtDir3fs rz2TVeuF/INRZZEUEWfP8kb80OHXqdm/Yg== X-Google-Smtp-Source: AKy350aBtz/pFIJ7bBe0k8W+f1BLIPfMqzyZMwChTEVCSK/nwLPqtX6IVMQwgJL5p5XQU+Pj/IWjRg== X-Received: by 2002:ac8:59cf:0:b0:3e4:d889:bc64 with SMTP id f15-20020ac859cf000000b003e4d889bc64mr460059qtf.5.1679660671625; Fri, 24 Mar 2023 05:24:31 -0700 (PDT) Received: from hurd (dsl-155-54.b2b2c.ca. [66.158.155.54]) by smtp.gmail.com with ESMTPSA id q21-20020a05620a0c9500b007422fa6376bsm14115400qki.77.2023.03.24.05.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 05:24:31 -0700 (PDT) From: Maxim Cournoyer To: Emmanuel Beffara Subject: Re: bug#62140: enable LVM in Grub References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> <20230314222628.GE14391@beffara.org> <87v8ireiq9.fsf@gmail.com> <20230323155819.GC5268@beffara.org> Date: Fri, 24 Mar 2023 08:24:30 -0400 In-Reply-To: <20230323155819.GC5268@beffara.org> (Emmanuel Beffara's message of "Thu, 23 Mar 2023 15:58:19 +0100") Message-ID: <87edpe1gn5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, Michael Rohleder , 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Emmanuel Beffara writes: > Hello, > > De Maxim Cournoyer le 23/03/2023 =C3=A0 13:48: >> It seems to me that since we produce grub.cfg ourselves if there's somet= hing >> to add there for LVM support (which I'm not sure there is -- apparently = it >> already works for you ?), it should be explicitly coded in (gnu bootload= er >> grub). > > It does not work for me, that is why I reported this! The system does not= boot > unless I manually add `insmod lvm` in `grub.cfg` because Grub does not fi= nd > the partition that contains the store. > > So I agree something has to be done there. OK, thanks for explaining. Could you please try https://issues.guix.gnu.org/60442 (by applying the patch to a local guix checkout, building it, then 'sudo -E ./pre-inst-env sudo guix system reconfigure /path/to/your/config.scm)? The test suite was broken it seems (it passed without the fix), but perhaps the fix still does work? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 08:32:48 2023 Received: (at 62140) by debbugs.gnu.org; 28 Mar 2023 12:32:48 +0000 Received: from localhost ([127.0.0.1]:49130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph8VM-0007eM-8x for submit@debbugs.gnu.org; Tue, 28 Mar 2023 08:32:48 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph8VJ-0007e2-RM; Tue, 28 Mar 2023 08:32:46 -0400 Received: (Authenticated sender: manu@beffara.org) by mail.gandi.net (Postfix) with ESMTPSA id 7D13E60014; Tue, 28 Mar 2023 12:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beffara.org; s=gm1; t=1680006759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+i6tMtK2mBq0/QhmB3g3cZ+WF7MHCpUPpJvEPRN95sE=; b=STg12QbG1beezowhCCwVLXIh/IgTQDgEOtX4u/4RIk9u2TeEPXPDPFcW00ZiPQX73ohFs5 y/QG/QQPHqnvvdksXDOEc8RlD7K6iHEXl0JSWmjglSDTWQzofQacr7oSOD0jS6OdgVxuGY zk0GP2K+Kg2Gap5k/SbO9T2ENxW+/u03rYfRLWD0+0+2gg1U5qIHRpge3dBDS2z0ZDUWqC yMIvf4m1jIsFYHEUZHRDBqSNv2OfSh6LgMCct+OdRr0E16dxdTmUpDXhO3VBMNM9Kd0zs+ Xmxsgb3bYjBiRnSVeAcFLiShw/ymfP1yZ3ubYeG/hbXhenGXSS5u0c5GQVPP7Q== Date: Tue, 28 Mar 2023 14:32:36 +0200 Message-ID: <20230328143236.GD1964@beffara.org> From: Emmanuel Beffara To: Maxim Cournoyer Subject: Re: bug#62140: enable LVM in Grub In-Reply-To: <87edpe1gn5.fsf@gmail.com> References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> <20230314222628.GE14391@beffara.org> <87v8ireiq9.fsf@gmail.com> <20230323155819.GC5268@beffara.org> <87edpe1gn5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, Michael Rohleder , 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, De Maxim Cournoyer le 24/03/2023 à 13:24: > OK, thanks for explaining. Could you please try > https://issues.guix.gnu.org/60442 (by applying the patch to a local guix > checkout, building it, then 'sudo -E ./pre-inst-env sudo guix system > reconfigure /path/to/your/config.scm)? The test suite was broken it > seems (it passed without the fix), but perhaps the fix still does work? I did as you suggested, and unfortunately the patch has no observable effect on my system. I can't say it comes as a surprise. Indeed, what the patch does is set the environment variable `GRUB_PRELOAD_MODULES` before calling `grub-install`, which is expected to have no effect: this variable is used by `grub-mkconfig` to generate a `grub.cfg`, but the code in Guix assembles a Grub configuration file itself and never calls `grub-mkconfig`. The same applies to the variable `GRUB_ENABLE_CRYPTODISK`, by the way. Maybe the way `grub.cfg` is produced has changed at some point in history ? The only hypothesis I can make is that it would influence `grub-install` by preloading the given modules in the installed image, but that is not the case. According to Grub's documentation, passing `--modules=...` to `grub-install` would have this effect, but I'm not sure it is the right approach. -- Emmanuel From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 10:10:47 2023 Received: (at 62140) by debbugs.gnu.org; 28 Mar 2023 14:10:47 +0000 Received: from localhost ([127.0.0.1]:50347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phA2A-000231-IO for submit@debbugs.gnu.org; Tue, 28 Mar 2023 10:10:46 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:36504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phA29-00022i-5N; Tue, 28 Mar 2023 10:10:45 -0400 Received: by mail-qt1-f172.google.com with SMTP id hf2so11982170qtb.3; Tue, 28 Mar 2023 07:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680012639; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=g4yGCBBGK/wjlUSZJbhXOcl46KKBl5wauDk4Mb/oYzk=; b=LgDmgJlNkr/h01aQ93BzicECmVfKU4GWxQ0FoCalGwEycLPamPpFw9172z3mttRuHs CYOmaZcZsje0xy7Pd/HhLJbH3FkQVCCFqAuDSq917Xci0Mbk9Bf8B8LgKgdoX+3cJg9s v8ZcksVtSpfI+ItlxbH5TRD/Fsm+QnBzJKN1sQL/63l+MYAh+AngLt+lrK1bzgRmBPOW tDwEaackmci6KWQ9X4v09K5ywf9HY/OmSQfqxPICobS6HKa4iFBrrQ1h4y6u7wMBReBS e3cW9Pz0tuE+LVNNokFK5wm5ZsF0c/pFpG3uNMBErTgPsvmhOYXmo++0vyU/1HK0Nowm evBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680012639; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=g4yGCBBGK/wjlUSZJbhXOcl46KKBl5wauDk4Mb/oYzk=; b=GNn5Fm4QUptBe417LRm+dhNRCsFmfaQgJALnBB28agX6hduKcXlmuEAvxE0E/VqwNL k2SZB2L8erwtcx054fmOi37Y0nzTUIDRcpDZ/LBy51cCxzV87AD1VQtAUvlRe3tpl8Fc 5iLFjwVZej9PxzzjoB9hbu/pF3j7qFThsrSCfCbbA2G8dHUdn2b7zc1PCtqyoR3S0ybi Q/uDp4f/ZleY0d0aMkTBp/LG3PEjZbuG5CpBTkf6ct13HeWUMIjCwbKghtbzI+LW8UA3 B4rxSvHgglOoaiNeIxKbwdaEcgQSH/0BdJ+RA5uHszo1b/0wsKIIoz2oXOn9rjSmHIgG 1bRA== X-Gm-Message-State: AO0yUKVK8NkXFX3T6RGCWLBfWe7jz3fFKp2rVsnAINAr93MOApCKez6K IiKq+/gSltHHDxA2sX2KpHVRmcSvwVM= X-Google-Smtp-Source: AK7set8rvDOJD/F+N+KeW4ss/afTpYCrKze9Scy82OR6ka1Z7la2a1JNiIDKCVcyqbWWszIindtNVg== X-Received: by 2002:ac8:5e0c:0:b0:3bf:c3be:758e with SMTP id h12-20020ac85e0c000000b003bfc3be758emr27752413qtx.16.1680012639172; Tue, 28 Mar 2023 07:10:39 -0700 (PDT) Received: from hurd (dsl-205-151-56-156.b2b2c.ca. [205.151.56.156]) by smtp.gmail.com with ESMTPSA id 11-20020a37030b000000b00745a55db5a3sm11966435qkd.24.2023.03.28.07.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 07:10:38 -0700 (PDT) From: Maxim Cournoyer To: Emmanuel Beffara Subject: Re: bug#62140: enable LVM in Grub References: <20230311190206.GD20567@beffara.org> <87sfe8n4ao.fsf@rohleder.de> <20230314222628.GE14391@beffara.org> <87v8ireiq9.fsf@gmail.com> <20230323155819.GC5268@beffara.org> <87edpe1gn5.fsf@gmail.com> <20230328143236.GD1964@beffara.org> Date: Tue, 28 Mar 2023 10:10:37 -0400 In-Reply-To: <20230328143236.GD1964@beffara.org> (Emmanuel Beffara's message of "Tue, 28 Mar 2023 14:32:36 +0200") Message-ID: <87v8ilnezm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62140 Cc: 62140@debbugs.gnu.org, Michael Rohleder , 44877@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Emmanuel Beffara writes: > Hi, > > De Maxim Cournoyer le 24/03/2023 =C3=A0 13:24: >> OK, thanks for explaining. Could you please try >> https://issues.guix.gnu.org/60442 (by applying the patch to a local guix >> checkout, building it, then 'sudo -E ./pre-inst-env sudo guix system >> reconfigure /path/to/your/config.scm)? The test suite was broken it >> seems (it passed without the fix), but perhaps the fix still does work? > > I did as you suggested, and unfortunately the patch has no observable eff= ect > on my system. Thanks for testing it! > I can't say it comes as a surprise. Indeed, what the patch does is set the > environment variable `GRUB_PRELOAD_MODULES` before calling `grub-install`, > which is expected to have no effect: this variable is used by `grub-mkcon= fig` > to generate a `grub.cfg`, but the code in Guix assembles a Grub configura= tion > file itself and never calls `grub-mkconfig`. The same applies to the vari= able > `GRUB_ENABLE_CRYPTODISK`, by the way. Maybe the way `grub.cfg` is produce= d has > changed at some point in history ? I'm not sure, but I agree it's confusing to have extraneous setenv there if they serve no purpose (and my understanding is the same as yours: I don't see how that'd work). > The only hypothesis I can make is that it would influence `grub-install` = by > preloading the given modules in the installed image, but that is not the = case. > According to Grub's documentation, passing `--modules=3D...` to `grub-ins= tall` > would have this effect, but I'm not sure it is the right approach. Since we already generate a custom grub.cfg, the right approach is probably to add any needed directive directly to it. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 23 16:10:55 2024 Received: (at 62140) by debbugs.gnu.org; 23 Jan 2024 21:10:55 +0000 Received: from localhost ([127.0.0.1]:44047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSO2o-0002nb-9w for submit@debbugs.gnu.org; Tue, 23 Jan 2024 16:10:55 -0500 Received: from mail-4324.protonmail.ch ([185.70.43.24]:20963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSJly-0003hi-Ic for 62140@debbugs.gnu.org; Tue, 23 Jan 2024 11:37:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1706027822; x=1706287022; bh=pt1DSyLdA7Bt5EYjlwfiPT4kky633Ht8WmG5tvxmKq4=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=jPoHMstCDrj4t6nV1qECH5XA0ffkNuQL8LCpbouodU/xn47eEOQj/XA2NSBe0bwy3 LuSGNETBW6M+CIoH0zaef4GoR/09C+ceBpW1vve+ZkXvDHlq6G/UGjngiMQTyYiwzr bpZv5SqewwkAheq3IA5AxE0joURWkIZYgZLjtHMKdLhZT9LwcjUV0PJtASiQ9EyUnb hbM6Lwj+zDunm4RSO2sKyOpY+yJ8ab5phTopI3L9VuKqFtHZEouPoE6ZBUG/Kf0u5M ncjuEMxUtpk9Xuo03H/v72MvwSvGy3er88tMxZWTsCczaMTkdS/QCY/5m4A0QToigA 4dzZMI0c/Q3Wg== Date: Tue, 23 Jan 2024 16:36:45 +0000 To: 62140@debbugs.gnu.org From: Erik Eduardo Subject: enable LVM in Grub Message-ID: Feedback-ID: 10490823:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_akyvq0bVlyC8hGgk8d30IaUZ7vpeWUNbR3EOeUP3pM" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62140 X-Mailman-Approved-At: Tue, 23 Jan 2024 16:10:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_akyvq0bVlyC8hGgk8d30IaUZ7vpeWUNbR3EOeUP3pM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SSBjb3VsZCBjb3JyZWN0bHkgaW1wbGVtZW50IGx2bSBhcyByb290IChJIHRoaW5rKSwgaG93ZXZl ciB0aGVyZSBpcyBhbnkgaW50ZW50aW9uIG9uIHN1cHBvcnQgdGhpcyBvbiBndWl4PyBMZXQgbWUg a25vdyBhbmQgSSB3aWxsIHRyeSB0byBzZW5kIGEgcGF0Y2gu --b1_akyvq0bVlyC8hGgk8d30IaUZ7vpeWUNbR3EOeUP3pM Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 SSBjb3VsZCBjb3JyZWN0bHkgaW1wbGVtZW50IGx2bSBhcyByb290IChJIHRoaW5rKSwgaG93ZXZl ciB0aGVyZSBpcyBhbnkgaW50ZW50aW9uIG9uIHN1cHBvcnQgdGhpcyBvbiBndWl4PyBMZXQgbWUg a25vdyBhbmQgSSB3aWxsIHRyeSB0byBzZW5kIGEgcGF0Y2guPGJyPjxicj48YnI+ --b1_akyvq0bVlyC8hGgk8d30IaUZ7vpeWUNbR3EOeUP3pM--