GNU bug report logs - #62138
[PATCH] gnu: a2ps: Update to 4.15

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62138: closed ([PATCH] gnu: a2ps: Update to 4.15)
Date: Mon, 03 Apr 2023 11:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 03 Apr 2023 13:12:07 +0200
with message-id <87edp1i5iw.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#62138] [PATCH v7] gnu: a2ps: Update to 4.15.3
has caused the debbugs.gnu.org bug report #62138,
regarding [PATCH] gnu: a2ps: Update to 4.15
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62138: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62138
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: a2ps: Update to 4.15
Date: Sat, 11 Mar 2023 22:48:15 -0800

* gnu/packages/pretty-print.scm (a2ps): update to 4.15
---
 gnu/packages/pretty-print.scm | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/pretty-print.scm b/gnu/packages/pretty-print.scm
index 7bc54c4a0b..bc104447d5 100644
--- a/gnu/packages/pretty-print.scm
+++ b/gnu/packages/pretty-print.scm
@@ -37,7 +37,9 @@ (define-module (gnu packages pretty-print)
   #:use-module (gnu packages)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
+  #:use-module (gnu packages bdw-gc)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gperf)
@@ -52,14 +54,14 @@ (define-module (gnu packages pretty-print)
 (define-public a2ps
   (package
     (name "a2ps")
-    (version "4.14")
+    (version "4.15")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnu/a2ps/a2ps-"
                                   version ".tar.gz"))
               (sha256
                (base32
-                "195k78m1h03m961qn7jr120z815iyb93gwi159p1p9348lyqvbpk"))
+                "0lk6qycjw26z6jhnf353z7m469xp91lypdf6ay54961g4alwbbd5"))
               (modules '((guix build utils)))
               (snippet
                ;; Remove timestamp from the installed 'README' file.
@@ -67,16 +69,12 @@ (define-public a2ps
                   (substitute* "etc/README.in"
                     (("@date@")
                      "1st of some month, sometime after 1970"))
-                  #t))
-              (patches (search-patches
-                        "a2ps-CVE-2001-1593.patch"
-                        "a2ps-CVE-2014-0466.patch"
-                        "a2ps-CVE-2015-8107.patch"))))
+                  #t))))
     (build-system gnu-build-system)
     (inputs
-     (list psutils gv))
+     (list psutils file gv libgc libpaper))
     (native-inputs
-     (list gperf groff perl))
+     (list gperf groff perl pkg-config))
     (arguments
      '(#:phases
        (modify-phases %standard-phases

base-commit: f289fe316aaa06e60f4b10e75e113cf1aeb03629
prerequisite-patch-id: 8c2c8788f860cf601f04bf10e2f932f63c0c449a
-- 
2.39.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andy Tai <atai <at> atai.org>
Cc: 62138-done <at> debbugs.gnu.org
Subject: Re: [bug#62138] [PATCH v7] gnu: a2ps: Update to 4.15.3
Date: Mon, 03 Apr 2023 13:12:07 +0200

Hello,

Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/pretty-print.scm (a2ps): update to 4.15.3.
>   Remove now unneeded patches.
>
> * gnu/packages/patches/a2ps-CVE-2001-1593.patch,
>   gnu/packages/patches/a2ps-CVE-2014-0466.patch,
>   gnu/packages/patches/a2ps-CVE-2015-8107.patch: Remove

Thank you.

I completed the commit message (missing modification of inputs) and pushed.

>      (inputs
> -     (list psutils gv))
> +     (list psutils file gv libgc libpaper))

I reordered it alphabetically.

> +         (add-after 'unpack 'skio-failed-tests

Typo fixed.

> +           (lambda _
> +                     (substitute* "tests/Makefile.am"
> +                       (("encoding.tst") ""))
> +                     (substitute* "tests/Makefile.am"
> +                       (("prolog-2.tst") ""))
> +                     (substitute* "tests/Makefile.in"
> +                       (("encoding.tst") ""))
> +                     (substitute* "tests/Makefile.in"
> +                       (("prolog-2.tst") ""))))

I simplified the multiple substitute* calls.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.