Subject: Re: [PATCH] gnu: Add cyanrip.

From: Liliana Marie Prikler <[email-masked]>
Date: Mon, 13 Mar 2023 21:42:30 +0100

Am Samstag, dem 11.03.2023 um 23:30 +0100 schrieb [email-masked]:
> From: Simon Streit <[email-masked]>
> 
> * gnu/packages/audio.scm (cyanrip): New variable.
> ---
>  gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6f3fa2a580..966a0b96f9 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -38,7 +38,7 @@
>  ;;; Copyright © 2021 Aleksandr Vityazev <[email-masked]>
>  ;;; Copyright © 2022 Arjan Adriaanse <[email-masked]>
>  ;;; Copyright © 2022 Juliana Sims <[email-masked]>
> -;;; Copyright © 2022 Simon Streit <[email-masked]>
> +;;; Copyright © 2022, 2023 Simon Streit <[email-masked]>
>  ;;; Copyright © 2022 Andy Tai <[email-masked]>
>  ;;; Copyright © 2023 Sergiu Ivanov <[email-masked]>
>  ;;; Copyright © 2023 David Thompson <[email-masked]>
> @@ -68,6 +68,7 @@ (define-module (gnu packages audio)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages build-tools)
>    #:use-module (gnu packages boost)
> +  #:use-module (gnu packages cdrom)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -124,6 +125,7 @@ (define-module (gnu packages audio)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages valgrind)
> +  #:use-module (gnu packages version-control)
>    #:use-module (gnu packages video)
>    #:use-module (gnu packages vim) ;xxd
>    #:use-module (gnu packages web)
> @@ -6316,3 +6318,29 @@ (define-public cubeb
>        (description "Cubeb is Mozilla's cross-platform audio
> library.")
>        (home-page "https://github.com/mozilla/cubeb")
>        (license license:isc))))
> +
> +(define-public cyanrip
> +  (package
> +    (name "cyanrip")
> +    (version "0.9.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/cyanreg/cyanrip")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
> +    (build-system meson-build-system)
> +    (native-inputs
> +     (list pkg-config))
> +    (propagated-inputs
> +     (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2
> neon))
Propagated inputs are not that great, prefer normal ones.  Also don't
let the lines get too long.
> +    (synopsis "Fully featured CD ripping program")
Avoid marketing buzzwords; perhaps use "Console CD ripper" instead?
> +    (description "Console CD ripper with automatic tagging through
> integration
> +with MusicBrainz , error detection, log generation, many formats,
> HDCD
> +decoding, covert art automatic download.")
Please use complete sentences for the description.

Cheers