GNU bug report logs - #62109
29.0.60; rust-ts-mode missing indentation for patterns

Previous Next

Package: emacs;

Reported by: Yuan Fu <casouri <at> gmail.com>

Date: Fri, 10 Mar 2023 22:34:01 UTC

Severity: normal

Found in version 29.0.60

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62109: closed (29.0.60; rust-ts-mode missing indentation for
 patterns)
Date: Sat, 11 Mar 2023 23:54:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 11 Mar 2023 15:53:21 -0800
with message-id <5559DA03-EC90-4878-9DA6-30A034AF0E9F <at> gmail.com>
and subject line Re: bug#62109: 29.0.60; rust-ts-mode missing indentation for patterns
has caused the debbugs.gnu.org bug report #62109,
regarding 29.0.60; rust-ts-mode missing indentation for patterns
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62109: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62109
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.60; rust-ts-mode missing indentation for patterns
Date: Fri, 10 Mar 2023 14:32:42 -0800
X-Debbugs-CC: dev <at> rjt.dev

Try this snippet:

fn main() {
    match &cli.command {
        Commands::Run {
a,
b,
c,
d,
        } => todo!(),
    }
}


The a, b, c, d don’t have corresponding indentation rules. I can add
some myself, but I’m not sure where to add and what’s the best rule to
add.

Yuan



[Message part 3 (message/rfc822, inline)]
From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 62109-done <at> debbugs.gnu.org
Subject: Re: bug#62109: 29.0.60; rust-ts-mode missing indentation for patterns
Date: Sat, 11 Mar 2023 15:53:21 -0800
[Message part 4 (text/plain, inline)]

> On Mar 10, 2023, at 6:04 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> On Friday, March 10th, 2023 at 21:03, Randy Taylor <dev <at> rjt.dev> wrote:
>> 
>> On Friday, March 10th, 2023 at 17:32, Yuan Fu casouri <at> gmail.com wrote:
>> 
>>> X-Debbugs-CC: dev <at> rjt.dev
>>> 
>>> Try this snippet:
>>> 
>>> fn main() {
>>> match &cli.command {
>>> Commands::Run {
>>> a,
>>> b,
>>> c,
>>> d,
>>> } => todo!(),
>>> 
>>> }
>>> }
>>> 
>>> The a, b, c, d don’t have corresponding indentation rules. I can add
>>> some myself, but I’m not sure where to add and what’s the best rule to
>>> add.
>>> 
>>> Yuan
>> 
>> 
>> Thanks for the report, I've attached a patch fixing it.
> 
> Sorry, forgot to include the bug #. Same patch with the bug # this time!
> 
[0001-Add-missing-indentation-rule-for-rust-ts-mode-Bug-62.patch (application/octet-stream, attachment)]
[Message part 6 (text/plain, inline)]

Brilliant, thanks! I applied it.

Yuan

This bug report was last modified 2 years and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.