GNU bug report logs - #62106
29.0.60; Emacs 29 changing user option values (?)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62106: closed (29.0.60; Emacs 29 changing user option values (?))
Date: Sat, 11 Mar 2023 16:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 11 Mar 2023 17:34:09 +0100
with message-id <87mt4jfdry.fsf <at> gmx.de>
and subject line Re: bug#62106: 29.0.60; Emacs 29 changing user option values (?)
has caused the debbugs.gnu.org bug report #62106,
regarding 29.0.60; Emacs 29 changing user option values (?)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62106: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62106
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.60; Emacs 29 changing user option values (?)
Date: Fri, 10 Mar 2023 22:16:34 +0000

Apologies for an incomplete bug report.  Feel free to close if not
helpful.

I downloaded the Windows binary posted today, with dependencies
included, and gave it a naive try using my setup.  Naturally I ran into
some problems.  But when I went to exit, my `kill-emacs-query-functions'
code that checks for changes to user option values (using function
`customize-unsaved') let me know that something had changed these option
values (I had not changed them):

connection-local-criteria-alist

Its value is

(((:application tramp)
  tramp-connection-local-default-system-profile tramp-connection-local-default-shell-profile))

Original value was nil


connection-local-profile-alist

The value is a long, complex Tramp alist.  Original value was nil.

So it looks like Tramp (?) might be messing with user-ooption values,
without resetting their state to tell Customize that they haven't been
changed since last saved.  This should be a no-no.

HTH.


In GNU Emacs 29.0.60 (build 1, x86_64-w64-mingw32)
 of 2023-03-10
Repository revision: 6fe9075ff3814ce825c9869c901903edad9d0b44
Windowing system distributor `Microsoft Corp.', version 10.0.19044
Configured using:
 `configure --with-modules --without-dbus --with-native-compilation
 --without-compress-install --with-tree-sitter CFLAGS=-O2'

[Message part 3 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 62106-done <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#62106: 29.0.60; Emacs 29 changing user option values (?)
Date: Sat, 11 Mar 2023 17:34:09 +0100

Version: 29.1

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

Hi,

>> I downloaded the Windows binary posted today, with dependencies
>> included, and gave it a naive try using my setup.  Naturally I ran into
>> some problems.  But when I went to exit, my `kill-emacs-query-functions'
>> code that checks for changes to user option values (using function
>> `customize-unsaved') let me know that something had changed these option
>> values (I had not changed them):
>>
>> connection-local-criteria-alist
>>
>> Its value is
>>
>> (((:application tramp)
>>   tramp-connection-local-default-system-profile tramp-connection-local-default-shell-profile))
>>
>> Original value was nil
>>
>>
>> connection-local-profile-alist
>>
>> The value is a long, complex Tramp alist.  Original value was nil.
>>
>> So it looks like Tramp (?) might be messing with user-ooption values,
>> without resetting their state to tell Customize that they haven't been
>> changed since last saved.  This should be a no-no.
>
> Let's CC Michael (I mean, the other one).  He changed that in
> 6058d3ebb41 - Respect customization nature of `connection-local-*' user
> options.
>
> Dunno what the intention was - could we use `setopt' here?

`setopt' does not really help. Using `customize-save-variable' instead
of `customize-set-variable' does the trick.

Pushed to the emacs-29 branch, closing the bug. Pls reply if it doesn't
work as expected.

> Michael.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.