GNU bug report logs - #62092
30.0.50; "case" does not work as dedenter in Python

Previous Next

Full log

View this message in rfc822 format

From: kobarity <kobarity <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Lele Gaifax <lele <at> metapensiero.it>, 62092 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#62092: 30.0.50; "case" does not work as dedenter in Python
Date: Tue, 15 Aug 2023 22:43:19 +0900

[Message part 1 (text/plain, inline)]

Mattias Engdegård wrote:
> 
> The test python-info-dedenter-opening-block-positions-7 added as part of this bug in 8f42db010d ends with
> 
> +   (equal (list (python-tests-look-at "case 2:" -1)
> +                (python-tests-look-at "case 1:" -1 t))
> +            (python-info-dedenter-opening-block-positions))))
> 
> which, as you can see, isn't actually a check; the `equal` result is thrown away.
> (Emacs master was just changed to detect this, so there is a byte-compiler warning.)
> 
> Unfortunately, wrapping the call in `should` fails, so there is more to it.
> Would you please take a look?

Sorry, I meant to use `should'.  Another mistake was forgetting to use
RESTORE-POINT argument when calling `python-tests-look-at'.  Attached
is the patch to fix this.  It also includes the indentation fix for 
`python-info-dedenter-opening-block-positions-6'.

[0001-Fix-test-in-python-tests.el-added-by-bug-62092.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.