Subject: Re: bug#6207: 23.1; align.el vhdl rules setup

From: "Basil L. Contovounesios" <[email-masked]>
Date: Thu, 26 Sep 2019 13:58:01 +0100

Stefan Kangas <[email-masked]> writes:

> How about the attached patch?

I haven't followed the discussion, just noticed some minor issues:

>  (defcustom align-dq-string-modes
>    (append align-lisp-modes align-c++-modes align-perl-modes
> -	  '(python-mode))
> +	  '(python-mode 'vhdl-mode))
                        ^
Stray quote?

> +(make-obsolete-variable 'align-vhdl-rules-list "not used" "27.1")
                                                  ^^^^^^^^^^
This produces the following in *Help*:

  This variable is obsolete since 27.1;
  not used

I think "it is no longer used." or similar, with trailing full stop,
would read better.

>  (defun align-set-vhdl-rules ()
>    "Setup the `align-mode-rules-list' variable for `vhdl-mode'."
> +  (define (obsolete nil "27.1"))
      ^^^^^^
declare?

Thanks,

-- 
Basil