From unknown Mon Aug 11 21:14:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62045 <62045@debbugs.gnu.org> To: bug#62045 <62045@debbugs.gnu.org> Subject: Status: 28.2; sed expression in install-etc does not work Reply-To: bug#62045 <62045@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:14:08 +0000 retitle 62045 28.2; sed expression in install-etc does not work reassign 62045 emacs submitter 62045 Ulrich M=C3=BCller severity 62045 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 02:53:28 2023 Received: (at submit) by debbugs.gnu.org; 8 Mar 2023 07:53:28 +0000 Received: from localhost ([127.0.0.1]:47702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZoc4-0000uA-9w for submit@debbugs.gnu.org; Wed, 08 Mar 2023 02:53:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:47288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZobx-0000tl-Oy for submit@debbugs.gnu.org; Wed, 08 Mar 2023 02:53:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZobt-0000wd-AK for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 02:53:19 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pZobp-0004Vq-OL for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 02:53:16 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: bug-gnu-emacs@gnu.org Subject: 28.2; sed expression in install-etc does not work Date: Wed, 08 Mar 2023 08:53:07 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=140.211.166.183; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) The sed expressions in the install-etc make target don't match the strings in the two desktop files for emacsclient. For emacsclient-mail.desktop, this was broken since its inception; for emacsclient.desktop, it is broken since commit cbf220bc31c0, where the shell wrapper was added. A trivial patch is included below. Should it be installed on emacs-29, or on master? ----- 8< ----- >From b6365f386474132a16585c566675cda94f1226d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Wed, 8 Mar 2023 08:25:49 +0100 Subject: [PATCH] Fix sed expression in install-etc make target * Makefile.in (install-etc): Fix sed expression for emacsclient desktop files. --- Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 2fb7754d683..4f2f2f15c97 100644 --- a/Makefile.in +++ b/Makefile.in @@ -841,7 +841,7 @@ install-etc: rm -f $${tmp} tmp=etc/emacsclient.tmpdesktop; rm -f $${tmp}; \ client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ - sed -e "/^Exec=emacsclient/ s|emacsclient|${bindir}/$${client_name}|" \ + sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ $(USE_STARTUP_NOTIFICATION_SED_CMD) \ ${srcdir}/etc/emacsclient.desktop > $${tmp}; \ @@ -855,7 +855,7 @@ install-etc: rm -f $${tmp} tmp=etc/emacsclient-mail.tmpdesktop; rm -f $${tmp}; \ client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ - sed -e "/^Exec=emacsclient/ s|emacsclient|${bindir}/$${client_name}|" \ + sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \ -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \ ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \ ${INSTALL_DATA} $${tmp} "$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \ -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 08:52:51 2023 Received: (at 62045) by debbugs.gnu.org; 8 Mar 2023 13:52:51 +0000 Received: from localhost ([127.0.0.1]:48072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZuDq-0004RL-Ty for submit@debbugs.gnu.org; Wed, 08 Mar 2023 08:52:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZuDp-0004R6-RD for 62045@debbugs.gnu.org; Wed, 08 Mar 2023 08:52:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZuDj-00033j-Dx; Wed, 08 Mar 2023 08:52:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=K7q0udeZy6UeMgBDHwF5cDo6/m1bUS/SY/VMQFXDlzk=; b=jTwZGojitYZGlGZl5U+H Yzs3dDAcTkJTAR5UExDv0jtwHEGH0e7eDGyT46PlqHoGpEOaAnGBdsuWQKGtkm3keC1YXYHyJUi7s rzef7XCdWH1AmiIXuJ3hwI2YXZF78rLfa4yhy10X5DZFc7QR1ZQw/N+TAl66zfslcgpQiP2o3/yoD 1gfpWNGkYmfrL6DAvP1stuLQcNLzo+7k6JbjaQnTHnwpcZvEha93yaUIDRJ067P66FyG/KQOFn+i5 Nm9u4Hkslme4Kq59ke9CuboiP2c/ZACd1IxEIEcseOl/KT7gwwXo+CNwvclvinZtCjMP0J+RrMVxl aXQFfbZE/hJ8Lg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZuDi-0003mf-U6; Wed, 08 Mar 2023 08:52:43 -0500 Date: Wed, 08 Mar 2023 15:52:40 +0200 Message-Id: <83y1o74afr.fsf@gnu.org> From: Eli Zaretskii To: Ulrich =?utf-8?Q?M=C3=BCller?= In-Reply-To: (message from Ulrich =?utf-8?Q?M=C3=BC?= =?utf-8?Q?ller?= on Wed, 08 Mar 2023 08:53:07 +0100) Subject: Re: bug#62045: 28.2; sed expression in install-etc does not work References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62045 Cc: 62045@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Müller > Date: Wed, 08 Mar 2023 08:53:07 +0100 > > The sed expressions in the install-etc make target don't match the > strings in the two desktop files for emacsclient. > > For emacsclient-mail.desktop, this was broken since its inception; > for emacsclient.desktop, it is broken since commit cbf220bc31c0, where > the shell wrapper was added. > > A trivial patch is included below. Should it be installed on emacs-29, > or on master? On emacs-29, of course. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 13:54:05 2023 Received: (at control) by debbugs.gnu.org; 8 Mar 2023 18:54:05 +0000 Received: from localhost ([127.0.0.1]:50233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZyvN-0004mY-J9 for submit@debbugs.gnu.org; Wed, 08 Mar 2023 13:54:05 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:35448 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZyvM-0004m3-6b for control@debbugs.gnu.org; Wed, 08 Mar 2023 13:54:04 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: control@debbugs.gnu.org Subject: Re: bug#62045: 28.2; sed expression in install-etc does not work References: <83y1o74afr.fsf@gnu.org> Date: Wed, 08 Mar 2023 19:53:54 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 62045 29.1 thanks From unknown Mon Aug 11 21:14:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Apr 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator