GNU bug report logs - #62043
[PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu

Previous Next

Full log

Message #14 received at 62043 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 62043 <at> debbugs.gnu.org
Subject: Re: bug#62043: [PATCH] Fix enums appearing as structs in
 c-ts-base-mode's imenu
Date: Thu, 9 Mar 2023 21:59:49 -0800

> On Mar 8, 2023, at 6:04 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> On Wednesday, March 8th, 2023 at 18:27, Yuan Fu <casouri <at> gmail.com> wrote:
>> 
>>> On Mar 7, 2023, at 5:49 PM, Randy Taylor dev <at> rjt.dev wrote:
>>> 
>>> X-Debbugs-CC: casouri <at> gmail.com
>>> 
>>> With {c, c++}-ts-mode, enums appear as structs in imenu. The attached patch fixes this.
>>> 
>>> Example:
>>> enum Thing { A, B, C };
>>> 
>>> Should appear as Enum Thing
>>> <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch>
>> 
>> 
>> Thanks! I wonder what determines which categories to merge together and which to not? If we separate Enums, should we also separate Unions?
>> 
>> Yuan
> 
> I think they should all be separate actually. Attached a patch that does so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch>

That’s probably the right thing to do. I applied the patch, thanks!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.