From unknown Fri Jun 20 07:17:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62043 <62043@debbugs.gnu.org> To: bug#62043 <62043@debbugs.gnu.org> Subject: Status: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Reply-To: bug#62043 <62043@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:17:12 +0000 retitle 62043 [PATCH] Fix enums appearing as structs in c-ts-base-mode's im= enu reassign 62043 emacs submitter 62043 Randy Taylor severity 62043 normal tag 62043 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 20:50:16 2023 Received: (at submit) by debbugs.gnu.org; 8 Mar 2023 01:50:16 +0000 Received: from localhost ([127.0.0.1]:47540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZiwZ-0005UU-N3 for submit@debbugs.gnu.org; Tue, 07 Mar 2023 20:50:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:38192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZiwX-0005UK-Mo for submit@debbugs.gnu.org; Tue, 07 Mar 2023 20:50:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZiwU-0003OX-1d for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 20:50:11 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZiwP-0000z4-NG for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 20:50:08 -0500 Date: Wed, 08 Mar 2023 01:49:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1678240201; x=1678499401; bh=ReMBK53CVQotY4L9Kijc18hUomQ1laUEtqYVJwxdVqg=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=npoWWSoqBYes4q4eRxwQrReuhnD2gEVjPUcr5sICvtnjZZKxghpMRi1y2CsRZNQn0 HWFJqTgm4LsuxOrKa25Up3G3h6LdV/lI51sbo5VqYy3nQe5A+HWqDn75XSsodbWaY8 QD9BDb0Pmru5cmrpO3WtrH6Hi4t9zalCFsylzjUAj2/wJ42eDoCeMk2K/liCMvRg0b C+MgM59yMe1/kSY6XnoJscmiaLCZYz9EnUoEO7e6Y/RyzHR8fkzxIPdjLyqFkvpw4S Hb0Ka9izJSPAp8U8hyrRLoW67QcxGMRd3QXjH2jEDr28bS1r92IIcetonrG0h2z97J uoxOyUts0WxAQ== To: "bug-gnu-emacs@gnu.org" From: Randy Taylor Subject: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Message-ID: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw" Received-SPF: pass client-ip=185.70.43.23; envelope-from=dev@rjt.dev; helo=mail-4323.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw Content-Type: multipart/alternative; boundary="b2_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw" --b2_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 WC1EZWJidWdzLUNDOiBjYXNvdXJpQGdtYWlsLmNvbQoKV2l0aCB7YywgYysrfS10cy1tb2RlLCBl bnVtcyBhcHBlYXIgYXMgc3RydWN0cyBpbiBpbWVudS4gVGhlIGF0dGFjaGVkIHBhdGNoIGZpeGVz IHRoaXMuCgpFeGFtcGxlOgplbnVtIFRoaW5nIHsgQSwgQiwgQyB9OwoKU2hvdWxkIGFwcGVhciBh cyBFbnVtIFRoaW5n --b2_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0 cHg7Ij5YLURlYmJ1Z3MtQ0M6IGNhc291cmlAZ21haWwuY29tPC9kaXY+PGRpdiBzdHlsZT0iZm9u dC1mYW1pbHk6IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0cHg7Ij48YnI+PC9kaXY+ PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0 cHg7Ij5XaXRoIHtjLCBjKyt9LXRzLW1vZGUsIGVudW1zIGFwcGVhciBhcyBzdHJ1Y3RzIGluIGlt ZW51LiBUaGUgYXR0YWNoZWQgcGF0Y2ggZml4ZXMgdGhpcy48L2Rpdj48ZGl2IHN0eWxlPSJmb250 LWZhbWlseTogQXJpYWwsIHNhbnMtc2VyaWY7IGZvbnQtc2l6ZTogMTRweDsiPjxicj48L2Rpdj48 ZGl2IHN0eWxlPSJmb250LWZhbWlseTogQXJpYWwsIHNhbnMtc2VyaWY7IGZvbnQtc2l6ZTogMTRw eDsiPkV4YW1wbGU6PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsLCBzYW5zLXNl cmlmOyBmb250LXNpemU6IDE0cHg7Ij48c3Bhbj5lbnVtIFRoaW5nIHsgQSwgQiwgQyB9Ozwvc3Bh bj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogQXJpYWwsIHNhbnMtc2VyaWY7IGZvbnQt c2l6ZTogMTRweDsiPjxicj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogQXJpYWwsIHNh bnMtc2VyaWY7IGZvbnQtc2l6ZTogMTRweDsiPlNob3VsZCBhcHBlYXIgYXMgRW51bSBUaGluZzxi cj48L2Rpdj4NCjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrIHByb3Rvbm1h aWxfc2lnbmF0dXJlX2Jsb2NrLWVtcHR5IiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsLCBzYW5z LXNlcmlmOyBmb250LXNpemU6IDE0cHg7Ij4NCiAgICA8ZGl2IGNsYXNzPSJwcm90b25tYWlsX3Np Z25hdHVyZV9ibG9jay11c2VyIHByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLWVtcHR5Ij48L2Rp dj4NCiAgICANCiAgICAgICAgICAgIDxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Js b2NrLXByb3RvbiBwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1lbXB0eSI+DQogICAgICAgIA0K ICAgICAgICAgICAgPC9kaXY+DQo8L2Rpdj4NCg== --b2_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw-- --b1_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw Content-Type: text/x-patch; name=0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch RnJvbSAwY2E2ZTE1YmNkM2U3NmJjMTRiNjY3ZDg4ZDYwZjQ0YzRlYTZkNTZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUdWUs IDcgTWFyIDIwMjMgMjA6Mzg6MTggLTA1MDAKU3ViamVjdDogW1BBVENIXSBGaXggZW51bXMgYXBw ZWFyaW5nIGFzIHN0cnVjdHMgaW4gYy10cy1iYXNlLW1vZGUncyBpbWVudQoKKiBsaXNwL3Byb2dt b2Rlcy9jLXRzLW1vZGUuZWwgKGMtdHMtYmFzZS1tb2RlKTogU2VwYXJhdGUgZW51bXMgb3V0CmZy b20gc3RydWN0cy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwgfCAzICsrLQogMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5l bAppbmRleCBmZGQ5NjJmZjAyMC4uOWJiNDk1MGRhOGMgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21v ZGVzL2MtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwKQEAgLTkz MCw3ICs5MzAsOCBAQCBjLXRzLWJhc2UtbW9kZQogICA7OyBJbWVudS4KICAgKHNldHEtbG9jYWwg dHJlZXNpdC1zaW1wbGUtaW1lbnUtc2V0dGluZ3MKICAgICAgICAgICAgICAgKGxldCAoKHByZWQg IydjLXRzLW1vZGUtLWRlZnVuLXZhbGlkLXApKQotICAgICAgICAgICAgICAgIGAoKCJTdHJ1Y3Qi ICwocnggYm9zIChvciAic3RydWN0IiAiZW51bSIgInVuaW9uIikKKyAgICAgICAgICAgICAgICBg KCgiRW51bSIgIlxcYGVudW1fc3BlY2lmaWVyXFwnIiAscHJlZCBuaWwpCisgICAgICAgICAgICAg ICAgICAoIlN0cnVjdCIgLChyeCBib3MgKG9yICJzdHJ1Y3QiICJ1bmlvbiIpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiX3NwZWNpZmllciIgZW9zKQogICAgICAgICAgICAgICAg ICAgICxwcmVkIG5pbCkKICAgICAgICAgICAgICAgICAgICgiVmFyaWFibGUiICwocnggYm9zICJk ZWNsYXJhdGlvbiIgZW9zKSAscHJlZCBuaWwpCi0tIAoyLjM5LjIKCg== --b1_aMTLurjL2Qtwa2gUQcHe8jlVyRVTNLnRM1jADJjL9xw-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 18:27:43 2023 Received: (at 62043) by debbugs.gnu.org; 8 Mar 2023 23:27:43 +0000 Received: from localhost ([127.0.0.1]:50404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa3CB-0008VU-HV for submit@debbugs.gnu.org; Wed, 08 Mar 2023 18:27:43 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:36791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa3C9-0008VF-Gb for 62043@debbugs.gnu.org; Wed, 08 Mar 2023 18:27:41 -0500 Received: by mail-pj1-f52.google.com with SMTP id cp7-20020a17090afb8700b0023756229427so4193126pjb.1 for <62043@debbugs.gnu.org>; Wed, 08 Mar 2023 15:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678318056; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YVxBB9y38CpTS2e1AFvCBzjMbqfjmjjKZiCXmdFvKZ4=; b=JosZv5EJVcnMwHMxC6Tc5CeAvDXF2TEkDnnVeetPMthwj3whZqXtu8EBWOWzTqyb5n jKdIqHIaVquVKtxSQpNWbl7wCNH/oWDVlWRNctFpciC/JLPuJgpqhyp65wqmEV4Slx1M yf6LyGiVK21cLN84lUnV2Dsf0Fhwd3Gm414mDNKbQjlO5fGGDTr3HVsVumCW+39CLT2G rlU/SaspUotE+4oZGX9i+X7V24PZspSU3BAUnxjTAYGx12zXdxEr3PXpx16/bplITczP QYtmWYmhzqfYPtyHKf9UKunOfSMMR0UvUwKZH+/H6uDQvH1cMAf+X99fiyakf1m9l/Sg qKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678318056; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YVxBB9y38CpTS2e1AFvCBzjMbqfjmjjKZiCXmdFvKZ4=; b=N1n6eAIgBeIv9Yv8QVj6mACb1FTS4AWmzmd4ATglLH+9xQjynCbdL71aLwjxq3eFls Fn8iRNXiwixw+Vw+lje4bSS+JQFXBJigmUwqF2ilu0Zo3kSnSFBFU4oMOAjZ0QDVUBnE yvZo/MrHI8kkZ1CH3nC8MiXyRjLNrOMsyk7MNcUVmSXwaEEtN5kdtITy8uJCL5COcbgL Fx1njSpuXe+kw+dTpXDRABSEmbtDdB2SArFqxixkFe7+ZRkqENJzsy2DL5u1pp50QnPx w7sayq3YYxoWem++Jxhz33iTTLgoafjLYXbvtjcKKKw6sL4Jp1rmPGHPEtLrJkV/tomV FnWg== X-Gm-Message-State: AO0yUKWLcTnIbHxho819/uawuiusMngfHgSDGV9E2WITgGstVXejOkMt HuysmAE7rKq0QlB+2y36ctpLaYZRbsplQA== X-Google-Smtp-Source: AK7set96hcJhIhBuOrOlltiFpVRwjXkFvjyMQmqJ92xrCUD0mbMSewaMI3m6OfEG2xZm51LFCWnEeg== X-Received: by 2002:a17:903:1251:b0:19e:d60a:e9e with SMTP id u17-20020a170903125100b0019ed60a0e9emr10282218plh.42.1678318055616; Wed, 08 Mar 2023 15:27:35 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u3-20020a170902e80300b0019a6e8ceb49sm10291546plg.259.2023.03.08.15.27.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2023 15:27:34 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu From: Yuan Fu In-Reply-To: Date: Wed, 8 Mar 2023 15:27:18 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Randy Taylor X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62043 Cc: 62043@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 7, 2023, at 5:49 PM, Randy Taylor wrote: >=20 > X-Debbugs-CC: casouri@gmail.com >=20 > With {c, c++}-ts-mode, enums appear as structs in imenu. The attached = patch fixes this. >=20 > Example: > enum Thing { A, B, C }; >=20 > Should appear as Enum Thing > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> Thanks! I wonder what determines which categories to merge together and = which to not? If we separate Enums, should we also separate Unions? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 21:04:45 2023 Received: (at 62043) by debbugs.gnu.org; 9 Mar 2023 02:04:45 +0000 Received: from localhost ([127.0.0.1]:50508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa5e8-00049R-OA for submit@debbugs.gnu.org; Wed, 08 Mar 2023 21:04:44 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:37421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa5e5-00049A-6e for 62043@debbugs.gnu.org; Wed, 08 Mar 2023 21:04:42 -0500 Date: Thu, 09 Mar 2023 02:04:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1678327474; x=1678586674; bh=mqeNy+ovk4XaM2whVnJEoyc0Ek7G2gysTR3opMANilk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mBi1K0v+7z8akz62CSoDcFb8uLiJCqqVZItEWe1u2LwK2bvk+qUtcwhPFFBP35H3u WNBBzZOVSXI0wKUFQU7L6olBXntmIVpRiA7jbhYVablQVjzN8O93Wy13WzBvdnRhtJ joHIBG3yMXqumP33XjPbxVEZ4/dcep9sHckC9SYfsiAzXbZQtQLUGAhYtqy7NJcSVM PF9dE8Ve+nin66CoeJ6yMek4kO5uDzKstVQQuB4m/snLQCn2Y3ZM5FXsX1hawSsh7J 7CnXzAo36juhD3vFRre8cMjJJ7l8zYq1u1iNNXTC7L56fYIEaYTgvOZpBvcQ8AnZfz b4o5AhP9hRjdA== To: Yuan Fu From: Randy Taylor Subject: Re: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62043 Cc: 62043@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wednesday, March 8th, 2023 at 18:27, Yuan Fu wrote: >=20 > > On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote: > >=20 > > X-Debbugs-CC: casouri@gmail.com > >=20 > > With {c, c++}-ts-mode, enums appear as structs in imenu. The attached p= atch fixes this. > >=20 > > Example: > > enum Thing { A, B, C }; > >=20 > > Should appear as Enum Thing > > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> >=20 >=20 > Thanks! I wonder what determines which categories to merge together and w= hich to not? If we separate Enums, should we also separate Unions? >=20 > Yuan I think they should all be separate actually. Attached a patch that does so= . --b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU Content-Type: text/x-patch; name=0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch RnJvbSBjOWIzMTA0YTRjY2EyZTkyMWZkNjM0MGE5OTFjNTYwMWMxYWU2YTMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUdWUs IDcgTWFyIDIwMjMgMjA6Mzg6MTggLTA1MDAKU3ViamVjdDogW1BBVENIXSBGaXggZW51bXMgYW5k IHVuaW9ucyBhcHBlYXJpbmcgYXMgc3RydWN0cyBpbiBjLXRzLWJhc2UtbW9kZSdzCiBpbWVudQoK KiBsaXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwgKGMtdHMtYmFzZS1tb2RlKTogU2VwYXJhdGUg ZW51bXMgYW5kIHVuaW9ucyBvdXQKZnJvbSBzdHJ1Y3RzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2Mt dHMtbW9kZS5lbCB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbCBi L2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbAppbmRleCBmZGQ5NjJmZjAyMC4uZmY4NmI5ZTA1 NDQgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbAorKysgYi9saXNwL3By b2dtb2Rlcy9jLXRzLW1vZGUuZWwKQEAgLTkzMCw5ICs5MzAsOSBAQCBjLXRzLWJhc2UtbW9kZQog ICA7OyBJbWVudS4KICAgKHNldHEtbG9jYWwgdHJlZXNpdC1zaW1wbGUtaW1lbnUtc2V0dGluZ3MK ICAgICAgICAgICAgICAgKGxldCAoKHByZWQgIydjLXRzLW1vZGUtLWRlZnVuLXZhbGlkLXApKQot ICAgICAgICAgICAgICAgIGAoKCJTdHJ1Y3QiICwocnggYm9zIChvciAic3RydWN0IiAiZW51bSIg InVuaW9uIikKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJfc3BlY2lmaWVyIiBl b3MpCi0gICAgICAgICAgICAgICAgICAgLHByZWQgbmlsKQorICAgICAgICAgICAgICAgIGAoKCJF bnVtIiAiXFxgZW51bV9zcGVjaWZpZXJcXCciICxwcmVkIG5pbCkKKyAgICAgICAgICAgICAgICAg ICgiU3RydWN0IiAiXFxgc3RydWN0X3NwZWNpZmllclxcJyIgLHByZWQgbmlsKQorICAgICAgICAg ICAgICAgICAgKCJVbmlvbiIgIlxcYHVuaW9uX3NwZWNpZmllclxcJyIgLHByZWQgbmlsKQogICAg ICAgICAgICAgICAgICAgKCJWYXJpYWJsZSIgLChyeCBib3MgImRlY2xhcmF0aW9uIiBlb3MpICxw cmVkIG5pbCkKICAgICAgICAgICAgICAgICAgICgiRnVuY3Rpb24iICJcXGBmdW5jdGlvbl9kZWZp bml0aW9uXFwnIiAscHJlZCBuaWwpCiAgICAgICAgICAgICAgICAgICAoIkNsYXNzIiAsKHJ4IGJv cyAob3IgImNsYXNzX3NwZWNpZmllciIKLS0gCjIuMzkuMgoK --b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 01:00:11 2023 Received: (at 62043) by debbugs.gnu.org; 10 Mar 2023 06:00:11 +0000 Received: from localhost ([127.0.0.1]:53472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paVnX-0003WE-7O for submit@debbugs.gnu.org; Fri, 10 Mar 2023 01:00:11 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:43666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paVnU-0003UY-Mr for 62043@debbugs.gnu.org; Fri, 10 Mar 2023 01:00:09 -0500 Received: by mail-pj1-f41.google.com with SMTP id y15-20020a17090aa40f00b00237ad8ee3a0so4210399pjp.2 for <62043@debbugs.gnu.org>; Thu, 09 Mar 2023 22:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678428001; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HnyEbD33rAaC4KU0WtYYooOAv8wwepnSY35Gb8KpkZI=; b=WOJBIf3HnnuHO8HLc9DbfqyF9vumoreNhWfrSMCUXe6OQIuNlGNjwxzt9VWk+0lq1/ vDOrFQ7FJI4HRy9+qZX5IRGDR1a6upXRu/xZ1d9rwOrTLCdjzd4l6d5u6tODZN1WkD61 8rqlTUBFhR8lVeH/7N/98qKLpr2l3YmK2UOVPCGM7se7Fa1fA8oftFhSEioy76ddsIvZ s4VQvjbWcogHNtjQuHyScJ0U0hUZYLQtPNLMvPPHSnKdvjUG74nw3gY7SGXv+pb/ihta Zbu3DEtQPYuVVcl1B0rbM1m/wuOHmUD/YRQZU73jhJxfV84BoUpsVu4A0olZzHS94rXT pygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678428001; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HnyEbD33rAaC4KU0WtYYooOAv8wwepnSY35Gb8KpkZI=; b=C1L+kGhn7o76E/gnNjggTmVYMY+db3pxA4JhaDyWfIJxeMyh7Sd37iimAfoQQLviho qRE0R5CJhei1wjlWOS7UMcVFRYaSgA74+Xfapyl4OmRuvxyLDsafW3QVaN04ANWilBpl D43h625RRWkNaKiDFrVReZsw965TPBiIYXQBU730Z5GbIsHbKaHiFwOuy/ZjD213HCQy w5uXD+l0DlN0LMsYtR/LbRtgG97qKAHacacIg/utpj6GkUOAHbXKpcsZnN3B71Yfud30 w6wnUgOAcDjZgbYq5W4fafl1iJJYYmHYDPcjQ2P1SOdZeYuEHp9eXQ1LYX574/85FAhA QiIA== X-Gm-Message-State: AO0yUKXRsHKWmz0ecVlGSl+dhKn+cQzAttf0Knob4kFQ0HJCnyKSx63c +JTzZmtdf9SRp3o/47iyTWM= X-Google-Smtp-Source: AK7set/d9brWqjAV44Y9kDZSIViwOTLM0qAmG0HmYoDxecQCHUVLbGv2UAbsxReFCU8XpAqBie4/Sw== X-Received: by 2002:a05:6a20:8413:b0:cc:6699:dd8a with SMTP id c19-20020a056a20841300b000cc6699dd8amr31107330pzd.45.1678428001451; Thu, 09 Mar 2023 22:00:01 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j26-20020aa78d1a000000b00593e5a45ce7sm551657pfe.173.2023.03.09.22.00.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2023 22:00:01 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu From: Yuan Fu In-Reply-To: Date: Thu, 9 Mar 2023 21:59:49 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> References: To: Randy Taylor X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62043 Cc: 62043@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 8, 2023, at 6:04 PM, Randy Taylor wrote: >=20 > On Wednesday, March 8th, 2023 at 18:27, Yuan Fu = wrote: >>=20 >>> On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote: >>>=20 >>> X-Debbugs-CC: casouri@gmail.com >>>=20 >>> With {c, c++}-ts-mode, enums appear as structs in imenu. The = attached patch fixes this. >>>=20 >>> Example: >>> enum Thing { A, B, C }; >>>=20 >>> Should appear as Enum Thing >>> <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> >>=20 >>=20 >> Thanks! I wonder what determines which categories to merge together = and which to not? If we separate Enums, should we also separate Unions? >>=20 >> Yuan >=20 > I think they should all be separate actually. Attached a patch that = does = so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch> That=E2=80=99s probably the right thing to do. I applied the patch, = thanks! Yuan From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 13:17:13 2023 Received: (at 62043-done) by debbugs.gnu.org; 10 Mar 2023 18:17:14 +0000 Received: from localhost ([127.0.0.1]:55853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pahIn-0004zP-Ka for submit@debbugs.gnu.org; Fri, 10 Mar 2023 13:17:13 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:46113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pahIk-0004zA-K6 for 62043-done@debbugs.gnu.org; Fri, 10 Mar 2023 13:17:12 -0500 Date: Fri, 10 Mar 2023 18:16:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1678472223; x=1678731423; bh=jn3Cq99Nc9SNW7PL9NGUeAzAmfzdsiuNzSX+GVH6LBU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=t22L9EmzvJZn3z8hhAJNFRrAW7B/HXDLuRpOygcW0e3gL1VQxdTmfKeKYGmfDS7yF hKTb9HzKWtCOFmmnVSXcIV8yS0Jtw8DG7oYY92ZOzpeRur3nqFA9Sve91o3saKTxqP WLuHamqudXvFnEeRY2h9LGx2WmuirPWQBlEklbZujF2CA8My/CzR4GP1ftDdSrCDRv Wp+EhhfUfftwJy7DZclYpsrzecXEecdRWG8maEQkPICSFK8gYdbG4pmI/+IKOWUGYH YaGIL8BRvCQn5e1ACP00f5ColP/lwcmYZ+Al/ZRYlD11BOSChZdkeDNpKPDYm2XkfZ 0D184LJI4dA0w== To: Yuan Fu From: Randy Taylor Subject: Re: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Message-ID: In-Reply-To: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> References: <394FE8AD-FAB3-4244-BD16-2D2014DAF2B0@gmail.com> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62043-done Cc: "62043-done@debbugs.gnu.org" <62043-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Friday, March 10th, 2023 at 00:59, Yuan Fu wrote: >=20 > > On Mar 8, 2023, at 6:04 PM, Randy Taylor dev@rjt.dev wrote: > >=20 > > On Wednesday, March 8th, 2023 at 18:27, Yuan Fu casouri@gmail.com wrote= : > >=20 > > > > On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote: > > > >=20 > > > > X-Debbugs-CC: casouri@gmail.com > > > >=20 > > > > With {c, c++}-ts-mode, enums appear as structs in imenu. The attach= ed patch fixes this. > > > >=20 > > > > Example: > > > > enum Thing { A, B, C }; > > > >=20 > > > > Should appear as Enum Thing > > > > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> > > >=20 > > > Thanks! I wonder what determines which categories to merge together a= nd which to not? If we separate Enums, should we also separate Unions? > > >=20 > > > Yuan > >=20 > > I think they should all be separate actually. Attached a patch that doe= s so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch> >=20 >=20 > That=E2=80=99s probably the right thing to do. I applied the patch, thank= s! >=20 > Yuan Thanks, closing. From unknown Fri Jun 20 07:17:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Apr 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator