GNU bug report logs - #62027
Subject: 29.0.60; Breaking change in forward-sentence/backward-sentence

Previous Next

Full log

Message #52 received at 62027-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: simenheg <at> runbox.com, 62027-done <at> debbugs.gnu.org, manuel <at> ledu-giraud.fr,
 mardani29 <at> yahoo.es
Subject: Re: [External] : bug#62027: Subject: 29.0.60; Breaking change in
 forward-sentence/backward-sentence
Date: Wed, 08 Mar 2023 18:52:36 +0200

> From: Drew Adams <drew.adams <at> oracle.com>
> CC: Eli Zaretskii <eliz <at> gnu.org>,
>         "62027-done <at> debbugs.gnu.org"
> 	<62027-done <at> debbugs.gnu.org>,
>         "mardani29 <at> yahoo.es" <mardani29 <at> yahoo.es>
> Date: Wed, 8 Mar 2023 15:52:51 +0000
> 
> > > Should perhaps the return values of
> > > `forward-sentence'/`backward-sentence' be documented
> > > to prevent this from happening again?
> > 
> > Why not: Hyrum's law might have won here.  But OTOH in master,
> > 'forward-sentence' is a now call to 'forward-sentence-function' that
> > could be changed by the user.  Maybe should we document
> > 'forward-sentence-default-function'?
> 
> Yes, but _both_ should mention the return value.
> And not just "to prevent this from happening again."
> Documenting this helps users use the functions.

Not when the value is a simple consequence of the implementation, no.

forward-sentence does its job by side effect, not by the value it
returns.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.