GNU bug report logs - #62027
Subject: 29.0.60; Breaking change in forward-sentence/backward-sentence

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> runbox.com>
Subject: bug#62027: closed (Re: bug#62027: Subject: 29.0.60; Breaking
 change in forward-sentence/backward-sentence)
Date: Tue, 07 Mar 2023 19:33:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#62027: Subject: 29.0.60; Breaking change in forward-sentence/backward-sentence

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62027 <at> debbugs.gnu.org.

-- 
62027: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62027
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: simenheg <at> runbox.com, 62027-done <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#62027: Subject: 29.0.60; Breaking change in
 forward-sentence/backward-sentence
Date: Tue, 07 Mar 2023 21:32:32 +0200

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: mardani29 <at> yahoo.es,  62027 <at> debbugs.gnu.org,  simenheg <at> runbox.com
> Date: Tue, 07 Mar 2023 20:07:44 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> [...]
> 
> > I tried, but it doesn't apply.  Did you produce the patch from the
> > emacs-29 branch or from some other branch?
> 
> Sorry, I produced it on master.  Here is the one for emacs-29.

Thanks, installed.

> Will this appear on master at a later time?

Yes, in a day or two.

[Message part 3 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Manuel Giraud <manuel <at> ledu-giraud.fr>
Subject: Subject: 29.0.60; Breaking change in
 forward-sentence/backward-sentence
Date: Tue, 07 Mar 2023 08:31:49 +0100

Hi.

Commit 460d5fd971489ba7b573d71a94cdaac2f9f1a767 introduced a new
function `count-sentences', which is nice, but it also silently changed
the return value of `forward-sentence' (and thus also
`backward-sentence') from returning the new value of point to returning
t/nil based on whether point moved or not.

I just discovered this because it caused one of my packages to break,
since it relies on the previous style return values from
`forward-sentence'/`backward-sentence'. It would be easy enough fix on
my part, but I'm wondering whether this change was intended, and if so,
whether it should be documented somewhere so package authors can adapt
more easily?

Or could perhaps the change in return values from
`forward-sentence'/`backward-sentence' be reverted to old behavior, and
the counting logic be left to `count-sentences' instead?

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.