GNU bug report logs - #62009
29.0.60; Emacs crashes on setf symbol-name

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Mon, 6 Mar 2023 19:28:01 UTC

Severity: normal

Found in version 29.0.60

Full log


View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Daniel Mendler <mail <at> daniel-mendler.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: philipk <at> posteo.net, michael_heerdegen <at> web.de, rpluim <at> gmail.com, gregory <at> heytings.org, monnier <at> iro.umontreal.ca, 62009 <at> debbugs.gnu.org, arstoffel <at> gmail.com
Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name
Date: Sat, 11 Mar 2023 00:01:10 +0200
On 10/03/2023 14:24, Daniel Mendler wrote:
> On 3/10/23 13:13, Eli Zaretskii wrote:
>>> Date: Fri, 10 Mar 2023 12:36:17 +0100
>>> Cc: Gregory Heytings<gregory <at> heytings.org>,
>>>   Philip Kaludercic<philipk <at> posteo.net>,michael_heerdegen <at> web.de,
>>>   monnier <at> iro.umontreal.ca,62009 <at> debbugs.gnu.org, Eli Zaretskii
>>>   <eliz <at> gnu.org>, Augusto Stoffel<arstoffel <at> gmail.com>
>>> From: Daniel Mendler<mail <at> daniel-mendler.de>
>>>
>>>>        /* Number of characters in string; MSB is used as the mark bit.  */
>>>>        ptrdiff_t size;
>>>>        /* If nonnegative, number of bytes in the string (which is multibyte).
>>>> 	 If negative, the string is unibyte:
>>>> 	 -1 for data normally allocated
>>>> 	 -2 for data in rodata (C string constants)
>>>> 	 -3 for data that must be immovable (used for bytecode)  */
>>>>        ptrdiff_t size_byte;
>>> Thanks! That's good. Given that a read only flag already exists, it is
>>> easy to fix the issue. We just have to make sure that the size is
>>> negative for the symbol names and add a check in `aset`.
>> Let's not do that!
> Why not? There won't be a performance cost.

Perhaps we could use some exact benchmark results.




This bug report was last modified 2 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.